mirror of
https://github.com/quay/quay.git
synced 2026-01-27 18:42:52 +03:00
* Convert all Python2 to Python3 syntax. * Removes oauth2lib dependency * Replace mockredis with fakeredis * byte/str conversions * Removes nonexisting __nonzero__ in Python3 * Python3 Dockerfile and related * [PROJQUAY-98] Replace resumablehashlib with rehash * PROJQUAY-123 - replace gpgme with python3-gpg * [PROJQUAY-135] Fix unhashable class error * Update external dependencies for Python 3 - Move github.com/app-registry/appr to github.com/quay/appr - github.com/coderanger/supervisor-stdout - github.com/DevTable/container-cloud-config - Update to latest mockldap with changes applied from coreos/mockldap - Update dependencies in requirements.txt and requirements-dev.txt * Default FLOAT_REPR function to str in json encoder and removes keyword assignment True, False, and str were not keywords in Python2... * [PROJQUAY-165] Replace package `bencode` with `bencode.py` - Bencode is not compatible with Python 3.x and is no longer maintained. Bencode.py appears to be a drop-in replacement/fork that is compatible with Python 3. * Make sure monkey.patch is called before anything else ( * Removes anunidecode dependency and replaces it with text_unidecode * Base64 encode/decode pickle dumps/loads when storing value in DB Base64 encodes/decodes the serialized values when storing them in the DB. Also make sure to return a Python3 string instead of a Bytes when coercing for db, otherwise, Postgres' TEXT field will convert it into a hex representation when storing the value. * Implement __hash__ on Digest class In Python 3, if a class defines __eq__() but not __hash__(), its instances will not be usable as items in hashable collections (e.g sets). * Remove basestring check * Fix expected message in credentials tests * Fix usage of Cryptography.Fernet for Python3 (#219) - Specifically, this addresses the issue where Byte<->String conversions weren't being applied correctly. * Fix utils - tar+stream layer format utils - filelike util * Fix storage tests * Fix endpoint tests * Fix workers tests * Fix docker's empty layer bytes * Fix registry tests * Appr * Enable CI for Python 3.6 * Skip buildman tests Skip buildman tests while it's being rewritten to allow ci to pass. * Install swig for CI * Update expected exception type in redis validation test * Fix gpg signing calls Fix gpg calls for updated gpg wrapper, and add signing tests. * Convert / to // for Python3 integer division * WIP: Update buildman to use asyncio instead of trollius. This dependency is considered deprecated/abandoned and was only used as an implementation/backport of asyncio on Python 2.x This is a work in progress, and is included in the PR just to get the rest of the tests passing. The builder is actually being rewritten. * Target Python 3.8 * Removes unused files - Removes unused files that were added accidentally while rebasing - Small fixes/cleanup - TODO tasks comments * Add TODO to verify rehash backward compat with resumablehashlib * Revert "[PROJQUAY-135] Fix unhashable class error" and implements __hash__ instead. This reverts commit 735e38e3c1d072bf50ea864bc7e119a55d3a8976. Instead, defines __hash__ for encryped fields class, using the parent field's implementation. * Remove some unused files ad imports Co-authored-by: Kenny Lee Sin Cheong <kenny.lee@redhat.com> Co-authored-by: Tom McKay <thomasmckay@redhat.com>
143 lines
5.0 KiB
Python
143 lines
5.0 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
import pytest
|
|
|
|
from base64 import b64encode
|
|
|
|
from auth.basic import validate_basic_auth
|
|
from auth.credentials import (
|
|
ACCESS_TOKEN_USERNAME,
|
|
OAUTH_TOKEN_USERNAME,
|
|
APP_SPECIFIC_TOKEN_USERNAME,
|
|
)
|
|
from auth.validateresult import AuthKind, ValidateResult
|
|
from data import model
|
|
|
|
from test.fixtures import *
|
|
|
|
|
|
def _token(username, password):
|
|
assert isinstance(username, str)
|
|
assert isinstance(password, str)
|
|
token_bytes = b"%s:%s" % (username.encode("utf-8"), password.encode("utf-8"))
|
|
return "basic " + b64encode(token_bytes).decode("ascii")
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"token, expected_result",
|
|
[
|
|
("", ValidateResult(AuthKind.basic, missing=True)),
|
|
("someinvalidtoken", ValidateResult(AuthKind.basic, missing=True)),
|
|
("somefoobartoken", ValidateResult(AuthKind.basic, missing=True)),
|
|
("basic ", ValidateResult(AuthKind.basic, missing=True)),
|
|
("basic some token", ValidateResult(AuthKind.basic, missing=True)),
|
|
("basic sometoken", ValidateResult(AuthKind.basic, missing=True)),
|
|
(
|
|
_token(APP_SPECIFIC_TOKEN_USERNAME, "invalid"),
|
|
ValidateResult(AuthKind.basic, error_message="Invalid token"),
|
|
),
|
|
(
|
|
_token(ACCESS_TOKEN_USERNAME, "invalid"),
|
|
ValidateResult(AuthKind.basic, error_message="Invalid access token"),
|
|
),
|
|
(
|
|
_token(OAUTH_TOKEN_USERNAME, "invalid"),
|
|
ValidateResult(
|
|
AuthKind.basic, error_message="OAuth access token could not be validated"
|
|
),
|
|
),
|
|
(
|
|
_token("devtable", "invalid"),
|
|
ValidateResult(AuthKind.basic, error_message="Invalid Username or Password"),
|
|
),
|
|
(
|
|
_token("devtable+somebot", "invalid"),
|
|
ValidateResult(
|
|
AuthKind.basic, error_message="Could not find robot with specified username"
|
|
),
|
|
),
|
|
(
|
|
_token("disabled", "password"),
|
|
ValidateResult(
|
|
AuthKind.basic,
|
|
error_message="This user has been disabled. Please contact your administrator.",
|
|
),
|
|
),
|
|
(
|
|
_token("usér", "passwôrd"),
|
|
ValidateResult(AuthKind.basic, error_message="Invalid Username or Password"),
|
|
),
|
|
],
|
|
)
|
|
def test_validate_basic_auth_token(token, expected_result, app):
|
|
result = validate_basic_auth(token)
|
|
assert result == expected_result
|
|
|
|
|
|
def test_valid_user(app):
|
|
token = _token("devtable", "password")
|
|
result = validate_basic_auth(token)
|
|
assert result == ValidateResult(AuthKind.basic, user=model.user.get_user("devtable"))
|
|
|
|
|
|
def test_valid_robot(app):
|
|
robot, password = model.user.create_robot("somerobot", model.user.get_user("devtable"))
|
|
token = _token(robot.username, password)
|
|
result = validate_basic_auth(token)
|
|
assert result == ValidateResult(AuthKind.basic, robot=robot)
|
|
|
|
|
|
def test_valid_token(app):
|
|
access_token = model.token.create_delegate_token("devtable", "simple", "sometoken")
|
|
token = _token(ACCESS_TOKEN_USERNAME, access_token.get_code())
|
|
result = validate_basic_auth(token)
|
|
assert result == ValidateResult(AuthKind.basic, token=access_token)
|
|
|
|
|
|
def test_valid_oauth(app):
|
|
user = model.user.get_user("devtable")
|
|
app = model.oauth.list_applications_for_org(model.user.get_user_or_org("buynlarge"))[0]
|
|
oauth_token, code = model.oauth.create_access_token_for_testing(
|
|
user, app.client_id, "repo:read"
|
|
)
|
|
token = _token(OAUTH_TOKEN_USERNAME, code)
|
|
result = validate_basic_auth(token)
|
|
assert result == ValidateResult(AuthKind.basic, oauthtoken=oauth_token)
|
|
|
|
|
|
def test_valid_app_specific_token(app):
|
|
user = model.user.get_user("devtable")
|
|
app_specific_token = model.appspecifictoken.create_token(user, "some token")
|
|
full_token = model.appspecifictoken.get_full_token_string(app_specific_token)
|
|
token = _token(APP_SPECIFIC_TOKEN_USERNAME, full_token)
|
|
result = validate_basic_auth(token)
|
|
assert result == ValidateResult(AuthKind.basic, appspecifictoken=app_specific_token)
|
|
|
|
|
|
def test_invalid_unicode(app):
|
|
token = b"\xebOH"
|
|
header = "basic " + b64encode(token).decode("ascii")
|
|
result = validate_basic_auth(header)
|
|
assert result == ValidateResult(AuthKind.basic, missing=True)
|
|
|
|
|
|
def test_invalid_unicode_2(app):
|
|
token = "“4JPCOLIVMAY32Q3XGVPHC4CBF8SKII5FWNYMASOFDIVSXTC5I5NBU”".encode("utf-8")
|
|
header = "basic " + b64encode(b"devtable+somerobot:%s" % token).decode("ascii")
|
|
result = validate_basic_auth(header)
|
|
assert result == ValidateResult(
|
|
AuthKind.basic,
|
|
error_message="Could not find robot with username: devtable+somerobot and supplied password.",
|
|
)
|
|
|
|
|
|
def test_invalid_unicode_3(app):
|
|
token = "sometoken"
|
|
auth = "“devtable+somerobot”:" + token
|
|
auth = auth.encode("utf-8")
|
|
header = "basic " + b64encode(auth).decode("ascii")
|
|
result = validate_basic_auth(header)
|
|
assert result == ValidateResult(
|
|
AuthKind.basic, error_message="Could not find robot with specified username",
|
|
)
|