mirror of
https://github.com/quay/quay.git
synced 2026-01-27 18:42:52 +03:00
konflux/mintmaker/master/python-gitlab-2.x
9 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
jbpratt
|
c6eb6b573d |
test(web): migrate more tests to playwright (#4773)
* test(web): migrate superuser-org-actions.cy.ts to Playwright Migrate Cypress E2E tests for superuser organization actions to Playwright following the project's MIGRATION.md guidelines. Changes: - Add new test file: playwright/e2e/superuser/org-actions.spec.ts - Consolidate 12 Cypress tests into 5 focused Playwright tests - Use real API data instead of mocked fixtures - Auto-cleanup via TestApi fixture Test coverage: - Superuser sees actions column and options menu for organizations - Regular user does not see organization options menu - Superuser can rename organization - Superuser can delete organization - Superuser can take ownership of organization Skipped from migration: - Quota menu tests (already covered by quota.spec.ts) - Fresh login requirement tests (low value, complex to mock) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(web): set superuser feature tag Signed-off-by: Brady Pratt <bpratt@redhat.com> * test(web): migrate superuser-messages.cy.ts to Playwright Migrate superuser messages tests from Cypress to Playwright, consolidating 14 original tests into 6 focused, value-add tests. Tests cover: - Non-superuser redirect to organization page - Full CRUD flow: create, view, and delete messages via UI - Error state when API fails to load messages - Loading spinner during message fetch - Read-only superuser can access and view messages - Read-only superuser sees disabled create/delete actions Infrastructure additions: - Add message() method to TestApi with auto-cleanup - Add CreatedMessage interface for type safety - Add SUPERUSERS_FULL_ACCESS feature tag 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(web): migrate superuser-user-management.cy.ts to Playwright Consolidates 29 Cypress tests into 11 Playwright tests covering superuser user management functionality. Changes: - Add CreatedUser interface and user() method to TestApi for user creation with auto-cleanup - Add createUserAsSuperuser() to API client using superuser endpoint - Add QuayAuthType and skipUnlessAuthType() helper for auth-type conditional tests - Create user-management.spec.ts with consolidated tests Tests cover: - Create user via UI (Database/AppToken auth only) - User access control based on user type - Change email and password (Database auth only) - Toggle user status (disable/enable) - Delete user - Take ownership (convert user to org) - Fresh login error handling with mocked responses - Send recovery email (MAILING feature) - Auth type visibility Key patterns: - Uses search to find users in paginated list - page.route() only for error scenarios per MIGRATION.md - skipUnlessAuthType() for auth-dependent tests - @feature:SUPERUSERS_FULL_ACCESS tag for all tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): delete more migrated cypress tests Signed-off-by: Brady Pratt <bpratt@redhat.com> * test(web): migrate superuser-framework Cypress test to Playwright Consolidates 7 Cypress tests into 4 Playwright tests covering: - Superuser navigation to all superuser pages - Navigation section visibility and expansion - Organizations table Settings column and actions menu - Regular user restrictions and redirects Uses real superuserPage/authenticatedPage fixtures instead of mocking. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): migrate superuser-service-keys Cypress test to Playwright Consolidates 17 Cypress tests into 5 Playwright tests: - non-superuser redirect to organization page - superuser CRUD lifecycle (create, view, search, update, delete) - error handling when create fails - read-only superuser permission restrictions - bulk select and delete operations Adds service key API methods to Playwright test utilities: - getServiceKeys, createServiceKey, updateServiceKey, deleteServiceKey - TestApi.serviceKey() with auto-cleanup support 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(web): migrate superuser-change-log Cypress test to Playwright Migrate superuser-change-log.cy.ts to Playwright with test consolidation: - 7 original tests reduced to 2 focused tests - Access control tests already covered by framework.spec.ts - Loading spinner and empty state tests skipped (low value) - Uses real API calls except for error state (acceptable mock) - No PatternFly class dependencies, uses role-based selectors 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(web): migrate superuser-usage-logs Cypress test to Playwright - Consolidate 7 Cypress tests into 2 Playwright tests - Access control tests already covered by framework.spec.ts - Add data-testid="usage-logs-table" to UsageLogsTable component - Tests verify: page header, date pickers, chart toggle, table loading, and filter functionality - Use structural assertions for parallel test safety 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Brady Pratt <bpratt@redhat.com> * test(web): remove unneeded comments Signed-off-by: Brady Pratt <bpratt@redhat.com> --------- Signed-off-by: Brady Pratt <bpratt@redhat.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> |
||
|
jbpratt
|
0638c19183 |
test(web): migrate more tests to playwright (#4767)
* test(web): migrate repository-autopruning to Playwright Consolidate 17 Cypress tests into 6 Playwright tests: - policy lifecycle (create, update, delete) - policy with tag pattern filter - multiple policies lifecycle - namespace policy display in repository settings - registry policy display - error handling (load failure) Uses @feature:AUTO_PRUNE tag for automatic test skipping. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test: enable features by default Signed-off-by: Brady Pratt <bpratt@redhat.com> * test(web): migrate create-account.cy.ts to Playwright Migrates the Create Account Cypress tests to Playwright following the MIGRATION.md guide: - Consolidates 10 Cypress tests into 6 focused Playwright tests - Uses real API calls instead of mocks - Adds data-testid attributes to CreateAccount component - Uses @feature:MAILING and @feature:QUOTA_MANAGEMENT tags to skip tests when features are not enabled - Creates custom fixtures for unauthenticated page access - Implements proper user cleanup after tests Tests: - form validation prevents invalid submissions - creates account with valid inputs and redirects - shows error for existing username - navigates to signin page via link - shows verification message (requires MAILING) - redirects to updateuser (requires QUOTA_MANAGEMENT) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Brady Pratt <bpratt@redhat.com> * chore(dev) add Mailpit for local email testing Add Mailpit email testing server to the local development environment to enable testing of FEATURE_MAILING functionality with Playwright. Changes: - Add mailpit service to docker-compose.yaml (ports 8025/1025) - Enable FEATURE_MAILING and configure SMTP settings in config.yaml - Add mailpit utilities to Playwright fixtures (getEmails, clearInbox, waitForEmail, getEmailBody, isAvailable) Usage: podman-compose up mailpit -d # Access Web UI at http://localhost:8025 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(web) use mailpit helpers for email confirmation support Test updates: - "creates account and redirects to organization" now confirms email - "redirects to updateuser when user has prompts" now confirms email - Tests detect FEATURE_MAILING at runtime and adapt accordingly - Email search uses recipient address for parallel test safety 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Brady Pratt <bpratt@redhat.com> * test(web): use mailpit for email notification test Replace mocked email authorization with real Mailpit verification in the notifications.spec.ts test. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Brady Pratt <bpratt@redhat.com> * test(web): mock user response in cypress test this broke when mailing was enabled Signed-off-by: Brady Pratt <bpratt@redhat.com> --------- Signed-off-by: Brady Pratt <bpratt@redhat.com> Co-authored-by: Claude <noreply@anthropic.com> |
||
Shaon H
|
8485956048 |
fix(web): display layers for multi-arch manifests (PROJQUAY-10020) (#4761)
When viewing a child manifest of a multi-architecture image, the Layers tab was showing "No layers found" because manifestData was fetched for the parent manifest list digest (which has no layers) but never re-fetched when the user selected a specific architecture. Fix: Make the Layers component fetch its own manifest data based on the digest prop using a new useManifestByDigest hook. This ensures layers are fetched for the correct child manifest digest. Changes: - Add useManifestByDigest hook using React Query - Update Layers component to fetch manifest data internally - Remove manifestData prop from Layers in TagDetailsTabs - Add Playwright e2e tests for multi-arch manifest layers 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> |
||
|
jbpratt
|
ef1974688e |
test(web): migrate more tests to playwright (#4762)
* test(web): migrate repository-shorthand-navigation to Playwright Migrate Cypress shorthand URL navigation tests to Playwright with real resources instead of mocked API responses. Consolidates 11 tests into 7. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): migrate repository-permissions to Playwright Migrate repository-permissions.cy.ts to Playwright, consolidating 6 Cypress tests into 3 Playwright tests covering: - Inline permission display, change, and delete operations - Bulk permission change and delete operations - Adding permissions for robots and teams Changes: - Add repository permission API utilities to client.ts - Add api.repositoryPermission() helper with auto-cleanup - Add data-testid attributes to PermissionsToolbar and AddPermission - Update MIGRATION.md checklist (11 migrated, 20%) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): migrate repository-notifications to Playwright Migrate 18 Cypress tests from repository-notifications.cy.ts to 7 consolidated Playwright tests covering notification CRUD operations, bulk actions, and recipient field functionality. Changes: - Add notification API utilities to client.ts - Add notification() method to TestApi for auto-cleanup - Add IMAGE_EXPIRY_TRIGGER to QuayFeature type - Add data-testid attributes to notification form components - Create notifications.spec.ts with 7 focused tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): migrate repositories-list to Playwright Migrate repositories-list.cy.ts from Cypress to Playwright, consolidating 11 tests into 6 focused e2e tests: - displays repositories in global and organization views - creates repositories with different visibility and namespaces - deletes multiple repositories via bulk action - changes visibility for multiple repositories - searches by name and supports regex mode - searches by name including organization Skipped pagination tests (test PatternFly, not app code). Added data-testid attributes: - CreateRepoModalTemplate: form inputs, visibility radios, buttons - BulkDeleteModalTemplate: modal, confirmation input - RepositoryToolBar: visibility confirmation buttons 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): migrate robot-accounts to Playwright Migrate robot-accounts.cy.ts from Cypress to Playwright, consolidating 12 tests into 4 focused e2e tests: - CRUD lifecycle: create, search, toolbar, and delete robot account - robot credentials and Kubernetes secrets - robot repository permissions: update single permission - robot wizard: org has 5 steps, user namespace has 3 steps Added data-testid attributes: - CreateRobotAccountModal: modal container - RobotTokensModal: regenerate button, token display, docker/podman commands - robotAccountWizard: step navigation, name/description inputs - ExpandCollapseButton, SearchInput, ToolbarButton: pass-through testid - RobotAccountKebab: menu items for permissions, tokens, delete - RobotAccountsList: table container 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): remove migrated cypress tests Signed-off-by: Brady Pratt <bpratt@redhat.com> --------- Signed-off-by: Brady Pratt <bpratt@redhat.com> Co-authored-by: Claude <noreply@anthropic.com> |
||
|
jbpratt
|
5a86c7a57f |
test(web): migrate some tests and improve framework (#4760)
* test(web): migrate logout Cypress test to Playwright Uses unique temporary users per test to avoid session invalidation conflicts when running in parallel. Quay's signout endpoint invalidates all sessions for a user, which would break parallel tests sharing users. Also documents the session-destructive test pattern in MIGRATION.md. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): migrate mirroring Cypress test to Playwright Migrates web/cypress/e2e/mirroring.cy.ts to Playwright following the MIGRATION.md guide. Consolidates 18 Cypress tests into 5 Playwright tests using real API calls instead of mocks. Changes: - Add mirroring API utilities to client.ts (changeRepositoryState, createMirrorConfig, getMirrorConfig, updateMirrorConfig, triggerMirrorSync, cancelMirrorSync) - Create mirroring.spec.ts with 5 consolidated tests covering: - State warning and form visibility - New mirror configuration lifecycle - Existing mirror configuration management - Sync operations - Error handling (only mock used for 400 error scenario) - Update MIGRATION.md checklist (8/54, 15%) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): add TestApi fixture with auto-cleanup for Playwright tests Introduce a TestApi class that wraps ApiClient and automatically tracks created resources for cleanup after each test. This eliminates the need for manual beforeEach/afterEach cleanup patterns and ensures resources are always cleaned up even when tests fail. Changes: - Add TestApi class to fixtures.ts with methods for creating orgs, repos, teams, robots, and prototypes with auto-cleanup - Add api and superuserApi fixtures that provide TestApi instances - Migrate all committed Playwright tests to use the new api fixture - Update MIGRATION.md with documentation for the new pattern The api fixture provides: - api.organization(prefix?) - creates org with unique name - api.repository(namespace?, prefix?, visibility?) - creates repo - api.team(orgName, prefix?, role?) - creates team - api.robot(orgName, prefix?, description?) - creates robot - api.prototype(orgName, role, delegate, activatingUser?) - creates default permission - api.setMirrorState(namespace, repoName) - sets repo to MIRROR state - api.raw - access underlying ApiClient for non-tracked operations Resources are cleaned up in reverse order (LIFO) after each test. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): remove migrated tests Signed-off-by: Brady Pratt <bpratt@redhat.com> * test(web): auto-skip Playwright tests based on @feature: tags Adds an auto-fixture to fixtures.ts that automatically skips tests when their @feature:X tags reference disabled Quay features. This eliminates duplication between tags and manual test.skip() calls. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix(web): set axios baseURL at module level for all routes (PROJQUAY-0000) Previously axios baseURL was only set inside StandaloneMain component, causing requests from /signin and other auth routes to go to the wrong URL (localhost:9000 instead of localhost:8080). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): use cy.session() for Cypress authentication Replace manual CSRF token + loginByCSRF pattern with cy.session() for proper session handling. Fixes race condition where React app made API calls before Cypress login completed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): fix notification drawer test flakiness with toPass polling Use Playwright's toPass to poll for notification appearance instead of a single assertion. The backend may take time to process push notifications, so reload and retry until the notification is visible. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Signed-off-by: Brady Pratt <bpratt@redhat.com> Co-authored-by: Claude <noreply@anthropic.com> |
||
|
jbpratt
|
05495a2995 |
test(web): migrate more tests to playwright (#4741)
* test(web): migrate notification-drawer Cypress test to Playwright Convert the notification-drawer.cy.ts test from mocked API responses to real API interactions. The test now creates a repository, configures a quay_notification for repo_push events, pushes an image to trigger the notification, then validates the drawer UI behavior (open, read, delete). Adds createRepositoryNotification method to the Playwright API client. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): migrate default-permissions Cypress test to Playwright - Add robot and prototype API methods to test client - Fix undefined allMembers bug in CreateTeamWizard.tsx - Fix missing return value in AddTeamMember.tsx setDeletedTeamMembers - Tests run in parallel with isolated state per test Co-authored-by: Claude <noreply@anthropic.com> * test(web): migrate external-scripts Cypress test to Playwright Co-authored-by: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> |
||
|
jbpratt
|
0ac8499067 |
test(web): consolidate Playwright API utils into ApiClient class (#4739)
* test(web): consolidate Playwright API utils into ApiClient class Migrate from individual function-based API utilities to a unified ApiClient class with CSRF token caching. This eliminates redundant token requests when tests make multiple API calls. Key changes: - Create ApiClient class with cached CSRF token - Add signIn() method for authentication flows - Update all test files to use ApiClient instances - Remove individual api/csrf.ts, organization.ts, repository.ts, team.ts, user.ts files in favor of single client.ts - Update fixtures.ts to use ApiClient for login 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Brady Pratt <bpratt@redhat.com> * test(web): run playwright on small machine for chrome only while we are migrating, swap things around to save time and money Signed-off-by: Brady Pratt <bpratt@redhat.com> --------- Signed-off-by: Brady Pratt <bpratt@redhat.com> Co-authored-by: Claude <noreply@anthropic.com> |
||
|
jbpratt
|
c52deaa6b3 |
test(web): migrate some cypress tests to playwright (#4734)
* test(web): migrate theme-switcher tests from Cypress to Playwright Replace Cypress theme-switcher.cy.ts with Playwright equivalent. Uses real API calls instead of mocked intercepts per migration guide. Tests theme toggle visibility, persistence, and browser color scheme detection via Playwright's emulateMedia API. - Add data-testid to user-menu-toggle for stable selector - Create playwright/e2e/ui/theme-switcher.spec.ts with 3 test cases - Update MIGRATION.md checklist (2/54 migrated) - Delete original Cypress test file 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): migrate breadcrumbs tests from Cypress to Playwright Add organization, team, and container API utilities to support the breadcrumbs test migration. Tests cover: - List pages (no breadcrumbs) - Organization, repository, tag, and team page breadcrumbs - Edge cases with same-name org/repo/team combinations The container utility supports both podman and docker for pushing test images when testing tag breadcrumbs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test(web): migrate overview tests from Cypress to Playwright Migrates web/cypress/e2e/overview.cy.ts to Playwright with 4 tests: - Expandable dropdowns show content - External links navigate correctly - Tabs switch content correctly - Purchase plans dropdown shows pricing options Uses getByRole for tab selection instead of PatternFly-generated IDs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Brady Pratt <bpratt@redhat.com> * test(ci): ignore test files for web preview no need in deploying the web preview if only tests or docs are modified Signed-off-by: Brady Pratt <bpratt@redhat.com> --------- Signed-off-by: Brady Pratt <bpratt@redhat.com> Co-authored-by: Claude <noreply@anthropic.com> |
||
|
jbpratt
|
69b7aff5b4 |
chore: add Playwright e2e test infrastructure (#4688)
* chore: add Playwright e2e test infrastructure Add Playwright test framework with custom fixtures for authenticated contexts, API utilities for test data management, and repository delete test as initial migration from Cypress. Key additions: - global-setup.ts: Creates admin, testuser, readonly test users - fixtures.ts: Pre-authenticated page/request fixtures by role - utils/api.ts: CRUD utilities for repositories - MIGRATION.md: Guide for migrating Cypress tests to Playwright - repository-delete.spec.ts: First migrated test with full cleanup 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Brady Pratt <bpratt@redhat.com> * chore: update web/.dockerignore exclude tests from being included in the intermediate build - this should improve caching when only tests change Signed-off-by: Brady Pratt <bpratt@redhat.com> * chore: add pre-commit check to block new cypress tests Signed-off-by: Brady Pratt <bpratt@redhat.com> --------- Signed-off-by: Brady Pratt <bpratt@redhat.com> Co-authored-by: Claude <noreply@anthropic.com> |