- Bump trivy adapter version to v0.39.1 (ref: #24080)
- Bump distribution version to v2.8.3-harbor.2 (ref: #23991)
(cherry picked from commit 0c7f91025d)
Signed-off-by: stonezdj <stonezdj@gmail.com>
* ci: migrate all GitHub workflows to CNCF-hosted runners
Replace the Oracle self-hosted labels and the GitHub-hosted defaults with
the CNCF runner pool:
oracle-vm-24cpu-96gb-x86-64 -> cncf-ubuntu-16-64-x86
ubuntu-latest -> cncf-ubuntu-16-64-x86
ubuntu-24.04-arm -> cncf-ubuntu-16-64-arm
The arm64 leg of the BUILD_PACKAGE matrix keeps building natively, now on
cncf-ubuntu-16-64-arm.
Signed-off-by: Vadim Bauer <vadim@8gears.com>
Signed-off-by: Vadim Bauer <vb@container-registry.com>
* ci: run pass-CI no-op stubs on the smallest CNCF runner
The pass-CI jobs only exist to satisfy required status checks on skipped
paths and execute nothing, so cncf-ubuntu-2-8-x86 is sufficient.
Signed-off-by: Vadim Bauer <vadim@8gears.com>
Signed-off-by: Vadim Bauer <vb@container-registry.com>
* ci: fix silently-disabled Go caching and cache CI Go tools
actions/setup-go ran before actions/checkout, so it looked for go.sum in an
empty workspace and logged:
Restore cache failed: Dependencies file is not found in
/home/ubuntu/_work/harbor/harbor. Supported file pattern: go.sum
With cache: true (the v5 default) this silently no-ops, so GOMODCACHE and
GOCACHE were cold on every job of every run. Checkout now runs first, and
cache-dependency-path points at src/go.sum under the checkout path.
Also cache $GOPATH/bin and only build the three CI tools and golangci-lint
when they are missing, instead of recompiling them from source every run.
Signed-off-by: Vadim Bauer <vadim@8gears.com>
Signed-off-by: Vadim Bauer <vb@container-registry.com>
* fix(make): resolve Go tool paths against the first GOPATH entry
CI sets GOPATH to a colon-separated list (go env GOPATH plus the workspace),
so $(shell go env GOPATH)/bin/golangci-lint expanded to the nonexistent path
'/home/ubuntu/go:/home/ubuntu/_work/harbor/harbor/bin/golangci-lint'.
This was masked because ut_install.sh installed golangci-lint using the same
broken expression, so both sides agreed on the same bogus location. Resolving
the tool against the first GOPATH entry (where go install actually writes
binaries) makes the path correct in both the single-entry and list cases.
Signed-off-by: Vadim Bauer <vadim@8gears.com>
Signed-off-by: Vadim Bauer <vb@container-registry.com>
* test(portal): wait for pagination control before clicking
The spec queried .pagination-next immediately after whenStable() and clicked
it, so it failed whenever the datagrid had not rendered yet. Retry the lookup
until the control appears.
Signed-off-by: Vadim Bauer <vadim@8gears.com>
Signed-off-by: Vadim Bauer <vb@container-registry.com>
* test: do not reuse cached go test results
With GOCACHE persisted across CI runs, go test replayed cached results instead
of executing the tests. Harbor's tests share a database across packages, so a
package that re-ran could observe state that the replayed packages never
created. -count=1 forces tests to run while still reusing the compilation cache.
Signed-off-by: Vadim Bauer <vadim@8gears.com>
Signed-off-by: Vadim Bauer <vb@container-registry.com>
* ci: fix Go caching in build-package and conformance, pin misspell
build-package.yml and conformance_test.yml also ran setup-go before checkout,
so their caches failed open exactly as CI.yml's did. Checkout now runs first
in both, with cache-dependency-path set.
cover and goveralls were installed but never used: goveralls is only named in a
commented-out line in ut_run.sh, and go test -cover uses the built-in tool, not
golang.org/x/tools/cmd/cover. Drop both and pin misspell, which make misspell
does invoke, so the cached tool version is reproducible.
Signed-off-by: Vadim Bauer <vadim@8gears.com>
Signed-off-by: Vadim Bauer <vb@container-registry.com>
---------
Signed-off-by: Vadim Bauer <vadim@8gears.com>
Signed-off-by: Vadim Bauer <vb@container-registry.com>
* bump: bump up trivy adapter version to v0.37.2-rc2
Update TRIVYADAPTERVERSION to v0.37.2-rc2 in Makefile.
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
* bump: bump up Go version to v1.26.4
Update Go version from 1.26.3 to 1.26.4 across makefiles, configuration, CI workflows, and documentation.
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
---------
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Signed-off-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com>
Upgrade Harbor UI to Angular 21, Clarity v18, and Node.js v22
- Upgrade the Harbor UI (src/portal) from Angular 16 to Angular 19 and subsequently to Angular 21.
- Upgrade VMware Clarity from v17 to v18, and Node.js from v20 to v22 (updated .nvmrc, CI.yml, Makefile, Dockerfile).
- Migrate Angular templates to the new @if/@for control flow syntax.
- Fix UI issues #1 through #35, including robot accounts, layout, dropdown overlay, and input styling.
- Fix unit tests: resolve NG0100 ExpressionChangedAfterItHasBeenCheckedError in policy.component.spec.ts, replace autoDetectChanges(true) with explicit detectChanges cycles, and use TestBed.overrideComponent to stub AddP2pPolicyComponent template.
- Fix Clarity v18 breaking changes: update dark-theme SCSS import, add cds-theme attribute for theming, update ClrDatagridStateInterface import path, add ClrIconModule to app module.
- Stabilize npm installs and resolve CI/CD pipeline hangs.
- Fix swagger-ui crash caused by React 19 createRoot removal:
- swagger-ui 5.28+ resolves a nested react-dom@19 which removed createRoot
from the main react-dom entry point (moved to react-dom/client). The
swagger-ui-es-bundle-core.js still imports createRoot from react-dom,
making it undefined and causing "TypeError: i is not a function" at render.
- app-swagger-ui/webpack.prod.js: alias bare 'swagger-ui' import to
swagger-ui-bundle.js (the standalone UMD build that ships with React 18
already bundled), bypassing the broken external react-dom@19 entirely.
- app-swagger-ui/package.json: add npm overrides to pin react and
react-dom to ^18.3.1 so future npm installs do not re-introduce React 19.
- angular.json: expose swagger-ui.bundle.js and swagger-ui-index.html
from app-swagger-ui/dist as Angular dev-server assets, enabling the
proxy to serve the locally built, fixed bundle during development.
- Convert eslint-plugin-header config from JSON to JS to apply the ESLint 9 schema fix at config-load time, removing the need for patch-package.
- Pin all dependency versions to exact installed versions from the lock file, and remove unused prettier-eslint package.
- Fix flake in P2pProviderService unit test by initializing date with 0 milliseconds to prevent cross-second duration calculation mismatches.
Signed-off-by: Ashish Patel <zoom2ashish@gmail.com>
Co-authored-by: stonezdj <stone.zhang@broadcom.com>
fix: support arm64 valkey build while preserving amd64 package path
- Keep amd64 behavior unchanged with tdnf install of valkey
- Isolate source-build fallback to arm64 only
- Verify source tarball with SHA256
- Move valkey version/checksum definition to root Makefile and pass as build args
Signed-off-by: ranimandepudi <ranichowdary.mandepudi@arm.com>
fix UT failures for Go 1.26.3 compatibility
Add //nolint:revive to packages whose names shadow Go stdlib
Fix mock file import ordering (goimports compliance)
Bump golangci-lint from v2.8.0 to v2.9.0 for Go 1.26 support
Update CI step label to reflect Go 1.26
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
* support configurable PIP_INDEX_URL for swagger client build
Pass PIP_INDEX_URL through Makefile (conditional env injection),
APITest-Util.robot (robot variable with public PyPI default), and
Group3-Upgrade/run.sh (-v forwarding to robot).
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
* wait more time for proxy cache ready
refine proxy cache test in migration prepare
Signed-off-by: stonezdj <stonezdj@gmail.com>
---------
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Signed-off-by: stonezdj <stonezdj@gmail.com>
PR #23205 added PIP_INDEX_URL plumbing but did not set a default, so when
the variable is unset the top-level Makefile forwarded an empty value to
the photon sub-make. The sub-make in turn passed `--build-arg pip_index_url=`
to `docker build`, which overrides the Dockerfile.base ARG default with an
empty string and breaks `pip3 install pipenv ... --index-url ` (the option
requires an argument). This caused the BUILD_PACKAGE jobs on main to fail.
Mirror the existing NPM_REGISTRY pattern by providing a default value for
PIP_INDEX_URL in the top-level Makefile.
Signed-off-by: Vadim Bauer <vb@container-registry.com>
Co-authored-by: Orlix <7236111+OrlinVasilev@users.noreply.github.com>
build: support custom PyPI index URL for prepare image builds
Pass PIP_INDEX_URL through the make build chain as a Docker --build-arg,
mirroring the existing NPM_REGISTRY pattern for the portal build.
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
This commit bumps up trivy to v0.69.1 and trivy adapter to v0.35.0-rc.2
It also updates the setting of revive to skip a package naming error
Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com>
1, bump go version from v1.24.6 to v1.25.6
2, temp workaround the lint issue.
3, fix the relevant compitable issues that introduced by go v1.25.
Signed-off-by: wang yan <yan-yw.wang@broadcom.com>
Co-authored-by: wang yan <yan-yw.wang@broadcom.com>
fix: resolve 'docker-compose: command not found' error
Add fallback to support Docker Compose V2 plugin format when
standalone docker-compose binary is not available.
Signed-off-by: coldenchen <coldenchen@tencent.com>
Co-authored-by: coldenchen <coldenchen@tencent.com>
remove extra build_base=false && pull_base_from_dockerhub=false logic
we do not block the case using local chached image(docker build --pull=false) while build_base=false
However we need gurantee always pull latest image while build package
And when there's some rate limit issue in the CICD situation we could set pull_base_from_dockerhub=false
Signed-off-by: my036811 <miner.yang@broadcom.com>
add BUILD_INSTALLER parameter to optionally build prepare and log container only when we need to build offline_installer
Signed-off-by: my036811 <miner.yang@broadcom.com>
* bump up golang version to v1.24.3
Signed-off-by: wang yan <wangyan@vmware.com>
* bump mockery version to support golang v2.14
Signed-off-by: wang yan <wangyan@vmware.com>
---------
Signed-off-by: wang yan <wangyan@vmware.com>
As the harbor exporter is not a core component for installation, so like the trivy, add a flag to controller whether package it into the offline installer.
Signed-off-by: wang yan <wangyan@vmware.com>
