Kunal Kushwaha
23b5f8c99f
BugFix: nil retured for string.
...
Build break on windows. introduced with PR #2207
Signed-off-by: Kunal Kushwaha <kushwaha_kunal_v7@lab.ntt.co.jp >
2015-11-12 16:00:32 +09:00
Olivier Gambier
89d9854943
Another pass at linting
...
Signed-off-by: Olivier Gambier <olivier@docker.com >
2015-11-10 16:58:14 +01:00
David Gageot
fb986b23e0
Merge pull request #2207 from jeanlaurent/1737-virtualbox-installation-path
...
Fix #1737 - Detect non default VirtualBox Installation Path
2015-11-10 10:02:38 +01:00
Jean-Laurent de Morlhon
b6ca1035bd
Fix for #1737 - Better detect non default VirtualBox Installation Path
...
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net >
2015-11-10 09:52:38 +01:00
David Gageot
a5a53bfbdd
Merge pull request #2212 from nathanleclaire/b2d_regression
...
Fix boot2docker import regression
2015-11-07 16:13:11 +01:00
Nathan LeClaire
ad757310fb
Fix boot2docker import regression
...
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com >
2015-11-06 17:10:41 -08:00
Amir Mohammad Saied
a6c44f5d4e
Use rackspace's specialized client
...
`openstack.NewDerivedDriver` sets client to `openstack.GenericClient`
therefore `rackspace.Client` is getting ignored.
`rackspace.Client.Authenticate` has different semantics than
`openstack.GenericClient.Authenticate`, thus almost all operations with
`rackspace` driver fail at the moment.
Signed-off-by: Amir Mohammad Saied <amirsaied@gmail.com >
2015-11-06 18:30:31 +00:00
David Gageot
4ac76457f9
Merge pull request #2199 from nathanleclaire/none_running
...
Change default state of none driver to state.Running
2015-11-06 07:59:49 +01:00
Nathan LeClaire
ac6a18ba25
Change none default state to Running
...
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com >
2015-11-05 18:37:15 -08:00
Olivier Gambier
d2ada6488c
Lint
...
Signed-off-by: Olivier Gambier <olivier@docker.com >
2015-11-05 13:34:07 -08:00
David Gageot
11922080a1
FIX #2171 Fix faulty flag and add tests for SetConfigFromFlags
...
Signed-off-by: David Gageot <david@gageot.net >
2015-11-05 18:57:03 +01:00
Nathan LeClaire
6be950f1c0
Merge pull request #2117 from dmp42/08-carry-on-2033
...
Carry on commits from #2033
2015-11-04 16:41:40 -08:00
Olivier Gambier
34ee11e51d
Merge pull request #2116 from dgageot/1628-oauth2
...
Move `goauth2/oauth` dependency to `golang.org/x/oauth2`
2015-11-04 08:54:20 -08:00
David Gageot
840ed7cc15
Migrate Digital Ocean driver to oauth2
...
Signed-off-by: David Gageot <david@gageot.net >
2015-11-04 10:20:44 +01:00
root
d1712e0cd3
Introduced a new flag for google driver:
...
--google-use-internal-ip
Signed-off-by: Mariusz Woloszyn <emsi@EmsiOSX.dom.qpqp01.pl >
2015-11-04 09:10:29 +00:00
David Gageot
7f5983b703
Merge pull request #2113 from dgageot/gce-custom-images
...
Fixes #1243 Custom GCE images support
2015-11-04 09:00:20 +01:00
Nathan LeClaire
c6d6eb863a
Merge pull request #2151 from todorez/fix-ip-clash
...
Fix DHCP server and host-only adapter IP address clash
2015-11-03 12:06:26 -08:00
Nathan LeClaire
9a4bc9a20d
Ensure that ls will still work when plugin cannot be found
...
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com >
2015-11-03 11:35:30 -08:00
Todor Minchev
36ca9c6063
Fix DHCP server and host-only adapter IP address clash
...
When setting up a host-only network we need to pass the IP address
of the host adapter (e.g 192.168.99.1) to the getRandomIPinSubnet function.
Passing the network address (e.g 192.168.1.0) can result in bypassing the IP
clash check and having the same address assigned to both the DHCP server
and the host-only network interface.
Signed-off-by: Todor Minchev <todor.minchev@linux.intel.com >
2015-11-03 11:26:31 -08:00
Olivier Gambier
ae2d344c2b
Carry on commits from #2033
...
A couple of small cleanup and enhancements that were dropped after the revert.
Signed-off-by: Olivier Gambier <olivier@docker.com >
2015-10-30 16:33:26 -07:00
David Gageot
0176f05db8
FIX #2127 Detect that HW virtualization is not supported
...
Signed-off-by: David Gageot <david@gageot.net >
2015-10-30 16:19:38 +01:00
Nathan LeClaire
92d67ff13f
Merge pull request #850 from dudymas/feat/openstack-nova-ip-pools
...
feature to fix #737 - openstack driver can use nova to allocate floating ips
2015-10-29 12:33:43 -07:00
aperepel
914ccb6968
Fixes #1243 Custom GCE images support
...
Signed-off-by: Andrew Grande <aprepel@gmail.com >
Signed-off-by: David Gageot <david@gageot.net >
2015-10-29 11:11:32 +01:00
David Gageot
b213da0961
Use PreCreateCheck to check the project/credentials
...
Signed-off-by: David Gageot <david@gageot.net >
2015-10-29 10:05:24 +01:00
Nathan LeClaire
232c611464
Merge pull request #2087 from dgageot/gce-default-auth
...
Use Google default authentication
2015-10-28 15:18:24 -07:00
David Gageot
970c630fd3
FIX #2093 warn in case we think VT-X is not enabled.
...
Signed-off-by: David Gageot <david@gageot.net >
2015-10-28 22:22:04 +01:00
David Gageot
77c2bbcdd2
FIX #2023 and #1061 Use google default authentication
...
Signed-off-by: David Gageot <david@gageot.net >
2015-10-28 22:16:22 +01:00
Flavio Castelli
2339e548f6
Fix panic when using openstack driver
...
The openstack driver was unusable because some cli flags were redifined.
That caused a runtime error like:
create flag redefined: openstack-ssh-user
panic: create flag redefined: openstack-ssh-user
Signed-off-by: Flavio Castelli <fcastelli@suse.com >
2015-10-28 08:53:54 +01:00
David Gageot
d316eb7e96
Print a better error when virtualbox fails
...
Instead of printing `exit status 1` we'll print
the stderr output
Signed-off-by: David Gageot <david@gageot.net >
2015-10-27 15:23:29 +01:00
David Gageot
6c5dc41e6d
Revert "Remove useless duplication on GetSSHHostname"
...
This reverts commit b6462eb6d0 .
Signed-off-by: David Gageot <david@gageot.net >
2015-10-26 18:47:14 +01:00
David Gageot
57dc1156de
Revert "Remove duplication over GetIP"
...
This reverts commit 99aacc7b79 .
Signed-off-by: David Gageot <david@gageot.net >
2015-10-26 18:47:03 +01:00
David Gageot
a7559fd3a8
Revert "Generic and Base slight cleanups"
...
This reverts commit 19625def22 .
Signed-off-by: David Gageot <david@gageot.net >
2015-10-26 18:46:54 +01:00
Nathan LeClaire
8b9291de64
Merge pull request #2033 from dmp42/03-cleanup
...
Code cleanup
2015-10-23 11:27:44 -07:00
Olivier Gambier
19625def22
Generic and Base slight cleanups
...
- tests for GetIP
- extract default values into consts (user & port)
- better error handling (cert permissions change)
- unexport Driver for generic (linting)
- ordering of methods and variables for better readability
Signed-off-by: Olivier Gambier <olivier@docker.com >
2015-10-23 10:38:57 -07:00
Olivier Gambier
4e7f8ed7a6
Merge pull request #1856 from databus23/b2d_gh_enterprise_urls
...
support github enterprise urls for b2d downloads
2015-10-23 10:37:46 -07:00
Olivier Gambier
11fd9648ac
Merge pull request #1639 from feelobot/validate-ec2-vpc-id-matches-subnet-id
...
Use SDK to Validate VpcID with SubnetId
2015-10-22 09:52:18 -07:00
Fabian Ruff
5021ffd2e7
support github enterprise urls for b2d downloads
...
This commit allows downloading boot2docker releases not only from the official releases url (https://api.github.com/repos/boot2docker/boot2docker/releases ) but from arbitrary github repositories that publish releases with a boot2docker.iso artifact. It also supports downloading from github enterprise.
Signed-off-by: Fabian Ruff <fabian@progra.de >
2015-10-22 16:12:21 +02:00
Olivier Gambier
99aacc7b79
Remove duplication over GetIP
...
+ ip address proper validation
Signed-off-by: Olivier Gambier <olivier@docker.com >
2015-10-21 13:48:13 -07:00
Olivier Gambier
b6462eb6d0
Remove useless duplication on GetSSHHostname
...
Signed-off-by: Olivier Gambier <olivier@docker.com >
2015-10-21 13:48:13 -07:00
Olivier Gambier
c2589c8099
Trivial cleanup / ordering / inline doc
...
Signed-off-by: Olivier Gambier <olivier@docker.com >
2015-10-21 13:48:13 -07:00
Olivier Gambier
bf3cd8b8f4
Remove useless duplication on PreCreateCheck
...
Signed-off-by: Olivier Gambier <olivier@docker.com >
2015-10-21 13:48:13 -07:00
Jeremy White
f9e40c2ce2
feat(openstack): add flag for using nova networks
...
Signed-off-by: Jeremy White <dudymas@gmail.com >
2015-10-21 16:03:26 -04:00
Chris Abernethy
6a7c8c2a25
Additional validation on virtualbox-hostonly-cidr
...
Check that the CIDR provided for a virtualbox host only CIDR is specified as a host IP and netmask, e.g., 192.168.100.1/24, and not a network IP and netmask, e.g., 192.168.100.0/24. This will help prevent confusion like #1383
Signed-off-by: Chris Abernethy <cabernet@chrisabernethy.com >
Signed-off-by: David Gageot <david@gageot.net >
2015-10-21 20:46:13 +02:00
Nathan LeClaire
56acdcf5ae
Merge pull request #2031 from hairyhenderson/check-vtx-darwin-1983
...
Adding support for darwin to IsVTXDisabled
2015-10-21 11:26:28 -07:00
David Gageot
38b7fe5013
FIX #2020 Better error when vboxmanage is missing
...
Signed-off-by: David Gageot <david@gageot.net >
2015-10-21 09:35:33 +02:00
Dave Henderson
e2856e36f4
Adding support for darwin to IsVTXDisabled
...
Signed-off-by: Dave Henderson <dhenderson@gmail.com >
2015-10-20 21:20:40 -04:00
feelobot
6b7628a175
Use SDK to Validate VpcID with SubnetId
...
Signed-off-by: feelobot <felix.a.rod@gmail.com >
2015-10-20 12:37:33 -07:00
David Gageot
94361315a8
Add tests to virtualbox driver
...
Signed-off-by: David Gageot <david@gageot.net >
2015-10-20 19:08:18 +02:00
David Gageot
4a33fabe8b
Check that VT-X/AMD-v is enabled
...
Signed-off-by: David Gageot <david@gageot.net >
2015-10-20 09:56:43 +02:00
Nathan LeClaire
447d262c06
Merge pull request #1939 from gmacario/fix-issue-1692
...
fix IPV6NetworkMaskPrefixLength value parsing
2015-10-19 14:17:51 -07:00