docker/docs
1
0
Fork 0
mirror of https://github.com/docker/docs.git synced 2026-11-05 00:14:17 +03:00
Code Activity
1,212 Commits 92 Branches 28 Tags
05b490ae75c36ec00f565430bfb4adb14ab32a89
Commit Graph

225 Commits

Author SHA1 Message Date
David Lawrence
11795a4573 rename data.ValidRoles to data.BaseRoles 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2016-01-07 17:38:52 -08:00
David Lawrence
d52dbde683 removing the ability to configure role names. It adds a lot of complexity without adding much value. If somebody wants custom role names they can implement it at the display level 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2016-01-07 17:38:05 -08:00
Ying Li
c1c0ccf4be Combine bootstrapClient and tuf/client's Client.Update into NotaryRepository.Update. 
- it is easier to understand what's going on in the online functions of NotaryRepository
- we can test NotaryRepository.Update independently (although it'd be nice to have some way
  of ensuring that the actual public functions of NotaryRepository like ListTargets,
  GetTargetByName, and Publish actually calls Update.
- distinct error if the remote repo doesn't exist.

This also stops wrapping signed.ErrExpired in client.ErrExpired, and just passes
signed.ErrExpired on directly.

Signed-off-by: Ying Li <ying.li@docker.com>
 2016-01-07 16:58:46 -08:00
David Lawrence
f417c834c4 switching out to consistently use canonical json for all marshalling of TUF data 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2016-01-06 11:15:27 -08:00
Diogo Mónica
30c488b3b4 Merge pull request #393 from docker/path-fix 
use path instead of filepath to express TUF roles
 2016-01-04 19:26:13 -08:00
Ying Li
61bbf7be49 Change ListTargetes and GetTargetsByName to return TargetWithRole. 
This object has both the target and the role in which the target was found.

Signed-off-by: Ying Li <ying.li@docker.com>
 2016-01-04 17:15:44 -08:00
Riyaz Faizullabhoy
dbb8c1065f use path instead of filepath to express TUF roles 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
 2016-01-04 16:23:02 -08:00
Ying Li
2f2a0b9c9f Display the role when listing targets using the Notary CLI. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2016-01-04 15:20:06 -08:00
Ying Li
ecd96c8218 Fix potential infinite loop in tuf/Client.TargetMeta 
Signed-off-by: Ying Li <ying.li@docker.com>
 2016-01-04 10:50:35 -08:00
Ying Li
9252d9d892 Update client.Target to include a RoleName, so we know where the target is when listed. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2016-01-04 10:49:54 -08:00
Ying Li
6028de0dd1 Merge pull request #387 from docker/backwards-compatibility 
Tests for backwards-compatibility reading/writing/exporting/importing old repo format
 2015-12-23 12:15:03 -08:00
Ying Li
785b2527b1 Test import/export of old repo format. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-23 11:47:37 -08:00
Diogo Mónica
ffca6fb522 Merge pull request #388 from docker/cleanup 
Rebased cleanup/remove PEM headers
 2015-12-23 11:36:25 -08:00
Ying Li
0465365fb6 Return an error if unable to encrypt a key as a valid PEM file 
Also address review comments and fix semantic conflict after rebase.

Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-23 09:44:51 -08:00
David Lawrence
fa788cb2a9 make x509 certs viable as delegated public key object 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-23 09:41:03 -08:00
David Lawrence
e516dd88f2 cleaning up tests by converting t.Fatal to assert.___ 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-23 09:41:03 -08:00
Ying Li
9573252ace Add backwards-compatbility test for client reading-writing 0.1-style repos. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-22 18:01:36 -08:00
Riyaz Faizullabhoy
9b0ae29427 ErrRepoNotInitialized test 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
 2015-12-22 16:53:31 -08:00
Riyaz Faizullabhoy
98b7dd7daf fixes to notary for docker integration 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
 2015-12-22 16:53:31 -08:00
Ying Li
332621607e Add more comments and assertions as per review. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-22 16:29:28 -08:00
Ying Li
6423c16233 Test pushing an uninitialized repo as well. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-22 16:29:28 -08:00
Ying Li
ebac6b158a Refactor tests to cover corrupt root/targets/delegations. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-22 16:29:28 -08:00
Ying Li
ab97f9e12e Refactor some of the code to reduce creating temp notary repo directory boilerplate. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-22 16:23:19 -08:00
Ying Li
d6234e5ef0 Add some simple failure cases where data is corrupt or we can't get server keys. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-22 16:23:19 -08:00
Ying Li
c1eb344b89 Rotation tests now test reading from other (non-publishing) clients. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-22 16:23:19 -08:00
Ying Li
f794193382 Address review comments (renaming, extra code left in, etc.) 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-22 15:32:05 -08:00
Ying Li
66384edfc3 Add some more publishing tests. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-22 00:44:50 -08:00
Ying Li
dcef24996e Add more delegation writing/publishing tests. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-22 00:23:32 -08:00
Ying Li
34055f8cf7 Code cleanups as per review, and after rebasing. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-18 16:51:48 -08:00
Ying Li
0892ebb13f Add checks to TUFRepo to fail on updating a target if there are no signing keys. 
So UpdateDelegation, DeleteDelegation, AddTargets, RemoveTargets now
all check for the role existence, not metadata existence.  And they
also check the role's signing keys - there's no point in adding if
we can't sign.

Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-18 16:37:24 -08:00
Ying Li
a1cbe5d43c Add test for, and fix bug with, publishing a bare repo not sending the targets file. 
It should always be published the first time, like the root.json.

Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-18 16:37:24 -08:00
Ying Li
c12958af36 Do not sign the actual targets metadata unless it's dirty. 
Previously we were always signing it, but we can't do that anymore
because then delegated users won't be able to publish ever (they
probably don't have the target key).

Some other related changes: when role keys are rotated, that role
needs to be marked as dirty now in order to be re-signed and
published.

Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-18 16:37:24 -08:00
Ying Li
7592a029ef Do not create the delegation metadata when the delegation is created. 
Only create it when a target is added to it, or other delegations
are added to it, or when getting a child delegation.

Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-18 16:37:24 -08:00
Ying Li
f1761afc25 Fallback on the parent role if the role to add a target to doesn't exist. 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-18 16:37:24 -08:00
Ying Li
3ecba24410 When publishing, also publish all the dirty targets roles. 
This is in addition to the canonical targets role, which always gets
re-signed and publish (we may want to revisit this later).

This makes some tests pass - still need to do fallback of roles
and publishing a created delegation role without necessarily
having the signing key for that role.

Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-18 16:37:24 -08:00
Ying Li
9f04ca66f7 Add tests for publishing targets to delegations, and delegations themselves. 
This involved a refactor test helper function assertPublishSucceeds to
take roles and expected published-to-roles.

Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-18 16:37:24 -08:00
David Lawrence
d3a54cab25 the empty string should be used in delegation Paths to indicate a role can sign anything 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-18 16:10:43 -08:00
David Lawrence
d49228ad70 fixing copy paste bad var name 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-18 11:54:01 -08:00
David Lawrence
a2a4870512 adding comment about priority ordering and updating test for ListTargets with delegates to hit default no roles passed case 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-18 11:21:12 -08:00
David Lawrence
574b4d543d updating ListTargets delegate test to check iteration of children and correct (lack of) overwriting. 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-17 21:28:52 -08:00
David Lawrence
9307692b52 reverse priority order or roles for ListTargets and GetTargetsByName 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-17 16:33:52 -08:00
David Lawrence
594049b24f fixing download to continue if we get ErrMetaNotFound 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-17 15:53:57 -08:00
David Lawrence
f72f799806 fixing up ListTargets and GetTargetByName to process prioritized roles more efficiently 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-17 14:56:05 -08:00
David Lawrence
4243b258b3 making GetTargetsByName work with delegations 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-17 10:46:41 -08:00
David Lawrence
4a9ebb8bc8 adding test for ListTargets with delegation 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-17 10:09:34 -08:00
David Lawrence
4694178bbe download delegation test 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-17 10:09:34 -08:00
David Lawrence
377b72a54f updating list targets to list across multiple roles 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-17 10:09:34 -08:00
David Lawrence
8f7e7adcef making stack thread safe 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
 2015-12-17 10:09:34 -08:00
Ying Li
15ad91eea3 Add tests for not being able to write changefiles when changing delegations. 
This involves refactoring some of the previous write error code.

Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-16 18:29:54 -08:00
Ying Li
c917c0b884 Split AddDelegation test so more more levels 
Signed-off-by: Ying Li <ying.li@docker.com>
 2015-12-16 17:54:50 -08:00