From 98bb98934e7d924f09ba6b27fd0e80060041d446 Mon Sep 17 00:00:00 2001 From: FrenchBen Date: Mon, 31 Aug 2015 14:05:38 -0400 Subject: [PATCH] Added react lint support and fixed possible NaN Signed-off-by: FrenchBen --- .eslintrc | 3 +++ package.json | 3 ++- src/app.js | 2 +- src/components/ContainerHome.react.js | 11 +++++++---- 4 files changed, 13 insertions(+), 6 deletions(-) diff --git a/.eslintrc b/.eslintrc index c3024dbbd1..bde0456ec3 100644 --- a/.eslintrc +++ b/.eslintrc @@ -1,5 +1,8 @@ root: true +plugins: + - react + ecmaFeatures: modules: true jsx: true diff --git a/package.json b/package.json index 8523a2f170..93a1cabde2 100644 --- a/package.json +++ b/package.json @@ -65,7 +65,8 @@ "babel": "^5.1.10", "babel-jest": "^5.2.0", "electron-prebuilt": "^0.27.3", - "eslint": "^1.0.0", + "eslint": "^1.3.1", + "eslint-plugin-react": "^3.3.0", "grunt": "^0.4.5", "grunt-babel": "^5.0.1", "grunt-chmod": "^1.0.3", diff --git a/src/app.js b/src/app.js index 6c300f2dc9..a902b06b2f 100644 --- a/src/app.js +++ b/src/app.js @@ -9,7 +9,7 @@ import metrics from './utils/MetricsUtil'; import template from './menutemplate'; import webUtil from './utils/WebUtil'; import hubUtil from './utils/HubUtil'; -var urlUtil = require ('./utils/URLUtil'); +var urlUtil = require('./utils/URLUtil'); var app = remote.require('app'); import request from 'request'; import docker from './utils/DockerUtil'; diff --git a/src/components/ContainerHome.react.js b/src/components/ContainerHome.react.js index f47cd9620b..cd9aeab3a0 100644 --- a/src/components/ContainerHome.react.js +++ b/src/components/ContainerHome.react.js @@ -13,12 +13,12 @@ var ContainerHome = React.createClass({ router: React.PropTypes.func }, - componentDidMount: function() { + componentDidMount: function () { this.handleResize(); window.addEventListener('resize', this.handleResize); }, - componentWillUnmount: function() { + componentWillUnmount: function () { window.removeEventListener('resize', this.handleResize); }, @@ -46,7 +46,7 @@ var ContainerHome = React.createClass({ render: function () { if (!this.props.container) { - return; + return ''; } let body; @@ -70,11 +70,14 @@ var ContainerHome = React.createClass({ } sum = sum / this.props.container.Progress.amount; + if (isNaN(sum)) { + sum = 0; + } body = (

Downloading Image

-

{(Math.round(sum*100)/100).toFixed(2)}%

+

{ (Math.round(sum * 100) / 100).toFixed(2) }%