From dda857ecfa018d22cb1071f4dfa1711fd2182df9 Mon Sep 17 00:00:00 2001 From: Andrew Hsu Date: Tue, 11 Jul 2017 00:35:28 +0000 Subject: [PATCH] SC2086 double quote Double quote to prevent globbing and word splitting. https://github.com/koalaman/shellcheck/wiki/SC2086 Signed-off-by: Andrew Hsu --- install.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/install.sh b/install.sh index 247d351..a5d0e68 100644 --- a/install.sh +++ b/install.sh @@ -262,14 +262,14 @@ do_install() { MAJOR_W=1 MINOR_W=10 - semverParse $version + semverParse "$version" shouldWarn=0 - if [ $major -lt $MAJOR_W ]; then + if [ "$major" -lt "$MAJOR_W" ]; then shouldWarn=1 fi - if [ $major -le $MAJOR_W ] && [ $minor -lt $MINOR_W ]; then + if [ "$major" -le "$MAJOR_W" ] && [ "$minor" -lt "$MINOR_W" ]; then shouldWarn=1 fi