Brian Goff ab16b6c61a Fix issues with tailing rotated jsonlog file ...

Fixes a race where the log reader would get events for both an actual
rotation as we from fsnotify (`fsnotify.Rename`).
This issue becomes extremely apparent when rotations are fast, for
example:

```
$ docker run -d --name test --log-opt max-size=1 --log-opt max-file=2
busybox sh -c 'while true; do echo hello; usleep 100000; done'
```

With this change the log reader for jsonlogs can handle rotations that
happen as above.

Instead of listening for both fs events AND rotation events
simultaneously, potentially meaning we see 2 rotations for only a single
rotation due to channel buffering, only listen for fs events (like
`Rename`) and then wait to be notified about rotation by the logger.
This makes sure that we don't see 2 rotations for 1, and that we don't
start trying to read until the logger is actually ready for us to.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Upstream-commit: 84e60a7e10278e3acd2b783d0e6955dc5198b57c
Component: engine

2016-08-15 13:57:28 -04:00

..

caps

Replace execdrivers with containerd implementation

2016-03-18 13:38:32 -07:00

cluster

Add logdrivers to executor from swarmkit

2016-07-08 13:33:40 -07:00

events

Add filter for events emitted by docker daemon

2016-05-23 19:00:47 -07:00

exec

Replace execdrivers with containerd implementation

2016-03-18 13:38:32 -07:00

graphdriver

Merge pull request #24091 from AkihiroSuda/fixZFS24008

2016-06-30 11:14:30 -07:00

links

Replace usage of pkg/nat with go-connections/nat.

2015-12-22 13:31:46 -05:00

logger

Fix issues with tailing rotated jsonlog file

2016-08-15 13:57:28 -04:00

network

api,daemon: cleanup some unused stuff

2016-06-21 14:15:19 -07:00

apparmor_default_unsupported.go

Replace execdrivers with containerd implementation

2016-03-18 13:38:32 -07:00

apparmor_default.go

Replace execdrivers with containerd implementation

2016-03-18 13:38:32 -07:00

archive_unix.go

Windows: docker cp consistent paths

2016-05-06 16:08:53 -07:00

archive_windows.go

Windows: Remove TP4 support from main code

2016-04-06 12:12:20 -07:00

archive.go

Windows: docker cp consistent paths

2016-05-06 16:08:53 -07:00

attach.go

Merge pull request #22777 from WeiZhang555/wait-restarting

2016-06-12 13:01:20 +02:00

auth.go

Moving some more methods away from daemon.go

2016-05-27 11:32:26 +02:00

changes.go

Move some container related methods and structs to smaller files

2016-05-24 21:31:15 +02:00

commit.go

Windows: CMD not honouring arg escaping

2016-06-15 16:46:32 -07:00

config_experimental.go

Move userns support out of experimental into master

2016-01-08 15:06:22 -05:00

config_solaris.go

Daemon to support network restore

2016-06-14 16:45:25 -07:00

config_stub.go

…

config_test.go

Add support for multiples runtimes

2016-06-14 07:47:31 -07:00

config_unix.go

Fix check code for --cluster-store and --cluster-advertise in config_unix.go

2016-06-29 02:36:43 +09:00

config_windows.go

Use "docker-runc" as alias for the default runtime

2016-06-22 11:59:26 -07:00

config.go

Fix spelling in comments, strings and documentation

2016-07-03 20:58:11 +03:00

container_operations_solaris.go

Get the Docker Engine to build clean on Solaris

2016-05-23 16:37:12 -07:00

container_operations_unix.go

Add support for --pid=container:<id>

2016-05-17 13:49:05 -04:00

container_operations_windows.go

Merge pull request #21809 from Microsoft/jjh/tp4removal

2016-04-06 14:11:33 -07:00

container_operations.go

Fix a grammatical error in errClusterNetworkOnRun()'s error message.

2016-07-05 16:18:06 +10:00

container.go

Validate hostname starting from 1.24 API.

2016-07-06 09:13:59 +02:00

create_unix.go

Merge pull request #21270 from ehazlett/resource-labels

2016-03-22 15:12:33 -04:00

create_windows.go

Windows: Default isolation and workdir

2016-05-26 13:24:22 -07:00

create.go

Validate hostname starting from 1.24 API.

2016-07-06 09:13:59 +02:00

daemon_experimental.go

Move userns support out of experimental into master

2016-01-08 15:06:22 -05:00

daemon_linux_test.go

Fix container mount cleanup issues

2016-03-30 17:25:49 -07:00

daemon_linux.go

Fix container mount cleanup issues

2016-03-30 17:25:49 -07:00

daemon_solaris.go

Daemon to support network restore

2016-06-14 16:45:25 -07:00

daemon_stub.go

Move userns support out of experimental into master

2016-01-08 15:06:22 -05:00

daemon_test.go

Wait for discovery on container start error

2016-05-11 09:49:51 -04:00

daemon_unix_test.go

Daemon to support network restore

2016-06-14 16:45:25 -07:00

daemon_unix.go

daemon: ensure we set default options to stock runtime

2016-07-08 15:58:06 +02:00

daemon_unsupported.go

Get the Docker Engine to build clean on Solaris

2016-05-23 16:37:12 -07:00

daemon_windows.go

Daemon to support network restore

2016-06-14 16:45:25 -07:00

daemon.go

Fix daemon not cleaned up w/ live restore enabled

2016-07-07 22:25:41 -04:00

debugtrap_unix.go

…

debugtrap_unsupported.go

Get the Docker Engine to build clean on Solaris

2016-05-23 16:37:12 -07:00

debugtrap_windows.go

Windows: psignal alias not required

2016-03-27 17:23:34 -07:00

delete_test.go

Remove static errors from errors package.

2016-02-26 15:49:09 -05:00

delete.go

Merge pull request #21802 from tiborvass/carry-21716

2016-04-06 15:21:38 -04:00

discovery_test.go

Fix minor vet warnings

2016-02-03 10:43:01 -08:00

discovery.go

Wait for discovery on container start error

2016-05-11 09:49:51 -04:00

errors.go

Remove static errors from errors package.

2016-02-26 15:49:09 -05:00

events_test.go

Add the possibility to log event with specific attributes

2016-01-17 12:14:01 +01:00

events.go

Add filter for events emitted by docker daemon

2016-05-23 19:00:47 -07:00

exec_linux.go

Replace execdrivers with containerd implementation

2016-03-18 13:38:32 -07:00

exec_solaris.go

Get the Docker Engine to build clean on Solaris

2016-05-23 16:37:12 -07:00

exec_windows.go

Windows: escape entrypoint before passing to libcontainerd

2016-03-30 12:59:50 -07:00

exec.go

Fix logrus formatting

2016-06-11 13:16:55 -07:00

export.go

Remove static errors from errors package.

2016-02-26 15:49:09 -05:00

health_test.go

Add support for user-defined healthchecks

2016-06-02 23:58:34 +02:00

health.go

Merge pull request #23442 from thaJeztah/remove-defaultExitOnUnhealthy

2016-06-11 16:37:39 -07:00

image_delete.go

Update rmi logic for canonical references

2016-06-17 10:15:56 -07:00

image_exporter.go

Move some image related methods & struct to smaller files

2016-05-21 22:36:11 +02:00

image_history.go

Move some image related methods & struct to smaller files

2016-05-21 22:36:11 +02:00

image_inspect.go

Move some image related methods & struct to smaller files

2016-05-21 22:36:11 +02:00

image_pull.go

Remove reference package dependency from the api.

2016-04-07 15:01:23 -07:00

image_push.go

Remove reference package dependency from the api.

2016-04-07 15:01:23 -07:00

image_tag.go

Remove reference package dependency from the api.

2016-04-07 15:01:23 -07:00

image.go

Move some image related methods & struct to smaller files

2016-05-21 22:36:11 +02:00

images.go

Treat digest only images as dangling

2016-06-30 11:32:49 -07:00

import.go

Remove reference package dependency from the api.

2016-04-07 15:01:23 -07:00

info.go

Fix seccomp output in docker info

2016-07-08 17:26:42 -07:00

inspect_solaris.go

Get the Docker Engine to build clean on Solaris

2016-05-23 16:37:12 -07:00

inspect_unix.go

Get the Docker Engine to build clean on Solaris

2016-05-23 16:37:12 -07:00

inspect_windows.go

Add Swarm management backend

2016-06-13 22:16:18 -07:00

inspect.go

Fix race on force deleting container created by task

2016-06-14 16:49:04 -07:00

keys_unsupported.go

Change root_maxkeys

2016-06-27 10:23:37 -07:00

keys.go

Change root_maxkeys

2016-06-27 10:23:37 -07:00

kill.go

*: fix logrus.Warn[f]

2016-06-11 19:42:38 +02:00

links_test.go

Extract container store from the daemon.

2016-01-19 13:21:41 -05:00

links.go

Add migration from sqlite links back to hostConfig

2016-01-11 11:31:29 -05:00

list_unix.go

Get the Docker Engine to build clean on Solaris

2016-05-23 16:37:12 -07:00

list_windows.go

Move Container to its own package.

2015-12-03 17:39:49 +01:00

list.go

Fixes #23596-returns empty string for NetworkID in response to /containers/json

2016-06-16 12:34:00 -07:00

logdrivers_linux.go

daemon/logger: Add logging driver for Google Cloud Logging

2016-03-01 08:06:10 -08:00

logdrivers_windows.go

Windows: Add ETW logging driver plug-in

2016-02-16 13:24:49 -08:00

logs.go

Fixing file handle leak for "docker logs"

2016-06-21 18:40:30 -07:00

monitor_linux.go

Adding postRunProcessing infrastructure for hanlding Windows Update.

2016-04-06 14:03:05 -07:00

monitor_solaris.go

Get the Docker Engine to build clean on Solaris

2016-05-23 16:37:12 -07:00

monitor_windows.go

Fix race on force deleting container created by task

2016-06-14 16:49:04 -07:00

monitor.go

Fixing bug in AttachStreams that would fail to close StdIn

2016-06-16 17:34:45 -07:00

mounts.go

Remove static errors from errors package.

2016-02-26 15:49:09 -05:00

names.go

Moving some more methods away from daemon.go

2016-05-27 11:32:26 +02:00

network.go

Revert "Fixed a few network UI issues in swarm-mode"

2016-07-07 16:23:42 -07:00

oci_linux.go

fix some typos

2016-06-21 15:29:25 +08:00

oci_solaris.go

Get the Docker Engine to build clean on Solaris

2016-05-23 16:37:12 -07:00

oci_windows.go

Windows: Added support for memory limit

2016-06-15 17:07:29 -07:00

pause.go

Replace execdrivers with containerd implementation

2016-03-18 13:38:32 -07:00

rename.go

No need for container.Lock if rename same name

2016-06-24 19:55:48 +02:00

resize.go

Replace execdrivers with containerd implementation

2016-03-18 13:38:32 -07:00

restart.go

Remove static errors from errors package.

2016-02-26 15:49:09 -05:00

search_test.go

Add --limit option to docker search

2016-06-02 19:12:20 -07:00

search.go

Add --limit option to docker search

2016-06-02 19:12:20 -07:00

seccomp_disabled.go

Fix seccomp output in docker info

2016-07-08 17:26:42 -07:00

seccomp_linux.go

Fix seccomp output in docker info

2016-07-08 17:26:42 -07:00

seccomp_unsupported.go

Fix seccomp output in docker info

2016-07-08 17:26:42 -07:00

selinux_linux.go

…

selinux_unsupported.go

…

start_linux.go

Update to new swarmkit/engine-api

2016-06-30 17:22:47 -07:00

start_windows.go

Add support for multiples runtimes

2016-06-14 07:47:31 -07:00

start.go

Validate hostname starting from 1.24 API.

2016-07-06 09:13:59 +02:00

stats_collector_solaris.go

Get the Docker Engine to build clean on Solaris

2016-05-23 16:37:12 -07:00

stats_collector_unix.go

Get the Docker Engine to build clean on Solaris

2016-05-23 16:37:12 -07:00

stats_collector_windows.go

Move Container to its own package.

2015-12-03 17:39:49 +01:00

stats.go

cleanup: clean up commented code in daemon/stats.go

2016-06-02 14:39:12 +08:00

stop.go

Add support for user-defined healthchecks

2016-06-02 23:58:34 +02:00

top_unix_test.go

Validate arguments for ps in docker top

2016-07-08 05:58:11 +00:00

top_unix.go

Validate arguments for ps in docker top

2016-07-08 05:58:11 +00:00

top_windows.go

Windows: Minimal docker top implementation

2016-03-20 16:45:53 -07:00

unpause.go

Replace execdrivers with containerd implementation

2016-03-18 13:38:32 -07:00

update_linux.go

Update containerd and runc vendoring

2016-06-14 07:47:31 -07:00

update_solaris.go

Get the Docker Engine to build clean on Solaris

2016-05-23 16:37:12 -07:00

update_windows.go

Windows libcontainerd implementation

2016-03-18 13:38:41 -07:00

update.go

Validate hostname starting from 1.24 API.

2016-07-06 09:13:59 +02:00

volumes_unit_test.go

reorder imports with goimports

2015-12-16 16:50:25 +01:00

volumes_unix.go

daemon: allow tmpfs to trump over VOLUME(s)

2016-06-15 16:01:51 +02:00

volumes_windows.go

Remove unneeded references to execDriver

2016-03-21 13:06:08 -07:00

volumes.go

daemon: allow tmpfs to trump over VOLUME(s)

2016-06-15 16:01:51 +02:00

wait.go

Fix race on force deleting container created by task

2016-06-14 16:49:04 -07:00