mirror of
https://github.com/docker/cli.git
synced 2026-01-15 07:40:57 +03:00
d0a61e9c18
- Errors sent to the walker callback functions were ignored. This meant that one could get a panic when calling methods on a nil FileInfo object. For example when the file did not exists any more. - Lstat calls inside walker callback are reduntant because walker already calls Lstat and passes the result to the callback. - Error returned from filepath.Rel() can never be EACCES because it compares strings and does not care about actual files. - If Matched() returns error then ValidateContextDirectory() must return error. Currently it still kept walking although the outcome was already known. - Function will now fail in case of unknown error(not EACCES nor ENOENT). Previous implementation did not make a clear decision about this (but panicked because of the issues above). Signed-off-by: Tõnis Tiigi <tonistiigi@gmail.com> (github: tonistiigi) Upstream-commit: a8914293fbb1328f9a5c931bd51e34f5d6584e17 Component: engine