mirror of
https://github.com/docker/cli.git
synced 2026-01-13 18:22:35 +03:00
eb5b03a8a3
The logic used in this function was confusing; some errors were ignored, but responses handled regardless. The intent here is to try to detect whether the destination exists inside the container and is of the right "type" (otherwise produce an error). Failing to "stat" the path in the container means we can't produce a nice error for the user, but we'll continue the request, which either would succeed or produce an error returned by the daemon. While working on this patch, I noticed that some error-handling on the daemon side is incorrect. This patch does not fix those cases, but makes the logic slightly easier to follow (we should consider extracting the "stat" code to a separate function though). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>