From f28565d173bb0677c9d22a450f7a729a97913bf1 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Tue, 23 Dec 2025 15:49:19 +0100 Subject: [PATCH] cli/command/service: replace reflect for gotest.tools assertion Signed-off-by: Sebastiaan van Stijn --- cli/command/service/update_test.go | 34 +++++++++++++++--------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/cli/command/service/update_test.go b/cli/command/service/update_test.go index b2731a3aba..bb346b2e6f 100644 --- a/cli/command/service/update_test.go +++ b/cli/command/service/update_test.go @@ -4,8 +4,8 @@ import ( "context" "fmt" "net/netip" - "reflect" "sort" + "strconv" "testing" "time" @@ -368,23 +368,23 @@ func TestUpdateHealthcheckTable(t *testing.T) { err: "--no-healthcheck conflicts with --health-* options", }, } - for i, c := range testCases { - flags := newUpdateCommand(nil).Flags() - for _, flag := range c.flags { - flags.Set(flag[0], flag[1]) - } - cspec := &swarm.ContainerSpec{ - Healthcheck: c.initial, - } - err := updateHealthcheck(flags, cspec) - if c.err != "" { - assert.Error(t, err, c.err) - } else { - assert.NilError(t, err) - if !reflect.DeepEqual(cspec.Healthcheck, c.expected) { - t.Errorf("incorrect result for test %d, expected health config:\n\t%#v\ngot:\n\t%#v", i, c.expected, cspec.Healthcheck) + for i, tc := range testCases { + t.Run(strconv.Itoa(i), func(t *testing.T) { + flags := newUpdateCommand(nil).Flags() + for _, flag := range tc.flags { + assert.Check(t, flags.Set(flag[0], flag[1])) } - } + cspec := &swarm.ContainerSpec{ + Healthcheck: tc.initial, + } + err := updateHealthcheck(flags, cspec) + if tc.err != "" { + assert.Error(t, err, tc.err) + } else { + assert.NilError(t, err) + assert.Check(t, is.DeepEqual(cspec.Healthcheck, tc.expected)) + } + }) } }