From 99288ec2bde3a507088b91ce05901f2d67fbf0f1 Mon Sep 17 00:00:00 2001 From: Ken Cochrane Date: Fri, 15 Mar 2013 07:49:27 -0700 Subject: [PATCH] made sure password was required, fixed docker help issue with login prompt Upstream-commit: 878ae25980c21b6678fa30ba09b426e7710e1b14 Component: engine --- components/engine/commands.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/components/engine/commands.go b/components/engine/commands.go index 09a6789216..ffc000ebf6 100644 --- a/components/engine/commands.go +++ b/components/engine/commands.go @@ -74,6 +74,10 @@ func (srv *Server) Help() string { // 'docker login': login / register a user to registry service. func (srv *Server) CmdLogin(stdin io.ReadCloser, stdout io.Writer, args ...string) error { + cmd := rcli.Subcmd(stdout, "login", "", "Register or Login to the docker registry server") + if err := cmd.Parse(args); err != nil { + return nil + } var username string var password string var email string @@ -91,6 +95,10 @@ func (srv *Server) CmdLogin(stdin io.ReadCloser, stdout io.Writer, args ...strin fmt.Fprint(stdout, "Password: ") fmt.Fscanf(stdin, "%s", &password) + if password == "" { + return errors.New("Error : Password Required\n") + } + fmt.Fprint(stdout, "Email (", authConfig.Email, "): ") fmt.Fscanf(stdin, "%s", &email) if email == "" {