From 8972e53ad0cf4bf1c525d2db5507c6a633542672 Mon Sep 17 00:00:00 2001
From: Sebastiaan van Stijn <github@gone.nl>
Date: Wed, 6 Aug 2025 10:41:23 +0200
Subject: [PATCH] cli/command: remove prompt utilities that were for internal
 use

- The `DisableInputEcho` and `PromptForInput` utilities were added in
  c15ade0c647606b769deb009a3c2e508efa71e67 as part of a bug-fix, which
  was part of v28.x. [There are no (publicly visible) users][1] of either.
- The `ErrPromptTerminated` was added in v26.x (originally added in
  10bf91a02d2abd4dec90b79bd10b91f6fbb8e05d, later updated in commit
  7c722c08d093c118ea727961be9aa0a23c83b733. [It is not used][2]
- The `PromptForConfirmation` was added in [moby@280c872] (docker v1.13.0)
  as part of the `docker <object> prune` subcommands. It was meant for
  internal use but exported to allow re-using it in the `container`,
  `image` (etc.) packages. However, a breaking change to its signature
  was made in 10bf91a02d2abd4dec90b79bd10b91f6fbb8e05d. It currently
  does [not appear to have any (public) users][2].

This patch removes the `ErrPromptTerminated`, `DisableInputEcho`,
`PromptForInput`, and `PromptForConfirmation` utilities from the
`cli/command` package. The core functionality of these is still
available in the `internal/prompt` package, which we may make
public at some point, but still needs some refining / decoupling.

[moby@280c872]: https://github.com/moby/moby/commit/280c8723667af385e0807a090ddc5cc57c46807e
[1]: https://grep.app/search?f.lang=Go&regexp=true&q=%5C.%28DisableInputEcho%7CPromptForInput%29%5C%28
[2]: https://grep.app/search?f.lang=Go&q=%5C.ErrPromptTerminated
[3]: https://grep.app/search?f.lang=Go&q=.PromptForConfirmation%28

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
---
 cli/command/utils.go | 39 ---------------------------------------
 1 file changed, 39 deletions(-)

diff --git a/cli/command/utils.go b/cli/command/utils.go
index e10956c0d5..10744e6f21 100644
--- a/cli/command/utils.go
+++ b/cli/command/utils.go
@@ -4,55 +4,16 @@
 package command
 
 import (
-	"context"
-	"io"
 	"os"
 	"path/filepath"
 	"strings"
 
 	"github.com/docker/cli/cli/config"
-	"github.com/docker/cli/cli/streams"
-	"github.com/docker/cli/internal/prompt"
 	"github.com/moby/moby/api/types/filters"
 	"github.com/pkg/errors"
 	"github.com/spf13/pflag"
 )
 
-const ErrPromptTerminated = prompt.ErrTerminated
-
-// DisableInputEcho disables input echo on the provided streams.In.
-// This is useful when the user provides sensitive information like passwords.
-// The function returns a restore function that should be called to restore the
-// terminal state.
-func DisableInputEcho(ins *streams.In) (restore func() error, err error) {
-	return prompt.DisableInputEcho(ins)
-}
-
-// PromptForInput requests input from the user.
-//
-// If the user terminates the CLI with SIGINT or SIGTERM while the prompt is
-// active, the prompt will return an empty string ("") with an ErrPromptTerminated error.
-// When the prompt returns an error, the caller should propagate the error up
-// the stack and close the io.Reader used for the prompt which will prevent the
-// background goroutine from blocking indefinitely.
-func PromptForInput(ctx context.Context, in io.Reader, out io.Writer, message string) (string, error) {
-	return prompt.ReadInput(ctx, in, out, message)
-}
-
-// PromptForConfirmation requests and checks confirmation from the user.
-// This will display the provided message followed by ' [y/N] '. If the user
-// input 'y' or 'Y' it returns true otherwise false. If no message is provided,
-// "Are you sure you want to proceed? [y/N] " will be used instead.
-//
-// If the user terminates the CLI with SIGINT or SIGTERM while the prompt is
-// active, the prompt will return false with an ErrPromptTerminated error.
-// When the prompt returns an error, the caller should propagate the error up
-// the stack and close the io.Reader used for the prompt which will prevent the
-// background goroutine from blocking indefinitely.
-func PromptForConfirmation(ctx context.Context, ins io.Reader, outs io.Writer, message string) (bool, error) {
-	return prompt.Confirm(ctx, ins, outs, message)
-}
-
 // PruneFilters merges prune filters specified in config.json with those specified
 // as command-line flags.
 //