From 72f76f2720e5a31918f991ee797bfc3041fad37c Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Mon, 18 Aug 2025 21:50:53 +0200 Subject: [PATCH] cli-plugins/manager: deprecate annotation metadata aliases These aliases were added in 292713c887b17339106e9f7f3647ed50bebc675d (part of v28.0), but did not deprecate them. They are no longer used in the CLI itself, but may be used by cli-plugin implementations. This deprecates the aliases in `cli-plugins/manager` in favor of their equivalent in `cli-plugins/manager/metadata`: - `CommandAnnotationPlugin` - `CommandAnnotationPluginVendor` - `CommandAnnotationPluginVersion` - `CommandAnnotationPluginInvalid` - `CommandAnnotationPluginCommandPath` Signed-off-by: Sebastiaan van Stijn --- cli-plugins/manager/annotations.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/cli-plugins/manager/annotations.go b/cli-plugins/manager/annotations.go index 8fc76b73c9..abe47fe091 100644 --- a/cli-plugins/manager/annotations.go +++ b/cli-plugins/manager/annotations.go @@ -6,25 +6,35 @@ const ( // CommandAnnotationPlugin is added to every stub command added by // AddPluginCommandStubs with the value "true" and so can be // used to distinguish plugin stubs from regular commands. + // + // Deprecated: use [metadata.CommandAnnotationPlugin]. This alias will be removed in the next release. CommandAnnotationPlugin = metadata.CommandAnnotationPlugin // CommandAnnotationPluginVendor is added to every stub command // added by AddPluginCommandStubs and contains the vendor of // that plugin. + // + // Deprecated: use [metadata.CommandAnnotationPluginVendor]. This alias will be removed in the next release. CommandAnnotationPluginVendor = metadata.CommandAnnotationPluginVendor // CommandAnnotationPluginVersion is added to every stub command // added by AddPluginCommandStubs and contains the version of // that plugin. + // + // Deprecated: use [metadata.CommandAnnotationPluginVersion]. This alias will be removed in the next release. CommandAnnotationPluginVersion = metadata.CommandAnnotationPluginVersion // CommandAnnotationPluginInvalid is added to any stub command // added by AddPluginCommandStubs for an invalid command (that // is, one which failed it's candidate test) and contains the // reason for the failure. + // + // Deprecated: use [metadata.CommandAnnotationPluginInvalid]. This alias will be removed in the next release. CommandAnnotationPluginInvalid = metadata.CommandAnnotationPluginInvalid // CommandAnnotationPluginCommandPath is added to overwrite the // command path for a plugin invocation. + // + // Deprecated: use [metadata.CommandAnnotationPluginCommandPath]. This alias will be removed in the next release. CommandAnnotationPluginCommandPath = metadata.CommandAnnotationPluginCommandPath )