dns/bind9
dns/bind9
1
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9.git synced 2025-04-18 09:44:09 +03:00
Code

fix: test: Fix the isc_rwlock_tryupgrade() function's unit test

Browse Source 
The pthread-based implementation of the isc_rwlock_tryupgrade()
function always returns ISC_R_LOCKBUSY. Fix the test by adding
conditional checks.

Closes #5287

Merge branch '5287-pthread-rwlock-tryupgrade-test-fix' into 'main'

See merge request isc-projects/bind9!10398
This commit is contained in:
Arаm Sаrgsyаn 2025-04-16 16:00:29 +00:00
commit b3208da958
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/isc/rwlock_test.c
View File

@ -138,8 +138,17 @@ ISC_RUN_TEST_IMPL(isc_rwlock_tryupgrade) {
isc_result_t result;
isc_rwlock_lock(&rwlock, isc_rwlocktype_read);
result = isc_rwlock_tryupgrade(&rwlock);
#if USE_PTHREAD_RWLOCK
/*
* Our pthread-based rwlock implementation does not support tryupgrade,
* and always returns ISC_R_LOCKBUSY.
*/
assert_int_equal(result, ISC_R_LOCKBUSY);
isc_rwlock_unlock(&rwlock, isc_rwlocktype_read);
#else
assert_int_equal(result, ISC_R_SUCCESS);
isc_rwlock_unlock(&rwlock, isc_rwlocktype_write);
#endif /* USE_PTHREAD_RWLOCK */
}
static void *