database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-11-12 13:01:09 +03:00
Code Activity
21,948 Commits 1,607 Branches 185 Tags
ec43d8040a063d39b5fccf24c60c4b206cafa671
Commit Graph

280 Commits

Author SHA1 Message Date
drh
1194904b81 Refactor field Expr.affinity into Expr.affExpr to avoid confusion with other 
fields and variables named "affinity" and display affExpr it in
sqlite3TreeViewExpr() output.

FossilOrigin-Name: a29f2a7d07beff64e489e8f824babc6228c4a499fadc0ee701caa60a63baadcd
 2019-08-05 18:01:42 +00:00
dan
72d1eac673 Fix a problem with renaming a table when a view or trigger within the schema uses a FILTER with an aggregate function that is not currently registered with the database. 
FossilOrigin-Name: 2ac0e42f8ab7a9184c2a2efd13bd50ab51bc01f9f34e9e63591fd18db02dff54
 2019-08-05 13:19:25 +00:00
dan
71f059c880 Fix a problem in ALTER TABLE triggered by views or triggers that include the construction "ORDER BY true" or "ORDER BY false". 
FossilOrigin-Name: 8168021f9ab5fb8b4888257963c9ec68fd1dfeedaf6bba4b8e07438001d0be0f
 2019-08-01 10:58:46 +00:00
drh
e209457295 Consolidate the removal of Window objects from the Select.pWin list into 
a single subroutine.

FossilOrigin-Name: e46b2afc99329c43de08d4a2e6ade4d2239d7409c5d5626bf272a3e0dd24d1b4
 2019-07-22 19:01:38 +00:00
dan
7f6f12bdd3 Remove Window objects from the corresponding Select.pWin list when they are deleted, as they are, for example, when the ORDER BY clause is optimized out. 
FossilOrigin-Name: fd7316cda0fdfe86985f41a97dff3beba188606ec9bc6fef38a686a6976a6e01
 2019-07-22 16:33:02 +00:00
dan
75b0821e99 Remove Window objects from the corresponding Select.pWin list when they are deleted. 
FossilOrigin-Name: d23f33168222dfa40a67dc7de58057418151989e81429e4af47617e86db04667
 2019-07-22 16:20:03 +00:00
dan
1e60261cfb Fix a problem with renaming tables when the schema contains an invocation of a currently unregistered aggregate with a FILTER clause. 
FossilOrigin-Name: bd37ce3fb8dee8d538f6afc0bfc13cdc3ebdd504e6461f0130c6ecc8af585f68
 2019-07-22 11:38:43 +00:00
drh
fd15e18d7f Make sure any window definitions in an ORDER BY clause are removed from 
the SELECT statement if the ORDER BY clause gets optimized out.

FossilOrigin-Name: 23b119671f0be3c6b72cf2dc5f7707a0626766db7aa56529ab00d33d1a0a1bee
 2019-07-20 21:12:31 +00:00
dan
9bf022d57c Fix a problem with renaming a table when the schema contains an invocation of a window function that is not currently registered. 
FossilOrigin-Name: ff290feb97f689cf6ce4162d6aa36f9f9dcf1bff3096847d53a85f39f728d2de
 2019-07-19 14:32:42 +00:00
dan
5e61c1b741 Fix error handling for the case where a window function is passed the wrong number of arguments. 
FossilOrigin-Name: 871796bb19e61c1282d8ac97a82d8b57bde50f2a2a08004ab53136d77c138df4
 2019-07-13 17:45:25 +00:00
dan
4f9adee289 Rework the FILTER clause implementation to share more code with window functions. 
FossilOrigin-Name: 5dac8c38dfc3f41c5c8fb49ca35de7fd1b21f269d72e8ba6ba59ed0a4030a54d
 2019-07-13 16:22:50 +00:00
dan
8117f113bc Minor performance improvement in sqlite3ExprDeleteNN(). 
FossilOrigin-Name: bcc8b38ac75b731a4cd2873ab83f423be036467a511b617c779869de9bbb5383
 2019-07-10 20:16:53 +00:00
dan
16e12c573d Add tests for the FILTER clause. And a bugfix. 
FossilOrigin-Name: 28aa1702f7f0334abd1b30e7aa48ea3679539b11bfbba32bc9f0d6049cf18a7b
 2019-07-03 18:31:20 +00:00
dan
6ba7ab0d25 Experimental implementation of FILTER clause for aggregate functions. 
FossilOrigin-Name: 1f1ae2d6ac8dcbb62e5aa3dc17bc67d559cb565fc0d0a8c00a596075d35f8130
 2019-07-02 11:56:47 +00:00
drh
d0ff601c62 Improved interface to double-quoted string literal enabling/disabling. 
FossilOrigin-Name: 923cfd53fcff2fcb91530bf819d2ecb0eda3f6a27dae29c7460f9ce3a3ffce7b
 2019-06-17 13:56:11 +00:00
drh
0a6873bfd6 Add SQLITE_DBCONFIG options LEGACY_ALTER_TABLE, NO_DQS_SCHEMA, and NO_DQS. 
FossilOrigin-Name: 1fad20925efa70d0c242e9cba8fa55456fb07a81229c1068da84c6e27d0c0be8
 2019-06-14 21:25:25 +00:00
dan
6ece353f2d Handle expressions like "expr IS TRUE COLLATE xyz" in the same way as "expr IS TRUE". Fix for [4d01eda8115b10d1]. 
FossilOrigin-Name: 5c6146b56a75a94f4baa10e95407c54dd0b9314a57a8702a4b96b15c4d7ac48c
 2019-06-12 13:49:32 +00:00
drh
a7d6db6ac0 The affinity of the unlikely() function and its cousins should be "none". 
Ticket [0c620df60bffd9ef]

FossilOrigin-Name: 614ecb0af47038848e8ba2aed6b92db6f33ddc4aea6361795dbde440380f5a35
 2019-06-11 21:02:15 +00:00
drh
3e4f6c43b8 A minor variation on check-in [1685610ef8e0dc] which (hopefully) makes the 
logic a little easier to follow.  Also disallows the use of the double-quoted
string hack in the query expression used for VACUUM INTO, which is not
strictly required, but moves us toward the goal of disallowing the double-quoted
string hack everywhere.

FossilOrigin-Name: 3e1b55f3ab85710ed81574904718205c7370b5f0b5a41029e961486d2e3f37c7
 2019-05-20 18:35:49 +00:00
dan
0d92571d65 Disallow string constants enclosed in double-quotes within new CREATE TABLE and CREATE INDEX statements. It is still possible to enclose column names in double-quotes, and existing database schemas that use double-quotes for strings can still be loaded. This addresses ticket [9b78184b]. 
FossilOrigin-Name: 1685610ef8e0dc9218b02461ceab14dc6114f4f5ef7fcda0da395094aff443e1
 2019-05-20 17:14:25 +00:00
dan
490e6f2506 Fix a stack overflow that could occur when renaming a table that has a trigger containing a window function invocation that itself contains a specific syntax error. 
FossilOrigin-Name: c621fc668c6538f9f5bdac204f012c64998679a61aa8e224d212503820224c09
 2019-04-29 11:27:58 +00:00
drh
d137f4e6e5 Recover a some of the performance lost by window function alias fix two 
check-ins back.

FossilOrigin-Name: 965cbcea117835d2c6d2ec58c8025b227f491c35805e282cb31228436bc6bec1
 2019-03-29 01:15:11 +00:00
dan
4ded26a53c Prevent aliases of window functions expressions from being used as arguments to aggregate or other window functions. 
FossilOrigin-Name: 1e16d3e8fc60d39ca3899759ff15d355fdd7d3e23b325d8d2b0f954e11ce8dce
 2019-03-28 16:15:05 +00:00
dan
781b7ac3f6 Fix a problem with a window function in a correlated sub-query where at least one reference to the outer SELECT appears in a FROM clause sub-select. 
FossilOrigin-Name: 9aca86f98388ff66b2bccb3fbfc486a3931398d2a8da139f905826ae2cdbb205
 2019-03-22 13:56:49 +00:00
dan
f030b37682 Internally, remove all references to a Window object that belongs to an expression in an ORDER BY clause if that expression is converted to an alias of a result-set expression. Fix for [4feb3159c6]. 
FossilOrigin-Name: 579b66eaa0816561c6e47ea116b46f229188f0fc84c1173bfe0d21df2dff9a9a
 2019-02-22 19:24:16 +00:00
dan
8cd2e4ae03 Build and test fixes for SQLITE_OMIT_WINDOWFUNC builds. 
FossilOrigin-Name: 8824115a9776e876a3677f0cb479e311ee65584d43872b37766a146afec72d8f
 2019-02-11 11:34:01 +00:00
dan
a5f9f42a0e Fix a problem with renaming a table within a schema that contains a composite query that uses a column alias as an ORDER BY term. 
FossilOrigin-Name: 2ca6b8f84ec07e313aa4e1c0894827401b418dcc4221e9c54c384f1c3893952a
 2019-01-23 19:50:46 +00:00
dan
d99950310f Fix problems with sub-selects in WINDOW definitions. Also rename-column operations when the column being renamed appears in a WINDOW definition that is part of a VIEW or TRIGGER. 
FossilOrigin-Name: 0387cb3add992b2028efe4f2100188d8f9fdfdcb233329857aa4b46a293cfc97
 2019-01-23 16:59:24 +00:00
dan
8b20e4a3eb Fix a problem with fix [b4b57413]. 
FossilOrigin-Name: ca7b7aaed010ec67bec5355a9ac1d7f229d6d5f2ba2d796b76f5e908b1267688
 2019-01-16 20:48:13 +00:00
dan
5e970a8f40 Fix a problem with renaming a column that is used as part of an ORDER BY on a 
compound SELECT within a database view or trigger.

FossilOrigin-Name: b4b5741366578b25ec6e4c415ab8239215e53b1c900be613575f40a826cfccc9
 2019-01-16 14:58:37 +00:00
drh
ee751fab4c Raise an error if the argument to VACUUM INTO is an identifier. 
FossilOrigin-Name: 6c6fb1c6ea452c70b56fd4ac796affebee21512adba0455ae81c291b715f544f
 2019-01-02 14:34:46 +00:00
drh
3c2db5def6 Fix harmless compiler warnings. 
FossilOrigin-Name: 27221c69901d2b4546167639c4a3c8f54b2e18820f1346870fa26b7c919027db
 2018-12-14 18:11:02 +00:00
drh
1a6c2b1d38 Further refinements to the sqlite3_normalized_sql() interface. TH3 now 
gives 100% MC/DC on that interface.

FossilOrigin-Name: c96bf6cca220e363b099455ce35195ce7e89d374a52dc787f56e7b11e587bced
 2018-12-10 20:01:40 +00:00
drh
893bd3751b Fix the sqlite3_normalized_sql() interface so that it renders 
double-quoted string literals as "?".

FossilOrigin-Name: 0d8e150434bbd179696f1ffe71d1e06cb3d43e6468496c7e481fca8486387bad
 2018-12-07 16:32:11 +00:00
drh
ec8fc62c42 Issue a warning whenever a double-quoted string literal is used. 
FossilOrigin-Name: ac9ad5043026b30394812457e1535df2759aea0d4510029561e92e386672796f
 2018-12-06 16:11:14 +00:00
drh
fdc75c9f53 Omit a line of code that has no affect on the outcome. 
FossilOrigin-Name: 5d933aa659eb7a13f9ab44fe7762be292a1c3c75b957a3b7e0bc6188257b62f4
 2018-12-02 01:15:16 +00:00
drh
eea8eb6d04 Do not allow direct access to internal-use SQL functions such as 
sqlite_rename_column() and sqlite3_rename_table() except when the
new SQLITE_TESTCTRL_INTERNAL_FUNCTIONS flag is set.

FossilOrigin-Name: 6e1330545e7b74fe5f1f20751a3425e2788441485fc07fcb7626e448c72027ce
 2018-11-26 18:09:15 +00:00
drh
5db90714aa Minor code simplification. 
FossilOrigin-Name: 22ae8a52dd2fb744f467c7dccf1d7fe7c7cef0e1dcc897dd492f897e84c9facb
 2018-09-20 20:43:28 +00:00
drh
eda079cd2c Combine the Expr.pTab and Expr.pWin fields into a union named "y". Add a new 
EP_WinFunc property that is only true if Expr.y.pWin is a valid pointer.
This reduces the size of the Expr object by 8 bytes, reduces the overall
amount of code, and shaves over 1 million cycles off of the speed test.

FossilOrigin-Name: ad130bb86e74e6ce165fdbdce3a19699510f0e62071c1c7923b5a4538d888c7c
 2018-09-20 19:02:15 +00:00
drh
504eba5f46 A minor code simplification, saved in a branch for future reference. 
FossilOrigin-Name: 5e458f4a92743effb9a3d3249767424fed8b444a05ca136c4a55d60c4d70c2cc
 2018-09-19 18:17:46 +00:00
dan
c9461ecc28 Extend RENAME TABLE to edit triggers and views. Still buggy. 
FossilOrigin-Name: 01308bae3acf33f78b5bb90892085eab340df093aafc17e6ccf6a7d6cf324897
 2018-08-29 21:00:16 +00:00
drh
3a843f525c Remove an unnecessary IN_RENAME_COLUMN macro from resolve.c. 
FossilOrigin-Name: 5858c0bde7c210f07cfa72cee95325847b26733abab4f56301b57cd816931e97
 2018-08-25 03:29:34 +00:00
dan
85a9d508df Fix a problem with renaming a column that occurs as an "excluded.colname" 
construction in an UPSERT that is part of a trigger program.

FossilOrigin-Name: bb2f7234968157b605522dea8e115d8772ab4234147894089d6e48fedf5d6a5d
 2018-08-24 20:10:22 +00:00
dan
1b0c5de434 Avoid incorrectly replacing tokens that refer to a column being renamed via an 
alias. For example, do not overwrite "xyz" when "a" is renamed in "CREATE VIEW
v1 AS SELECT a AS xyz FROM tbl WHERE xyz=1"

FossilOrigin-Name: ad072a835f97ff418f5919d94f547ce8afb4fc7c7b590deba41f1e62136a79ac
 2018-08-24 16:04:26 +00:00
dan
07e9523364 Rename internal function sqlite3RenameToken() to sqlite3RenameTokenMap() and 
sqlite3MoveRenameToken() to sqlite3RenameTokenRemap().

FossilOrigin-Name: b9ae9a0a188b82d7066f6ef7d21592889df0a61559e9a0e01819e9d5a92c3f36
 2018-08-21 16:32:53 +00:00
dan
dabc268f96 Ensure that CREATE VIEW, TRIGGER or INDEX statements can be edited by ALTER 
TABLE RENAME COLUMN even if they use collation-sequences or
user-defined-functions that are not available.

FossilOrigin-Name: 540014efd6a048373313c6cd9413de10d5d7114daf537cf5999ccf3c5c3f9358
 2018-08-17 17:18:16 +00:00
dan
cf8f289542 Experimental implementation of ALTER TABLE ... RENAME COLUMN. Still buggy. 
FossilOrigin-Name: fa0fc01eb48a864f0a3d43f9b805d5ed2e530846ee0c34fcbc2eabd9e5696277
 2018-08-09 20:47:01 +00:00
drh
eee0861155 Fix a harmless warning about comment formatting in the previous 
check-in.  Simplify the ORDER BY dereferencing logic so that it avoids
unreachable branches.

FossilOrigin-Name: 0f6ec605e131ab3d53b9df32af0a3207146a9abbd22dcabd6ef050b92f96735d
 2018-07-10 07:39:23 +00:00
dan
f607bec749 Fix a segfault caused by having identical window functions in the select-list 
and ORDER BY clause of a SELECT statement.

FossilOrigin-Name: 693b4350d741391226a33ab6a05eaad61e8ef1590176f01e8aed2a212e2d6419
 2018-07-02 17:14:37 +00:00
dan
7262ca94cb Fix a segfault caused by invoking a regular aggregate as a window-function. 
And some problems with count(*) when used as a window-function.

FossilOrigin-Name: 4f3c8a82fd1c5b14d84f2301e34cfc8d52fe4b3a60840c39e895c11f2da529d9
 2018-07-02 12:07:32 +00:00