database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2026-01-13 20:39:27 +03:00
Code Activity
23,722 Commits 1,627 Branches 187 Tags
eba21cd4bee8d8b8a30a4183553dbc2d45747797
Commit Graph

275 Commits

Author SHA1 Message Date
drh
e1c4743121 Disable the sqlite3_error_offset() when the error occurs in a trigger or 
view or some other bit of text that is not part of the original statement.

FossilOrigin-Name: 0e909e34fa74e7b9b7954e4ed4c39dd293c1d413b58fda03607faab74aa382ad
 2022-02-07 18:52:56 +00:00
drh
1da88b5ce6 Add ALWAYS() macros. Change some existing ALWAYS() into assert(). Other 
code simplifications.

FossilOrigin-Name: 4aa27b4fcd1ffd06c38357a87ba3f5776367570439c49652f0903873def0bb23
 2022-01-24 19:38:56 +00:00
drh
0c7d3d399d Remove many redundant checks for sqlite3.mallocFailed now that any OOM should 
cause Parse.nErr to be non-zero.

FossilOrigin-Name: 1f7fa46126ea33ed30e93186aff3df51068aeb4be6f79a102bfe8c4e44941d71
 2022-01-24 16:47:12 +00:00
drh
c692df2784 Make it so that any Parse object is always linked into the database conenction 
while it is active.  Hence, an OOM will cause Parse.nErr to be set.

FossilOrigin-Name: 6a45d8fe8bfbc11a5b86d25237e1f8bccfb0f22f3dcaf004ba797aeb57b365ec
 2022-01-24 15:34:55 +00:00
dan
f5bc444077 Ensure that any error encountered while coding a trigger program is transfered to the main Parse structure before it is used with any other routine that might set the error code. 
FossilOrigin-Name: 4293656578811b500786335de7cc9ac0d6ccc6fb273b9419a86968a095404c43
 2022-01-24 11:25:42 +00:00
dan
c6977c1c0d Fix an assert() failure that could follow an OOM when coding a RETURNING trigger. dbsqlfuzz case 5d3e2438f15dc32b473d9f29413157857efa1212. 
FossilOrigin-Name: 7ae596dd4a73a09585c5dc9f4faf75d126d0733fc2fb32c1de64126a1088d967
 2022-01-05 15:54:02 +00:00
drh
ebc4434e99 Improved handling of OOM errors in sqlite3ExpandReturning(). 
dbsqlfuzz 1040b720f0bbc3bdcfe7336acffbf71517e3ef82.

FossilOrigin-Name: 33c6b8e94bda12df13b4d2dd782b3120c3628596b86ef531d20b3100bf159b50
 2022-01-05 11:49:58 +00:00
drh
41584df573 Ensure that the affinity of columns is honored in the RETURNING clause. 
See [forum:/forumpost/e0c7574ab2|forum post e0c7574ab2] for the bug report.

FossilOrigin-Name: 4711fb69547f4f17653ab116030c32fdcc2c836410349d1d025866ffc15704da
 2021-12-29 04:31:54 +00:00
drh
a4a871c286 Show the preferred schema table names in the output of "PRAGMA table_list". 
FossilOrigin-Name: 9147390d9885a37a62edc1058f313434627f1b59965c890877d2cb119e355c78
 2021-11-04 14:04:20 +00:00
drh
cf9d36d1b3 Refactor field names in the Column object, zCnName and zCnColl, to make them 
unique and thus easier to find amid all the other code.

FossilOrigin-Name: 8b781dcaf68e0cf12a844708c82eee00193e340195cbca915d077e4846983bf3
 2021-08-02 18:03:43 +00:00
drh
f38524d20d Refactor the Table object to reduce its memory footprint. 
FossilOrigin-Name: bbb6759bcf6e01d36dfc787a82a610d359f50aaeac8104b73883a84906d54e1f
 2021-08-02 16:41:57 +00:00
dan
cf1e25566b When generating data for a RETURNING clause, avoid assuming cursor number 0 is available for use. 
FossilOrigin-Name: 4b2c59acce6ff1bb6c9c04c45c80945ae23a26588718cc20635d60f7497adabb
 2021-06-28 15:25:17 +00:00
drh
9088186bfb Improved column name and column type determination for the RETURNING clause. 
FossilOrigin-Name: 699c33990a9438f28673ecf34f1e521d1af0b01c6ee30a608c0c91d2d593590e
 2021-05-19 12:17:03 +00:00
drh
3765c03243 Further improvements to the handling of RETURNING clauses on changes 
to TEMP tables with triggers.
dbsqlfuzz 683913e98f54fe4f14e8dd11a48011f73bdca58d

FossilOrigin-Name: ff3538ae37a02f4f36a15cddd1245171e724aac9c84b2e576980fd3806302775
 2021-04-27 17:18:10 +00:00
drh
a476768340 RETURNING bug fix: Correctly deal with RETURNING statements on changes to 
TEMP tables that also have triggers.
dbsqlfuzz 78b9400770ef8cc7d9427dfba26f4fcf46ea7dc2

FossilOrigin-Name: d0b15eccbfe1e50c3daf7b2fd4769a52bba35d553b07e462ca3f5f22df6742fd
 2021-04-27 13:04:18 +00:00
drh
4c4a25727f Earlier detection and handling of OOM problems. 
dbsqlfuzz 39f2963ea5559aa3a16e24e0e3cb42aac85a7371.

FossilOrigin-Name: 8d46df73132e46abb32b9dc129b6beb978d34dac3d372fb004ca283b0832d04c
 2021-04-06 12:50:24 +00:00
larrybr
b0e62b0a21 Avoid compile error when SQLITE_OMIT_VIRTUALTABLE defined. 
FossilOrigin-Name: 0ee0ef476ba9e17794c088a1347a136df3eb1ef864da884cfe81e3b2e94e9719
 2021-04-04 14:22:02 +00:00
drh
9af69ff547 Correctly capture the error when a RETURNING clause appears on an 
attempt to UPDATE an eponymous virtual table.
dbsqlfuzz 486f791cbe2dc45839310073e71367a1d8ad22dd.

FossilOrigin-Name: 778a9a6e6f8d960fd55ac9be7eea20b1875a46192db85e63dddc61b632b30173
 2021-04-02 20:43:26 +00:00
drh
0d23f678b1 Raise an error if a term of the form "TABLE.*" appears in the RETURNING clause, 
as SQLite does not (yet) know how to handle that.
Ticket [132994c8b1063bfb].

FossilOrigin-Name: 3039bcaff95bb5d096c80b5eefdaeda6abd1d1337e829f32fd28a968f663f481
 2021-03-30 01:52:21 +00:00
drh
a979993b25 Improved labeling of EXPLAIN QUERY PLAN output. Many test failures due to 
the different output format.

FossilOrigin-Name: 6f8faec0222a7ca07cc1a5ed16cc08d92c6e20bbcb34851b4eff9e624de53601
 2021-03-19 13:00:28 +00:00
dan
6a5a13df97 Fix various issues with the changes on this branch. Add test cases for the same. 
FossilOrigin-Name: 10538ec6fc1642dfc2ca6cef06ce6cb9e124847b421ccf01f5842064fad379ab
 2021-02-17 20:08:22 +00:00
drh
8729642112 Fix harmless compiler warnings. 
FossilOrigin-Name: 5f8bf99579e6663fc701cdc94f685584a86398c4687e25e7e241de755398f17d
 2021-02-07 12:59:43 +00:00
drh
29f6a365cc Remove unreachable code. Fix a shift UB problem introduced yesterday 
and discovered by OSSFuzz.

FossilOrigin-Name: 078dbff04a95a001bbd8690ab08038fbb5506899df8290991b53fd1122a4c30c
 2021-02-05 17:34:47 +00:00
drh
7dec804d42 Remove dead code. Fix RETURNING for INSERT into a virtual table. 
FossilOrigin-Name: dbfa38699c87ab4bf390666e411dda8d375c7b53b9b4fb131adacbf575867a72
 2021-02-04 22:59:19 +00:00
drh
e1db9343d5 Fix an issue with RETURNING from UPSERT. 
FossilOrigin-Name: 757b74ba0fd64634a365bd73955181191767ad8816a33a362e32ece250299a51
 2021-02-04 21:17:12 +00:00
drh
552562c48f Snapshot. New design appears to work on a simple test case. 
FossilOrigin-Name: 8a65fbeecf3597e30853c5f0ccd9b8b46c508854fa521e58e0db279deebca7d4
 2021-02-04 20:52:20 +00:00
drh
381bdacc8f Preliminary changes for a new implementation of RETURNING that captures all 
results in a buffer and plays them all back after the DML statement
completes.  This avoids problems with interleaved DML statements.
This particular check-in is a non-functional work in progress.

FossilOrigin-Name: 04b77d63216ce11b4e797946953bcde504fc005807c7a5ac757fbf47d78698dc
 2021-02-04 17:29:04 +00:00
drh
2aa41c82da Modify the SQLITE_DBCONFIG_ENABLE_TRIGGER setting so that it only disables 
main-schema triggers and allows TEMP trigger to continue operating.  This is
safe, since only the application (not an attacker) can add TEMP triggers.
It will also all us to disengage SQLITE_DBCONFIG_ENABLE_TRIGGER on Fossil
databases since Fossil has no main-schema triggers but does use TEMP triggers.

FossilOrigin-Name: a10c5a2503ff2998f6ee40f721aab8c9579052e535dc141bd57d10551eaea387
 2021-02-03 00:55:34 +00:00
drh
cb83dc9e95 Do not allow aggregates in a RETURNING clause. Fix a memory leak that 
occurs when window functions are used in a RETURNING clause.

FossilOrigin-Name: 2e9bd94b9ad37c7e4123b7324f2fe42d3609a65af449eb8a0064057647709a73
 2021-02-02 20:46:11 +00:00
drh
709dd13927 Report an error if RETURNING is used for DELETE or UPDATE of a virtual table. 
FossilOrigin-Name: bd5dee8425327fde0429043ce325b910f1b7951988d9a448a8eeeb713a46bc81
 2021-02-02 12:01:22 +00:00
drh
c9be863098 Allow the RETURNING trigger to exist for virtual tables. 
FossilOrigin-Name: 2f244ab4a2ba2bdb608cf44ef02e00738ad58c10a76d9e4222dc843a17103d92
 2021-02-02 00:16:15 +00:00
drh
7baf3d411b Modify RETURNING so that it does not return changes implemented by 
cascading foreign keys or by triggers.

FossilOrigin-Name: 6e62470a737cbde7f3fdcd027b98eb0b3dd11d063c63501d3c18448e93f5959f
 2021-02-01 01:57:55 +00:00
drh
9407b6ef29 Mark an unreachable branch as ALWAYS(). 
FossilOrigin-Name: cb8b797a64f65fca01c5faaeb30cbe4a53b56b81e696d1b62a90362d7ef8f924
 2021-01-31 16:45:10 +00:00
drh
662fe79647 When setting the number of result columns in a RETURNING trigger, be sure 
to set that value in the top-level bytecode program, not in the immediate
caller of the trigger.

FossilOrigin-Name: 1f1ce7ceb9807d22efea496f33908040ee196a31cd192f27ec0fb3e23afb729c
 2021-01-31 12:41:20 +00:00
drh
28828c550f Improved comments on the new code. 
FossilOrigin-Name: a38f0c1d7c1d7635732ac370d8fbc7e6a2005378e4621da7bc4f51a2f99912d1
 2021-01-30 21:55:38 +00:00
drh
658f0a3679 Fix a memory deallocation problem that comes up when doing a RETURNING query 
on a corrupt database.  I think I fixed this before, but it got unfixed with
stale editor content.

FossilOrigin-Name: 02b1415efb7d9849499afe4e9dbf7e470484bf144d6ca3d28fdc38fc0ac10afa
 2021-01-30 02:43:26 +00:00
drh
343256b9b0 Another attempt to get trigger selection correct for RETURNING triggers. 
FossilOrigin-Name: 1b8ed52275a54800df90682d694b482f55f26c6c4a420659f9a3b7bfc61e8abe
 2021-01-30 02:34:47 +00:00
drh
16d861ffc2 When running the RETURNING trigger, if it is tagged as a DELETE trigger, 
do not use it as INSERT or UPDATE.

FossilOrigin-Name: 3c7a6e04ddde34961d8e9d0443913e572a80853cf14a8263cec19523c39ca744
 2021-01-30 02:22:38 +00:00
drh
ba71a8a01b Test cases added. RETURNING works with UPSERT as does PG. 
FossilOrigin-Name: f5698f96e27c9b8669ec6016bb9920ef7580c4146eb61d628a0f62be5135ce94
 2021-01-30 01:30:26 +00:00
drh
8f4e2e25c4 Better handling of errors in RETURNING due to corrupt database files. 
FossilOrigin-Name: 6aa2a058d136d0b24d94c5cbe1ce447eb435c1a1c7cdce5e435f1548bb3f05e7
 2021-01-29 22:33:05 +00:00
drh
dac9a5f7df Allow "*" wildcards in the RETURNING clause. 
FossilOrigin-Name: b0e3ae303db2a035583a05848ab7977e612d7e40c77e31ea9e0166de443c901f
 2021-01-29 21:18:46 +00:00
drh
b835247954 Working prototype. 
FossilOrigin-Name: b7ef4dc21f187ff4ff679e823782535188c3814aa6ce720b3a01c6d3ba4ef9f5
 2021-01-29 19:32:17 +00:00
drh
f54a80fe5c Performance optimization (and size reduction) in sqlite3TriggerList() for the 
common case where there are no TEMP triggers.

FossilOrigin-Name: 0defaf730bdc82212a5d3feeb2e16f16423b1691b0aaa7da1787eb82ea39ae9e
 2021-01-29 13:47:36 +00:00
drh
cf3c078f93 Add a linked list of ParseCleanup objects to the end of a Parse object and 
use that list as a place to put other sub-objects that need to be deallocated.
Have a single such list for infrequently used sub-objects is more efficient
than doing an a separate check for each kind of sub-object.

FossilOrigin-Name: affa2b7b316941b8a6c4d0d1ff212c81a593faf1d05d129e14d2b70d73a25c59
 2021-01-11 20:37:02 +00:00
drh
4e451aad54 Suppress errors associated with TEMP triggers that reference objects in 
non-TEMP databases.  This is a continuation of the fix for ticket #3810
shown in check-in [ba1afc040171810d]
from [/timeline?c=trunk:200908061743|2009-08-06], based on a bug report in
[forum:/forumpost/157dc791df|forum post 157dc791df]

FossilOrigin-Name: 991ca9b26bacd8f6b64498057fe28f2068466a220f372fd365b6685f583f0e92
 2020-11-05 19:13:44 +00:00
drh
b866a65d4d Fix a double-free of the FROM clause of an UPDATE inside of triggers. 
FossilOrigin-Name: 706c8da2f6d9299f0ad3b3c93332b38071e8e88b4d1660c1841309919b64fd18
 2020-07-16 02:36:24 +00:00
dan
e7877b2d6b Support UPDATE...FROM statements in trigger programs. 
FossilOrigin-Name: 4f6d8d0ebf40029218a1d3b05ea657c0c5953b01c6f0b6a628465aa44c67e7f3
 2020-07-14 19:51:01 +00:00
drh
1e32bed3c1 Further refactoring of the schema table name. 
FossilOrigin-Name: 9536fa0ae0c1ae6e2e98d2fa11e5acda7f3c9b8ca5061b6f7f8cae63a11d936b
 2020-06-19 13:33:53 +00:00
drh
346a70ca1e Provide "sqlite_schema" as an alternative name to the table that holds the 
database schema.

FossilOrigin-Name: 61782a7ae3c25cf59d7a676cb295eb024d17c46e532ae78c6fe871a91d712fa9
 2020-06-15 20:27:35 +00:00
dan
465c2b8964 Consolidate some code on this branch. 
FossilOrigin-Name: a85c63daa640e02fdfd891a05a1a09e848c9621a5dd6e112338451008623ecbb
 2020-03-21 15:10:40 +00:00