database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-11-14 00:22:38 +03:00
Code Activity
20,306 Commits 1,608 Branches 185 Tags
e22976c5357fb6501cb0dd40220b8d48bd9295bb
Commit Graph

1354 Commits

Author SHA1 Message Date
drh
45616c7f75 Add an "|| CORRUPT_DB" term to an assert() statement in the btree defragmenter. 
FossilOrigin-Name: 6bfd8655f006e031c0d4c988356c4b9206efa6bfdb034fde8ffa3361521a4844
 2019-02-28 13:21:36 +00:00
drh
eaac9996ed Use unsigned integers to count the number of pages in a freelist during 
an integrity_check, to avoid any possibility of a signed integer overflow.

FossilOrigin-Name: 05b87e0755638d31f6d8918f8758362f8c3981661449b5171180a8498f66bd9d
 2019-02-26 16:17:06 +00:00
drh
12fe9a0d25 Fix an assert() that might not be true if the database file is corrupt. 
FossilOrigin-Name: f2d400db4dbfb05e2540178ed3662f97f8c57a95f8129886c7081c35e53adf0d
 2019-02-19 16:42:54 +00:00
drh
56785a0a80 Fix an assert() that might be false for a corrupt database. 
FossilOrigin-Name: 0cfb888723fb8ff0763bbc23acb7d21a53f6d1c40661d8468248644281b29d85
 2019-02-16 22:45:55 +00:00
drh
9c7e44cddd Improved oversized cell detection when updating ptrmap pages in 
balance_nonroot().

FossilOrigin-Name: aa61435a4c3800f023788081c1342ad6a05a41449a424fa6c039d5ca46072256
 2019-02-14 15:27:12 +00:00
drh
5860a61d59 Further performance improvements to btreeInitPage(). 
FossilOrigin-Name: 93ae382e97c23c90312739481e47ef7f9bc475a8382c063a2de2986c950c0aec
 2019-02-12 16:58:26 +00:00
drh
a941ff712d Change an assert() into a NEVER(), since the condition is difficult to prove 
with certainty.  Improved comment on the MemPage.nFree field.

FossilOrigin-Name: fec071b89df2cbafda365077bb54bc9999e12086f36d6cea8d125662b36638dc
 2019-02-12 00:58:10 +00:00
drh
8357c662b3 Do not invoke btreeComputeFreeSpace() when not necessary. 
FossilOrigin-Name: f11b0ed47402034378ded2c60b82841b81cd1319cdb72d1ef052faef29a5294d
 2019-02-11 22:50:01 +00:00
drh
d4a6744b50 Improvements to comments. No changes to code. 
FossilOrigin-Name: 16eb0fc8f8cce51eaa5305ebc9f3bd8c8d935dd3ebebab6820e5629f9292eec2
 2019-02-11 19:27:36 +00:00
drh
6813350966 Fix test cases. Avoid unnecessary tests for MemPage.nFree less than zero. 
FossilOrigin-Name: 480a5090befdc29eaeb6f0b22831c980d6ee92438d9b2e766de68b037ded38b8
 2019-02-11 17:22:30 +00:00
drh
c01f41cfa6 Updates to a comment to keep it in alignment to the changes on this branch. 
FossilOrigin-Name: 7499f74351415e601eb48eff6b6fccd3a78d137f5ea9cd7cac46b904772966de
 2019-02-11 12:51:39 +00:00
drh
85a379b74b Fix a page-cache reference leak in the btree balancer when there is a corrupt 
database.

FossilOrigin-Name: 9285899120dec24ff2944431ad455d7ae217ef408ae2f1a3e7bdfb897099028c
 2019-02-09 22:33:44 +00:00
drh
b0ea9432a1 Defer computing the MemPage.nFree value of an in-memory btree page 
until it is actually needed, since for many pages it is never needed.
This checkin works sufficiently to prove the concept, but still has issues
with exception handling.

FossilOrigin-Name: 1d43ee4000b71f5c6d49244dee96358c567f09ba3451b9d22895a796d3f61ad6
 2019-02-09 21:06:40 +00:00
drh
298f45c641 Small performance improvement and size reduction for pageFindSlot() - the 
routine in btree.c that locates a free slot for a cell on a btree page.

FossilOrigin-Name: 1969372ac72d25cc642a0268f4bb0ae4b59f2dca568c119ef61b67183b3a8bd9
 2019-02-08 22:34:59 +00:00
drh
53d30dd371 Early detection of implausibly sized records to avoid unnecessary 
large memory allocations.

FossilOrigin-Name: 2c8769c69f301307db6663adb8b7c0b89f5959516bf6110cb8ff4b21bd903f70
 2019-02-04 21:10:24 +00:00
drh
26b7ec8b24 Improve the strict enforcement of cell sizes in balancing from 
check-in [12713f320b2c1def] so that it also works with table-btrees
in addition to index-btrees.

FossilOrigin-Name: ef27e7a08728aa7447ae19812803ac5c4a9d80c97541014bd292485792005a3e
 2019-02-01 14:50:43 +00:00
drh
3f4f6823ac Fix harmless compiler warnings. 
FossilOrigin-Name: 9a93c68a7673bda2e6c308d3b2798d0fb12fde399996cae24b1f0d5864adf355
 2019-01-29 16:54:31 +00:00
drh
a046643820 More robust handling of corrupt database file in the rebalance operation of 
the btree logic.

FossilOrigin-Name: 97704cb7d29fa7cc4ea9a6761a7844c1946d637ea2b22d287fc787ae0f63c407
 2019-01-29 16:41:13 +00:00
drh
0c873bf28a Change the definition of the BtCursor.skipNext field so that it is undefined 
for states CURSOR_VALID and CURSOR_INVALID.

FossilOrigin-Name: 6089d5dba73437d787259033e94a38cf1b0c87cac4a89c27e69d8239c22f496e
 2019-01-28 00:42:06 +00:00
drh
e6a9efb976 Ensure that the btree cursor is correctly set up prior to backing it up 
as part of a delete operation on a divider cell in an index.

FossilOrigin-Name: a3ea1a822d3a110f4f186f2fc8550f435c8c98635d058096b7be9d4df7066b8b
 2019-01-26 23:34:50 +00:00
dan
ba14c69b4f Fix a couple of assert() statments in btree.c that could fail with corrupt databases. 
FossilOrigin-Name: 5eb5e8289fa71e5e29e081d33d4a59c64b463bf6b06d7070c05c46d77d808ad4
 2019-01-25 13:42:12 +00:00
dan
b0c4c94996 Fix a potential problem with "INSERT INTO ... SELECT * FROM" (or VACUUM) statements on a corrupted database. 
FossilOrigin-Name: db4b4c2c1e9f1adacfb1b2fedb717a4d8bb0a299c3b11835404a99fcd67bf24b
 2019-01-24 15:16:17 +00:00
drh
55469bbafb Use memmove() instead of memcpy() in a place where buffers might overlap 
if the database file is badly corrupted, to prevent warnings
from ASAN and valgrind.

FossilOrigin-Name: 65ad6c55f1ba9bc2f75afffa3adaf19f145fad7ac9a00ccce6372e9a2cc4341b
 2019-01-24 13:36:47 +00:00
drh
e3dadac591 Stricter enforcement of cell sizes when doing balancing operations on the 
btree, in order to catch file corruption sooner.

FossilOrigin-Name: 12713f320b2c1def273dd8b7833dddaaad5331aba779d4b1ec9aa949814f38fe
 2019-01-23 19:25:59 +00:00
drh
87c3ad4537 Enhance the btree search routine so that it does early detection of 
impossibly large keys and thereby avoids a large malloc() call.

FossilOrigin-Name: 3ecaaee69f49e43d38047b7d53b82689eba7f7d33541fcac3c32b6dc8a568458
 2019-01-21 23:18:22 +00:00
drh
e6c628e98c Make sure the extra bytes allocated for the saved cursor position by 
check-in [160b1e31c0f27257] are initialized to zero.

FossilOrigin-Name: 2737564929e86ead84a3ff6512369268198d38b46e3e02866f8ce34babc76cb9
 2019-01-21 16:01:17 +00:00
drh
d12db3dabb Avoid reading off the front of a page buffer when balancing a corrupt 
btree page.

FossilOrigin-Name: cb50509020d952fa9efed8df7fa08b07b71ae9bdbdefea216b6e660863291039
 2019-01-14 05:48:10 +00:00
drh
0f1bf4c1ac Improved detection of database corruption while balancing pages from an 
auto_vacuum database with overflow pages.  Test cases in TH3.

FossilOrigin-Name: 35f04235c477501390acea126d07a730d81d03cdf7abcd82d861e397b3f75b0f
 2019-01-13 20:17:21 +00:00
dan
e6370e9c29 Fix a problem handling a negative value in the "number-of-pages" database 
header field. Also a problem with running "REINDEX tbl" against a virtual
table for which the SQL passed to sqlite3_declare_vtab() contains PRIMARY KEY
or UNIQUE constraints.

FossilOrigin-Name: 556dd8922f65af93084ee725c638b8dc696b611dd508c212a3b507d6ca474031
 2019-01-11 17:41:23 +00:00
drh
f10ce63651 Fix PRAGMA integrity_check so that it does not cancel the PRAGMA vdbe_debug 
setting.

FossilOrigin-Name: aaa3a19f8cf5ba7003634e4610abc7832354af91d7c7f65469218678f66bcd46
 2019-01-11 14:46:44 +00:00
drh
dcc2700d7e The page size becomes fixed as soon as page1 from a non-empty database file 
is read.

FossilOrigin-Name: 6064584d578f0ac7aba3f67912a5d9eb1a3c6001469f6b9becbe68871131f887
 2019-01-06 02:06:31 +00:00
dan
97c8cb3ed8 Ensure that when a new cursor is opened by OP_OpenDup, any existing cursor 
with the same id opened by a previous OP_OpenDup is closed first.

FossilOrigin-Name: 5c188361a91407805c0feb4bf6d3214522ce3e55013efcf63a4613ecd416bcbc
 2019-01-01 18:00:17 +00:00
drh
ae10474125 Fix possible integer overflow while running PRAGMA integrity_check on a 
database file with a badly corrupted freelist.

FossilOrigin-Name: 395599116d801324f0763e59bc5e2fc8622aa5b7572e0c1c9a982efbb3cc8280
 2018-12-14 17:57:01 +00:00
drh
d7a5e49840 Back out the expansion of the temporary buffer size from 
[32754ca6f86da816] and replace it with an explicit test for buffer
overreads.

FossilOrigin-Name: 8ba3d9f38090c4bbbcffba1930e5c26f69ff61f49b72a4a5a59253d37341380f
 2018-12-14 16:20:54 +00:00
drh
e7acce66b2 Avoid a buffer overread in ptrmapPutOvflPtr() that can occurs in a 
corrupt database file that has large entries and uses autovacuum.

FossilOrigin-Name: f8b781cf41800e9f61a1c5376404a97e76a2bbbcaa17396d42be62f731363947
 2018-12-14 16:00:38 +00:00
dan
fffaf23013 When saving the position of a cursor at the b-tree layer, allocate a few extra 
bytes at the end of the buffer used to save the key. Otherwise, if the key is
corrupt, the code that restores the cursor position may overread the buffer by a
little.

FossilOrigin-Name: 160b1e31c0f27257c06c2987af9ec3a64abfacb2150325b72e8ccd3d217b5baa
 2018-12-14 13:18:35 +00:00
drh
203b1ea0f5 Detect when an attempt is made to write to a pointer map page that is also 
being used as a btree page and report corruption.

FossilOrigin-Name: 3036fd71ac7063359b04a0ed54a6c63a380eb7ff75cd29ed27486d4259066aee
 2018-12-14 03:14:18 +00:00
drh
6301c43f23 dbfuzz2 found a NEVER() that is sometimes true. 
FossilOrigin-Name: 1201615cbbd3070158ea5fab3d2c8c95f41b25d6da096a44cb9257a7b7405efc
 2018-12-13 21:52:18 +00:00
drh
8061ad8abd Add extra tests for database corruption inside the defragmentPage() routine, 
as dbfuzz2 has found ways for corruption to leak into that point.  Add test
cases in fuzzdata7.db.

FossilOrigin-Name: 997b65117f8c12dba5fb85434fde9765cdb0d2a49cc3e31979abba3e21350086
 2018-12-13 21:11:22 +00:00
drh
1641f11f4c Fix a problem in sqlite3BtreeDelete() in which deleting an entry from a 
corrupt database can leave a btree page with zero cells.

FossilOrigin-Name: 682053d1e603c21b8085c39db618a39b23ec8d2c4d822fd19634db0e03038ea2
 2018-12-13 21:05:45 +00:00
drh
5881dfea2c New database corruption test cases discovered by dbfuzz2. The new cases 
have been added to test/fuzzdata7.db, but have not yet all been fixed,
so tests will not currently pass.

FossilOrigin-Name: b4210d320c6426d2838d4cc08709fdfd015c1c95fcad9a5f9e8fd390c23b9fad
 2018-12-13 03:36:13 +00:00
drh
d5b44d60c7 When masking bits off of sqlite3.flags, make sure the mask is 64 bits 
in size so as not to accidentally mask of high-order bits.

FossilOrigin-Name: 53d3b169d8e1892163526caff2c843302c92e280fdeff6831e23a9bb15b82be3
 2018-12-06 17:06:02 +00:00
dan
09236755ee Fix a problem reading from temp databases in SQLITE_DIRECT_OVERFLOW_READ 
builds.

FossilOrigin-Name: 81629ba91475938b6ad528e7b1dbef4ad22239782bb2e9c1bb59413aba11da87
 2018-11-22 19:10:14 +00:00
drh
0f1c2eb5f2 Correct the internal logic for SQLITE_DBCONFIG_DEFENSIVE. 
FossilOrigin-Name: 76094345821246c887a31a234b339d03a78eddbb9fab33b06c3c20797c038349
 2018-11-03 17:31:48 +00:00
drh
a296cda016 Add the SQLITE_DBCONFIG_DEFENSIVE flag. 
FossilOrigin-Name: af3f29d49359af2291b1d9e06e0db76fd000fbd24b4ac84d2668a0d1322efd83
 2018-11-03 16:09:59 +00:00
drh
49272bc728 Improved corrupt database detection in the relocatePage() routine of 
the b-tree module.

FossilOrigin-Name: d57873337a2a7a0d717dc7726cd2682b5bea594d2d1ff8f16c2485161fcd6b16
 2018-10-31 01:04:18 +00:00
drh
040d77aa71 New checked in PRAGMA integrity_check to validate the autovacuum settings 
in the header.

FossilOrigin-Name: a4663f09c91d1381a831f61a2b8e8a113eb6083932c4aea2ad0c011ece1418c5
 2018-07-20 15:44:09 +00:00
drh
91d5866eb6 Enhanced detection of problems on the freelist and on overflow list in 
PRAGMA integrity_check.

FossilOrigin-Name: 11e58f5b37d99848978007d834d187c262d904eb9d58924742e028d7cb324e64
 2018-07-20 13:39:28 +00:00
dan
ea933f07b0 Experimental fix for resetting databases that have been deemed read-only due 
to a corrupt "read-version" header field.

FossilOrigin-Name: e2394002d02754bb45d56e805df9bc5a2ef0d14e5d94262c1f8ab7643bc27c8f
 2018-07-19 11:44:02 +00:00
drh
f710345303 Add an ALWAYS() around a branch in sqlite3BtreeSkipNext() that we believe 
must always be true.

FossilOrigin-Name: 12be361a532df0c22a7e4d97658b82a69b1a205d4cca8d092b9e6b7790c1ee40
 2018-07-09 20:41:39 +00:00