database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-11-12 13:01:09 +03:00
Code Activity
21,092 Commits 1,607 Branches 185 Tags
d901b168b58bb82192bcfc5dcb3b7ae316af1497
Commit Graph

189 Commits

Author SHA1 Message Date
dan
1b0c5de434 Avoid incorrectly replacing tokens that refer to a column being renamed via an 
alias. For example, do not overwrite "xyz" when "a" is renamed in "CREATE VIEW
v1 AS SELECT a AS xyz FROM tbl WHERE xyz=1"

FossilOrigin-Name: ad072a835f97ff418f5919d94f547ce8afb4fc7c7b590deba41f1e62136a79ac
 2018-08-24 16:04:26 +00:00
drh
79a5ee93c7 Fix harmless compiler warnings in the ALTER TABLE logic. Rephrase an 
error message to use active voice.

FossilOrigin-Name: a7dae59a7e7b187fa2e9457bbb4b01cfe3d48bbdf59c3f8f7b4156bcde3bda98
 2018-08-23 19:32:04 +00:00
dan
07e9523364 Rename internal function sqlite3RenameToken() to sqlite3RenameTokenMap() and 
sqlite3MoveRenameToken() to sqlite3RenameTokenRemap().

FossilOrigin-Name: b9ae9a0a188b82d7066f6ef7d21592889df0a61559e9a0e01819e9d5a92c3f36
 2018-08-21 16:32:53 +00:00
dan
0624939818 Rationalize some duplicated code in alter.c. Also improve error messages for 
ALTER TABLE RENAME COLUMN in some cases.

FossilOrigin-Name: 5d2163c734aea8c0e1611af1161734bf141e7bd02c08f0b5f2e7bac3c7dfd2a5
 2018-08-21 15:06:59 +00:00
dan
d145e5f46f Minor changes to function tokenExpr() in order to claw back cycles lost to the 
rename-column change.

FossilOrigin-Name: 479976955ecb27c3e77a280187eaf23722178549e072b34f3183354a27a4e5c3
 2018-08-21 08:29:48 +00:00
dan
b013738b4c Add further tests for RENAME COLUMN. 
FossilOrigin-Name: 82c4c10a96db76f39edf5f6d027294d449d75b5a18da70da3667786da90e184d
 2018-08-20 20:01:01 +00:00
dan
9d70557e80 Ensure that it is not possible to rename columns of system tables, views or 
virtual tables.

FossilOrigin-Name: 786b5991dc0bb6ba13327a3ac9d04efbf8b591dedc736b719b206ffd865b1918
 2018-08-20 16:16:05 +00:00
drh
38d9964a73 Additional fixes for harmless compiler warnings that are specific to this 
branch.

FossilOrigin-Name: 9d8e73bf71e996b810959ffc0e60de69b5e8ca3301df52f9c35d5e9075921798
 2018-08-18 18:27:18 +00:00
dan
24fedb94c2 Improvements to error handling in ALTER TABLE RENAME COLUMN. 
FossilOrigin-Name: 7fa1faeaff30b74b68ee6f4b363d837f21cf313d8262361c901bda884df139a2
 2018-08-18 17:35:38 +00:00
dan
499b825487 Allow an ALTER TABLE RENAME COLUMN to proceed even if the schema contains a 
virtual table for which the module is unavailable.

FossilOrigin-Name: 7b72b2360a70eb1f788b3c4d745967dfedb2c80af6b2e146ba940a3741fd51a1
 2018-08-17 18:08:28 +00:00
dan
0cbb0b11f1 Further progress on updating trigger programs as part of ALTER TABLE RENAME 
COLUMN.

FossilOrigin-Name: 3f47222b6e20e1c1ef41c0f7391c8b5c7648e2a2d6013303d155ad59ce27143a
 2018-08-16 19:49:16 +00:00
dan
5be60c55e8 (no comment) 
FossilOrigin-Name: e272dc2b1c0edab59a40f32c77c81a3e636937280524161eff5669cb0046ad84
 2018-08-15 20:28:39 +00:00
dan
356afab163 Fix a problem when renaming an IPK column that is also part of a child key. 
FossilOrigin-Name: 6e6a2bfdbbfd4ffc14be88962ff97bf3c626fef9d1a337715d2a4be1a657fb0d
 2018-08-14 21:05:35 +00:00
dan
f62e8937ac Fix a problem when renaming an IPK column that is also part of a child key. 
FossilOrigin-Name: ad15486022209205c65fb5ffdbe30a7b99379170451e6aff4bab6e90b549d6c7
 2018-08-14 21:03:38 +00:00
drh
af4023de22 Do not allow ALTER TABLE RENAME COLUMN on a virtual table. 
FossilOrigin-Name: f6d6b472713c21deace3fd52c0b0b6901d758af043c238f004fabe52b01f730c
 2018-08-14 20:38:18 +00:00
dan
987db767d2 Have ALTER TABLE RENAME edit column references in CREATE VIEW statements. 
FossilOrigin-Name: db829dc1a2d7afa49798a2fd32d1f070185b23e513416e65d8144fda24f23b50
 2018-08-14 20:18:50 +00:00
drh
1595abcda6 Improved error messages when an ALTER TABLE RENAME COLUMN fails due to a 
duplicate column name.

FossilOrigin-Name: 37d11b8e8224a8b241ff57b9c4b9499db39dde4ddcb56ff8b03a3d08091a4c11
 2018-08-14 19:27:51 +00:00
dan
689b9d269c Fix ALTER TABLE RENAME COLUMN in cases where the column being renamed is an 
IPK declared with a separate PRIMARY KEY clause - "CREATE TABLE x(y INTEGER,
PRIMARY KEY(y))".

FossilOrigin-Name: 32ca8418df8735a6c53e53153f733579e514711f091e4e09ecce83db85fe4d85
 2018-08-14 16:18:19 +00:00
dan
5496d6a25a Edit the WHEN and UPDATE OF clauses of trigger programs as part of ALTER TABLE 
RENAME COLUMN.

FossilOrigin-Name: 5fdb6b0aafba727139e1937ef5950e4434a77f95a10fc46f8010ca2de3922326
 2018-08-13 17:14:26 +00:00
drh
0a1cc223bd Make the sqlite_rename_column() SQL function resistant to problems caused 
by OOMs and/or malformed parameters submitted by hostile application code.
Also add additional comments to the RENAME COLUMN logic.

FossilOrigin-Name: 87743ddef11749b4017d60abc297abfd673e02a26a2ae45ffec861327578aa30
 2018-08-13 17:02:26 +00:00
drh
4a2c747c4c Fix legacy comments on Token. Begin commenting the new ALTER TABLE RENAME 
COLUMN code.  Fix a memory leak in the sqlite_rename_column() SQL function.

FossilOrigin-Name: 32edc8920376aabb84ebe1900eaa9512d23f1b44d6459e4916dc6b07db66e27c
 2018-08-13 15:09:48 +00:00
drh
5fc22cdfde Fix issues with ALTER TABLE RENAME COLUMN associated with OOM errors. 
FossilOrigin-Name: 0b28dd5c2e4908d5e49eaedd359492e46de8af3bf84120f4683b3ea906882fbf
 2018-08-13 13:43:11 +00:00
dan
404c3ba0d6 If the new column name in an ALTER TABLE RENAME COLUMN statement is quoted, 
then also use quotes for the column name in the edited SQL statements.

FossilOrigin-Name: ca5184a25f9150540a3e401ef67df0606efa7a294d70e3fa5edad9854003eb36
 2018-08-11 20:38:33 +00:00
dan
a8762ae27c Fix a bug causing ALTER TABLE RENAME COLUMN to fail when renaming an IPK 
column that is used in a CHECK constraint.

FossilOrigin-Name: 6595c8811f13719d0aed8041abc7e1cade41c57427bcbf3503e2e42408eaa03b
 2018-08-11 17:49:23 +00:00
dan
872165f260 Fix a bug causing all ALTER TABLE RENAME COLUMN commands to fail if ANALYZE 
had been run on the database. Also prevent the user from renaming the columns
of system tables.

FossilOrigin-Name: ca644a2877c26561f8fb3b3feb74a070cd46621acb105577f04bc936c9b72a95
 2018-08-11 17:34:38 +00:00
dan
e325ffed04 Reload the entire schema after renaming a column in order to ensure that the 
schema for any tables for which parent key definitions were changed are
reloaded.

FossilOrigin-Name: f4497b0136e9fcb1121a834c86f84eeaf8f1e7d3157d409484e086bcef3487f1
 2018-08-11 13:40:20 +00:00
dan
5da06d3d7e Ensure the schema cookie is changed when a column is renamed. 
FossilOrigin-Name: 2dec9ea4ab1779d00bb22add0aa9a8536661d8abc9f4c2fb8628e04d4cd84326
 2018-08-10 20:19:34 +00:00
drh
ad866a1e00 Fix harmless compiler warnings. 
FossilOrigin-Name: 9564d7008c3fd804401a5da6ea342c6f4261db14e9f994d1a38883358a7c6f8c
 2018-08-10 19:33:09 +00:00
dan
6fe7f23fa9 When a column is renamed, update any references to it in REFERENCES clauses 
that belong to other tables.

FossilOrigin-Name: 191079bd4f774528a1e39b71b4a4ce7859dee0edf0ce72e4b6968ae889dc35c8
 2018-08-10 19:19:33 +00:00
dan
cf8f289542 Experimental implementation of ALTER TABLE ... RENAME COLUMN. Still buggy. 
FossilOrigin-Name: fa0fc01eb48a864f0a3d43f9b805d5ed2e530846ee0c34fcbc2eabd9e5696277
 2018-08-09 20:47:01 +00:00
dan
2b5f152601 Fix a minor problem in the code for determining whether or not an SQL 
statement is SQLITE_TOOBIG.

FossilOrigin-Name: 763e6c9e2bbc0a6ef8d8361069bf7160790c9064f24f0e336b7ed85668735da9
 2018-06-30 20:00:35 +00:00
drh
df12595c09 Change a comma into a logically equivalent but semantically clearer semicolon. 
FossilOrigin-Name: 71f97f0f82b3abfb07feb78d64a182fc50ff396e85d6f5aac479dbf58ba4d00a
 2018-06-06 23:31:26 +00:00
drh
8257aa8dbe Add the new sqlite3.mDbFlags field. Factor out bits of sqlite3.flags that 
do not interact with PRAGMA statements into sqlite3.mDbFlags.

FossilOrigin-Name: 3808a00f06d372cc531da039d97bd974e4a6576a30cf63bf562f83f186b313b3
 2017-07-26 19:59:13 +00:00
drh
59a386ea03 Minor code simplification in the ALTER TABLE logic. 
FossilOrigin-Name: bfc4e7f30e4654b9603457fb6a4136828e346dcfe4e313fdf56ed62d131b7156
 2017-06-28 01:12:53 +00:00
drh
e0a04a36a6 All temp.sqlite_master to be used as an alias for sqlite_temp_master. 
FossilOrigin-Name: 8d646905b830d5bb29092e103ac5cb499b3c7e5a
 2016-12-16 01:00:21 +00:00
drh
79df77821a Refactor the Table.nRef field as Table.nTabRef for easier grepping. 
FossilOrigin-Name: 9cae4c2e300e20304ced0dc8c1415c4922185928
 2016-12-14 14:07:35 +00:00
drh
69c338263a Rename the Db.zName field to Db.zDbSName to make it more descriptive and to 
distinguish it from all of the other "zName" variables scattered throughout
the code.

FossilOrigin-Name: 92a22f01343a898455fd61c3b8e7d7c954f5b569
 2016-08-18 14:33:11 +00:00
drh
86396219a3 Fix ALTER TABLE so that it does not promote the schema version past 3, as 
that will cause DESC indexes to go corrupt.
Ticket [f68bf68513a1c].

FossilOrigin-Name: a7db6e45ad45be9b3003f61d4163f543498a7c9d
 2016-07-14 19:13:11 +00:00
drh
94eaafa9ce Reduce the amount of heap required to store many schemas by storing each 
column datatype appended to the column name, rather than as a separate
allocation.

FossilOrigin-Name: 842b21162713bb141b845b01c136457a31af4ab0
 2016-02-29 15:53:11 +00:00
drh
94fa9c414a Eliminate the need for the Column.zDflt (using Column.pDflt instead) to reduce 
the amount of memory needed to hold the schema.

FossilOrigin-Name: d8c94a46dfa94930732c2de2aa79675c5087d36e
 2016-02-27 21:16:04 +00:00
drh
80738d9c3e Improvements to the application-defined function mechanism so that it is 
more compact and runs faster, especially when the application defines
thousands of new SQL functions.

FossilOrigin-Name: 3201fbcc5105d23132e6b8b7ac825e66af4f8a39
 2016-02-15 00:34:16 +00:00
drh
bbde018230 Code simplification: ALTER TABLE ADD COLUMN always upgrades the file_format 
to 4 if is not there already.  No need to upgrade to only 2 or 3 since format
4 has now been supported for over 10 years.

FossilOrigin-Name: e1d8ec85546caeca3bb7a05ad962a2aed91194ce
 2016-02-09 16:09:22 +00:00
pdr
bb3da060e3 Fix an assert() to have a test instead of a side effect 
FossilOrigin-Name: a2952231ac7abe165ed070875728f752ae0be608
 2016-02-06 14:14:43 +00:00
drh
4a642b6060 Improvements to the way that OOM errors are processed. 
FossilOrigin-Name: c3ef03478a5788c855b3aef385d43ae7f494f440
 2016-02-05 01:55:27 +00:00
drh
4df86af329 Remove unnecessary sets of db->mallocFailed. 
FossilOrigin-Name: b787165b25a240fd5b4a5c7f73b395f30213a1d7
 2016-02-04 11:48:00 +00:00
drh
1861afcdbb Change the OP_SetCookie instruction to write the literal P3 value, not the 
value in register P3.

FossilOrigin-Name: 6d7d4703ebf3754bec74123d5ba7e861a705f90f
 2016-02-01 21:48:34 +00:00
drh
728e0f91bb Compiler warning fixes: Rename some local variables from "j1" to avoid a 
name collision with the j1() bessel function in the math library.  Omit a
dummy initializer that gcc 4.6.3 does not like.

FossilOrigin-Name: 9ddef84d432813f3ece8012047d08441caa3315d
 2015-10-10 14:41:28 +00:00
drh
076e85f59c Add the sqlite3VdbeLoadString() and sqlite3VdbeMultiLoad() routines to help 
with code generation, especially on PRAGMAs.  Rename sqlite3VdbeAddGoto()
to just sqlite3VdbeGoto().

FossilOrigin-Name: 847387ec8e6fef283899578fb232b2c23b00ee5b
 2015-09-03 13:46:12 +00:00
drh
05883a3409 Rename SQLITE_AFF_NONE to SQLITE_AFF_BLOB. 
FossilOrigin-Name: bce3f04186cd2d69414a5a98b5b77dc8f060554a
 2015-06-02 15:32:08 +00:00
dan
d68d1f4863 Fix an assert() failure that could occur if the internal sqlite3_rename_parent() SQL scalar function was invoked directly. 
FossilOrigin-Name: 36e515261825be60ffdc73d13340d77cf377e8e1
 2015-04-28 14:07:02 +00:00