drh
25c3b8caf4
Reduce the size of the NameContext object by grouping seldom-used fields
...
into a union.
FossilOrigin-Name: dba3095feeeb55b5c0ebe33bdd4be8ba1f24478406685d3a042a69d9c380e742
2018-04-16 10:34:13 +00:00
dan
24e25d32ce
Experimental change to "SELECT * FROM ... ORDER BY" processing to load some
...
column values from the db after sorting.
FossilOrigin-Name: 9719cb46bbf501ce80f185159d594f593dd0b2639b9ef5a71a6c7b70046cb08d
2018-04-14 18:46:20 +00:00
dan
d6189eafa4
Minor simplification to internal function generateSortTail().
...
FossilOrigin-Name: f32cdb41ca213cfcfe0bb5bfe56930d43e55525fa5640274b00f1ccce7f69634
2018-04-11 14:11:53 +00:00
drh
a5746e0317
Minor changes to the input grammar resulting in a faster and slightly smaller
...
parser.
FossilOrigin-Name: a2c443c0ee9a0e0b2d10298b8a74ff00a1a66e3f96f4093348f0fef977587204
2018-04-09 20:36:09 +00:00
dan
4f9a7e5cb7
Fix an assertion failure triggered by a SELECT with a compound sub-query that
...
contains an incorrectly placed ORDER BY clause. This problem is just an
assert() failure - non-DEBUG builds are not affected. Problem found by
OSSFuzz.
FossilOrigin-Name: 823779d31eb09cda5effe747d9adb35e600a52d4274226586437f674e7824d91
2018-03-31 16:31:51 +00:00
drh
6a9b9527fa
The push-down optimization was being too aggressive such that it sometimes
...
generated incorrect results. Reinstate the restriction (4) (with
qualifications) that was removed by check-ins
[b5d3dd8cb0b1e4] and [dd568c27b1d765].
FossilOrigin-Name: f08c1731b0b1dddcba190b094a35306a159713d3db939330f73075ff1d72c81e
2018-03-27 15:13:43 +00:00
drh
7fbb101c54
Relax LEFT-JOIN restrictions on the push-down optimization.
...
FossilOrigin-Name: b5d3dd8cb0b1e42ed0671a12d22af05194ea9522e4f41fd4bb0deff70b8b0757
2018-03-21 01:59:46 +00:00
drh
efce69de37
Do a more thorough job of cleaning erasing traces of the strength-reduced
...
LEFT JOIN.
FossilOrigin-Name: 08833dda3a25965cc509d0244d7cd68bdb2306351ca52862f347e1efe5db4508
2018-03-20 22:52:27 +00:00
drh
2589787c5a
If terms of the WHERE clause require that the right table in a LEFT JOIN
...
not be a null row, then simplify the LEFT JOIN into an ordinary JOIN.
FossilOrigin-Name: 5b7abecc7ab8ccbbb8cb5e0f672e67625c2555ad03442efbf34cb395f5bb71a8
2018-03-20 21:16:15 +00:00
drh
cd0abc24d1
Improvements to the HAVING-to-WHERE optimization. The code uses less space
...
and less CPU, and there is now ".selecttrace" output.
FossilOrigin-Name: 5ad668d4339397fe66fe085e0527e37a1930917da88d462a8d89a465faa15e28
2018-03-20 18:08:33 +00:00
drh
9579947c55
Remove a debugging statement accidently left in
...
check-in [eddc35f3057e59fd]
FossilOrigin-Name: 85a31557ac0d0401c1bf2e23a502dc2ea57d9b1bc23c01de693f5d3fe22d8341
2018-03-20 13:00:33 +00:00
drh
2d277bb5cb
Add the ability to disable the push-down optimization using the 0x1000 bit of
...
SQLITE_TESTCTRL_OPTIMIZATIONS.
FossilOrigin-Name: eddc35f3057e59fdc25a6911abfaa53a10cc43d8030925b65737b2f51f907421
2018-03-20 11:24:30 +00:00
drh
cfd74700da
Minor improvements to ".selecttrace". No changes to non-debug code.
...
FossilOrigin-Name: 03e541f606ead1a13e1084db88e168278c82a2ba72b18c89baafeab3141367b4
2018-03-19 22:28:34 +00:00
drh
926961dc53
Improved ".selecttrace" output formatting. No changes in non-debug code.
...
FossilOrigin-Name: 30704d2a52d37717d8b34a402c99ea32453e5c1a9840037dba96591f4acc1503
2018-03-19 16:06:11 +00:00
drh
9f8952390a
When unpacking a sorter record, do so from right to left instead of left to
...
right, since by starting with the right-most column, the work done by
OP_Column opcodes is reduced.
FossilOrigin-Name: 8055e4f42446ceb5bcf752bbf41a73289c3ca759c56c9f779edc3d7f202b7881
2018-01-24 20:42:42 +00:00
drh
b058d05452
Avoid excess stack usage when a VALUES clause with lots of rows occurs
...
within a scalar expression. This fixes a problem discovered by OSSFuzz.
FossilOrigin-Name: a4fa0581ba7cfd45fabe0198f55b3c2c8ee3ecfd2825aeed91116f44e77d760b
2018-01-14 20:12:23 +00:00
drh
755b0fd358
Move the generation of output column names earlier in the case of a
...
CREATE TABLE AS. This is a fix for ticket [3b4450072511e62] and a
continuation of check-in [ade7ddf1998190b2b63] that fixes cases of
ticket [de3403bf5ae5f72ed6] that were missed previously.
FossilOrigin-Name: 6b2ff26c25bb9da344add79c93fb3e49fa034a89b38ef56e08e18d21de61f707
2017-12-23 12:33:40 +00:00
drh
07859486c6
Add a SELECTTRACE() macro to indicate when column names are assigned to
...
a SELECT statement. This helps with debugging for tickets like
[de3403bf5ae5f72e] and [3b4450072511e621].
FossilOrigin-Name: 8f194008c3aaa4ef287200e37bc5278ba9c377a7091ee3f95bad66513226b083
2017-12-23 11:51:40 +00:00
drh
8c0833fb21
In the parse tree, combine LIMIT and OFFSET into a single expression rooted
...
on a TK_LIMIT node, for a small code size reduction and performance increase,
and a reduction in code complexity.
FossilOrigin-Name: 3925facd942c9df663f9b29b1e6f94f6be14af8c2b99eb691bfc836b4c220826
2017-11-14 23:48:23 +00:00
drh
9d9c41e25e
Remove unnecessary NEVER() and ALWAYS() conditionals.
...
FossilOrigin-Name: 1c80c75d4be2f3d44fb18bb4c07eccac2aba79b688215a741317dfc47dc7c2ce
2017-10-31 03:40:15 +00:00
drh
fca23557fe
Reactivate query flattening when the result set of the outer query has
...
no function calls or subqueries. This is a partial reversal of
check-in [c9104b59]. Co-routines are still preferred if the outer
query has a complex result set, but for simple results sets, query flattening
is used. Check-in [4464f40ccd7] is completely backed
out due to this change.
FossilOrigin-Name: d17ef7d153058f7332b3fec421ade42c67e26b06f36fc1629e6799537a5afc5f
2017-10-28 20:51:54 +00:00
drh
47d9f83982
Enhance the min/max optimization so that it works with indexes on
...
expressions.
FossilOrigin-Name: 6caec9082b3ad6d3f89f6291084a8f5c80f296630e2e94bc764389ac1a47a833
2017-10-26 20:04:28 +00:00
drh
7ea11066b6
Extra ".selecttrace" output following aggregate analysis. No changes to
...
production builds.
FossilOrigin-Name: 6fbf74ab3189b9cb20cf7cc8db0226eb935a8eab477cc83b8390492fcf2f1f76
2017-10-26 18:43:19 +00:00
drh
6fe3733ba9
Catch and avoid a 16-bit integer overflow on the number of columns in a
...
common table expression. This fixes a problem found by OSS-Fuzz. The
test case is in TH3.
FossilOrigin-Name: 6ee8cb6ae5fd076ec226bb184b5690ba29f9df8cfaef47aaf13336873b4c1f6c
2017-10-21 14:17:31 +00:00
drh
316ab93e2c
Remove unnecessary "#if SQLITE_MAX_COLUMN". SQLITE_MAX_COLUMN is always
...
defined.
FossilOrigin-Name: 6ec82acde81a46a75ed5931fc7dd813f2523753106ad7b8f0b544b9da9824d5a
2017-10-21 13:29:26 +00:00
drh
7c58fea39f
Turn restriction 20 on the query flattener into an assert since the situation
...
restricted can no longer occur because of the more aggressive use of
co-routines.
FossilOrigin-Name: 4464f40ccd7c5553f4d44120ca6dac4e9445f08f083f7dcb3bd66b4413d818e0
2017-10-04 12:06:31 +00:00
drh
cdb2f60743
Remove a redundant restriction from the query flattener.
...
FossilOrigin-Name: 66629b2a0997ceedcfb38553f2200466b6c4e352ea00f8a0a7cb67a660c19523
2017-10-04 05:59:54 +00:00
drh
e76acc654f
Fix a minor typo in the query flattener header comment. No code changes.
...
FossilOrigin-Name: d050dc605c24bcf60c0c47d13612ad53b871d3d4eff681c0c1b933acf53fb5ee
2017-10-04 02:30:45 +00:00
drh
0c4db03481
Simplify the computation of types on columns of a view.
...
FossilOrigin-Name: 772b0db1469c9e1c2728cf65dd070e29c624e75c3a5da72ee1297f15d758dd13
2017-10-03 19:53:12 +00:00
drh
8906a4b802
Add some OK_IF_ALWAYS_TRUE() marks on optimization branches in select.c.
...
FossilOrigin-Name: 1dd828088d6981dfebf9f4d650dad8431bece4405650c61f90eb8d8f43289b52
2017-10-03 17:29:40 +00:00
drh
ce2c482e5a
Remove an unused variable from sqlite3Insert() and fix harmless
...
compiler warnings associated with -DSQLITE_MUTATION_TEST.
FossilOrigin-Name: 7be760e907274131bcd4acfaff9e72c9c59a05e7d411db3d9afe690fe0d64b4b
2017-10-03 17:17:34 +00:00
drh
a78d757c36
Fix the sqlite3_column_decltype() interface to return the correct datatype
...
when the value comes through a CTE.
FossilOrigin-Name: 966438bd259ade3a2d4a6ec9587ce79c81a21b942248bffb389995b9132b53e3
2017-10-03 16:57:33 +00:00
drh
e2463398fd
The simplification to sqlite3SelectExpand() in last night's
...
[3a4ffb21] check-in was not completely correct. This adjustment is needed
for correct OOM handling in some configurations.
FossilOrigin-Name: c5ad5e1675f6cb5a54df21606dfec2198a7cf88acc529460ebe27bdab128a6e5
2017-10-03 14:24:24 +00:00
drh
cafc2f7b3e
Do not compute column and row size estimates for the transient Table objects
...
associated with the result set of a SELECT statement, since those estimates
are never used for anything constructive.
FossilOrigin-Name: e4342fd401d4025eecc53ebfcd59f3150166a5f0bd6adb1b5820703bd4a1ec58
2017-10-03 03:01:09 +00:00
drh
878fcf9d4e
Mark a single branch within sqlite3SelectExpand() as an optimization.
...
FossilOrigin-Name: 3a4ffb21d0ee2326c31b9ddc512d79d4ebf3a249a2840e88e99165978eec31fd
2017-10-02 23:50:08 +00:00
drh
b7651e6b60
Simplification to sqlite3SelectPrep() for improved testability.
...
FossilOrigin-Name: 5bf2ccb908dc6ebf7e063014b0a4bed7e3e9e0a555f78c6b4f6647adfb7209e4
2017-10-02 23:30:45 +00:00
drh
2f65b2f512
Add the OK_IF_ALWAYS_TRUE() and OK_IF_ALWAYS_FALSE() macros for marking
...
conditionals that improve performance but do not change the outcome.
FossilOrigin-Name: 6035c9b2728f47d338696978eb6fe5a7d6cb84bbea0792ef985c0986ac8f39dd
2017-10-02 21:29:51 +00:00
drh
67cc51a491
More details in the header comment of pushDownWhereTerms(). No changes to
...
code.
FossilOrigin-Name: 928486231ff7cc0df17a5aa23a080a1b8720e168db5227a7dbd34861283ba689
2017-09-30 11:47:06 +00:00
drh
508e2d00f3
Fix unreachable conditionals and revise a testcase that was made obsolete by
...
the changes on this branch.
FossilOrigin-Name: 71f0adf7ca6824c3aba69104b9976dbb71b377474529e1a36220b4804293501e
2017-09-30 01:25:04 +00:00
drh
25c221eb1d
Always render a subquery that is not part of a join as a co-routine.
...
FossilOrigin-Name: 6b1651d711eae6e7c65a191f02ca2439160bcd677099712289e76a0f8422fd37
2017-09-29 22:13:24 +00:00
drh
fd06385f21
Merge the query flattener comment improvements from trunk.
...
FossilOrigin-Name: f62cd4d940506c39db82e83ff3df8ab1856f1fb91ffda835ae2d727263ee9b0b
2017-09-29 16:08:46 +00:00
drh
d981e8289a
Clean up the comments on the query flattener to more clearly and accurately
...
express the conditions under which the flattener is able to run.
FossilOrigin-Name: 0840f9f824c16212ce3fd6c859e501176eb0a58924ea1728a54d5bdfd0c25c86
2017-09-29 16:07:56 +00:00
drh
129c398d4b
Merge changes from trunk.
...
FossilOrigin-Name: 06f432fb7c979f1bb7f01f5c90716ce5c0248f73f70b78a9870b9de5c9bf7ef4
2017-09-29 14:31:16 +00:00
drh
824d21aff3
Make sure the 6th parameter to the authorizer callback for view subqueries
...
has the correct view name.
FossilOrigin-Name: 2a45bbc9fd1c64f1c4c4dac38f063cd67480fcb6da24bf93fdefbfca66fd81ab
2017-09-29 12:44:52 +00:00
drh
23768298d2
Better names for subqueries in EXPLAIN comments.
...
FossilOrigin-Name: 04ef40a8fea88776e0d8b73d942922d45d0c038fbfac1a9a82b9322181b4ad92
2017-09-29 12:12:52 +00:00
drh
648fe49f96
Do not flatten subqueries that contain an ORDER BY or GROUP BY clause and
...
can be implemented using a co-routine.
FossilOrigin-Name: 042d655dd9002e8b89a798ad955b0285891aecf79f6978c5312e70ffe0609a46
2017-09-28 20:06:53 +00:00
drh
2e9d706252
Remove the (undocumented) query-planner control that prevents
...
a "SELECT ALL" subquery in FROM clause from being implemented as a co-routine.
FossilOrigin-Name: ff2f5a31a2ac67a2fdbb25793e8013cb0e062ab90bdcba2d52a62d6d4d8b6d18
2017-09-28 17:29:24 +00:00
drh
3d240d2119
Fix over-length source code lines in select.c. No logic changes.
...
FossilOrigin-Name: fd3267ef92384fcefaee7460a5ffbaf8ddcb6049eec36f72a7046a43e2871fbf
2017-09-28 16:56:55 +00:00
drh
70efa84da7
Add new routines to simplify dealing with collating sequences in expressions:
...
sqlite3ExprNNCollSeq() and sqlite3ExprCollSeqMatch().
FossilOrigin-Name: 490e488ea963fe725b16212822c8608f2b6abce688931b611446bc2cbfe6b87c
2017-09-28 01:58:23 +00:00
drh
63347e7df8
Minor simplification of error message generation during compound query
...
code generation.
FossilOrigin-Name: a944719314e0ac2f1954b65668815769eba3ab3e39a74666293b8dea52a184b2
2017-09-18 13:16:10 +00:00