database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-11-11 01:42:22 +03:00
Code Activity
27,211 Commits 1,607 Branches 185 Tags
8dd4697e48c04a405c9c8da4a68b948e45b1f159
Commit Graph

379 Commits

Author SHA1 Message Date
drh
36a9f5c24c Fix a possible UAF in SEH if an exception occurs at an inopportune moment 
during WAL processing.

FossilOrigin-Name: 91b91037e348fa10cf6a9d8a0ffbfdebb4a40e0e336b65b112ed1c828e75cda7
 2023-08-17 14:19:44 +00:00
dan
9541fbc283 Fix a problem in sqlite3_snapshot_recover() introduced by the [8a6b0c24937e855b] merge. 
FossilOrigin-Name: c2577eb0a4a627c65d675f1446514843486092be9cb271b682793a0107e496cd
 2023-08-14 18:21:56 +00:00
dan
5e22dfb6a5 Add a comment describing the contents of the ExceptionInformation[] array for win32 EXCEPTION_IN_PAGE_ERROR exceptions. No changes to code. 
FossilOrigin-Name: 8e20354242d5f34a90b6c00d9034535ef6f6086ee4971230c7fd69985e2777d2
 2023-07-26 18:34:34 +00:00
drh
5202b7ca75 Update the latest trunk enhancements into the wal-shm-exceptions branch. 
FossilOrigin-Name: 3187ee3f69fc28a259ba0e951ac10a65c07ef2c3866acbefaf9544333a930cc6
 2023-07-24 12:59:53 +00:00
drh
8a1104940d Reduce divergence between branches: trunk and wal-shm-exceptions. 
FossilOrigin-Name: d38ed6b1fc6b572997d520c36f256c11404fb1bd5f28acab07466bfc96554a8f
 2023-07-11 19:54:17 +00:00
drh
66422b57f9 Get fault injection for testing working correctly. Other code clean-up. 
FossilOrigin-Name: ff492277ed00c1f637a5b4ccd6d8193ea22f6781f90073861588a2b7d5c045b7
 2023-07-11 15:52:52 +00:00
drh
5d3cc0c09b Fix a warning. Unclear yet if the code is correct this way or not. 
FossilOrigin-Name: 2df4fd76ef48bb63389df8d783059af6b8f2cbb2c11d07953b408e71f50b625b
 2023-07-10 18:16:49 +00:00
drh
cc9380f68d Merge the latest trunk enhancements into the wal-shm-exceptions branch. 
FossilOrigin-Name: f655d08d019bab0c578886e91ca24fd956d1b3dea9b9c9104812b3cf62e5e556
 2023-07-10 18:05:23 +00:00
drh
ff96718b52 Merge all recent trunk enhancements into the wal-shm-exceptions branch. 
FossilOrigin-Name: e59cea2d851be68559e7d01a01cb05684c44d151d022ea9790ce99671016ab00
 2023-07-06 17:55:33 +00:00
larrybr
55be21647e Fix straggler misspellings and tidy the custom dictionary. Also include pickups from [forum:/info/c61fb09afd|forum post c61fb09afd]. 
FossilOrigin-Name: 8c291d99946eb32b20b743921202f9c7cfb716268ff526817b27adbb7942e40b
 2023-06-07 17:03:22 +00:00
larrybr
bc91738e66 Add a C-source spell-checking facility. make misspell (on Nix) 
FossilOrigin-Name: 26c1bb4bd9e9f56613c3aa87407a7f562fd4ebde5bfd6dece02078001d9a45f8
 2023-06-07 08:40:31 +00:00
drh
dda2833a4e Add a comment to the [0512f82a2cde7447] change to link it to its TH3 test case. 
FossilOrigin-Name: 1281d4d9d799ef83e6eb51d656ede82b4503d39adf169deb936b30ebfddd88b1
 2023-05-03 13:33:37 +00:00
drh
ce2aa8bebe If the page size is wrong on the page1 content inside a WAL file, then 
running VACUUM could trigger an assert().  This check-in changes that assert()
into a branch that returns SQLITE_CORRUPT.
[forum:/info/4ef9b37d74d2d2e8|Forum post 4ef9b37d74d2d2e8]

FossilOrigin-Name: 0512f82a2cde7447cb348d9fd620f39f2f0e359141903cde20f7ba30b5d34af3
 2023-05-03 06:48:08 +00:00
drh
3f4a319934 Unwrap the loop in the WAL hash function. 
FossilOrigin-Name: eb94ae13206762a42ddad12e0d1461df83e9759e44a369f188cd3aad82f211c4
 2023-04-12 20:23:03 +00:00
drh
fc7f8f81da Back out the optimization at [1a8c2e54375ee2cf7] because there are some 
cases where it does not work.

FossilOrigin-Name: fe39c8d5fd813308fb27a05ce257ff003d3c09c0372f500e8def5a528a2558b7
 2022-07-11 18:11:51 +00:00
drh
3325a5c497 Size reduction and performance optimization in sqlite3WalFindFrame(). 
FossilOrigin-Name: 1a8c2e54375ee2cf73773b798fed0ae07b42f5e068fddc513c093de5c1f46615
 2022-07-04 15:14:25 +00:00
drh
f208abdd99 A better and more robust fix for the problem of reading a read-only WAL 
mode database with existing -wal and -shm files, replacing [f426874e005e3c23].

FossilOrigin-Name: 71bfd0b57ab197405606b8096b8521d784ff174c4eecf1d9804d38342c03cc80
 2022-01-20 14:40:34 +00:00
drh
d6b44ec32a Fix the ability to read read-only WAL-mode database when -shm is present, 
([00ec95fcd02bb415|check-in 00ec95fcd02bb415]) so that it works
for the case of 64K page size.

FossilOrigin-Name: f426874e005e3c23e8a00083b7c201408e072bca413e52bfc436da6483afb0cd
 2022-01-20 02:04:53 +00:00
drh
e574a9233c Fixes to internal comments. No changes to code or documentation. 
FossilOrigin-Name: 1489b196ce82cddf7360aff6c89219ca25e666187f0f5ff6419ba3b504cdef8d
 2021-11-26 15:08:55 +00:00
drh
eaad533e54 Ensure that all possible outcomes for walIndexPage() are accounted for by 
callers.

FossilOrigin-Name: 12715c6b234a04627ca27e94bfa8bd456998360a9f0117480e0038f4747818d6
 2021-10-27 23:55:30 +00:00
drh
71c3ea7523 Avoid the 1-based indexing on the WalHashLoc.aPgno[] array. Make it 0-indexed 
instead.

FossilOrigin-Name: 28f5f709b4b28ba7f6f56bdd4a9e8c04d0d2df90d13d6df1a589fa4a65163f4d
 2021-10-27 20:23:59 +00:00
drh
5f25627a1c Improve the comment on walIndexPage() to more accurately describe the 
post-conditions.

FossilOrigin-Name: b619e936455f4001b543a9a58dea2ac9ebd598327d6be01130ca6e7e9764ffe6
 2021-10-27 19:57:59 +00:00
dan
9023444fea If an EXCEPTION_IN_PAGE_ERROR exception is caught, make the underlying OS error code available via sqlite3_system_errno(). 
FossilOrigin-Name: fdb20e9ee48465b94aa6ac3c5e263ecaa7c3b10f4a193e79f965b7c35944b08b
 2021-09-10 21:28:56 +00:00
dan
ee7c667a36 Change the structuree exception handler in wal.c to catch EXCEPTION_IN_PAGE_ERROR instead of EXCEPTION_ACCESS_VIOLATION. 
FossilOrigin-Name: 0c6ab539cfbc908550fa993a587e85d644b6335853ff9781caae860c461c045d
 2021-08-26 21:12:07 +00:00
drh
67ae593ffe Use VVA_ONLY() instead of TESTONLY() in SEH macros so that the build 
works for coverage testing.

FossilOrigin-Name: 9e9d5b566da72adf780685ea27da7d76a7274e904a533438255af92875c94503
 2021-08-20 18:18:12 +00:00
dan
5b6c3c8f7d Add missing SEH_INJECT_FAULT macros. 
FossilOrigin-Name: 27e9bdb3a90a5826f45d32e0378e9afa90a16ac762a75236f38218f41bc45ded
 2021-08-20 17:23:19 +00:00
dan
c6effdbfba Add some assert() statements and fix small issues with code on this branch. 
FossilOrigin-Name: bd9b373b177a71f5eaeb7ce8dd1dc755b34951ee1376c24652418bb329bfcb45
 2021-08-20 16:19:19 +00:00
dan
b15c63cbb9 Fix a problem on this branch causing checkpoints that do not proceed because they can't get the CHECKPOINT lock to return incorrect output values. 
FossilOrigin-Name: 5a98820c3d20766813bb4b0da23247ac90f380c07827ff13b61d5b606d8311aa
 2021-08-20 11:50:12 +00:00
drh
aecd7f9d75 Enable this branch to run both with and without the -DSQLITE_USE_SEH option. 
FossilOrigin-Name: 840e0a14ebc4a85d4ede0223287d4c1e4465e9f20c3c43bfc74775dddec1fa8f
 2021-08-19 23:10:57 +00:00
dan
8aa22ffe98 If SQLITE_USE_SEH is defined, handle structured-exceptions thrown by MSVC builds if the *-shm file mapping is accessed after it becomes invalid for some reason. 
FossilOrigin-Name: 5c5fa47076c5da25ca92248df3a4c11b90a0225a07f05d7220fa95d9bbb36f43
 2021-08-19 21:01:15 +00:00
drh
f873392dde Enhance the wal.c source file with an ASCII-art schematic of the -shm file 
header.

FossilOrigin-Name: a6c160e08a61d105f8aab959440ac5ec4f1aaca8f0d393e08e7c2c67815b5bb2
 2021-07-29 18:34:35 +00:00
drh
944d85dfe2 Fix an error in one of the assert() statements added by [23b08fe9db24a953]. 
FossilOrigin-Name: ad24334bc06dc9ae52825a1873a1eab6c258d77fcc00dec55884ddddecd9932e
 2021-07-29 17:01:44 +00:00
drh
fd4c7862ee Improve comments and add new assert() statements in WAL to help document 
how everything works.

FossilOrigin-Name: 23b08fe9db24a953cc231b093cf74d140c9965d22964d0401ff8ab3d4ecba443
 2021-07-29 16:48:21 +00:00
drh
0449f6561f Fix a harmless "unused variable" warning when compiling with 
-DSQLITE_COVERAGE_TEST.

FossilOrigin-Name: 0bef3fb11fb95d7ede82b59aea26e99e2e23b3bce48009181e691ea17ae78a61
 2021-04-30 12:30:35 +00:00
dan
91faeec8d0 Modify a test for corruption within the wal checkpoint code to account for the pending-byte page. And for the fact that test configurations might move the pending-byte page. 
FossilOrigin-Name: 7dfb74c37e678dde347d9d85846672f82ad282e300e32676330b764be2e4d580
 2020-08-11 18:00:10 +00:00
drh
799443b14f Do the oversize-WAL corruption test before the size hint is issued. 
FossilOrigin-Name: fdc5fb902d7f2d10f73e64fe30c67153b59b26c5d707fc9c354e90967dbcc214
 2020-08-07 19:52:01 +00:00
dan
88819d5870 Return an SQLITE_CORRUPT error if the final expected size of the database when checkpointing is not reasonable - where reasonable is defined (basically) as the sum of the sizes of the database and wal files. 
FossilOrigin-Name: e2799563c8a97f617c6d932719b312e3d5bff051a9a397492df8d88e8bb4260a
 2020-08-07 16:28:02 +00:00
drh
e592c18c1c Provide an alternative "guaranteed-safe" method for overwriting the WAL index 
on recovery, in case some platform is found for which memcpy() cannot do this
safely.

FossilOrigin-Name: 168cccbabbd4807bdb04953f395cd1a245c46e9d4816a09c9d024ecd5432759d
 2020-07-30 22:33:36 +00:00
drh
8deae5ade3 Fix signed/unsigned compiler warnings. 
FossilOrigin-Name: 1d69eee8b085d514f442840346f001b4785f8ec64f5ba66943e9577b26e2e29c
 2020-07-29 12:23:20 +00:00
drh
e7f3edcd49 Add an sqlite3FaultSim() to make an OOM case more accessible and remove 
the ALWAYS() on the conditional that is false when the OOM actually occurs.

FossilOrigin-Name: 2a251af84ff1f5ca281aa69c5410d6ae7aa5a85ef47149909a297525e1651e9d
 2020-07-28 17:17:36 +00:00
drh
f31230af12 On recovery, always overwrite the old with the new, even if they are the same. 
Add ALWAYS() macros on branches currently thought to be unreachable, pending
additional testing.

FossilOrigin-Name: 7052cf1d533f6404d0f45cf0b3e8a11c1ee27eccb64680a7fd308c8da7cbd544
 2020-07-27 20:16:37 +00:00
drh
8caebb26c5 Improved error reporting if walLockExclusive() fails. 
FossilOrigin-Name: cf962d213abe1b55ebbcfecf1de9d5d61709509d1ce3cbd56d8cf4c9ad65e5a9
 2020-07-27 15:01:10 +00:00
dan
d3e38b7c0e Allow a wal mode recovery to proceed even if there are readers. 
FossilOrigin-Name: 74374aebf9abf3d6b6a3920967a079ceaa4c6276dc6c177682742c2be405b7b7
 2020-07-25 20:16:27 +00:00
dan
ec206a7d34 Use AtomicStore() to set values in the wal-index hash table. 
FossilOrigin-Name: 1ab30c75f2fe14d1ee77d0eace4e29ba8f805d63e2da0897b111ea1311f409aa
 2020-06-04 16:07:51 +00:00
drh
91960aa53f Make sure variable declarations are at start of scope even when 
SQLITE_ENABLE_SNAPSHOT is used.

FossilOrigin-Name: a77ceaf6ba934b1d73c90b8980191a65d02ad6ce1e11e6baf573b3a132685545
 2020-05-25 12:02:12 +00:00
drh
5a8cd2e40c Add compiler hints to disable TSAN for the routines that access the -shm 
file header in WAL mode using a double-read with memory barrier.

FossilOrigin-Name: 3117c1b5a9e348fd8d16ba9d03fdafaad8514567fb3403f72b86d6162ad40bde
 2020-05-19 15:51:10 +00:00
drh
f16cf653f4 In wal.c, improved comments on concurrency issues. More use of 
AtomicLoad() and AtomicStore().

FossilOrigin-Name: 4bf566feca3a8fbe5e386533aac30e0ac25836cfc820a3abd91e156bd6198b4a
 2020-05-19 12:27:29 +00:00
drh
d924e7bc78 Use the sqlite3Realloc() interface internally, rather than the public 
sqlite3_realloc64() equivalent, to avoid unnecessary calls to
sqlite3_initialize().

FossilOrigin-Name: 1313557b512297e7b75ed748894379b2022aecf696d5a58318e46a668321c1ff
 2020-05-17 00:26:44 +00:00
dan
8b4f231c47 Use AtomicStore() and AtomicLoad() in a few more places to avoid a theoretically undefined behaviour. This is not actually problem on any known hardware. 
FossilOrigin-Name: fda57d4d2f1499c861d43026aa9362d1a30d67c9c002ebf5b0cdc25251537fbb
 2020-05-13 13:33:30 +00:00
dan
bc9fc18e45 Fix an assert() failure that could follow an IO error. 
FossilOrigin-Name: e89c864299024cdce395a15c19b000b976142b9eed267901a288adaa695f9e65
 2020-05-06 21:24:29 +00:00