database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-11-12 13:01:09 +03:00
Code Activity
22,976 Commits 1,607 Branches 185 Tags
26d61e5adfbc9e1a3955d1fb04a5f5f06ebfdb13
Commit Graph

1213 Commits

Author SHA1 Message Date
dan
26d61e5adf Fix problems with ALTER TABLE and schemas that contain views with some recursive CTEs, or CTEs that reference other CTEs. 
FossilOrigin-Name: 8b1f9a51e962cd9a5593a1ecf4da6c86e34c4f9ff96ffcea0fb421880c8836cb
 2021-06-11 11:14:24 +00:00
drh
abc15f1b9a Fix harmless compiler warnings. 
FossilOrigin-Name: 83aca2d8704e51eeed5652b1506c6fc883c0397728cda456f229369788b8608a
 2021-06-04 16:11:19 +00:00
dan
19e4eefbca Fix a case where combining row-value UPDATE FROM syntax with window functions over aggregates can cause an error. 
FossilOrigin-Name: 4a587c3492faa99490fd67ca1de9fceafcdc12d220f42817791923be258b73f1
 2021-06-03 18:56:42 +00:00
drh
14c4d42874 Take care that the code is not generated for the same Select object more 
than once, as transformations that apply during the first pass might
cause problems for the second pass.
dbsqlfuzz 836b625cd8a41809ef80fc7ebaa6554357bcb463.

FossilOrigin-Name: f30fb19ff763a7cbe768ea49954704e14d6400f69bb4257c9c890e1564e14835
 2021-05-26 18:46:51 +00:00
drh
bf7f3a005e Fix the TreeView module so that it works with the TK_ERROR exprssion. 
Also fix an assert() that was failing due to the recent TK_ERROR addition.

FossilOrigin-Name: dd56fbe0cfb0f7848190ce097b378321dd25ae509c7edf93682b091014824fc6
 2021-05-24 11:35:16 +00:00
drh
0542812726 Additional defenses (above and beyond [b986600520696b0c]) to prevent an 
invalid subquery from causing problems downstream.  If an error is found
while analyzing a subquery expression, change the expression to TK_ERROR
so inhibit further processing on that expression.
dbsqlfuzz cf624b8c0484c66e0f552bf6475e3e3f2c22b24e.

FossilOrigin-Name: 0be6b6c9f7c562e764792a4a5eb53ed11b230174b19361f7cd7778c743314bbd
 2021-05-24 00:17:04 +00:00
drh
ec2f689b21 Fix a faulty assert() statement in sqlite3ExprListDup(). This is a continuation 
of the fix at [59812e7ef705226c].

FossilOrigin-Name: 240f7494bfa3e0806ae2f971e78039c62a419de647cb9e807309f90e1d2a536d
 2021-05-20 23:25:28 +00:00
drh
433a3e935d Back out the EXISTS-to-IN optimization. It slows things down rather than 
speeds them up depending on the query.  And (see
[forum:/forumpost/8692d94725|forum post 8692d94725]) it sometimes results in
an incorrect answer.  We may come back and revisit this optimization later,
but for now it seems best just to disable it.

FossilOrigin-Name: 16252d73fa73569fd7506676f6ffbbcd43addfb105384fb74449d30ca720904a
 2021-05-04 12:07:16 +00:00
drh
feef447271 Add ALWAYS() to branches that are no longer reachable due to recent 
enhancements.

FossilOrigin-Name: 63c50fbdeed831ba450d1dce67e968a7daa2b69ac1270eb271fb1e1873d4a07e
 2021-04-26 21:00:51 +00:00
drh
3c6edc8a11 More aggressive detection of OOM errors in resolveAlias(). 
dbsqlfuzz 7f96832c2ef7ee472022ed805b064e55e41094b2

FossilOrigin-Name: e99faf4f82746761c389e24db1b00ee94b9f849e7bcb29517fa0ca10290afc41
 2021-04-26 15:28:06 +00:00
drh
7a04e296f3 Improved OOM detection in sqlite3ExprCheckIN(). 
dbsqlfuzz 46ae2d8f473ac672f3042cc14ab67aeab9ffa6c2

FossilOrigin-Name: fac12115a994a1b4347586e68faf38895ee9cb588eaa84c6f71cf9afd4c488b4
 2021-04-23 00:59:38 +00:00
drh
9da977f1a5 In the sqlite3SelectDup() routine, do not do an incomplete duplication due 
to OOM.  This in turn requires several new NEVER() and ALWAYS() macros for
unreachable branches.

FossilOrigin-Name: a61c0e6b78bd39f55464fafd257e68effded64995a66e8fa2d686e8c507ebe43
 2021-04-20 12:14:12 +00:00
drh
de0e1b150c Performance optimizations in the code generator, especially in name 
resolution.

FossilOrigin-Name: ab83a99899ceae931b43e0c4b3f8f8b83bc832f1568de5692c0d038c968f8a87
 2021-04-16 22:53:57 +00:00
drh
197561cd42 Remove an ALWAYS() from a branch in sqlite3ExprAddCollateToken() which can 
be false following an OOM.
dbsqlfuzz 9e8516bf1e786c84e520ae43141b75b7399f8618.

FossilOrigin-Name: 6af4e6d054efd8445e1010aabd584f36e70dfad0de13bd0e2f1761cad4d9a7d6
 2021-04-16 12:33:52 +00:00
drh
f817189e1b Fix an assert() in the code generator for expressions so that it is valid 
even after an OOM.

FossilOrigin-Name: 427e83eb583a4f63650912f078122e7373fe8c7ea11acfdab464d748b4235261
 2021-04-14 11:20:44 +00:00
drh
5cc9daf8a2 Fix a faulty assert() inside sqlite3ExprDup(). 
FossilOrigin-Name: 59812e7ef705226c801f95ec7f78cc931f9957ffb66715607d63874813b280cb
 2021-04-12 23:18:18 +00:00
drh
4c4a25727f Earlier detection and handling of OOM problems. 
dbsqlfuzz 39f2963ea5559aa3a16e24e0e3cb42aac85a7371.

FossilOrigin-Name: 8d46df73132e46abb32b9dc129b6beb978d34dac3d372fb004ca283b0832d04c
 2021-04-06 12:50:24 +00:00
larrybr
dabada6020 Make shell .parameter feature type-agnostic. Hush harmless compiler warning. 
FossilOrigin-Name: 35cf295e026d067c9f059fde6b150e65163fe171d37501eb1e5742e691793340
 2021-04-04 12:52:58 +00:00
drh
b3ad4e6118 Defer deletion of expressions that are optimized out by the AND optimizer 
in the sqlite3ExprAnd() routine until the corresponding Parse object is
deleted.  This avoids a dangling pointer in AggInfo if sqlite3ExprAnd()
is invoked by the push-down optimization.  The dangling pointer appears
to be harmless in release builds, only showing up in debug builds.
Problem found by dbsqlfuzz.

FossilOrigin-Name: c36b43589abd9f62a709bdb47b8748e0c1e8743487a3d83d1eb35eb06b65d763
 2021-03-31 13:31:33 +00:00
drh
529df929de Fix VDBE coverage macros. 
FossilOrigin-Name: ebe100de55ccdf6abccde5d8e6e96099b6e8dc3527f1441265e2b86b6661a66b
 2021-03-29 19:47:39 +00:00
drh
4bc20452b5 Omit the SQLITE_STOREP2 and SQLITE_KEEPNULL options from the comparison 
opcodes, allowing them to run faster.  This required refactoring the
vector comparison logic, which in turn required changing OP_ElseNotEq into
OP_ElseEq.

FossilOrigin-Name: 380b46054b6a9b67e57357815e8e94057253fa3cce838ae76e5d5031c6bd26b2
 2021-03-29 18:53:47 +00:00
drh
871e7ff43d Add the OP_ZeroOrNull opcode and use it to compute boolean values for 
scalar comparisons, rather than the SQLITE_STOREP2 parameter to the comparison
opcode.

FossilOrigin-Name: 93781b6f10a94fb273204b95156a8b90e07071f28c89e7966c659a0f44f60e98
 2021-03-29 14:40:48 +00:00
drh
50e43c5094 Add the ExprList.nAlloc column and use it to make the sqlite3ExprListAppend() 
routine much faster.

FossilOrigin-Name: 1d3c4662c2f522ac695d97441324069f3fc65f3fa0b87194c7094dfb8cd549f2
 2021-03-23 14:27:35 +00:00
drh
340fd0bc23 Dbsqlfuzz found a new way to make that branch in codeVectorCompare 
reachable.

FossilOrigin-Name: 959272c27555e39f180d46257afe45d41da1f5df38ea269196c06741ff6a278e
 2021-03-19 16:29:40 +00:00
drh
66f9655599 Restore the NEVER() that was taken out by [f481636f1a0333c6] because that 
case is no longer reachable after the previous check-in.

FossilOrigin-Name: e3a78b2a237a2e101faf01dde913f63641da8854720a9daa4b45a9c5dfe30b1b
 2021-03-19 14:51:15 +00:00
drh
099b385d17 Do not confuse the constant SQLITE_MAX_ATTACHED with the maximum number of 
schemas.  Add the new SQLITE_MAX_DB constant for the maximum number of
schemas.  [forum:/forumpost/a006d86f72|Forum post a006d86f72].

FossilOrigin-Name: 7b65fb9f7bd616f834633afd64b3448bf9ca2b6e4cc6d6c01e75d1d877c88a79
 2021-03-10 16:35:37 +00:00
drh
a79e2a2d28 Materialize any CTE that is used more than once. 
FossilOrigin-Name: ba59159fbe6b83fb6d79fbfee22d983768b0ebbaac7e99d2ac66c810e5e04100
 2021-02-21 23:44:14 +00:00
drh
7601294ad3 Rename the "struct SrcList_item" object to the more succinct "SrcItem". 
This is a symbolic change only.  The logic is unmodified.

FossilOrigin-Name: bfd5bf2c73110fcb36db9ba2a949ff516131fbd3e89325f88fe9f5c2b4ed87b2
 2021-02-21 21:04:54 +00:00
drh
9ffa258a01 Improved handling of vector equalities in the EXISTS-to-IN translator. 
FossilOrigin-Name: ef49ee4a3766146963bfb6b013472f9836afb9c5b0d21a8533871cf961139e38
 2021-01-16 20:22:11 +00:00
drh
235667a858 Use NEVER and ALWAYS macros to confirm that the return value from 
sqlite3ExprSkipCollateAndLikely() is never NULL in some of its use cases.

FossilOrigin-Name: 76d2eb86e109fc3cbdba2e8175c22ed7660b59bb9315f6c55c565587f33ad43b
 2020-11-08 20:44:30 +00:00
drh
9bb612f2c8 Fix a faulty assert() statement. Add new test cases. 
FossilOrigin-Name: 80ecdb3da4558bb08ee3ec6edbde906ad5b3b8182e672b5ba0d5dfa8041cee0a
 2020-10-02 12:42:51 +00:00
dan
6c3b4b07d1 Fix a crash that could occur in SQLITE_MAX_EXPR_DEPTH=0 builds when processing SQL containing syntax errors. 
FossilOrigin-Name: 5f58dd3a19605b6f49b4364fa29892502eff35f12a7693a8694100e1844711ea
 2020-08-20 16:25:26 +00:00
drh
46fe138d98 Do not skip over TK_IF_NULL_ROW operators when bypassing TK_COLLATE operators. 
Fix to check-in [ac31edd3eeafcef4] which was itself a fix for ticket
[45f4bf4eb4ffd788].

FossilOrigin-Name: 871f2ddcfbb9196dbd851a350e3471ee6d242d86bbd755201f7e2406fce3ac55
 2020-08-19 23:32:06 +00:00
drh
08b9208660 Fix harmless compiler warnings that surface in newer versions of GCC. 
FossilOrigin-Name: 9d670a318381f219b467653f5f9539097808b887ae37291ce13be462dedfb18d
 2020-08-10 14:18:00 +00:00
drh
5b107654e9 Readd the ALWAYS() macro that was removed by [f7a74f89dbd58b47] as the 
condition is no longer reachable due to the previous check-in.

FossilOrigin-Name: 9cb03beae42d814a1b1b69f72865fde502d3f443313ec29edd010d1de40225eb
 2020-07-13 15:35:08 +00:00
drh
6af305de1e Remove unnecessary code from the window functions implementation. 
FossilOrigin-Name: 1e87da9c93309d1d69b1e0ab65c615b9ff9c1c6813ad0c7b90d2495be4ba0adc
 2020-07-10 21:43:53 +00:00
drh
d8d335d737 Fix a possible null pointer deref following OOM. Discovered by dbsqlfuzz. 
FossilOrigin-Name: cc888878ea8d5bc754c69de523819d32d6d9853857e31d7287f9dbfd723428db
 2020-06-26 04:34:28 +00:00
drh
1e32bed3c1 Further refactoring of the schema table name. 
FossilOrigin-Name: 9536fa0ae0c1ae6e2e98d2fa11e5acda7f3c9b8ca5061b6f7f8cae63a11d936b
 2020-06-19 13:33:53 +00:00
drh
74e0d96695 Identifiers "TRUE" and "FALSE" cannot take on their boolean constant values if 
they are operands of the "." operator.

FossilOrigin-Name: ad738286e2441b5e84d05366db3fcafabe66be766f21fe6c17f43a8fabab16fb
 2020-06-13 03:18:21 +00:00
drh
bc050b8f27 Mark an always-true conditional with ALWAYS(). 
FossilOrigin-Name: 35a236841764a10cdcda63f34e1a8e7ffa43933bc89cb32f675454327834d7bf
 2020-06-09 22:11:06 +00:00
dan
ed41a96bc1 Ensure that aggregate functions that (a) are part of SELECT statements with no FROM clause and (b) have one or more scalar sub-selects as arguments are assigned to the correct aggregate context. 
FossilOrigin-Name: 16a41fa8c4c74bba4e908a9c19e6cf5a927cac140e2070c9abf303158be7257b
 2020-06-09 17:45:48 +00:00
drh
81185a5138 Give the expression pointer fields of AggInfo distinctive names in order to 
simplify tracking of all their uses.

FossilOrigin-Name: a53bdd311c4154fd5e1131efbb9665362f79db5a35ce9f7b1547f74b8ee2d8ba
 2020-06-09 13:38:12 +00:00
drh
2f82acc036 Fix minor OOM problems. 
FossilOrigin-Name: 8b23d80271aab38abe42ee8b3ca4b746572ecef26c2a37b094b01560e6be9d45
 2020-06-07 22:44:23 +00:00
drh
bf7909734a AggInfo objects might be referenced even after the sqlite3Select() function 
that created them has exited.  So AggInfo cannot be a stack variable.  And it
must not be freed until the Parse object is destroyed.

FossilOrigin-Name: 3c840b4df306e2db1da08673e9ede973b4cb6d2b3f9eeeab5835e39452ee3056
 2020-06-07 20:18:07 +00:00
drh
896366282d Alternative fix to ticket [c8d3b9f0a750a529]: Prior to deleting or modifying 
an Expr not that is referenced by an AggInfo, modify the AggInfo to get its
own copy of the original Expr.

FossilOrigin-Name: 7682d8a768fbccfe0cc956e9f6481637146e1ab9763b248ff11052761ce32e32
 2020-06-07 17:33:18 +00:00
drh
b639a2094a Small performance improvement and size reduction in the expression 
code generator.

FossilOrigin-Name: eeb53e219551d8a05a87f1de9a7cd9af295d08a296f1f435a8509ea1252ccdcc
 2020-05-27 12:44:28 +00:00
drh
399062cccb Change a datatype from i16 to int to appease Converity and help eliminate 
a false-positive.

FossilOrigin-Name: 5b560ec49041d89c87ea3315d8fc17f7fb0e03a82091934be7373b290183f82e
 2020-05-27 00:02:07 +00:00
drh
bdd4f7d91c Innocuous changes to help Coverity avoid false-positives. 
FossilOrigin-Name: 4ec8a5a203f10d228d0b3389120638766cc343179dbe38d5dbf69b650765934c
 2020-05-26 10:54:46 +00:00
drh
0934d64045 Defensive code that tries to prevent a recurrence of problems like the 
one described in ticket [7a5279a25c57adf1]

FossilOrigin-Name: 572105de1d44bca4f18c99d373458889163611384eebbc9659474874ee1701f4
 2020-05-25 15:19:52 +00:00
drh
e40cc16b47 Move some utility Walker callbacks into the walker.c source file, as they 
seem to belong there better.

FossilOrigin-Name: dac438236f7c5419d4e7e094e8b3f19f83cd3b1a18bc8acb14aee90d4514fa3c
 2020-05-24 03:01:36 +00:00