database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-08-05 15:55:57 +03:00
Code Activity
30,100 Commits 1,570 Branches 183 Tags
optimize-null-values
Commit Graph

52 Commits

Author SHA1 Message Date
drh
1521ca4c20 Refactor the SrcItem object so that information about subqueries is stored 
in a separately allocated Subquery object.  This reduces the memory requirements
for SrcItem and makes the code run faster.  It also provides an expansion path
for subquery processing that does not burden simple queries.  The current
checking mostly works, but there are still issues that need to be tracked
down and fixed.

FossilOrigin-Name: 8ff5dda8448d7e1a533d7f27db2573ce68fa9956b9d9847ced45e83c1f06bab0
 2024-08-19 22:48:30 +00:00
drh
b204b6aa7b Give unique names to fields in the SrcItem object, to facilitate analysis of 
how those fields are used using "grep".

FossilOrigin-Name: 9f5aeef3cbc2c95267c8f7bf60d5c66971a76789669fb0e8f853273ff6f616f2
 2024-08-17 23:23:23 +00:00
drh
f82c8cb0d5 Avoid unnecessary NULL pointer checks on calls to sqlite3WalkExpr(). 
FossilOrigin-Name: 73d86a12fb068456a884c030fddd87020d6ec9d56376de541cf082b2104174d3
 2023-06-19 23:27:22 +00:00
larrybr
bc91738e66 Add a C-source spell-checking facility. make misspell (on Nix) 
FossilOrigin-Name: 26c1bb4bd9e9f56613c3aa87407a7f562fd4ebde5bfd6dece02078001d9a45f8
 2023-06-07 08:40:31 +00:00
drh
a4eeccdfdf Protect all accesses to the Expr.x union using nearby assert()s and branches. 
FossilOrigin-Name: 8eaa1d4a98b24adf245bbd2fe9212aa6a924a0f09c445906d7f87574f36a7423
 2021-10-07 17:43:30 +00:00
dan
be12083bc7 Fix problems with refering to CTEs from within sub-selects in PARTITION BY or ORDER BY clauses of window frame definitions. Also a problem with renaming a column when the schema contains a trigger containing a correlated sub-select within a window frames PARTITION BY or ORDER BY clause. 
FossilOrigin-Name: 4c6cd54a8db78e5535912e76856bed4f797261aaca4248c69d2e2452194de297
 2021-05-17 16:20:41 +00:00
drh
9da977f1a5 In the sqlite3SelectDup() routine, do not do an incomplete duplication due 
to OOM.  This in turn requires several new NEVER() and ALWAYS() macros for
unreachable branches.

FossilOrigin-Name: a61c0e6b78bd39f55464fafd257e68effded64995a66e8fa2d686e8c507ebe43
 2021-04-20 12:14:12 +00:00
drh
5e8e7464d0 An improvement to check-in [1a341378ab24a509] that omits the new 
Walker.bWalkWinDefn boolean (which is not always initialized) and uses
a special value for xSelectCallback2 instead.

FossilOrigin-Name: bef2238de9550de84d4cd1c970a542b43db288d73d09a3c3ced7f98bb3188fd3
 2021-04-19 19:59:16 +00:00
dan
3c6fbd6dd9 Remove a couple of NEVER() macros from the code for walking window lists. 
FossilOrigin-Name: 4ec9ef4bcd12bd9ba5e1a2424f75479070d12c25f1272548c6cf3f89be826b8c
 2021-04-17 20:13:53 +00:00
drh
7b0d34fe32 Ensure that variables are not used in the WINDOW clause of a query inside 
of a trigger.  dbsqlfuzz d9cf66100064952b66951845dfab41de1c124611

FossilOrigin-Name: 1a341378ab24a5091e6cf03b9e957d11b2bfe5c711835e8c583785f8fa0125d3
 2021-04-17 13:46:23 +00:00
drh
7601294ad3 Rename the "struct SrcList_item" object to the more succinct "SrcItem". 
This is a symbolic change only.  The logic is unmodified.

FossilOrigin-Name: bfd5bf2c73110fcb36db9ba2a949ff516131fbd3e89325f88fe9f5c2b4ed87b2
 2021-02-21 21:04:54 +00:00
dan
a3d33ebe4a Fix a problem when flattening joins between a UNION ALL sub-query and another sub-query that uses more than one window function. 
FossilOrigin-Name: ef9733fe1c6b31849a5da1037d21915f82e0e4ab42d1a23ead8a121012f1bace
 2020-12-21 18:39:58 +00:00
drh
e40cc16b47 Move some utility Walker callbacks into the walker.c source file, as they 
seem to belong there better.

FossilOrigin-Name: dac438236f7c5419d4e7e094e8b3f19f83cd3b1a18bc8acb14aee90d4514fa3c
 2020-05-24 03:01:36 +00:00
drh
2aee514b4c Recompute the set of columns used for each table when the table is 
involved in query flattening.

FossilOrigin-Name: a9bb71ba708ba72255ba8d18c9856e38ddf53eae2d61c8435149354fb2b2459e
 2020-03-21 00:05:53 +00:00
drh
ec123e1301 Fix an indentation error and improve the placement of an assert() based 
on a tweet from Yuri Kotov.

FossilOrigin-Name: e6314e386c6877c669bd32788d3886253b0a187bee2c3889f4eaba219f5e52c7
 2019-11-22 11:47:04 +00:00
drh
c5cc870ef8 Refinement to check-in [348e7f193a963390] that avoids unreachable branches. 
FossilOrigin-Name: bbfb2908ecd113c88e69a0984cbe2550463cdd3a67648b0e4e3578e80630136e
 2019-07-19 15:00:32 +00:00
dan
750c6ba5e5 Fix a problem with renaming tables when the schema contains WINDOW definitions with (illegal) non-numeric expressions as part of a PRECEDING or FOLLOWING clause. 
FossilOrigin-Name: 348e7f193a963390a0595183d603541f85c5d1a911c98ed2e06599691ffe98f5
 2019-07-19 11:20:42 +00:00
dan
a1ac03590b Fix a faulty assert() in walker.c that could fail when processing an ALTER TABLE statement on a schema containing invalid table references that are part of a WINDOW definition. 
FossilOrigin-Name: ee076c28d8ee0f5b099cdef83ae6cea6ef5aa209ab528d7c49949dd653ce019c
 2019-07-19 10:31:29 +00:00
dan
4f9adee289 Rework the FILTER clause implementation to share more code with window functions. 
FossilOrigin-Name: 5dac8c38dfc3f41c5c8fb49ca35de7fd1b21f269d72e8ba6ba59ed0a4030a54d
 2019-07-13 16:22:50 +00:00
dan
8117f113bc Minor performance improvement in sqlite3ExprDeleteNN(). 
FossilOrigin-Name: bcc8b38ac75b731a4cd2873ab83f423be036467a511b617c779869de9bbb5383
 2019-07-10 20:16:53 +00:00
dan
6ba7ab0d25 Experimental implementation of FILTER clause for aggregate functions. 
FossilOrigin-Name: 1f1ae2d6ac8dcbb62e5aa3dc17bc67d559cb565fc0d0a8c00a596075d35f8130
 2019-07-02 11:56:47 +00:00
drh
6a02f237e3 Remove an unreachable branch. 
FossilOrigin-Name: 4c976f171342ba2d39779279c28f3bc088572c440922e3e4421a3bf541263360
 2019-01-24 04:44:54 +00:00
dan
d99950310f Fix problems with sub-selects in WINDOW definitions. Also rename-column operations when the column being renamed appears in a WINDOW definition that is part of a VIEW or TRIGGER. 
FossilOrigin-Name: 0387cb3add992b2028efe4f2100188d8f9fdfdcb233329857aa4b46a293cfc97
 2019-01-23 16:59:24 +00:00
drh
eda079cd2c Combine the Expr.pTab and Expr.pWin fields into a union named "y". Add a new 
EP_WinFunc property that is only true if Expr.y.pWin is a valid pointer.
This reduces the size of the Expr object by 8 bytes, reduces the overall
amount of code, and shaves over 1 million cycles off of the speed test.

FossilOrigin-Name: ad130bb86e74e6ce165fdbdce3a19699510f0e62071c1c7923b5a4538d888c7c
 2018-09-20 19:02:15 +00:00
dan
867be212bc Fix another problem that could cause a crash when a window function was used 
in a view.

FossilOrigin-Name: e954145a3addf60247954b9161473cd02ae2400f469840523093e25e23fbc54d
 2018-06-25 11:42:08 +00:00
dan
c316307315 Fix problems with using window-functions in correlated sub-queries. 
FossilOrigin-Name: 3e23cfc8133342a4de6813afdc33d726f06d625424b16d0999fb22be51bf8913
 2018-06-23 19:29:56 +00:00
drh
8c0833fb21 In the parse tree, combine LIMIT and OFFSET into a single expression rooted 
on a TK_LIMIT node, for a small code size reduction and performance increase,
and a reduction in code complexity.

FossilOrigin-Name: 3925facd942c9df663f9b29b1e6f94f6be14af8c2b99eb691bfc836b4c220826
 2017-11-14 23:48:23 +00:00
drh
9d9c41e25e Remove unnecessary NEVER() and ALWAYS() conditionals. 
FossilOrigin-Name: 1c80c75d4be2f3d44fb18bb4c07eccac2aba79b688215a741317dfc47dc7c2ce
 2017-10-31 03:40:15 +00:00
drh
dceed86d07 Small optimization in the Expr tree walker. 
FossilOrigin-Name: 264a5e1b75ee073bd019483e289c3d8d79abcf5a765435be23ac3c21b1db8246
 2017-08-17 19:23:16 +00:00
drh
d10866798d Exploit the fact that Expr.pRight and Expr.x are never used at the same time 
for a small performance gain.

FossilOrigin-Name: aacbb9a461fdb34c7f9c8ce348e44c3e96c93334f210d438d92bfac1794dc686
 2017-07-07 13:59:34 +00:00
drh
c2d14a9a33 More efficient and compact implementation of walkExpr(). 
FossilOrigin-Name: 115d4b83392d346634866dd959bef30fca50db2e526df17eaeb3d94da7fc895e
 2017-07-07 12:58:30 +00:00
drh
3da70a6112 Very slightly smaller and faster sqlite3WalkSelect(). 
FossilOrigin-Name: 9bc65635b29a4991c7821ef0939975d007f9ac23716717699353ef3246e27791
 2017-07-07 11:49:48 +00:00
drh
979dd1be57 Optimizations to the Walker object and its methods to make the code a little 
smaller and to help it run a little faster.

FossilOrigin-Name: 6854a34ed708259f2280f7ee56cec09f7fc99810dc739dc2814ddeae286aa2c4
 2017-05-29 14:26:07 +00:00
drh
567bd44917 Minor comment typo fixes. No changes to code. 
FossilOrigin-Name: 01cd9fb176cde30658233e36aad44e4a5519612e
 2017-03-07 12:18:23 +00:00
drh
209bc522b0 Add the EP_Leaf flag bit to the Expr.flags field to indicate Expr 
nodes that do not have substructure.  Use that bit to avoid unnecessary
recursion.

FossilOrigin-Name: 8a6ea455cd1bf42ae0a7f1f1789baf88d782db13
 2016-09-23 21:36:24 +00:00
drh
d43075bcaf Small performance optimization in the expression walker. 
FossilOrigin-Name: c6e6afb9391704d9119335f2ce17df3968acb514
 2016-09-19 02:19:00 +00:00
drh
922802c44e Performance enhancement in the expression walker. 
FossilOrigin-Name: ebccbd96094ac64de39dbd0d220d3a7afd8cd40e
 2016-08-10 18:56:32 +00:00
drh
50922cfc7c Performance optimization in sqlite3WalkExpr(). 
FossilOrigin-Name: 2f8bd5fab8cc51d1f8932c3490fd24dbccf6ef31
 2016-01-11 14:19:14 +00:00
drh
01d230ce05 A list of arguments following a table name translates into equality 
constraints against hidden columns in that table.

FossilOrigin-Name: 40e12cfe4c29475417ba89fb637b4c763cf74016
 2015-08-19 17:11:37 +00:00
peter.d.reid
60ec914c74 Fix typos in comments. No code changes. 
FossilOrigin-Name: e62aab5e9290503869e1f4d5e0fefd2b4dee0a69
 2014-09-06 16:39:46 +00:00
dan
b290f11775 Fix some problems to do with WITH clauses and name resolution. 
FossilOrigin-Name: 6a549187ed8b5ed50daefa676ff666ae2ed43346
 2014-01-17 14:59:27 +00:00
drh
c5cd124900 Increase the number of bits available in Expr.flags. Other tweaks aimed at 
making expression processing more robust.

FossilOrigin-Name: 579a512538528cf4bb4381ba393c5d9e7310086b
 2013-09-12 16:50:49 +00:00
drh
aa87f9a68b Make sure the affinity and datatype of sub-subqueries are initialized 
prior to subqueries as the latter relies on the former.

FossilOrigin-Name: 39b4e6ff9316cc78ea88349091e195b8104d1e9e
 2013-04-25 00:57:10 +00:00
drh
ed551b95a4 Add test cases and fix bugs associated with the previous check-in 
enhancements to nested aggregate subquery processing.

FossilOrigin-Name: 00b1dc71be4c3420730b5f7840af824ea86165e7
 2012-08-23 19:46:11 +00:00
drh
c81c11f62c Remove the obsolete "$Id:$" RCS identifier strings from the source code. 
FossilOrigin-Name: f6c045f649036958078cb15cd9d5453680c82b0c
 2009-11-10 01:30:52 +00:00
drh
f7828b5cd6 Additional updates to the symbol resolver and expression tree walker to 
facilitate test coverage. (CVS 6764)

FossilOrigin-Name: a49c2d4befcc33dd98543fe7b4d4f0bae56f1a90
 2009-06-15 23:15:59 +00:00
drh
33e619fc1c Additional refinements to Expr handling. Restore compression of trigger 
expressions.  Change Expr.zToken to Expr.u.zToken and added Expr.u.iValue.
Remove an unnecessary ExprDup from CHECK constraint processing.  And so forth. (CVS 6682)

FossilOrigin-Name: 4ac2bdfbb4230b6ceaae87e738fa61036bbe03cb
 2009-05-28 01:00:55 +00:00
drh
b7916a78ff Simplifications to the Expr object: Remove Expr.span completely and convert 
Expr.token into a char* Expr.zToken.  Also simplify the Token object by
removing the Token.dyn and Token.quoted fields. (CVS 6681)

FossilOrigin-Name: 7cb1c3ba0759539cb035978fdaff6316775986f3
 2009-05-27 10:31:29 +00:00
drh
12ffee8cb9 Minor refactoring of the expression-compaction logic for clarity of 
presentation.  New comments added.  The EXPRDUP_DISTINCTSPAN flag is
removed as obsolete. (CVS 6470)

FossilOrigin-Name: 44ded2ea67374f187a111df69c3f51f866735400
 2009-04-08 13:51:51 +00:00
drh
0a9aa2253c Do not attempt to walk a TokenOnly or SpanOnly expression tree node. 
Ticket #3791. (CVS 6469)

FossilOrigin-Name: 8362d883248f00a8ec7294bf027fd19758aec5f2
 2009-04-08 12:21:30 +00:00