database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2026-10-26 21:59:27 +03:00
Code Activity
21,677 Commits 1,786 Branches 392 Tags
explain-improvements
Commit Graph

206 Commits

Author SHA1 Message Date
drh
9fc1b9af36 NEVER() and ALWAYS() macros tagging unreachable branches. 
FossilOrigin-Name: 34b877742ef78e9bb3f16815180f4ad9cd722beb1d610f713400a3b25d68aa9b
 2020-01-02 22:23:01 +00:00
drh
5f6a2ed7f2 Merge recent enhancements from trunk. 
FossilOrigin-Name: 39d55579376906f212271ce9b2d367e3ad029fb173f22c7253312b467970208a
 2019-12-31 14:49:10 +00:00
dan
394aa710f2 Fix a potential problem with ALTER TABLE commands on schemas that contains a triggers or view featuring a sub-query that uses an ON clause with a join that is not a LEFT JOIN. 
FossilOrigin-Name: 365dd8b663d5a28af33556b2b3820c6b5482114ef741a1d82b55c6e154f3043a
 2019-12-20 14:18:29 +00:00
drh
b2ab3dcff0 Fix harmless compiler warnings. 
FossilOrigin-Name: 2bbd014c900e0d71fd30ec647739b82c5dc3aa237a0203f5a1db50593dae199e
 2019-12-20 14:08:34 +00:00
drh
1548d5276f Do not continue an ALTER TABLE tree walk of a subquery if a prior error 
is seen in the tree.  Report the problem immediately, without continuing.

FossilOrigin-Name: 01ca865f31c0c817ede7f357401ef76cf311ae662397908464f53e1c147f5b6b
 2019-12-20 12:55:21 +00:00
drh
646975c521 Clean up the ExprList that holds the names of columns in a CTE before checking 
for unused references in the ALTER TABLE implementation.

FossilOrigin-Name: 8223e79f987feda5c8e51ec52cec6798cca16d070b10558939e2888ca1a25b8e
 2019-12-17 12:03:30 +00:00
drh
c4938ea2ba Tie up the loose ends in the ExprList size reduction. 
FossilOrigin-Name: 59d0f3afe5249a2a6453fe7bc810c2c7beb896d3800174c7c90f9304c0b1ad88
 2019-12-13 00:49:42 +00:00
drh
41cee66848 Change the name of the Expr.a.zName field to zEName, so that it has a name 
that is distinct from other fields and variables and is hence easier to
grep for.

FossilOrigin-Name: d3783357f8fa76c42a86f12b214522f0388c37773c36ab8c5ce0623abbc4436a
 2019-12-12 20:22:34 +00:00
drh
2bc5cf9ae9 Add a NEVER() to the ALTER TABLE fix in check-in [1d2e53a39b87e364] 
FossilOrigin-Name: c7309ed3c7588c7e51e09418bf5cfd4611539b44c39cef9ed4ae0e385bae7625
 2019-12-09 19:29:10 +00:00
dan
38096961c7 Avoid infinite recursion in the ALTER TABLE code when a view contains an unused CTE that references, directly or indirectly, the view itself. 
FossilOrigin-Name: 1d2e53a39b87e364685e21de137655b6eee725e4c6d27fc90865072d7c5892b5
 2019-12-09 08:13:43 +00:00
dan
e6dc1e5b70 Fix a problem in ALTER TABLE that could occur if an index, view or trigger in the schema features an expression of the form ((SELECT ...) IN ()) where the SELECT statement uses a CTE. 
FossilOrigin-Name: 7e5ad8e0ab7ee91a5ccb19a9654d6a036233f74d2fdc45f7315feb3d9d035fd4
 2019-12-05 14:31:43 +00:00
drh
d63b69b8a2 Ensure that an ALWAYS() in the rename logic really is always true, even 
for faulty inputs.

FossilOrigin-Name: 54410f0e7710542d5159d0449898598d2b7f7676bfd993644ca47da1bf1fcdac
 2019-12-04 15:08:58 +00:00
dan
8f4076223d Fix an assert() failure that could occur in ALTER TABLE code when the schema contains a view that uses a CTE. 
FossilOrigin-Name: 75b04a4b0d2e65bfcd02cf4e0b6d8f1954957c590814a9b8f9a9ee2adc2ec022
 2019-12-04 14:26:38 +00:00
drh
070ae3beea Break out the test for writable shadow tables into a separate subroutine. 
FossilOrigin-Name: 8ad34d36a141fa8f5d9bd784dfeb892c983897a6dc6b867607cc668508acf944
 2019-11-16 13:51:31 +00:00
drh
035f6d909f Do not allow ALTER TABLE ADD COLUMN for a STORED column. 
FossilOrigin-Name: 42fc08bc1528a34a603c2c085b515766a8d33ae7ea0350a52b0ca24b94ebcbc5
 2019-10-24 01:04:10 +00:00
drh
b9bcf7ca60 Refactor names of column index transformation functions, for clarity. 
Get generated columns working with ALTER TABLE RENAME COLUMN.

FossilOrigin-Name: 27ab41c9102e7801ff829488fc123a8040da008bef373d6704efbe2f93e1da90
 2019-10-19 13:29:10 +00:00
drh
c27ea2ae8d ALTER TABLE is able to add a VIRTUAL column. 
FossilOrigin-Name: 120c6b78cb51532f783014605f1107d40b2e4f54e3852fb1f8f167d0c0b78c69
 2019-10-16 20:05:56 +00:00
drh
92a2824cc6 An improved fix for the dbsqlfuzz-discovered ALWAYS() failure following OOM in 
sqlite3ExprCollSeq().  This time with a test case (engineered by Dan).

FossilOrigin-Name: 907f7965b335d8d5441f2e386bb190d1f93ffcd45ca98d2d1c621dede491fc5e
 2019-10-09 15:37:58 +00:00
drh
efb02281a4 Change sqlite3SelectDup() to always return NULL if an OOM has occurred. 
FossilOrigin-Name: 01ba4641ab436c6065c8725908fc0913f2abded4ea62e004b7534e0116b9451a
 2019-10-09 15:00:37 +00:00
dan
03e025e217 Fix a problem with running ALTER TABLE ADD COLUMN statements within a transaction that writes to one or more virtual tables. 
FossilOrigin-Name: 31e85fbbc4cfd09a98b4a6dc6624f863816f376c6a4eef1fafc657c8e1abbc36
 2019-10-07 18:43:21 +00:00
drh
c5a93d4c85 Validate the type, name, and tbl_name fields of the sqlite_master table when 
loading the schema, unless writable_schema is engaged.

FossilOrigin-Name: 724f4df9ccc2b683f7091a3f7a8c20ee210f44d7a610cd1b4c49da1c274add08
 2019-08-12 00:08:07 +00:00
drh
bdf4cf0b90 Ensure that sqlite3RenameExprUnmap() does an unmap of the result set alias 
names in subqueries when ALTER TABLE fails because of a syntax error in a
trigger.

FossilOrigin-Name: d3b6f1665f6fb5fc5cf1c0864d779d0b24746ada530f755c7b6ff34766bd2188
 2019-06-15 15:21:49 +00:00
drh
2c3f46500f Mark an unreachable branch with an ALWAYS macro. 
FossilOrigin-Name: d4755aca4b435eed62b54af84013f7f176d3fa5b7b1c243555d59de5749fcde5
 2019-06-11 16:43:58 +00:00
dan
0b277a980a Have the ALTER TABLE code handle the case where an entire expression that includes a sub-select is excluded from a view, trigger or index. 
FossilOrigin-Name: f2c8179f3c0b77f10da3f9b0771db4dec30d0bbf0b7f4751ce439bfb08da8f6f
 2019-06-11 12:03:10 +00:00
dan
65455fc682 Fix a problem with renaming a table that starts with "sqlite". Fix for ticket [f00d7b65]. 
FossilOrigin-Name: a2ead8aa4517b63cda7bf84464326e9cb5e228224caa603568c0e04ea44e6588
 2019-04-19 16:34:22 +00:00
dan
1f3b284b11 Ensure that ALTER TABLE commands open statement transactions. Fix for [596d059a]. 
FossilOrigin-Name: 0f2129f59f7df929106e2af876c2976dea6528c1dc1850d64cddb256f20e121a
 2019-03-15 16:17:32 +00:00
dan
0e14e98706 Fix a fairly obscure problem allowing an "ALTER TABLE RENAME col TO ..." statement to modify the schema in such a way as to break a reference within a trigger program. 
FossilOrigin-Name: 64bec9e6214c6932fab5a3fb8c569ae14cd2d603bd0f8b26104815c3bb9d396a
 2019-01-18 16:06:18 +00:00
drh
a1bd5c6aae Move a local variable declaration into the outermost scope in which it 
is used. This fixes an ASAN warning.

FossilOrigin-Name: ac3b6021d9437ab1c027850d321f0a3e575b008763d8d515e2347f7d4e7c294b
 2019-01-13 00:58:57 +00:00
drh
885eeb676b Enhance the ALTER TABLE RENAME COLUMN feature so that it works on tables 
that have redundant UNIQUE and/or PRIMARY KEY constraints.
Fix for ticket [bc8d94f0fbd633fd9a051e3]

FossilOrigin-Name: f09aa3248e2b4a32ff5b5d37084cb2a27445322cb06a3354cef723f4f0b2cd34
 2019-01-09 02:02:24 +00:00
dan
397a78d4a1 In defensive mode, do not allow shadow tables to be renamed using ALTER TABLE. 
FossilOrigin-Name: 23e200da5cfbde0798e67cd9e016e4a1cd73b67981e1af841493fcd123d8f547
 2018-12-18 20:31:14 +00:00
drh
974b24896a Fix a potential NULL pointer dereference that can occur in ALTER TABLE 
following an OOM.  Test case in TH3.

FossilOrigin-Name: ea50815bf80ab0d36891518f209acbcd3d6d8d84529741bffd4e841874c78aff
 2018-12-06 01:53:12 +00:00
dan
ea41251eb0 Ensure that ALTER TABLE modifies table and column names embedded in WITH 
clauses that are part of views and triggers.

FossilOrigin-Name: f44bc7a8b3fac82aa5598e9bdaf65ea4dd3c331cf90c1d5ba26ff1698e92c230
 2018-12-05 13:49:04 +00:00
drh
eea8eb6d04 Do not allow direct access to internal-use SQL functions such as 
sqlite_rename_column() and sqlite3_rename_table() except when the
new SQLITE_TESTCTRL_INTERNAL_FUNCTIONS flag is set.

FossilOrigin-Name: 6e1330545e7b74fe5f1f20751a3425e2788441485fc07fcb7626e448c72027ce
 2018-11-26 18:09:15 +00:00
drh
49b269e095 Minor comment enhancement in alter.c. No changes to code. 
FossilOrigin-Name: 12920bcb99b25e147e1877ee001bc551a743e3530c954fe2b45a18a4eef9eeff
 2018-11-26 15:00:25 +00:00
dan
b430701823 When a table is renamed using "ALTER TABLE RENAME TO", update any REFERENCES 
clauses that refer to the table, unless "PRAGMA legacy_alter_table" is true
and "PRAGMA foreign_keys" is set to false (i.e. so that when "PRAGMA
legacy_alter_table" is set behaviour is still compatible with versions 3.24
and earlier).

FossilOrigin-Name: ae9638e9c0ad0c366f93c88a850f6b4cc86881e9f3f9f1e39574d9d83ddd8a6a
 2018-11-09 20:04:05 +00:00
drh
f470c37a2b Add an ALWAYS on an unreachable branch in the ALTER TABLE logic. 
FossilOrigin-Name: ebcd4523171f0988ff08e2bf36fb8a0caa40efe7ac7556b4eb206784969b03e4
 2018-10-03 18:05:36 +00:00
dan
5351e884aa Fix a problem with ALTER TABLE commands when the schema features an INSTEAD of 
trigger that uses NEW.* or OLD.*.

FossilOrigin-Name: c52f457e56eb9d573eb67093731eb231aaf6fd6dbdc397e6f948b82736fbe3ab
 2018-10-01 07:04:12 +00:00
drh
42eb070729 Add the "PRAGMA legacy_alter_table=ON" command to enable the pre-3.25.0 
behavior of ALTER TABLE that does not modify the bodies of triggers or
views or the WHERE clause of a partial index.  Enable the legacy behavior
by default when running the xRename method of virtual tables.

FossilOrigin-Name: 7edd26ed27ed1e7eab603058f7d55f2eac45e7bd1908bfa5f32293611883b157
 2018-09-20 20:15:02 +00:00
drh
eda079cd2c Combine the Expr.pTab and Expr.pWin fields into a union named "y". Add a new 
EP_WinFunc property that is only true if Expr.y.pWin is a valid pointer.
This reduces the size of the Expr object by 8 bytes, reduces the overall
amount of code, and shaves over 1 million cycles off of the speed test.

FossilOrigin-Name: ad130bb86e74e6ce165fdbdce3a19699510f0e62071c1c7923b5a4538d888c7c
 2018-09-20 19:02:15 +00:00
dan
34566c4434 By default, make all "ALTER TABLE RENAME" statements executed within a virtual 
table xRename() method exhibit the legacy behaviour.

FossilOrigin-Name: 71947337e98b90debb13b390119bc2a6b39dd41535151b836071ee327a31e45d
 2018-09-20 17:21:21 +00:00
dan
674b894269 Add a PRAGMA that restores the legacy ALTER TABLE RENAME TO behaviour. 
FossilOrigin-Name: 5acad2e92c11c209bedc6ac8a709595e8070eed028ffc82af61499e5ceaa5e2b
 2018-09-20 08:28:01 +00:00
dan
de79e094bc Minor modification to the fix on this branch to avoid adding extra conditional 
compilation macros.

FossilOrigin-Name: 4d8be404dab265b51e5a6a95e83be85c22512e19a437191690c7d845c87ff259
 2018-09-17 13:38:45 +00:00
drh
16b870d804 Restrict the scope of internal-use functions in alter.c. 
FossilOrigin-Name: 4396914f8e1a847d86c22fb0b91e7431cf19aa260cbec520af3564248d6897ad
 2018-09-12 15:51:56 +00:00
dan
e8ab40d219 Fix an invalid pointer comparison triggered by renaming a table column when 
there are views with explicit column names in the schema.

FossilOrigin-Name: 572de7e4e33562c72cd90790b267ba389370f21ddcaebc4db609fd76ae9b7ada
 2018-09-12 08:51:48 +00:00
drh
3b70045096 Remove a faulty ALWAYS() macro added by check-in [8fa254aa6329bdd0]. 
FossilOrigin-Name: fc47316e9b6b9f4c37cb7d3fe2af3f4dfb900fb5f07945dbf1239152a2d8f836
 2018-09-07 19:12:08 +00:00
drh
a488ec9f0a Add assert() and ALWAYS() to identify two unreachable branches. 
FossilOrigin-Name: 8fa254aa6329bdd085b8e2c78d8e8a698b418eda8b2d48e0082dd9cd428cef29
 2018-09-07 18:52:25 +00:00
dan
d5e6fef2a1 Fix a problem with renaming a non-temp table that has at least one temp 
trigger and shares its name with a temp table.

FossilOrigin-Name: ceb60bd7e5f2a0a4247bff476fc6468227305467339ae0c24591be9d2b14bdde
 2018-09-07 15:50:31 +00:00
dan
202a0274db Minor fixes for problems revealed by releasetest.tcl. 
FossilOrigin-Name: 1a8aedc3376b7ae32fa7b2c367eedd483e2629908836efd10ee5bd1fe0784675
 2018-09-07 11:51:21 +00:00
dan
1041a6a817 Fix a problem in ALTER TABLE with SQLITE_OMIT_VIRTUALTABLE builds. 
FossilOrigin-Name: fa835145e63749e06e04bd50ff992afaeae05dcdd1df597d13911f944e62076b
 2018-09-06 17:47:09 +00:00
dan
1d85c6bf48 Ensure that the tbl_name column in the sqlite_temp_master table is updated 
correctly as part of a RENAME TABLE operation.

FossilOrigin-Name: ffecfca511718e39e0003b380d5113755b8a11405a5bd80cc04503d9557f0842
 2018-09-06 16:01:37 +00:00