database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-08-08 14:02:16 +03:00
Code Activity
30,720 Commits 1,570 Branches 184 Tags
bedrock
Commit Graph

1471 Commits

Author SHA1 Message Date
drh
325420616f The sqlite3FaultSim(300) error from [1e8863909ac369e5] must be treated as 
an OOM, since it simulates an OOM.  Also fix deferred deletion of Expr objects
from [a53bdd311c4154fd] so that it does not corrupt the AST if an OOM occurs.

FossilOrigin-Name: c623d9a51e0ae6b4a8e1186714d14e7aa3df55246e123323481f07f07749dea5
 2024-05-10 18:10:34 +00:00
drh
788ade3487 Allow arbitrary expressions as the second argument to RAISE(). 
FossilOrigin-Name: 003e1c8c27824cb917b3869bdf9000f32ff0b6887a2aff8516712cfe865cf34d
 2024-05-08 17:42:13 +00:00
drh
ebf9702b34 Avoid unnecessary recursion in sqlite3ExprDeleteNN(). This complicates the 
code, but it is needed to prevent nuisance "stack overflow" reports from
OSSFuzz while it is running the latest ASAN.

FossilOrigin-Name: 70abc144ca90a58ea25dc2d90683545246c084d961215c20ec070b0abe640371
 2024-05-06 19:04:46 +00:00
dan
5b27ecafbc Avoid slowdown when exprNodeIsConstant() is called on deeply nested SQL functions. 
FossilOrigin-Name: 1c0b0345451853846076467831884f951c92ec79476be40ce7f7b766fd2d8fc1
 2024-04-24 11:40:47 +00:00
drh
660322f96f Merge trunk enhancements into the pushdown-subquery branch. 
FossilOrigin-Name: 27865e316f8dfbf4c20290cf1be3024d7518fec46655e34f3fc435e15346c63e
 2024-04-07 10:30:29 +00:00
drh
05c6d13027 Add comments to note the name abiguity between the MySQL push-down 
optimization and the WHERE-clause push-down optimization.

FossilOrigin-Name: 3d5fb1ec7a0440072d6e3b957903c85d0f32b8b07207a1ef22d1a69cf5e664d1
 2024-04-07 10:27:18 +00:00
drh
6951c49779 Do not allow changes to sqlite3ExprIsTableConstant() that support pushdown of 
subqueries interfere with the hash-join logic.

FossilOrigin-Name: 8682931f9c6b40e1b09139c10bbe932c38330b5eb0c5c84f2432ad19a6793e37
 2024-04-06 18:30:09 +00:00
drh
de6a4be9b5 Generalize pushdown to allow any uncorrelated subquery to be pushed down. 
FossilOrigin-Name: 87c45fb0d5f5ca5d6d1ad27bef83f294231d17d94299e1997364a7975b423e38
 2024-04-06 12:19:50 +00:00
drh
743ae4c68b Experimental enhancement in which expressions of the form "expr IN table" 
can be pushed down into subexpressions.

FossilOrigin-Name: 2cbd7838fd6ffdf210f34671cd2e3e749a076a3a6f155bbe5f910a67db31c5b1
 2024-04-05 20:01:28 +00:00
drh
a509a90958 The RAISE() operator is not a constant expression and cannot participate in 
the VALUE-as-coroutine optimization.
dbsqlfuzz 74cf7c9904360322a6c917e4934b127543d1cd51

FossilOrigin-Name: 6a06dc73847716c88d65651d1bf0e002002303881df1389beac884d0032eae08
 2024-03-25 20:35:14 +00:00
drh
a631eb378d Do not automatically assume that ROWID is NOT NULL when compiled with 
SQLITE_ALLOW_ROWID_IN_VIEW.
dbsqlfuzz 31b38eeb63a4e1562de665078f52b7b47a7543cf

FossilOrigin-Name: 80c4223098c1827ff3a564f1f9a4203164a943e9a83eef99df68378fa3c4764b
 2024-03-24 16:33:31 +00:00
drh
27ea83f66e Make sure the new u1.nRow value is copied when making a copy of a SrcItem 
object.  This fixes a problem in [ac6f095e13e43d66] from yesterady.

FossilOrigin-Name: 262f8f9d80d37160e4126634b99aa48fce2073e61f6365e8bdbe1cc4fa560a96
 2024-03-19 19:42:56 +00:00
drh
871786b792 Fix the patch at [10ee6fcba08ab128] so that it works on reduced-size Expr 
nodes.

FossilOrigin-Name: 260bd764c3f2d6d067adb9cd0045b7c24d5e00b02ab2735b1cba455a6143ff4c
 2024-03-18 13:10:54 +00:00
dan
2f4a8cc2d8 Fix a problem caused by a non-aggregate function with an OVER clause in a multi-row VALUES clause. 
FossilOrigin-Name: 10ee6fcba08ab1281235197602148fe062560e1d5034a477b8e7b574dd3e2907
 2024-03-18 10:54:48 +00:00
drh
ec00a4d111 A formerly impossible case has now become possible because of the new 
ExprIsConstant enhancements.  So deal with that.

FossilOrigin-Name: 9ba3cff9d48fe8fc8a0a51291169599209d464465e44bdfd60058fd1e314a2b1
 2024-03-16 21:04:32 +00:00
drh
7dc3e923c4 Further expand the scope of usage for the enhacement to expr-is-constant. 
FossilOrigin-Name: d7eadcf7dd089f0f4aa963c58f0df32edd951368c9906375fd62b0a61cd393b8
 2024-03-16 20:15:34 +00:00
drh
4713b2d73c Assert that the eCode is always non-zero upon entry into exprNodeIsConstant(). 
FossilOrigin-Name: f71b28f6713126745bca53e098dfe3444d4235d6a2b87ced5b333a7f0ee79be8
 2024-03-16 19:48:51 +00:00
dan
40514dd1f6 Fix exprNodeIsConstantFunction() so that it returns WRC_Continue, not WRC_Abort, if the function really is constant. 
FossilOrigin-Name: d85dd4de2d0989127e0ae6a2eec9d83a577777f8d5ba40700084a0b498016634
 2024-03-16 14:27:10 +00:00
drh
f696591dd4 Enhance the sqlite3ExprIsConstant() function so that it recognizes 
constant functions.  So far the enhancement only applies to the multi-row
VALUES clause, but it could possibly be applied in many other places.

FossilOrigin-Name: c9e0488c6c0135932b6e76b0f3f3acd69ef65327e0a54daa59777f35da1aef26
 2024-03-16 13:18:48 +00:00
dan
815e055bff Attempt to reduce the memory used by VALUES clauses in as many statements as possible, not just INSERT. This branch still has problems. 
FossilOrigin-Name: 17d1f7cfabc7593d0725051b0c7c9619a23a482265f30f15ab9493fef5caeeb0
 2024-03-11 17:27:19 +00:00
dan
7ab40cda7b Remove code that added a P4 parameter to the OP_Variable opcode. This is no longer required. 
FossilOrigin-Name: dd5977c9a8a418be3fbd646d74933996381099a9263a02eb4a990f0084463dc1
 2024-03-05 18:41:03 +00:00
drh
8597eee119 Always convert 32-bit integer literals into EP_IntValue notation, even if 
they contain "_" separators.

FossilOrigin-Name: 2dfc427f676255cbe189a26bfec2405d41d31ccc4512c55b31e6e633261d7a23
 2024-02-28 01:12:21 +00:00
drh
71a32aede3 Remove an ALWAYS() added in [c50e6c2ace49d092] because it is sometimes false. 
dbsqlfuzz c393a4f783d42efd9552772110aff7e5d937f15e.

FossilOrigin-Name: b9daf37e57cde12c4de271a2b1995e8e91b6411f8c2e8882e536241929609b3a
 2023-12-24 12:02:36 +00:00
drh
c52aebb443 Remove redundant conditional from sqlite3ExprCanBeNull(). 
FossilOrigin-Name: 257f96a2d22c605885fa66220c28cf7dc5941c330bccee3f132b9e7b70d89d30
 2023-12-19 15:51:14 +00:00
drh
09259aff6c Add ALWAYS() and NEVER() on branches made unreachable by recent changes. 
FossilOrigin-Name: c50e6c2ace49d0928b05cbfd877c621e9a0f77dc4e056ccb1dbe5cf118a00d00
 2023-12-19 14:53:39 +00:00
drh
3e2ec83e0b Ignore COLLATE operators when determining whether the result of a subexpression 
should be shallow-copied or deep-copied.

FossilOrigin-Name: 34ae36a45e814bed7c8340412c7ef3fc849b82357656d0eb5f0f805e59d846d0
 2023-12-19 13:45:05 +00:00
drh
a3569fb2ca Extra ALWAYS() macros to verify state in the sqlite3ExprCanBeNull() routine. 
FossilOrigin-Name: be19b84c9f3fe127165809908add148dbe9a827a55608b0490de7e69b7f7f191
 2023-12-19 11:57:29 +00:00
drh
07117f8118 Pass subtype information through the aggregate ORDER BY sorter for 
aggregate functions that use subtype information.

FossilOrigin-Name: 3536f4030eab6d650b7ed729d2f71eb6cc3b5fbe16b4e96b99008d66522aaccb
 2023-12-14 13:58:50 +00:00
drh
f86a07b0c4 Add ALWAYS() on branches added in [ec0ae4030968c782] that are always true. 
FossilOrigin-Name: 451cef8609e96dd9244818adc5c6f240544694bcb4ae620e88f90e403e59d70f
 2023-12-07 13:14:34 +00:00
drh
82fc1b63f6 Work around LLVM's newfound hatred of function pointer casts. 
[forum:/forumpost/1a7d257346636292|Forum post 1a7d257346636292].

FossilOrigin-Name: ec0ae4030968c782af48d1c776351c14b2ada21d40aeb97915f33df30706e18f
 2023-12-06 18:25:41 +00:00
drh
4f77a27032 Back out an incorrect change to the sqlite3ExprCompareSkip() function that 
was added way back on 2019-08-22 for [44578865fa7baf97|check-in 44578865fa7ba]
and which was only today discovered to be incorrect by
[forum:/forumpost/45ec3d9788|forum post 45ec3d9788].

FossilOrigin-Name: f5b3eb0fc8936ba274a7654ff6dfa7d4654bd8dbca7f3a5ec1134b0b5260d59d
 2023-11-20 15:54:00 +00:00
drh
7df044633d Add NEVER() to a branch made unreachable by [6f9eed826f5b3d1c]. 
FossilOrigin-Name: 26dcaa34e3521783bde687749d590eca54cecb4bb95ef332a4a6473c4141d052
 2023-11-14 16:53:52 +00:00
dan
d928e78088 Fix another obscure problem with nested aggregates. dbsqlfuzz 04408efc51. 
FossilOrigin-Name: 6f9eed826f5b3d1cb08402925b406a7fe9b54259af1ba5eba92d4d37fbad628a
 2023-11-14 14:50:34 +00:00
drh
5ba99da869 Fix harmless compiler warnings in test code. 
FossilOrigin-Name: d1895dd8f5757a339f619f22b29c8a739398ded673bb9c93f1b8eb8a4b38f510
 2023-10-31 17:40:30 +00:00
drh
8f99cb9ad6 When doing a DISTINCT aggregate that contains an ORDER BY, only the 
arguments to the aggregate need to be distinct, not the ORDER BY terms.

FossilOrigin-Name: d2dbbdf7194bab4e5e3b74d3dbffb012a335829824c775c72dd7347c013d2125
 2023-10-25 14:54:16 +00:00
drh
bd8941a4f8 Fix sqlite3ExprDup() alignment assertions so that they work on 32-bit 
platforms.

FossilOrigin-Name: 143f95efc7114455b1920f1d2f9a867392740f608d1dda4306005f01238103f8
 2023-10-23 12:16:27 +00:00
drh
5e6dde3b35 Fix [f5c01676fd281e93] so that it always preserves 8-byte alignment for Expr 
objects.  Add new assert() statement to verify this.

FossilOrigin-Name: 678a9728dc6b88d8ef924c86603056df18204bc9a9c4776b9baffd7c5b10c5f2
 2023-10-22 23:44:32 +00:00
drh
e98f62fb3f Omit some redundant calls to strlen() used to find the size of 
Expr.u.zToken in sqliteExprDup().  This inefficiency was seen while working
on the previous check-in, and I thought it best to fix it while it was
fresh in mind.

FossilOrigin-Name: b7a84eff5dcdf5b2ff81331097cdc64d0c5d16a4ae224320f39b64541ec72dc7
 2023-10-20 18:09:08 +00:00
drh
ab3eb5b770 Improvements to the sqlite3ExprDup() logic for faster performance and better 
run-time error detection.  This check-in fixes the 5x oversize memory allocation
bug from [f371e4c0f8ea73ae] as well as all other known issues that result from
handing the ORDER BY clause of an aggregate function off of the pLeft pointer
of the Expr object.

FossilOrigin-Name: f5c01676fd281e938181b846dd2024d050f597dc6a7a91928beab9d8553dfdb5
 2023-10-20 17:15:15 +00:00
drh
90e4a3b7fc Simplifications and optimizations to the Expr object duplication logic. 
The 5x multiplier crutch from [f371e4c0f8ea73ae] is still present.  More
fixes are still needed.

FossilOrigin-Name: 56142a78163b755f16afc05201f623a7a19d9a4b0620a67f7fa20d2a965a288d
 2023-10-20 15:47:30 +00:00
drh
d707e012f0 Use sqlite3ParserAddCleanup() instead of calling sqlite3ExprListDelete() 
directly when disposing of an unused ORDER BY in an aggregate function,
to avoid disrupting ALTER TABLE data structures.

FossilOrigin-Name: d083e42086733ecd79aba8c268e020b01782bfe1cfa9684ce1c277af9c8bf92a
 2023-10-20 10:18:03 +00:00
drh
5f53f85e22 For TK_ORDER expression nodes to always be full-size. 
FossilOrigin-Name: a5c73b46f4772f214ffbfa31cb87dce82ebd690addabef539bd09def26b7744d
 2023-10-19 19:57:57 +00:00
drh
5080397e67 Fix an adverse interaction between the new aggregate ORDER BY logic and the 
expression compressor.

FossilOrigin-Name: f371e4c0f8ea73aee9ea0645f396e3da20f1eb97be34c83de9d94c9cbb959934
 2023-10-19 19:19:59 +00:00
drh
4e254641ff Simplify the Expr compression logic slightly by adding the new EP_FullSize 
property to expressions that are exceptions to the rule and should not be
compressed.

FossilOrigin-Name: d5ae82ec52eafed5e3dc8c9d99685f6523fce7d973ef7e8d9d75ed9b8912426a
 2023-10-19 18:07:58 +00:00
drh
519017f25a Fix the sqlite3ReferencesSrcList() routine so that it recognizes columns 
in the ORDER BY clause of an aggregate.  Fixes a problem with
[634286828dad873d] discoverd by dbsqlfuzz.

FossilOrigin-Name: 3d26f1aaa4876f21f2c3abf13bbc37933c8f32471153e29019880cc9530cb011
 2023-10-19 12:12:49 +00:00
drh
0b633640fa Merge the latest changes from trunk. 
FossilOrigin-Name: d18bc400146812c8c5048af7eaf4a5371ddd80fc9ce895d253b6114b9eae7fc3
 2023-10-19 01:09:49 +00:00
drh
69ff726d4d Fix a false-positive in run-time error checking. 
FossilOrigin-Name: cd63eec0758960d9ee63d7b964ec62e2bd622f8c94a58bd9556046381ffa18d0
 2023-10-19 00:25:35 +00:00
drh
d05e54efff Changes for test coverage. 
FossilOrigin-Name: ddfa09c6031afd4391a9888381bf09214cd542a826b431eeb1537a070f65c5f9
 2023-10-18 23:48:24 +00:00
drh
20b95f8d3f Make sure all terms of the ORDER BY within an aggregate go through aggregate 
analysis.  Do not attach an aggregate ORDER BY to a window function.

FossilOrigin-Name: 16f3805514a741405f70e0ee3b5a6b67720bc75719372e82daa4136fe411ea2b
 2023-10-18 22:03:48 +00:00
drh
49dc1be96f Basic test cases. 
FossilOrigin-Name: 6cccf86c362631ada0c6cbaf661520648f8bbf7ae2b137b3d7d959647387e5c2
 2023-10-18 19:44:59 +00:00