database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-08-01 06:27:03 +03:00
Code Activity

Fix savepoint related bugs. A rollback caused by an IO error or "OR ROLLBACK" clause while one or more savepoints were open was leaving the sqlite3 structure in an invalid state. (CVS 6128)

Browse Source 
FossilOrigin-Name: e5d42c69a3b325ca12f53184e33964230acbdd1f
This commit is contained in:
danielk1977
2009-01-07 08:12:16 +00:00
parent f2a84e3ca6
commit fc158bf920
5 changed files with 65 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
test/savepoint.test
View File

@ -9,7 +9,7 @@
#
#***********************************************************************
#
# $Id: savepoint.test,v 1.8 2009/01/06 13:40:08 danielk1977 Exp $
# $Id: savepoint.test,v 1.9 2009/01/07 08:12:16 danielk1977 Exp $
set testdir [file dirname $argv0]
source $testdir/tester.tcl
@ -745,5 +745,38 @@ do_test savepoint-11.6 {
file size test.db
} {8192}
#-------------------------------------------------------------------------
# The following tests - savepoint-12.* - test the interaction of
# savepoints and "ON CONFLICT ROLLBACK" clauses.
#
do_test savepoint-12.1 {
execsql {
CREATE TABLE t4(a PRIMARY KEY, b);
INSERT INTO t4 VALUES(1, 'one');
}
} {}
do_test savepoint-12.2 {
# The final statement of the following SQL hits a constraint when the
# conflict handling mode is "OR ROLLBACK" and there are a couple of
# open savepoints. At one point this would fail to clear the internal
# record of the open savepoints, resulting in an assert() failure
# later on.
#
catchsql {
BEGIN;
INSERT INTO t4 VALUES(2, 'two');
SAVEPOINT sp1;
INSERT INTO t4 VALUES(3, 'three');
SAVEPOINT sp2;
INSERT OR ROLLBACK INTO t4 VALUES(1, 'one');
}
} {1 {column a is not unique}}
do_test savepoint-12.3 {
sqlite3_get_autocommit db
} {1}
do_test savepoint-12.4 {
execsql { SAVEPOINT one }
} {}
finish_test