database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-08-05 15:55:57 +03:00
Code Activity

Ensure that all four callbacks are provided when registering a window function

Browse Source 
(otherwise SQLITE_MISUSE is returned).

FossilOrigin-Name: 5720dcd8b111b1f8712c8fb4b441ccb129e838db8c26a6e9e0f095dc6a851f6b
This commit is contained in:
dan
2018-06-18 17:36:41 +00:00
parent 660af939b0
commit f87e10c75e
5 changed files with 58 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/test_window.c
View File

@@ -176,6 +176,49 @@ static int SQLITE_TCLAPI test_create_window(
return TCL_OK;
}
static int SQLITE_TCLAPI test_create_window_misuse(
void * clientData,
Tcl_Interp *interp,
int objc,
Tcl_Obj *CONST objv[]
){
sqlite3 *db;
int rc;
if( objc!=2 ){
Tcl_WrongNumArgs(interp, 1, objv, "DB");
return TCL_ERROR;
}
if( getDbPointer(interp, Tcl_GetString(objv[1]), &db) ) return TCL_ERROR;
rc = sqlite3_create_window_function(db, "fff", -1, SQLITE_UTF8, 0,
0, testWindowFinal, testWindowValue, testWindowInverse,
0
);
if( rc!=SQLITE_MISUSE ) goto error;
rc = sqlite3_create_window_function(db, "fff", -1, SQLITE_UTF8, 0,
testWindowStep, 0, testWindowValue, testWindowInverse,
0
);
if( rc!=SQLITE_MISUSE ) goto error;
rc = sqlite3_create_window_function(db, "fff", -1, SQLITE_UTF8, 0,
testWindowStep, testWindowFinal, 0, testWindowInverse,
0
);
if( rc!=SQLITE_MISUSE ) goto error;
rc = sqlite3_create_window_function(db, "fff", -1, SQLITE_UTF8, 0,
testWindowStep, testWindowFinal, testWindowValue, 0,
0
);
if( rc!=SQLITE_MISUSE ) goto error;
return TCL_OK;
error:
Tcl_SetObjResult(interp, Tcl_NewStringObj("misuse test error", -1));
return TCL_ERROR;
}
int Sqlitetest_window_Init(Tcl_Interp *interp){
static struct {
char *zName;
@@ -183,6 +226,7 @@ int Sqlitetest_window_Init(Tcl_Interp *interp){
int clientData;
} aObjCmd[] = {
{ "sqlite3_create_window_function", test_create_window, 0 },
{ "test_create_window_function_misuse", test_create_window_misuse, 0 },
};
int i;
for(i=0; i<sizeof(aObjCmd)/sizeof(aObjCmd[0]); i++){