database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-08-05 15:55:57 +03:00
Code Activity

Defer the check for error check Pgno zero until after the page fetch misses,

Browse Source 
to gain a few CPU cycles and a small size reduction.

FossilOrigin-Name: ece326db50201937eb688809df39edc7fb97413b4614d2e2e783418192f7b02a
This commit is contained in:
drh
2022-02-23 17:16:30 +00:00
parent 584bfcaeb6
commit eac750e9a6
3 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/pager.c
View File

@@ -5491,7 +5491,6 @@ static int getPageNormal(
assert( assert_pager_state(pPager) );
assert( pPager->hasHeldSharedLock==1 );
if( pgno==0 ) return SQLITE_CORRUPT_BKPT;
pBase = sqlite3PcacheFetch(pPager->pPCache, pgno, 3);
if( pBase==0 ){
pPg = 0;
@@ -5519,10 +5518,10 @@ static int getPageNormal(
/* The pager cache has created a new page. Its content needs to
** be initialized. But first some error checks:
**
** (*) obsolete. Was: maximum page number is 2^31
** (2) Never try to fetch the locking page
** (1) Never try to fetch the locking page
** (2) Never try to fetch page 0, which does not exist
*/
if( pgno==PAGER_SJ_PGNO(pPager) ){
if( pgno==PAGER_SJ_PGNO(pPager) || pgno==0 ){
rc = SQLITE_CORRUPT_BKPT;
goto pager_acquire_err;
}