database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-11-12 13:01:09 +03:00
Code Activity

An UPDATE of a table that is indexed by a constant virtual column that uses

Browse Source 
the one-pass optimization might cause the table seek to be omitted before
reaching row DELETE/INSERT.  Fix this by coding an extra OP_Column in that
circumstance.  Ticket [ec8abb025e78f40c]

FossilOrigin-Name: e54560495926fbb8a2ce829c677a2dd0066e46b7a8d4ada9d8a34a3426959836
This commit is contained in:
drh
2019-12-26 23:16:18 +00:00
parent e752040c09
commit d3ee3ad12f
4 changed files with 39 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/update.c
View File

@@ -800,6 +800,22 @@ void sqlite3Update(
/* Delete the index entries associated with the current record. */
sqlite3GenerateRowIndexDelete(pParse, pTab, iDataCur, iIdxCur, aRegIdx, -1);
#ifndef SQLITE_OMIT_GENERATED_COLUMNS
/* If pTab contains one or more virtual columns, then it is possible
** (though unlikely) that no OP_Column opcodes have been run against
** the table since the OP_SeekDeferred, meaning that there has not been
** a seek against the cursor yet. The OP_Delete opcode and OP_Insert
** opcodes that follow will be needing this seek, so code a bogus
** OP_Column just to make sure the seek has been done.
** See ticket ec8abb025e78f40c 2019-12-26
*/
if( eOnePass!=ONEPASS_OFF && (pTab->tabFlags & TF_HasVirtual)!=0 ){
int r1 = sqlite3GetTempReg(pParse);
sqlite3VdbeAddOp3(v, OP_Column, iDataCur, 0, r1);
sqlite3VdbeChangeP5(v, OPFLAG_TYPEOFARG);
}
#endif /* SQLITE_OMIT_GENERATED_COLUMNS */
/* If changing the rowid value, or if there are foreign key constraints
** to process, delete the old record. Otherwise, add a noop OP_Delete
** to invoke the pre-update hook.