database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2026-01-06 08:01:16 +03:00
Code Activity

Move the generation of output column names earlier, to right after

Browse Source 
name resolution and before query transformations such as flattening. 
This prevents the names from getting mangled by query transformations, 
and obviates hacks in the query flattener that attempt to work around 
the name mangling. The resulting code is smaller and faster and gives
more consistent output. Fix to ticket [de3403bf5ae5f72ed].

FossilOrigin-Name: ade7ddf1998190b2b630715774963150d86bed3211b7fd600cbf3068427e1531
This commit is contained in:
drh
2017-07-31 16:42:46 +00:00
parent ea2844f153 ce00d05a7b
commit c644980c4d
4 changed files with 84 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
test/colname.test
View File

@@ -13,7 +13,6 @@
# The focus of this file is testing how SQLite generates the names
# of columns in a result set.
#
# $Id: colname.test,v 1.7 2009/06/02 15:47:38 drh Exp $
set testdir [file dirname $argv0]
source $testdir/tester.tcl
@@ -326,4 +325,58 @@ do_test colname-8.1 {
}
} {123}
# 2017-07-29: Interaction between column naming and query flattening.
# For years now, the query flattener has inserted AS clauses on the
# outer query that were the original SQL text of the column. This caused
# column-name shifts when the query flattener was enhanced, breaking
# legacy applications. See https://sqlite.org/src/info/41c27bc0ff1d3135
# for details.
#
# To fix this, the column naming logic was moved ahead of the query
# flattener so that column names are assigned before the query flattener
# runs.
#
db close
sqlite3 db :memory:
do_test colname-9.100 {
db eval {
CREATE TABLE t1(a,b);
INSERT INTO t1 VALUES(1,2);
CREATE VIEW v1(x,y) AS SELECT a,b FROM t1;
}
execsql2 {SELECT v1.x, (Y) FROM v1}
# Prior to the fix, this would return: "v1.x 1 (Y) 2"
} {x 1 y 2}
do_test colname-9.110 {
execsql2 {SELECT * FROM v1}
} {x 1 y 2}
do_test colname-9.120 {
db eval {
CREATE VIEW v2(x,y) AS SELECT a,b FROM t1 LIMIT 10;
}
execsql2 {SELECT * FROM v2 WHERE 1}
} {x 1 y 2}
do_test colname-9.130 {
execsql2 {SELECT v2.x, [v2].[y] FROM v2 WHERE 1}
} {x 1 y 2}
do_test colname-9.140 {
execsql2 {SELECT +x, +y FROM v2 WHERE 1}
} {+x 1 +y 2}
do_test colname-9.200 {
db eval {
CREATE TABLE t2(c,d);
INSERT INTO t2 VALUES(3,4);
CREATE VIEW v3 AS SELECT c AS a, d AS b FROM t2;
}
execsql2 {SELECT t1.a, v3.a AS n FROM t1 LEFT JOIN v3}
} {a 1 n 3}
do_test colname-9.211 {
execsql2 {SELECT t1.a AS n, v3.a FROM t1 JOIN v3}
} {n 1 a 3}
do_test colname-9.210 {
execsql2 {SELECT t1.a, v3.a AS n FROM t1 JOIN v3}
} {a 1 n 3}
finish_test