database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-11-08 03:22:21 +03:00
Code Activity

Fix the code generation for UPDATE and DELETE so that

Browse Source 
BEFORE triggers that use RAISE(IGNORE) do not leave extra
values on the stack.  Ticket #2767 (CVS 4535)

FossilOrigin-Name: 3391f4139ccfe62cc27739a06567c422ddae9c69
This commit is contained in:
drh
2007-11-11 18:36:34 +00:00
parent bc674334e5
commit 95c0775484
5 changed files with 114 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/update.c
View File

@@ -12,7 +12,7 @@
** This file contains C code routines that are called by the parser
** to handle UPDATE statements.
**
** $Id: update.c,v 1.140 2007/08/16 10:09:03 danielk1977 Exp $
** $Id: update.c,v 1.141 2007/11/11 18:36:34 drh Exp $
*/
#include "sqliteInt.h"
@@ -318,6 +318,8 @@ void sqlite3Update(
}
if( triggers_exist ){
int mem1; /* Memory address storing the rowid for next row to update */
/* Create pseudo-tables for NEW and OLD
*/
sqlite3VdbeAddOp(v, OP_OpenPseudo, oldIdx, 0);
@@ -328,10 +330,10 @@ void sqlite3Update(
/* The top of the update loop for when there are triggers.
*/
addr = sqlite3VdbeAddOp(v, OP_FifoRead, 0, 0);
mem1 = pParse->nMem++;
sqlite3VdbeAddOp(v, OP_MemStore, mem1, 0);
if( !isView ){
sqlite3VdbeAddOp(v, OP_Dup, 0, 0);
sqlite3VdbeAddOp(v, OP_Dup, 0, 0);
/* Open a cursor and make it point to the record that is
** being updated.
*/
@@ -381,6 +383,11 @@ void sqlite3Update(
newIdx, oldIdx, onError, addr) ){
goto update_cleanup;
}
if( !isView ){
sqlite3VdbeAddOp(v, OP_MemLoad, mem1, 0);
sqlite3VdbeAddOp(v, OP_Dup, 0, 0);
}
}
if( !isView && !IsVirtual(pTab) ){