database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-11-12 13:01:09 +03:00
Code Activity

When an assignment occurs in a boolean, always test the result using "!=0"

Browse Source 
to avoid confusion and make it clear that assignment is intended, not
an equality test.  Ticket #3491. (CVS 5879)

FossilOrigin-Name: 89ee5295bdea6f2c093eb6a44d69917dcc8459e3
This commit is contained in:
drh
2008-11-11 00:36:16 +00:00
parent c717b382b8
commit 4d01aeedbb
3 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/pcache.c
View File

@@ -11,7 +11,7 @@
*************************************************************************
** This file implements that page cache.
**
** @(#) $Id: pcache.c,v 1.34 2008/10/17 18:51:53 danielk1977 Exp $
** @(#) $Id: pcache.c,v 1.35 2008/11/11 00:36:17 drh Exp $
*/
#include "sqliteInt.h"
@@ -524,7 +524,7 @@ static PgHdr *pcacheRecyclePage(void){
PgHdr *p = 0;
assert( sqlite3_mutex_held(pcache_g.mutex) );
if( (p=pcache_g.pLruTail) ){
if( (p=pcache_g.pLruTail)!=0 ){
assert( (p->flags&PGHDR_DIRTY)==0 );
pcacheRemoveFromLruList(p);
pcacheRemoveFromHash(p);
@@ -940,7 +940,8 @@ void sqlite3PcacheTruncate(PCache *pCache, Pgno pgno){
static void pcacheEnforceMaxPage(void){
PgHdr *p;
assert( sqlite3_mutex_held(pcache_g.mutex) );
while( pcache_g.nCurrentPage>pcache_g.nMaxPage && (p = pcacheRecyclePage()) ){
while( pcache_g.nCurrentPage>pcache_g.nMaxPage
&& (p = pcacheRecyclePage())!=0 ){
pcachePageFree(p);
}
}