database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-07-29 08:01:23 +03:00
Code Activity

Allow an ALTER TABLE RENAME COLUMN to proceed even if the schema contains a

Browse Source 
virtual table for which the module is unavailable.

FossilOrigin-Name: 7b72b2360a70eb1f788b3c4d745967dfedb2c80af6b2e146ba940a3741fd51a1
This commit is contained in:
dan
2018-08-17 18:08:28 +00:00
parent dabc268f96
commit 499b825487
4 changed files with 46 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
test/altercol.test
View File

@ -334,23 +334,36 @@ do_execsql_test 8.4.5 {
# More triggers.
#
proc do_rename_column_test {tn old new lSchema} {
reset_db
set lSorted [list]
foreach sql $lSchema {
execsql $sql
lappend lSorted [string trim $sql]
for {set i 0} {$i < 2} {incr i} {
# DROP all tables and views in database.
set sql "SELECT name FROM sqlite_master WHERE type='table' ORDER BY 1"
foreach nm [db eval $sql] { db eval "DROP TABLE $nm" }
set sql "SELECT name FROM sqlite_master WHERE type='view' ORDER BY 1"
foreach nm [db eval $sql] { db eval "DROP VIEW $nm" }
set lSorted [list]
foreach sql $lSchema {
execsql $sql
lappend lSorted [string trim $sql]
}
set lSorted [lsort $lSorted]
do_execsql_test $tn.$i.1 {
SELECT sql FROM sqlite_master WHERE sql!='' ORDER BY 1
} $lSorted
if {0 && $i==1} {
db close
sqlite3 db test.db
}
do_execsql_test $tn.$i.2 "ALTER TABLE t1 RENAME $old TO $new"
do_execsql_test $tn.$i.3 {
SELECT sql FROM sqlite_master ORDER BY 1
} [string map [list $old $new] $lSorted]
}
set lSorted [lsort $lSorted]
do_execsql_test $tn.1 {
SELECT sql FROM sqlite_master WHERE sql!='' ORDER BY 1
} $lSorted
do_execsql_test $tn.2 "ALTER TABLE t1 RENAME $old TO $new"
do_execsql_test $tn.3 {
SELECT sql FROM sqlite_master ORDER BY 1
} [string map [list $old $new] $lSorted]
}
foreach {tn old new lSchema} {
@ -397,7 +410,7 @@ reset_db
foreach {tn old new lSchema} {
1 _x_ _xxx_ {
{ CREATE TABLE t1(a, b, _x_) }
{ CREATE VIEW v1 AS SELECT a, b, _x_ FROM t1 WHERE _x_='abc' COLLATE xyz }
{ CREATE VIEW s1 AS SELECT a, b, _x_ FROM t1 WHERE _x_='abc' COLLATE xyz }
}
2 _x_ _xxx_ {
@ -409,7 +422,13 @@ foreach {tn old new lSchema} {
{ CREATE TABLE t1(a, b, _x_) }
{ CREATE VIEW v1 AS SELECT a, b, _x_ FROM t1 WHERE _x_ = unicode(1, 2, 3) }
}
4 _x_ _xxx_ {
{ CREATE TABLE t1(a, b, _x_) }
{ CREATE VIRTUAL TABLE e1 USING echo(t1) }
}
} {
register_echo_module db
do_rename_column_test 10.$tn $old $new $lSchema
}