database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-08-08 14:02:16 +03:00
Code Activity

Have the OP_ReleaseReg opcode also invalidate the registers if P5 is non-zero.

Browse Source 
FossilOrigin-Name: 937be22106f7e3f08712febd342d6cb81d129f2d5ab24ce80b3a5c3f9bbde54e
This commit is contained in:
drh
2020-01-02 17:46:02 +00:00
parent 9f3e6fadde
commit 3aef2fb1b4
7 changed files with 37 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/vdbe.c
View File

@@ -7811,7 +7811,7 @@ case OP_Abortable: {
#endif
#ifdef SQLITE_DEBUG
/* Opcode: ReleaseReg P1 P2 P3 * *
/* Opcode: ReleaseReg P1 P2 P3 * P5
** Synopsis: release r[P1@P2] mask P3
**
** Release registers from service. Any content that was in the
@@ -7826,10 +7826,12 @@ case OP_Abortable: {
** a change to the value of the source register for the OP_SCopy will no longer
** generate an assertion fault in sqlite3VdbeMemAboutToChange().
**
** TODO: Released registers ought to also have their datatype set to
** MEM_Undefined so that any subsequent attempt to read the released
** If P5 is set, then all released registers have their type set
** to MEM_Undefined so that any subsequent attempt to read the released
** register (before it is reinitialized) will generate an assertion fault.
** However, there are places in the code generator which release registers
**
** P5 ought to be set on every call to this opcode.
** However, there are places in the code generator will release registers
** before their are used, under the (valid) assumption that the registers
** will not be reallocated for some other purpose before they are used and
** hence are safe to release.
@@ -7850,7 +7852,7 @@ case OP_ReleaseReg: {
for(i=0; i<pOp->p2; i++, pMem++){
if( i>=32 || (constMask & MASKBIT32(i))==0 ){
pMem->pScopyFrom = 0;
/* MemSetTypeFlag(pMem, MEM_Undefined); // See the TODO */
if( i<32 && pOp->p5 ) MemSetTypeFlag(pMem, MEM_Undefined);
}
}
break;