1
0
mirror of https://github.com/sqlite/sqlite.git synced 2025-11-19 21:43:15 +03:00

Fix over-length source code lines in resolver.c. No logic changes.

FossilOrigin-Name: c12edb85076d0832e3a0abbbba4d07f3cb5d7f0e
This commit is contained in:
drh
2015-02-09 10:20:19 +00:00
parent d10d18da5f
commit 31e7147dfa
3 changed files with 31 additions and 24 deletions

View File

@@ -1,5 +1,5 @@
C Fix\spotential\s32-bit\sinteger\soverflow\sproblems\son\sthe\soffset\sand\slength\nparameters\sto\ssqlite3_blob_read()\sand\ssqlite3_blob_write().\s\sFor\nsqlite3_blob_open(),\smake\ssure\sthe\s*ppBlob\sreturn\sparameter\sis\szeroed\sif\nthe\sinterface\sfails\swith\sSQLITE_MISUSE. C Fix\sover-length\ssource\scode\slines\sin\sresolver.c.\s\sNo\slogic\schanges.
D 2015-02-07T15:16:35.893 D 2015-02-09T10:20:19.068
F Makefile.arm-wince-mingw32ce-gcc d6df77f1f48d690bd73162294bbba7f59507c72f F Makefile.arm-wince-mingw32ce-gcc d6df77f1f48d690bd73162294bbba7f59507c72f
F Makefile.in 6b9e7677829aa94b9f30949656e27312aefb9a46 F Makefile.in 6b9e7677829aa94b9f30949656e27312aefb9a46
F Makefile.linux-gcc 91d710bdc4998cb015f39edf3cb314ec4f4d7e23 F Makefile.linux-gcc 91d710bdc4998cb015f39edf3cb314ec4f4d7e23
@@ -228,7 +228,7 @@ F src/pragma.h 09c89bca58e9a44de2116cc8272b8d454657129f
F src/prepare.c 173a5a499138451b2561614ecb87d78f9f4644b9 F src/prepare.c 173a5a499138451b2561614ecb87d78f9f4644b9
F src/printf.c 05edc41450d0eb2c05ef7db113bf32742ae65325 F src/printf.c 05edc41450d0eb2c05ef7db113bf32742ae65325
F src/random.c ba2679f80ec82c4190062d756f22d0c358180696 F src/random.c ba2679f80ec82c4190062d756f22d0c358180696
F src/resolve.c f6c46d3434439ab2084618d603e6d6dbeb0d6ada F src/resolve.c 4ebd1064bded2556a8856c6f00fe2b9642f6efc3
F src/rowset.c eccf6af6d620aaa4579bd3b72c1b6395d9e9fa1e F src/rowset.c eccf6af6d620aaa4579bd3b72c1b6395d9e9fa1e
F src/select.c 1f2087523007c42900ffcbdeaef06a23ad9329fc F src/select.c 1f2087523007c42900ffcbdeaef06a23ad9329fc
F src/shell.c 82c25508dac802b32198af6f5256ca1597c6a1af F src/shell.c 82c25508dac802b32198af6f5256ca1597c6a1af
@@ -1239,7 +1239,7 @@ F tool/vdbe_profile.tcl 67746953071a9f8f2f668b73fe899074e2c6d8c1
F tool/warnings-clang.sh f6aa929dc20ef1f856af04a730772f59283631d4 F tool/warnings-clang.sh f6aa929dc20ef1f856af04a730772f59283631d4
F tool/warnings.sh 0abfd78ceb09b7f7c27c688c8e3fe93268a13b32 F tool/warnings.sh 0abfd78ceb09b7f7c27c688c8e3fe93268a13b32
F tool/win/sqlite.vsix deb315d026cc8400325c5863eef847784a219a2f F tool/win/sqlite.vsix deb315d026cc8400325c5863eef847784a219a2f
P 0f65a7e2e09f801b66897479d501607caeae4abf P 5df02f50f8348dfde4fc15126abc7b7ef7803e69
R a72e608518946b8cddba99b1913bccc8 R a6e72909415716c47fbdc8c9892a4441
U drh U drh
Z 826c67b7d3493617a37693ae1605b2c3 Z da26ece2df8d0d323ede5e0a841cad93

View File

@@ -1 +1 @@
5df02f50f8348dfde4fc15126abc7b7ef7803e69 c12edb85076d0832e3a0abbbba4d07f3cb5d7f0e

View File

@@ -247,9 +247,10 @@ static int lookupName(
testcase( pNC->ncFlags & NC_PartIdx ); testcase( pNC->ncFlags & NC_PartIdx );
testcase( pNC->ncFlags & NC_IsCheck ); testcase( pNC->ncFlags & NC_IsCheck );
if( (pNC->ncFlags & (NC_PartIdx|NC_IsCheck))!=0 ){ if( (pNC->ncFlags & (NC_PartIdx|NC_IsCheck))!=0 ){
/* Silently ignore database qualifiers inside CHECK constraints and partial /* Silently ignore database qualifiers inside CHECK constraints and
** indices. Do not raise errors because that might break legacy and ** partial indices. Do not raise errors because that might break
** because it does not hurt anything to just ignore the database name. */ ** legacy and because it does not hurt anything to just ignore the
** database name. */
zDb = 0; zDb = 0;
}else{ }else{
for(i=0; i<db->nDb; i++){ for(i=0; i<db->nDb; i++){
@@ -320,7 +321,8 @@ static int lookupName(
if( pMatch ){ if( pMatch ){
pExpr->iTable = pMatch->iCursor; pExpr->iTable = pMatch->iCursor;
pExpr->pTab = pMatch->pTab; pExpr->pTab = pMatch->pTab;
assert( (pMatch->jointype & JT_RIGHT)==0 ); /* RIGHT JOIN not (yet) supported */ /* RIGHT JOIN not (yet) supported */
assert( (pMatch->jointype & JT_RIGHT)==0 );
if( (pMatch->jointype & JT_LEFT)!=0 ){ if( (pMatch->jointype & JT_LEFT)!=0 ){
ExprSetProperty(pExpr, EP_CanBeNull); ExprSetProperty(pExpr, EP_CanBeNull);
} }
@@ -641,7 +643,8 @@ static int resolveExprStep(Walker *pWalker, Expr *pExpr){
pExpr->affinity = SQLITE_AFF_INTEGER; pExpr->affinity = SQLITE_AFF_INTEGER;
break; break;
} }
#endif /* defined(SQLITE_ENABLE_UPDATE_DELETE_LIMIT) && !defined(SQLITE_OMIT_SUBQUERY) */ #endif /* defined(SQLITE_ENABLE_UPDATE_DELETE_LIMIT)
&& !defined(SQLITE_OMIT_SUBQUERY) */
/* A lone identifier is the name of a column. /* A lone identifier is the name of a column.
*/ */
@@ -706,19 +709,20 @@ static int resolveExprStep(Walker *pWalker, Expr *pExpr){
if( n==2 ){ if( n==2 ){
pExpr->iTable = exprProbability(pList->a[1].pExpr); pExpr->iTable = exprProbability(pList->a[1].pExpr);
if( pExpr->iTable<0 ){ if( pExpr->iTable<0 ){
sqlite3ErrorMsg(pParse, "second argument to likelihood() must be a " sqlite3ErrorMsg(pParse,
"second argument to likelihood() must be a "
"constant between 0.0 and 1.0"); "constant between 0.0 and 1.0");
pNC->nErr++; pNC->nErr++;
} }
}else{ }else{
/* EVIDENCE-OF: R-61304-29449 The unlikely(X) function is equivalent to /* EVIDENCE-OF: R-61304-29449 The unlikely(X) function is
** likelihood(X, 0.0625). ** equivalent to likelihood(X, 0.0625).
** EVIDENCE-OF: R-01283-11636 The unlikely(X) function is short-hand for ** EVIDENCE-OF: R-01283-11636 The unlikely(X) function is
** likelihood(X,0.0625). ** short-hand for likelihood(X,0.0625).
** EVIDENCE-OF: R-36850-34127 The likely(X) function is short-hand for ** EVIDENCE-OF: R-36850-34127 The likely(X) function is short-hand
** likelihood(X,0.9375). ** for likelihood(X,0.9375).
** EVIDENCE-OF: R-53436-40973 The likely(X) function is equivalent to ** EVIDENCE-OF: R-53436-40973 The likely(X) function is equivalent
** likelihood(X,0.9375). */ ** to likelihood(X,0.9375). */
/* TUNING: unlikely() probability is 0.0625. likely() is 0.9375 */ /* TUNING: unlikely() probability is 0.0625. likely() is 0.9375 */
pExpr->iTable = pDef->zName[0]=='u' ? 8388608 : 125829120; pExpr->iTable = pDef->zName[0]=='u' ? 8388608 : 125829120;
} }
@@ -735,7 +739,9 @@ static int resolveExprStep(Walker *pWalker, Expr *pExpr){
return WRC_Prune; return WRC_Prune;
} }
#endif #endif
if( pDef->funcFlags & SQLITE_FUNC_CONSTANT ) ExprSetProperty(pExpr,EP_Constant); if( pDef->funcFlags & SQLITE_FUNC_CONSTANT ){
ExprSetProperty(pExpr,EP_Constant);
}
} }
if( is_agg && (pNC->ncFlags & NC_AllowAgg)==0 ){ if( is_agg && (pNC->ncFlags & NC_AllowAgg)==0 ){
sqlite3ErrorMsg(pParse, "misuse of aggregate function %.*s()", nId,zId); sqlite3ErrorMsg(pParse, "misuse of aggregate function %.*s()", nId,zId);
@@ -1046,7 +1052,8 @@ int sqlite3ResolveOrderGroupBy(
resolveOutOfRangeError(pParse, zType, i+1, pEList->nExpr); resolveOutOfRangeError(pParse, zType, i+1, pEList->nExpr);
return 1; return 1;
} }
resolveAlias(pParse, pEList, pItem->u.x.iOrderByCol-1, pItem->pExpr, zType,0); resolveAlias(pParse, pEList, pItem->u.x.iOrderByCol-1, pItem->pExpr,
zType,0);
} }
} }
return 0; return 0;