database/sqlite
1
0
Fork 0
mirror of https://github.com/sqlite/sqlite.git synced 2025-11-14 00:22:38 +03:00
Code Activity

Disable the LEFT JOIN flattening optimization for aggregate queries, as it

Browse Source 
does not currently work.  Further fix for ticket [cad1ab4cb7b0fc344].

FossilOrigin-Name: 44b21e35c92137cc519d0cc87c627cc531d0bd442a7b9a7356fa2c6bc5f70fb6
This commit is contained in:
drh
2017-05-23 15:21:37 +00:00
parent eff0a7b25e
commit 1d1fc5e385
4 changed files with 27 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/select.c
View File

@@ -3301,7 +3301,8 @@ static void substSelect(
** due to ticket [2f7170d73bf9abf80] from 2015-02-09.)
**
** (3) The subquery is not the right operand of a LEFT JOIN
** or the subquery is not itself a join.
** or the subquery is not itself a join and the outer query is not
** an aggregate.
**
** (4) The subquery is not DISTINCT.
**
@@ -3497,11 +3498,16 @@ static int flattenSubquery(
**
** which is not at all the same thing.
**
** If the subquery is the right operand of a LEFT JOIN, then the outer
** query cannot be an aggregate. This is an artifact of the way aggregates
** are processed - there is not mechanism to determine if the LEFT JOIN
** table should be all-NULL.
**
** See also tickets #306, #350, and #3300.
*/
if( (pSubitem->fg.jointype & JT_OUTER)!=0 ){
isLeftJoin = 1;
if( pSubSrc->nSrc>1 ){
if( pSubSrc->nSrc>1 || isAgg ){
return 0; /* Restriction (3) */
}
}