mirror of
https://github.com/facebook/rocksdb.git
synced 2026-10-23 08:09:02 +03:00
Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/15387 ## Summary RocksDB's `.clang-tidy` enables `cppcoreguidelines-special-member-functions`, `cppcoreguidelines-virtual-class-destructor` and the noexcept-move checks, and clang warns `-Wdeprecated-copy-with-user-provided-dtor`. A full scan reports 476 findings. In most of them, a class declares a destructor (or copy operations) but leaves the rest of copy/move implicit. That has two costs. Readers can't tell whether a class may be copied or moved. And resource-owning classes keep an implicit copy that would double-free if anyone ever used it. This diff resolves 453 of the 476. Approach, picked per class from least to most invasive: 1. An empty user-provided destructor becomes `= default`. This covers most interface classes, such as `virtual ~X() {}` -> `= default`. If the class is still copied, that would only rename the deprecated-copy warning, so the destructor is removed instead when nothing needs it (`Customizable`, `TableFactory` and `InternalKeyComparator` inherit a virtual one; `IteratorWrapperBase` isn't polymorphic), and `MemTableRep::KeyComparator` gets defaulted copy and move. 2. Classes whose copy is already deleted get explicitly deleted move operations too. Move was already unavailable, so this only documents it. 3. Resource-owning classes that are never copied get deleted copy and move operations. Examples: the C API wrapper structs, which run a `destructor_` callback (edited in `tools/c_api_gen/c_base.cc` and regenerated into `db/c.cc`); `ShardedCache`, which frees its shards; iterator wrappers; and RAII handles. 4. Value types that are copied or moved get the missing operations as `= default`, which keeps their current behavior. 5. Exception specifications of existing functions are unchanged, except for `WriteBatch`'s move assignment (below): no other `noexcept` is added or removed. Only the move operations this diff newly declares (`Comparator`, `FileSampledStats` and the thread-local `Entry`) are `noexcept`; they copy only scalars or atomics. `WriteBatch`'s copy and move assignment destroyed `*this` and placement-new'ed a new `WriteBatch` over it. That is undefined behavior when `*this` is a subclass, and if the copy constructor threw, `*this` was left destroyed and was later destroyed again. Move assignment now assigns member-wise and ends in the same state as the move constructor, which leaves `has_key_with_ts_`, the timestamp-size tracking and the other fields it doesn't copy at their defaults. `rep_` is swapped through a temporary, because a plain string move-assignment can keep the old buffer (e.g. a large batch reset with `batch = WriteBatch()` would keep its memory). Nothing in it can throw, so it is now `noexcept`. Copy assignment copies into a temporary and moves it in, so a throwing copy leaves `*this` unchanged. Bugs this exposed and fixed: - `RestoreAfterCopyOrCreateWorkItem` (backup engine): the hand-written move constructor and assignment moved only some fields, so `from_file` and `to_file` were empty after `push_back(std::move(...))`. A restore that hit a checksum mismatch then reported "While restoring -> : ..." without file names. It now uses the compiler-generated moves, which are still `noexcept`. - `ExternalSstFileIngestionJob` lived in a `std::vector`, and its destructor frees raw-owned pointers, so the implicit copy used on vector reallocation would double-free. Its file batches also point into its own inline file storage, so neither a copy nor a move is safe after `Prepare()`. Copy and move are now deleted, and `DBImpl` holds jobs through `std::unique_ptr`. Compatibility: no public class loses an operation users can call. Public interfaces mostly only get `virtual ~X() = default;`. `WriteBatch`'s move assignment becomes `noexcept`, which is not part of the mangled name, so the ABI doesn't change. `SubcompactionJobInfo` and `CompactionJobInfo` intentionally stay C++20 aggregates, so users' aggregate and designated initializers keep compiling. `Configurable`, `CompareInterface`, `WriteBatchBase`, `ObjectLibrary::Entry` and `MemTableRep::KeyComparator` declare defaulted copy and move, and `Customizable` no longer declares a destructor. As a result, `Configurable` and `Customizable` subclasses that declare no destructor or copy operations of their own now move their registered-options list instead of copying it. In-tree, these are the mutable-options adapters, the table factories, the memory allocators and test classes; all are held through smart pointers or used in place, and `Clone()` copies, so none is moved by value. Not changed (23): `IODebugContext` (custom deep copy plus a `std::shared_mutex`), `DBWithColumnFamilies` in db_bench (stored in a `std::vector` with non-movable members), `Snapshot`'s protected virtual destructor (intended), `ManagedSnapshot`, the `SubcompactionJobInfo` and `CompactionJobInfo` aggregates, and the 16 noexcept-move-constructor and noexcept-swap findings on existing functions, including `autovector`'s move assignment (adding `noexcept` would change their exception specifications). Copying `ManagedSnapshot` already double-releases the snapshot. Fixing that needs a real move implementation and is a behavior change, so it is left for a separate diff. Reviewed By: rban1 Differential Revision: D123186309 fbshipit-source-id: 6f8e57e233e12199a007407130bb9a1f6d52e8d1
171 lines
5.0 KiB
C++
171 lines
5.0 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
#pragma once
|
|
|
|
#include <functional>
|
|
|
|
#include "util/random.h"
|
|
#include "utilities/persistent_cache/hash_table.h"
|
|
#include "utilities/persistent_cache/lrulist.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// Evictable Hash Table
|
|
//
|
|
// Hash table index where least accessed (or one of the least accessed) elements
|
|
// can be evicted.
|
|
//
|
|
// Please note EvictableHashTable can only be created for pointer type objects
|
|
template <class T, class Hash, class Equal>
|
|
class EvictableHashTable : private HashTable<T*, Hash, Equal> {
|
|
public:
|
|
using hash_table = HashTable<T*, Hash, Equal>;
|
|
|
|
explicit EvictableHashTable(const size_t capacity = 1024 * 1024,
|
|
const float load_factor = 2.0,
|
|
const uint32_t nlocks = 256)
|
|
: HashTable<T*, Hash, Equal>(capacity, load_factor, nlocks),
|
|
lru_lists_(new LRUList<T>[hash_table::nlocks_]) {
|
|
assert(lru_lists_);
|
|
}
|
|
|
|
virtual ~EvictableHashTable() { AssertEmptyLRU(); }
|
|
|
|
// No copying allowed
|
|
EvictableHashTable(const EvictableHashTable&) = delete;
|
|
EvictableHashTable& operator=(const EvictableHashTable&) = delete;
|
|
EvictableHashTable(EvictableHashTable&&) = delete;
|
|
EvictableHashTable& operator=(EvictableHashTable&&) = delete;
|
|
|
|
//
|
|
// Insert given record to hash table (and LRU list)
|
|
//
|
|
bool Insert(T* t) {
|
|
const uint64_t h = Hash()(t);
|
|
typename hash_table::Bucket& bucket = GetBucket(h);
|
|
LRUListType& lru = GetLRUList(h);
|
|
port::RWMutex& lock = GetMutex(h);
|
|
|
|
WriteLock _(&lock);
|
|
if (hash_table::Insert(&bucket, t)) {
|
|
lru.Push(t);
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
//
|
|
// Lookup hash table
|
|
//
|
|
// Please note that read lock should be held by the caller. This is because
|
|
// the caller owns the data, and should hold the read lock as long as he
|
|
// operates on the data.
|
|
bool Find(T* t, T** ret) {
|
|
const uint64_t h = Hash()(t);
|
|
typename hash_table::Bucket& bucket = GetBucket(h);
|
|
LRUListType& lru = GetLRUList(h);
|
|
port::RWMutex& lock = GetMutex(h);
|
|
|
|
ReadLock _(&lock);
|
|
if (hash_table::Find(&bucket, t, ret)) {
|
|
++(*ret)->refs_;
|
|
lru.Touch(*ret);
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
//
|
|
// Evict one of the least recently used object
|
|
//
|
|
T* Evict(const std::function<void(T*)>& fn = nullptr) {
|
|
uint32_t random = Random::GetTLSInstance()->Next();
|
|
const size_t start_idx = random % hash_table::nlocks_;
|
|
T* t = nullptr;
|
|
|
|
// iterate from start_idx .. 0 .. start_idx
|
|
for (size_t i = 0; !t && i < hash_table::nlocks_; ++i) {
|
|
const size_t idx = (start_idx + i) % hash_table::nlocks_;
|
|
|
|
WriteLock _(&hash_table::locks_[idx]);
|
|
LRUListType& lru = lru_lists_[idx];
|
|
if (!lru.IsEmpty() && (t = lru.Pop()) != nullptr) {
|
|
assert(!t->refs_);
|
|
// We got an item to evict, erase from the bucket
|
|
const uint64_t h = Hash()(t);
|
|
typename hash_table::Bucket& bucket = GetBucket(h);
|
|
T* tmp = nullptr;
|
|
bool status = hash_table::Erase(&bucket, t, &tmp);
|
|
assert(t == tmp);
|
|
(void)status;
|
|
assert(status);
|
|
if (fn) {
|
|
fn(t);
|
|
}
|
|
break;
|
|
}
|
|
assert(!t);
|
|
}
|
|
return t;
|
|
}
|
|
|
|
void Clear(void (*fn)(T*)) {
|
|
for (uint32_t i = 0; i < hash_table::nbuckets_; ++i) {
|
|
const uint32_t lock_idx = i % hash_table::nlocks_;
|
|
WriteLock _(&hash_table::locks_[lock_idx]);
|
|
auto& lru_list = lru_lists_[lock_idx];
|
|
auto& bucket = hash_table::buckets_[i];
|
|
for (auto* t : bucket.list_) {
|
|
lru_list.Unlink(t);
|
|
(*fn)(t);
|
|
}
|
|
bucket.list_.clear();
|
|
}
|
|
// make sure that all LRU lists are emptied
|
|
AssertEmptyLRU();
|
|
}
|
|
|
|
void AssertEmptyLRU() {
|
|
#ifndef NDEBUG
|
|
for (uint32_t i = 0; i < hash_table::nlocks_; ++i) {
|
|
WriteLock _(&hash_table::locks_[i]);
|
|
auto& lru_list = lru_lists_[i];
|
|
assert(lru_list.IsEmpty());
|
|
}
|
|
#endif
|
|
}
|
|
|
|
//
|
|
// Fetch the mutex associated with a key
|
|
// This call is used to hold the lock for a given data for extended period of
|
|
// time.
|
|
port::RWMutex* GetMutex(T* t) { return hash_table::GetMutex(t); }
|
|
|
|
private:
|
|
using LRUListType = LRUList<T>;
|
|
|
|
typename hash_table::Bucket& GetBucket(const uint64_t h) {
|
|
const uint32_t bucket_idx = h % hash_table::nbuckets_;
|
|
return hash_table::buckets_[bucket_idx];
|
|
}
|
|
|
|
LRUListType& GetLRUList(const uint64_t h) {
|
|
const uint32_t bucket_idx = h % hash_table::nbuckets_;
|
|
const uint32_t lock_idx = bucket_idx % hash_table::nlocks_;
|
|
return lru_lists_[lock_idx];
|
|
}
|
|
|
|
port::RWMutex& GetMutex(const uint64_t h) {
|
|
const uint32_t bucket_idx = h % hash_table::nbuckets_;
|
|
const uint32_t lock_idx = bucket_idx % hash_table::nlocks_;
|
|
return hash_table::locks_[lock_idx];
|
|
}
|
|
|
|
std::unique_ptr<LRUListType[]> lru_lists_;
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|