mirror of
https://github.com/facebook/rocksdb.git
synced 2026-10-23 08:09:02 +03:00
Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/15387 ## Summary RocksDB's `.clang-tidy` enables `cppcoreguidelines-special-member-functions`, `cppcoreguidelines-virtual-class-destructor` and the noexcept-move checks, and clang warns `-Wdeprecated-copy-with-user-provided-dtor`. A full scan reports 476 findings. In most of them, a class declares a destructor (or copy operations) but leaves the rest of copy/move implicit. That has two costs. Readers can't tell whether a class may be copied or moved. And resource-owning classes keep an implicit copy that would double-free if anyone ever used it. This diff resolves 453 of the 476. Approach, picked per class from least to most invasive: 1. An empty user-provided destructor becomes `= default`. This covers most interface classes, such as `virtual ~X() {}` -> `= default`. If the class is still copied, that would only rename the deprecated-copy warning, so the destructor is removed instead when nothing needs it (`Customizable`, `TableFactory` and `InternalKeyComparator` inherit a virtual one; `IteratorWrapperBase` isn't polymorphic), and `MemTableRep::KeyComparator` gets defaulted copy and move. 2. Classes whose copy is already deleted get explicitly deleted move operations too. Move was already unavailable, so this only documents it. 3. Resource-owning classes that are never copied get deleted copy and move operations. Examples: the C API wrapper structs, which run a `destructor_` callback (edited in `tools/c_api_gen/c_base.cc` and regenerated into `db/c.cc`); `ShardedCache`, which frees its shards; iterator wrappers; and RAII handles. 4. Value types that are copied or moved get the missing operations as `= default`, which keeps their current behavior. 5. Exception specifications of existing functions are unchanged, except for `WriteBatch`'s move assignment (below): no other `noexcept` is added or removed. Only the move operations this diff newly declares (`Comparator`, `FileSampledStats` and the thread-local `Entry`) are `noexcept`; they copy only scalars or atomics. `WriteBatch`'s copy and move assignment destroyed `*this` and placement-new'ed a new `WriteBatch` over it. That is undefined behavior when `*this` is a subclass, and if the copy constructor threw, `*this` was left destroyed and was later destroyed again. Move assignment now assigns member-wise and ends in the same state as the move constructor, which leaves `has_key_with_ts_`, the timestamp-size tracking and the other fields it doesn't copy at their defaults. `rep_` is swapped through a temporary, because a plain string move-assignment can keep the old buffer (e.g. a large batch reset with `batch = WriteBatch()` would keep its memory). Nothing in it can throw, so it is now `noexcept`. Copy assignment copies into a temporary and moves it in, so a throwing copy leaves `*this` unchanged. Bugs this exposed and fixed: - `RestoreAfterCopyOrCreateWorkItem` (backup engine): the hand-written move constructor and assignment moved only some fields, so `from_file` and `to_file` were empty after `push_back(std::move(...))`. A restore that hit a checksum mismatch then reported "While restoring -> : ..." without file names. It now uses the compiler-generated moves, which are still `noexcept`. - `ExternalSstFileIngestionJob` lived in a `std::vector`, and its destructor frees raw-owned pointers, so the implicit copy used on vector reallocation would double-free. Its file batches also point into its own inline file storage, so neither a copy nor a move is safe after `Prepare()`. Copy and move are now deleted, and `DBImpl` holds jobs through `std::unique_ptr`. Compatibility: no public class loses an operation users can call. Public interfaces mostly only get `virtual ~X() = default;`. `WriteBatch`'s move assignment becomes `noexcept`, which is not part of the mangled name, so the ABI doesn't change. `SubcompactionJobInfo` and `CompactionJobInfo` intentionally stay C++20 aggregates, so users' aggregate and designated initializers keep compiling. `Configurable`, `CompareInterface`, `WriteBatchBase`, `ObjectLibrary::Entry` and `MemTableRep::KeyComparator` declare defaulted copy and move, and `Customizable` no longer declares a destructor. As a result, `Configurable` and `Customizable` subclasses that declare no destructor or copy operations of their own now move their registered-options list instead of copying it. In-tree, these are the mutable-options adapters, the table factories, the memory allocators and test classes; all are held through smart pointers or used in place, and `Clone()` copies, so none is moved by value. Not changed (23): `IODebugContext` (custom deep copy plus a `std::shared_mutex`), `DBWithColumnFamilies` in db_bench (stored in a `std::vector` with non-movable members), `Snapshot`'s protected virtual destructor (intended), `ManagedSnapshot`, the `SubcompactionJobInfo` and `CompactionJobInfo` aggregates, and the 16 noexcept-move-constructor and noexcept-swap findings on existing functions, including `autovector`'s move assignment (adding `noexcept` would change their exception specifications). Copying `ManagedSnapshot` already double-releases the snapshot. Fixing that needs a real move implementation and is a behavior change, so it is left for a separate diff. Reviewed By: rban1 Differential Revision: D123186309 fbshipit-source-id: 6f8e57e233e12199a007407130bb9a1f6d52e8d1
242 lines
6.5 KiB
C++
242 lines
6.5 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
#pragma once
|
|
|
|
#include <assert.h>
|
|
|
|
#include <list>
|
|
#include <vector>
|
|
|
|
#ifdef OS_LINUX
|
|
#include <sys/mman.h>
|
|
#endif
|
|
|
|
#include "rocksdb/env.h"
|
|
#include "util/mutexlock.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// HashTable<T, Hash, Equal>
|
|
//
|
|
// Traditional implementation of hash table with synchronization built on top
|
|
// don't perform very well in multi-core scenarios. This is an implementation
|
|
// designed for multi-core scenarios with high lock contention.
|
|
//
|
|
// |<-------- alpha ------------->|
|
|
// Buckets Collision list
|
|
// ---- +----+ +---+---+--- ...... ---+---+---+
|
|
// / | |--->| | | | | |
|
|
// / +----+ +---+---+--- ...... ---+---+---+
|
|
// / | |
|
|
// Locks/ +----+
|
|
// +--+/ . .
|
|
// | | . .
|
|
// +--+ . .
|
|
// | | . .
|
|
// +--+ . .
|
|
// | | . .
|
|
// +--+ . .
|
|
// \ +----+
|
|
// \ | |
|
|
// \ +----+
|
|
// \ | |
|
|
// \---- +----+
|
|
//
|
|
// The lock contention is spread over an array of locks. This helps improve
|
|
// concurrent access. The spine is designed for a certain capacity and load
|
|
// factor. When the capacity planning is done correctly we can expect
|
|
// O(load_factor = 1) insert, access and remove time.
|
|
//
|
|
// Micro benchmark on debug build gives about .5 Million/sec rate of insert,
|
|
// erase and lookup in parallel (total of about 1.5 Million ops/sec). If the
|
|
// blocks were of 4K, the hash table can support a virtual throughput of
|
|
// 6 GB/s.
|
|
//
|
|
// T Object type (contains both key and value)
|
|
// Hash Function that returns an hash from type T
|
|
// Equal Returns if two objects are equal
|
|
// (We need explicit equal for pointer type)
|
|
//
|
|
template <class T, class Hash, class Equal>
|
|
class HashTable {
|
|
public:
|
|
explicit HashTable(const size_t capacity = 1024 * 1024,
|
|
const float load_factor = 2.0, const uint32_t nlocks = 256)
|
|
: nbuckets_(
|
|
static_cast<uint32_t>(load_factor ? capacity / load_factor : 0)),
|
|
nlocks_(nlocks) {
|
|
// pre-conditions
|
|
assert(capacity);
|
|
assert(load_factor);
|
|
assert(nbuckets_);
|
|
assert(nlocks_);
|
|
|
|
buckets_.reset(new Bucket[nbuckets_]);
|
|
#ifdef OS_LINUX
|
|
mlock(buckets_.get(), nbuckets_ * sizeof(Bucket));
|
|
#endif
|
|
|
|
// initialize locks
|
|
locks_.reset(new port::RWMutex[nlocks_]);
|
|
#ifdef OS_LINUX
|
|
mlock(locks_.get(), nlocks_ * sizeof(port::RWMutex));
|
|
#endif
|
|
|
|
// post-conditions
|
|
assert(buckets_);
|
|
assert(locks_);
|
|
}
|
|
|
|
virtual ~HashTable() { AssertEmptyBuckets(); }
|
|
|
|
// No copying allowed
|
|
HashTable(const HashTable&) = delete;
|
|
HashTable& operator=(const HashTable&) = delete;
|
|
HashTable(HashTable&&) = delete;
|
|
HashTable& operator=(HashTable&&) = delete;
|
|
|
|
//
|
|
// Insert given record to hash table
|
|
//
|
|
bool Insert(const T& t) {
|
|
const uint64_t h = Hash()(t);
|
|
const uint32_t bucket_idx = h % nbuckets_;
|
|
const uint32_t lock_idx = bucket_idx % nlocks_;
|
|
|
|
WriteLock _(&locks_[lock_idx]);
|
|
auto& bucket = buckets_[bucket_idx];
|
|
return Insert(&bucket, t);
|
|
}
|
|
|
|
// Lookup hash table
|
|
//
|
|
// Please note that read lock should be held by the caller. This is because
|
|
// the caller owns the data, and should hold the read lock as long as he
|
|
// operates on the data.
|
|
bool Find(const T& t, T* ret, port::RWMutex** ret_lock) {
|
|
const uint64_t h = Hash()(t);
|
|
const uint32_t bucket_idx = h % nbuckets_;
|
|
const uint32_t lock_idx = bucket_idx % nlocks_;
|
|
|
|
port::RWMutex& lock = locks_[lock_idx];
|
|
lock.ReadLock();
|
|
|
|
auto& bucket = buckets_[bucket_idx];
|
|
if (Find(&bucket, t, ret)) {
|
|
*ret_lock = &lock;
|
|
return true;
|
|
}
|
|
|
|
lock.ReadUnlock();
|
|
return false;
|
|
}
|
|
|
|
//
|
|
// Erase a given key from the hash table
|
|
//
|
|
bool Erase(const T& t, T* ret) {
|
|
const uint64_t h = Hash()(t);
|
|
const uint32_t bucket_idx = h % nbuckets_;
|
|
const uint32_t lock_idx = bucket_idx % nlocks_;
|
|
|
|
WriteLock _(&locks_[lock_idx]);
|
|
|
|
auto& bucket = buckets_[bucket_idx];
|
|
return Erase(&bucket, t, ret);
|
|
}
|
|
|
|
// Fetch the mutex associated with a key
|
|
// This call is used to hold the lock for a given data for extended period of
|
|
// time.
|
|
port::RWMutex* GetMutex(const T& t) {
|
|
const uint64_t h = Hash()(t);
|
|
const uint32_t bucket_idx = h % nbuckets_;
|
|
const uint32_t lock_idx = bucket_idx % nlocks_;
|
|
|
|
return &locks_[lock_idx];
|
|
}
|
|
|
|
void Clear(void (*fn)(T)) {
|
|
for (uint32_t i = 0; i < nbuckets_; ++i) {
|
|
const uint32_t lock_idx = i % nlocks_;
|
|
WriteLock _(&locks_[lock_idx]);
|
|
for (auto& t : buckets_[i].list_) {
|
|
(*fn)(t);
|
|
}
|
|
buckets_[i].list_.clear();
|
|
}
|
|
}
|
|
|
|
protected:
|
|
// Models bucket of keys that hash to the same bucket number
|
|
struct Bucket {
|
|
std::list<T> list_;
|
|
};
|
|
|
|
// Substitute for std::find with custom comparator operator
|
|
typename std::list<T>::iterator Find(std::list<T>* list, const T& t) {
|
|
for (auto it = list->begin(); it != list->end(); ++it) {
|
|
if (Equal()(*it, t)) {
|
|
return it;
|
|
}
|
|
}
|
|
return list->end();
|
|
}
|
|
|
|
bool Insert(Bucket* bucket, const T& t) {
|
|
// Check if the key already exists
|
|
auto it = Find(&bucket->list_, t);
|
|
if (it != bucket->list_.end()) {
|
|
return false;
|
|
}
|
|
|
|
// insert to bucket
|
|
bucket->list_.push_back(t);
|
|
return true;
|
|
}
|
|
|
|
bool Find(Bucket* bucket, const T& t, T* ret) {
|
|
auto it = Find(&bucket->list_, t);
|
|
if (it != bucket->list_.end()) {
|
|
if (ret) {
|
|
*ret = *it;
|
|
}
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool Erase(Bucket* bucket, const T& t, T* ret) {
|
|
auto it = Find(&bucket->list_, t);
|
|
if (it != bucket->list_.end()) {
|
|
if (ret) {
|
|
*ret = *it;
|
|
}
|
|
|
|
bucket->list_.erase(it);
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
// assert that all buckets are empty
|
|
void AssertEmptyBuckets() {
|
|
#ifndef NDEBUG
|
|
for (size_t i = 0; i < nbuckets_; ++i) {
|
|
WriteLock _(&locks_[i % nlocks_]);
|
|
assert(buckets_[i].list_.empty());
|
|
}
|
|
#endif
|
|
}
|
|
|
|
const uint32_t nbuckets_; // No. of buckets in the spine
|
|
std::unique_ptr<Bucket[]> buckets_; // Spine of the hash buckets
|
|
const uint32_t nlocks_; // No. of locks
|
|
std::unique_ptr<port::RWMutex[]> locks_; // Granular locks
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|