1
0
mirror of https://github.com/facebook/rocksdb.git synced 2026-10-23 08:09:02 +03:00
Files
rocksdb/utilities/persistent_cache/block_cache_tier_file.h
Josh Kang 4b983da055 Spell out special member functions (rule of five) (#15387)
Summary:
Pull Request resolved: https://github.com/facebook/rocksdb/pull/15387

## Summary

RocksDB's `.clang-tidy` enables `cppcoreguidelines-special-member-functions`,
`cppcoreguidelines-virtual-class-destructor` and the noexcept-move checks,
and clang warns `-Wdeprecated-copy-with-user-provided-dtor`. A full scan
reports 476 findings. In most of them, a class declares a destructor (or
copy operations) but leaves the rest of copy/move implicit. That has two
costs. Readers can't tell whether a class may be copied or moved. And
resource-owning classes keep an implicit copy that would double-free if
anyone ever used it. This diff resolves 453 of the 476.

Approach, picked per class from least to most invasive:
1. An empty user-provided destructor becomes `= default`. This covers most
   interface classes, such as `virtual ~X() {}` -> `= default`. If the
   class is still copied, that would only rename the deprecated-copy
   warning, so the destructor is removed instead when nothing needs it
   (`Customizable`, `TableFactory` and `InternalKeyComparator` inherit a
   virtual one; `IteratorWrapperBase` isn't polymorphic), and
   `MemTableRep::KeyComparator` gets defaulted copy and move.
2. Classes whose copy is already deleted get explicitly deleted move
   operations too. Move was already unavailable, so this only documents
   it.
3. Resource-owning classes that are never copied get deleted copy and move
   operations. Examples: the C API wrapper structs, which run a
   `destructor_` callback (edited in `tools/c_api_gen/c_base.cc` and
   regenerated into `db/c.cc`); `ShardedCache`, which frees its shards;
   iterator wrappers; and RAII handles.
4. Value types that are copied or moved get the missing operations as
   `= default`, which keeps their current behavior.
5. Exception specifications of existing functions are unchanged, except
   for `WriteBatch`'s move assignment (below): no other `noexcept` is
   added or removed. Only the move operations this diff
   newly declares (`Comparator`, `FileSampledStats` and the thread-local
   `Entry`) are `noexcept`; they copy only scalars or atomics.

`WriteBatch`'s copy and move assignment destroyed `*this` and
placement-new'ed a new `WriteBatch` over it. That is undefined behavior
when `*this` is a subclass, and if the copy constructor threw, `*this`
was left destroyed and was later destroyed again. Move assignment now
assigns member-wise and ends in the same state as the move constructor,
which leaves `has_key_with_ts_`, the timestamp-size tracking and the
other fields it doesn't copy at their defaults. `rep_` is swapped through
a temporary, because a plain string move-assignment can keep the old
buffer (e.g. a large batch reset with `batch = WriteBatch()` would keep
its memory). Nothing in it can throw, so it is now `noexcept`. Copy
assignment copies into a temporary and moves it in, so a throwing copy
leaves `*this` unchanged.

Bugs this exposed and fixed:
- `RestoreAfterCopyOrCreateWorkItem` (backup engine): the hand-written
  move constructor and assignment moved only some fields, so `from_file`
  and `to_file` were empty after `push_back(std::move(...))`. A restore
  that hit a checksum mismatch then reported "While restoring  -> : ..."
  without file names. It now uses the compiler-generated moves, which
  are still `noexcept`.
- `ExternalSstFileIngestionJob` lived in a `std::vector`, and its
  destructor frees raw-owned pointers, so the implicit copy used on
  vector reallocation would double-free. Its file batches also point into
  its own inline file storage, so neither a copy nor a move is safe after
  `Prepare()`. Copy and move are now deleted, and `DBImpl` holds jobs
  through `std::unique_ptr`.

Compatibility: no public class loses an operation users can call. Public
interfaces mostly only get `virtual ~X() = default;`.
`WriteBatch`'s move assignment becomes `noexcept`, which is not part of
the mangled name, so the ABI doesn't change.
`SubcompactionJobInfo` and `CompactionJobInfo` intentionally stay C++20
aggregates, so users' aggregate and designated initializers keep
compiling. `Configurable`, `CompareInterface`, `WriteBatchBase`,
`ObjectLibrary::Entry` and `MemTableRep::KeyComparator` declare defaulted
copy and move, and `Customizable` no longer declares a destructor. As a
result, `Configurable` and `Customizable` subclasses that declare no
destructor or copy operations of their own now move their
registered-options list instead of copying it. In-tree, these are the
mutable-options adapters, the table factories, the memory allocators and
test classes; all are held through smart pointers or used in place, and
`Clone()` copies, so none is moved by value.

Not changed (23): `IODebugContext` (custom deep copy plus a
`std::shared_mutex`), `DBWithColumnFamilies` in db_bench (stored in a
`std::vector` with non-movable members), `Snapshot`'s protected virtual
destructor (intended), `ManagedSnapshot`, the `SubcompactionJobInfo` and
`CompactionJobInfo` aggregates, and the 16 noexcept-move-constructor and
noexcept-swap findings on existing functions, including `autovector`'s
move assignment (adding `noexcept` would change their exception
specifications). Copying `ManagedSnapshot` already double-releases the
snapshot. Fixing that needs a real move implementation and is a behavior
change, so it is left for a separate diff.

Reviewed By: rban1

Differential Revision: D123186309

fbshipit-source-id: 6f8e57e233e12199a007407130bb9a1f6d52e8d1
2026-10-12 16:00:09 -07:00

299 lines
10 KiB
C++

// Copyright (c) 2013, Facebook, Inc. All rights reserved.
// This source code is licensed under both the GPLv2 (found in the
// COPYING file in the root directory) and Apache 2.0 License
// (found in the LICENSE.Apache file in the root directory).
#pragma once
#include <list>
#include <memory>
#include <string>
#include <vector>
#include "file/random_access_file_reader.h"
#include "port/port.h"
#include "rocksdb/comparator.h"
#include "rocksdb/env.h"
#include "util/crc32c.h"
#include "util/mutexlock.h"
#include "utilities/persistent_cache/block_cache_tier_file_buffer.h"
#include "utilities/persistent_cache/lrulist.h"
#include "utilities/persistent_cache/persistent_cache_tier.h"
#include "utilities/persistent_cache/persistent_cache_util.h"
// The io code path of persistent cache uses pipelined architecture
//
// client -> In Queue <-- BlockCacheTier --> Out Queue <-- Writer <--> Kernel
//
// This would enable the system to scale for GB/s of throughput which is
// expected with modern devies like NVM.
//
// The file level operations are encapsulated in the following abstractions
//
// BlockCacheFile
// ^
// |
// |
// RandomAccessCacheFile (For reading)
// ^
// |
// |
// WriteableCacheFile (For writing)
//
// Write IO code path :
//
namespace ROCKSDB_NAMESPACE {
class WriteableCacheFile;
struct BlockInfo;
// Represents a logical record on device
//
// (L)ogical (B)lock (Address = { cache-file-id, offset, size }
struct LogicalBlockAddress {
LogicalBlockAddress() {}
explicit LogicalBlockAddress(const uint32_t cache_id, const uint32_t off,
const uint16_t size)
: cache_id_(cache_id), off_(off), size_(size) {}
uint32_t cache_id_ = 0;
uint32_t off_ = 0;
uint32_t size_ = 0;
};
using LBA = LogicalBlockAddress;
// class Writer
//
// Writer is the abstraction used for writing data to file. The component can be
// multithreaded. It is the last step of write pipeline
class Writer {
public:
explicit Writer(PersistentCacheTier* const cache) : cache_(cache) {}
virtual ~Writer() = default;
// write buffer to file at the given offset
virtual void Write(WritableFile* const file, CacheWriteBuffer* buf,
const uint64_t file_off,
const std::function<void()> callback) = 0;
// stop the writer
virtual void Stop() = 0;
PersistentCacheTier* const cache_;
};
// class BlockCacheFile
//
// Generic interface to support building file specialized for read/writing
class BlockCacheFile : public LRUElement<BlockCacheFile> {
public:
explicit BlockCacheFile(const uint32_t cache_id)
: LRUElement<BlockCacheFile>(), cache_id_(cache_id) {}
explicit BlockCacheFile(Env* const env, const std::string& dir,
const uint32_t cache_id)
: LRUElement<BlockCacheFile>(),
env_(env),
dir_(dir),
cache_id_(cache_id) {}
~BlockCacheFile() override = default;
// append key/value to file and return LBA locator to user
virtual bool Append(const Slice& /*key*/, const Slice& /*val*/,
LBA* const /*lba*/) {
assert(false && "not implemented");
return false;
}
// read from the record locator (LBA) and return key, value and status
virtual bool Read(const LBA& /*lba*/, Slice* /*key*/, Slice* /*block*/,
char* /*scratch*/) {
assert(false && "not implemented");
return false;
}
// get file path
std::string Path() const {
return dir_ + "/" + std::to_string(cache_id_) + ".rc";
}
// get cache ID
uint32_t cacheid() const { return cache_id_; }
// Add block information to file data
// Block information is the list of index reference for this file
virtual void Add(BlockInfo* binfo) {
WriteLock _(&rwlock_);
block_infos_.push_back(binfo);
}
// get block information
std::list<BlockInfo*>& block_infos() { return block_infos_; }
// delete file and return the size of the file
virtual Status Delete(uint64_t* size);
protected:
port::RWMutex rwlock_; // synchronization mutex
Env* const env_ = nullptr; // Env for OS
const std::string dir_; // Directory name
const uint32_t cache_id_; // Cache id for the file
std::list<BlockInfo*> block_infos_; // List of index entries mapping to the
// file content
};
// class RandomAccessFile
//
// Thread safe implementation for reading random data from file
class RandomAccessCacheFile : public BlockCacheFile {
public:
explicit RandomAccessCacheFile(Env* const env, const std::string& dir,
const uint32_t cache_id,
const std::shared_ptr<Logger>& log)
: BlockCacheFile(env, dir, cache_id), log_(log) {}
~RandomAccessCacheFile() override = default;
// open file for reading
bool Open(const bool enable_direct_reads);
// read data from the disk
bool Read(const LBA& lba, Slice* key, Slice* block, char* scratch) override;
private:
std::unique_ptr<RandomAccessFileReader> freader_;
protected:
bool OpenImpl(const bool enable_direct_reads);
bool ParseRec(const LBA& lba, Slice* key, Slice* val, char* scratch);
std::shared_ptr<Logger> log_; // log file
};
// class WriteableCacheFile
//
// All writes to the files are cached in buffers. The buffers are flushed to
// disk as they get filled up. When file size reaches a certain size, a new file
// will be created provided there is free space
class WriteableCacheFile : public RandomAccessCacheFile {
public:
explicit WriteableCacheFile(Env* const env, CacheWriteBufferAllocator* alloc,
Writer* writer, const std::string& dir,
const uint32_t cache_id, const uint32_t max_size,
const std::shared_ptr<Logger>& log)
: RandomAccessCacheFile(env, dir, cache_id, log),
alloc_(alloc),
writer_(writer),
max_size_(max_size) {}
~WriteableCacheFile() override;
// create file on disk
bool Create(const bool enable_direct_writes, const bool enable_direct_reads);
// read data from logical file
bool Read(const LBA& lba, Slice* key, Slice* block, char* scratch) override {
ReadLock _(&rwlock_);
const bool closed = eof_ && bufs_.empty();
if (closed) {
// the file is closed, read from disk
return RandomAccessCacheFile::Read(lba, key, block, scratch);
}
// file is still being written, read from buffers
return ReadBuffer(lba, key, block, scratch);
}
// append data to end of file
bool Append(const Slice&, const Slice&, LBA* const) override;
// End-of-file
bool Eof() const { return eof_; }
private:
friend class ThreadedWriter;
static const size_t kFileAlignmentSize = 4 * 1024; // align file size
bool ReadBuffer(const LBA& lba, Slice* key, Slice* block, char* scratch);
bool ReadBuffer(const LBA& lba, char* data);
bool ExpandBuffer(const size_t size);
void DispatchBuffer();
void BufferWriteDone();
void CloseAndOpenForReading();
void ClearBuffers();
void Close();
// File layout in memory
//
// +------+------+------+------+------+------+
// | b0 | b1 | b2 | b3 | b4 | b5 |
// +------+------+------+------+------+------+
// ^ ^
// | |
// buf_doff_ buf_woff_
// (next buffer to (next buffer to fill)
// flush to disk)
//
// The buffers are flushed to disk serially for a given file
CacheWriteBufferAllocator* const alloc_ = nullptr; // Buffer provider
Writer* const writer_ = nullptr; // File writer thread
std::unique_ptr<WritableFile> file_; // RocksDB Env file abstraction
std::vector<CacheWriteBuffer*> bufs_; // Written buffers
uint32_t size_ = 0; // Size of the file
const uint32_t max_size_; // Max size of the file
bool eof_ = false; // End of file
uint32_t disk_woff_ = 0; // Offset to write on disk
size_t buf_woff_ = 0; // off into bufs_ to write
size_t buf_doff_ = 0; // off into bufs_ to dispatch
size_t pending_ios_ = 0; // Number of ios to disk in-progress
bool enable_direct_reads_ = false; // Should we enable direct reads
// when reading from disk
};
//
// Abstraction to do writing to device. It is part of pipelined architecture.
//
class ThreadedWriter : public Writer {
public:
// Representation of IO to device
struct IO {
explicit IO(const bool signal) : signal_(signal) {}
explicit IO(WritableFile* const file, CacheWriteBuffer* const buf,
const uint64_t file_off, const std::function<void()> callback)
: file_(file), buf_(buf), file_off_(file_off), callback_(callback) {}
IO(const IO&) = default;
IO& operator=(const IO&) = default;
IO(IO&&) = default;
IO& operator=(IO&&) = default;
~IO() = default;
size_t Size() const { return sizeof(IO); }
WritableFile* file_ = nullptr; // File to write to
CacheWriteBuffer* buf_ = nullptr; // buffer to write
uint64_t file_off_ = 0; // file offset
bool signal_ = false; // signal to exit thread loop
std::function<void()> callback_; // Callback on completion
};
explicit ThreadedWriter(PersistentCacheTier* const cache, const size_t qdepth,
const size_t io_size);
~ThreadedWriter() override { assert(threads_.empty()); }
// No copying allowed
ThreadedWriter(const ThreadedWriter&) = delete;
ThreadedWriter& operator=(const ThreadedWriter&) = delete;
ThreadedWriter(ThreadedWriter&&) = delete;
ThreadedWriter& operator=(ThreadedWriter&&) = delete;
void Stop() override;
void Write(WritableFile* const file, CacheWriteBuffer* buf,
const uint64_t file_off,
const std::function<void()> callback) override;
private:
void ThreadMain();
void DispatchIO(const IO& io);
const size_t io_size_ = 0;
BoundedQueue<IO> q_;
std::vector<port::Thread> threads_;
};
} // namespace ROCKSDB_NAMESPACE