mirror of
https://github.com/facebook/rocksdb.git
synced 2026-10-23 08:09:02 +03:00
Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/15387 ## Summary RocksDB's `.clang-tidy` enables `cppcoreguidelines-special-member-functions`, `cppcoreguidelines-virtual-class-destructor` and the noexcept-move checks, and clang warns `-Wdeprecated-copy-with-user-provided-dtor`. A full scan reports 476 findings. In most of them, a class declares a destructor (or copy operations) but leaves the rest of copy/move implicit. That has two costs. Readers can't tell whether a class may be copied or moved. And resource-owning classes keep an implicit copy that would double-free if anyone ever used it. This diff resolves 453 of the 476. Approach, picked per class from least to most invasive: 1. An empty user-provided destructor becomes `= default`. This covers most interface classes, such as `virtual ~X() {}` -> `= default`. If the class is still copied, that would only rename the deprecated-copy warning, so the destructor is removed instead when nothing needs it (`Customizable`, `TableFactory` and `InternalKeyComparator` inherit a virtual one; `IteratorWrapperBase` isn't polymorphic), and `MemTableRep::KeyComparator` gets defaulted copy and move. 2. Classes whose copy is already deleted get explicitly deleted move operations too. Move was already unavailable, so this only documents it. 3. Resource-owning classes that are never copied get deleted copy and move operations. Examples: the C API wrapper structs, which run a `destructor_` callback (edited in `tools/c_api_gen/c_base.cc` and regenerated into `db/c.cc`); `ShardedCache`, which frees its shards; iterator wrappers; and RAII handles. 4. Value types that are copied or moved get the missing operations as `= default`, which keeps their current behavior. 5. Exception specifications of existing functions are unchanged, except for `WriteBatch`'s move assignment (below): no other `noexcept` is added or removed. Only the move operations this diff newly declares (`Comparator`, `FileSampledStats` and the thread-local `Entry`) are `noexcept`; they copy only scalars or atomics. `WriteBatch`'s copy and move assignment destroyed `*this` and placement-new'ed a new `WriteBatch` over it. That is undefined behavior when `*this` is a subclass, and if the copy constructor threw, `*this` was left destroyed and was later destroyed again. Move assignment now assigns member-wise and ends in the same state as the move constructor, which leaves `has_key_with_ts_`, the timestamp-size tracking and the other fields it doesn't copy at their defaults. `rep_` is swapped through a temporary, because a plain string move-assignment can keep the old buffer (e.g. a large batch reset with `batch = WriteBatch()` would keep its memory). Nothing in it can throw, so it is now `noexcept`. Copy assignment copies into a temporary and moves it in, so a throwing copy leaves `*this` unchanged. Bugs this exposed and fixed: - `RestoreAfterCopyOrCreateWorkItem` (backup engine): the hand-written move constructor and assignment moved only some fields, so `from_file` and `to_file` were empty after `push_back(std::move(...))`. A restore that hit a checksum mismatch then reported "While restoring -> : ..." without file names. It now uses the compiler-generated moves, which are still `noexcept`. - `ExternalSstFileIngestionJob` lived in a `std::vector`, and its destructor frees raw-owned pointers, so the implicit copy used on vector reallocation would double-free. Its file batches also point into its own inline file storage, so neither a copy nor a move is safe after `Prepare()`. Copy and move are now deleted, and `DBImpl` holds jobs through `std::unique_ptr`. Compatibility: no public class loses an operation users can call. Public interfaces mostly only get `virtual ~X() = default;`. `WriteBatch`'s move assignment becomes `noexcept`, which is not part of the mangled name, so the ABI doesn't change. `SubcompactionJobInfo` and `CompactionJobInfo` intentionally stay C++20 aggregates, so users' aggregate and designated initializers keep compiling. `Configurable`, `CompareInterface`, `WriteBatchBase`, `ObjectLibrary::Entry` and `MemTableRep::KeyComparator` declare defaulted copy and move, and `Customizable` no longer declares a destructor. As a result, `Configurable` and `Customizable` subclasses that declare no destructor or copy operations of their own now move their registered-options list instead of copying it. In-tree, these are the mutable-options adapters, the table factories, the memory allocators and test classes; all are held through smart pointers or used in place, and `Clone()` copies, so none is moved by value. Not changed (23): `IODebugContext` (custom deep copy plus a `std::shared_mutex`), `DBWithColumnFamilies` in db_bench (stored in a `std::vector` with non-movable members), `Snapshot`'s protected virtual destructor (intended), `ManagedSnapshot`, the `SubcompactionJobInfo` and `CompactionJobInfo` aggregates, and the 16 noexcept-move-constructor and noexcept-swap findings on existing functions, including `autovector`'s move assignment (adding `noexcept` would change their exception specifications). Copying `ManagedSnapshot` already double-releases the snapshot. Fixing that needs a real move implementation and is a behavior change, so it is left for a separate diff. Reviewed By: rban1 Differential Revision: D123186309 fbshipit-source-id: 6f8e57e233e12199a007407130bb9a1f6d52e8d1
159 lines
5.4 KiB
C++
159 lines
5.4 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
#pragma once
|
|
|
|
#ifndef OS_WIN
|
|
#include <unistd.h>
|
|
#endif // ! OS_WIN
|
|
|
|
#include <atomic>
|
|
#include <list>
|
|
#include <memory>
|
|
#include <set>
|
|
#include <sstream>
|
|
#include <stdexcept>
|
|
#include <string>
|
|
#include <thread>
|
|
|
|
#include "memory/arena.h"
|
|
#include "memtable/skiplist.h"
|
|
#include "monitoring/histogram.h"
|
|
#include "port/port.h"
|
|
#include "rocksdb/cache.h"
|
|
#include "rocksdb/comparator.h"
|
|
#include "rocksdb/persistent_cache.h"
|
|
#include "rocksdb/system_clock.h"
|
|
#include "util/coding.h"
|
|
#include "util/crc32c.h"
|
|
#include "util/mutexlock.h"
|
|
#include "utilities/persistent_cache/block_cache_tier_file.h"
|
|
#include "utilities/persistent_cache/block_cache_tier_metadata.h"
|
|
#include "utilities/persistent_cache/persistent_cache_util.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
//
|
|
// Block cache tier implementation
|
|
//
|
|
class BlockCacheTier : public PersistentCacheTier {
|
|
public:
|
|
explicit BlockCacheTier(const PersistentCacheConfig& opt)
|
|
: opt_(opt),
|
|
insert_ops_(static_cast<size_t>(opt_.max_write_pipeline_backlog_size)),
|
|
buffer_allocator_(opt.write_buffer_size, opt.write_buffer_count()),
|
|
writer_(this, opt_.writer_qdepth,
|
|
static_cast<size_t>(opt_.writer_dispatch_size)) {
|
|
Info(opt_.log, "Initializing allocator. size=%d B count=%" ROCKSDB_PRIszt,
|
|
opt_.write_buffer_size, opt_.write_buffer_count());
|
|
}
|
|
|
|
~BlockCacheTier() override {
|
|
// Close is re-entrant so we can call close even if it is already closed
|
|
BlockCacheTier::Close().PermitUncheckedError();
|
|
assert(!insert_th_.joinable());
|
|
}
|
|
|
|
// No copying allowed
|
|
BlockCacheTier(const BlockCacheTier&) = delete;
|
|
BlockCacheTier& operator=(const BlockCacheTier&) = delete;
|
|
BlockCacheTier(BlockCacheTier&&) = delete;
|
|
BlockCacheTier& operator=(BlockCacheTier&&) = delete;
|
|
|
|
Status Insert(const Slice& key, const char* data, const size_t size) override;
|
|
Status Lookup(const Slice& key, std::unique_ptr<char[]>* data,
|
|
size_t* size) override;
|
|
Status Open() override;
|
|
Status Close() override;
|
|
bool Erase(const Slice& key) override;
|
|
bool Reserve(const size_t size) override;
|
|
|
|
bool IsCompressed() override { return opt_.is_compressed; }
|
|
|
|
std::string GetPrintableOptions() const override { return opt_.ToString(); }
|
|
|
|
PersistentCache::StatsType Stats() override;
|
|
|
|
void TEST_Flush() override {
|
|
while (insert_ops_.Size()) {
|
|
/* sleep override */
|
|
SystemClock::Default()->SleepForMicroseconds(1000000);
|
|
}
|
|
}
|
|
|
|
private:
|
|
// Percentage of cache to be evicted when the cache is full
|
|
static const size_t kEvictPct = 10;
|
|
// Max attempts to insert key, value to cache in pipelined mode
|
|
static const size_t kMaxRetry = 3;
|
|
|
|
// Pipelined operation
|
|
struct InsertOp {
|
|
explicit InsertOp(const bool signal) : signal_(signal) {}
|
|
explicit InsertOp(std::string&& key, const std::string& data)
|
|
: key_(std::move(key)), data_(data) {}
|
|
~InsertOp() {}
|
|
|
|
InsertOp() = delete;
|
|
InsertOp(InsertOp&& /*rhs*/) = default;
|
|
InsertOp& operator=(InsertOp&& rhs) = default;
|
|
|
|
// used for estimating size by bounded queue
|
|
size_t Size() { return data_.size() + key_.size(); }
|
|
|
|
std::string key_;
|
|
std::string data_;
|
|
bool signal_ = false; // signal to request processing thread to exit
|
|
};
|
|
|
|
// entry point for insert thread
|
|
void InsertMain();
|
|
// insert implementation
|
|
Status InsertImpl(const Slice& key, const Slice& data);
|
|
// Create a new cache file
|
|
Status NewCacheFile();
|
|
// Get cache directory path
|
|
std::string GetCachePath() const { return opt_.path + "/cache"; }
|
|
// Cleanup folder
|
|
Status CleanupCacheFolder(const std::string& folder);
|
|
|
|
// Statistics
|
|
struct Statistics {
|
|
HistogramImpl bytes_pipelined_;
|
|
HistogramImpl bytes_written_;
|
|
HistogramImpl bytes_read_;
|
|
HistogramImpl read_hit_latency_;
|
|
HistogramImpl read_miss_latency_;
|
|
HistogramImpl write_latency_;
|
|
std::atomic<uint64_t> cache_hits_{0};
|
|
std::atomic<uint64_t> cache_misses_{0};
|
|
std::atomic<uint64_t> cache_errors_{0};
|
|
std::atomic<uint64_t> insert_dropped_{0};
|
|
|
|
double CacheHitPct() const {
|
|
const auto lookups = cache_hits_ + cache_misses_;
|
|
return lookups ? 100 * cache_hits_ / static_cast<double>(lookups) : 0.0;
|
|
}
|
|
|
|
double CacheMissPct() const {
|
|
const auto lookups = cache_hits_ + cache_misses_;
|
|
return lookups ? 100 * cache_misses_ / static_cast<double>(lookups) : 0.0;
|
|
}
|
|
};
|
|
|
|
port::RWMutex lock_; // Synchronization
|
|
const PersistentCacheConfig opt_; // BlockCache options
|
|
BoundedQueue<InsertOp> insert_ops_; // Ops waiting for insert
|
|
ROCKSDB_NAMESPACE::port::Thread insert_th_; // Insert thread
|
|
uint32_t writer_cache_id_ = 0; // Current cache file identifier
|
|
WriteableCacheFile* cache_file_ = nullptr; // Current cache file reference
|
|
CacheWriteBufferAllocator buffer_allocator_; // Buffer provider
|
|
ThreadedWriter writer_; // Writer threads
|
|
BlockCacheTierMetadata metadata_; // Cache meta data manager
|
|
std::atomic<uint64_t> size_{0}; // Size of the cache
|
|
Statistics stats_; // Statistics
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|