mirror of
https://github.com/facebook/rocksdb.git
synced 2026-10-23 08:09:02 +03:00
Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/15387 ## Summary RocksDB's `.clang-tidy` enables `cppcoreguidelines-special-member-functions`, `cppcoreguidelines-virtual-class-destructor` and the noexcept-move checks, and clang warns `-Wdeprecated-copy-with-user-provided-dtor`. A full scan reports 476 findings. In most of them, a class declares a destructor (or copy operations) but leaves the rest of copy/move implicit. That has two costs. Readers can't tell whether a class may be copied or moved. And resource-owning classes keep an implicit copy that would double-free if anyone ever used it. This diff resolves 453 of the 476. Approach, picked per class from least to most invasive: 1. An empty user-provided destructor becomes `= default`. This covers most interface classes, such as `virtual ~X() {}` -> `= default`. If the class is still copied, that would only rename the deprecated-copy warning, so the destructor is removed instead when nothing needs it (`Customizable`, `TableFactory` and `InternalKeyComparator` inherit a virtual one; `IteratorWrapperBase` isn't polymorphic), and `MemTableRep::KeyComparator` gets defaulted copy and move. 2. Classes whose copy is already deleted get explicitly deleted move operations too. Move was already unavailable, so this only documents it. 3. Resource-owning classes that are never copied get deleted copy and move operations. Examples: the C API wrapper structs, which run a `destructor_` callback (edited in `tools/c_api_gen/c_base.cc` and regenerated into `db/c.cc`); `ShardedCache`, which frees its shards; iterator wrappers; and RAII handles. 4. Value types that are copied or moved get the missing operations as `= default`, which keeps their current behavior. 5. Exception specifications of existing functions are unchanged, except for `WriteBatch`'s move assignment (below): no other `noexcept` is added or removed. Only the move operations this diff newly declares (`Comparator`, `FileSampledStats` and the thread-local `Entry`) are `noexcept`; they copy only scalars or atomics. `WriteBatch`'s copy and move assignment destroyed `*this` and placement-new'ed a new `WriteBatch` over it. That is undefined behavior when `*this` is a subclass, and if the copy constructor threw, `*this` was left destroyed and was later destroyed again. Move assignment now assigns member-wise and ends in the same state as the move constructor, which leaves `has_key_with_ts_`, the timestamp-size tracking and the other fields it doesn't copy at their defaults. `rep_` is swapped through a temporary, because a plain string move-assignment can keep the old buffer (e.g. a large batch reset with `batch = WriteBatch()` would keep its memory). Nothing in it can throw, so it is now `noexcept`. Copy assignment copies into a temporary and moves it in, so a throwing copy leaves `*this` unchanged. Bugs this exposed and fixed: - `RestoreAfterCopyOrCreateWorkItem` (backup engine): the hand-written move constructor and assignment moved only some fields, so `from_file` and `to_file` were empty after `push_back(std::move(...))`. A restore that hit a checksum mismatch then reported "While restoring -> : ..." without file names. It now uses the compiler-generated moves, which are still `noexcept`. - `ExternalSstFileIngestionJob` lived in a `std::vector`, and its destructor frees raw-owned pointers, so the implicit copy used on vector reallocation would double-free. Its file batches also point into its own inline file storage, so neither a copy nor a move is safe after `Prepare()`. Copy and move are now deleted, and `DBImpl` holds jobs through `std::unique_ptr`. Compatibility: no public class loses an operation users can call. Public interfaces mostly only get `virtual ~X() = default;`. `WriteBatch`'s move assignment becomes `noexcept`, which is not part of the mangled name, so the ABI doesn't change. `SubcompactionJobInfo` and `CompactionJobInfo` intentionally stay C++20 aggregates, so users' aggregate and designated initializers keep compiling. `Configurable`, `CompareInterface`, `WriteBatchBase`, `ObjectLibrary::Entry` and `MemTableRep::KeyComparator` declare defaulted copy and move, and `Customizable` no longer declares a destructor. As a result, `Configurable` and `Customizable` subclasses that declare no destructor or copy operations of their own now move their registered-options list instead of copying it. In-tree, these are the mutable-options adapters, the table factories, the memory allocators and test classes; all are held through smart pointers or used in place, and `Clone()` copies, so none is moved by value. Not changed (23): `IODebugContext` (custom deep copy plus a `std::shared_mutex`), `DBWithColumnFamilies` in db_bench (stored in a `std::vector` with non-movable members), `Snapshot`'s protected virtual destructor (intended), `ManagedSnapshot`, the `SubcompactionJobInfo` and `CompactionJobInfo` aggregates, and the 16 noexcept-move-constructor and noexcept-swap findings on existing functions, including `autovector`'s move assignment (adding `noexcept` would change their exception specifications). Copying `ManagedSnapshot` already double-releases the snapshot. Fixing that needs a real move implementation and is a behavior change, so it is left for a separate diff. Reviewed By: rban1 Differential Revision: D123186309 fbshipit-source-id: 6f8e57e233e12199a007407130bb9a1f6d52e8d1
105 lines
4.0 KiB
C++
105 lines
4.0 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include <atomic>
|
|
|
|
#include "rocksdb/memory_allocator.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
// A memory allocator using new/delete
|
|
class DefaultMemoryAllocator : public MemoryAllocator {
|
|
public:
|
|
static const char* kClassName() { return "DefaultMemoryAllocator"; }
|
|
const char* Name() const override { return kClassName(); }
|
|
void* Allocate(size_t size) override {
|
|
return static_cast<void*>(new char[size]);
|
|
}
|
|
|
|
void Deallocate(void* p) override { delete[] static_cast<char*>(p); }
|
|
};
|
|
|
|
// Base class for a MemoryAllocator. This implementation does nothing
|
|
// and implements the methods in failuse mode (assert if the methods are
|
|
// invoked). Implementations can extend this class and override these methods
|
|
// when they are enabled via compiler switches (e.g., the
|
|
// JeMallocMemoryAllocator can define these methods if ROCKSDB_JEMALLOC is
|
|
// defined at compile time. If compiled in "disabled" mode, this class provides
|
|
// default/failure implementations. If compiled in "enabled" mode, the derived
|
|
// class needs to provide the appopriate "enabled" methods for the "real"
|
|
// implementation. Failure of the "real" implementation to implement ovreride
|
|
// any of these methods will result in an assert failure.
|
|
class BaseMemoryAllocator : public MemoryAllocator {
|
|
public:
|
|
void* Allocate(size_t /*size*/) override {
|
|
assert(false);
|
|
return nullptr;
|
|
}
|
|
|
|
void Deallocate(void* /*p*/) override { assert(false); }
|
|
};
|
|
|
|
// A Wrapped MemoryAllocator. Delegates the memory allcator functions to the
|
|
// wrapped one.
|
|
class MemoryAllocatorWrapper : public MemoryAllocator {
|
|
public:
|
|
// Initialize an MemoryAllocatorWrapper that delegates all calls to *t
|
|
explicit MemoryAllocatorWrapper(const std::shared_ptr<MemoryAllocator>& t);
|
|
~MemoryAllocatorWrapper() override = default;
|
|
|
|
// Return the target to which to forward all calls
|
|
MemoryAllocator* target() const { return target_.get(); }
|
|
// Allocate a block of at least size. Has to be thread-safe.
|
|
void* Allocate(size_t size) override { return target_->Allocate(size); }
|
|
|
|
// Deallocate previously allocated block. Has to be thread-safe.
|
|
void Deallocate(void* p) override { return target_->Deallocate(p); }
|
|
|
|
// Returns the memory size of the block allocated at p. The default
|
|
// implementation that just returns the original allocation_size is fine.
|
|
size_t UsableSize(void* p, size_t allocation_size) const override {
|
|
return target_->UsableSize(p, allocation_size);
|
|
}
|
|
|
|
const Customizable* Inner() const override { return target_.get(); }
|
|
|
|
protected:
|
|
std::shared_ptr<MemoryAllocator> target_;
|
|
};
|
|
|
|
// A memory allocator that counts the number of allocations and deallocations
|
|
// This class is useful if the number of memory allocations/dellocations is
|
|
// important.
|
|
class CountedMemoryAllocator : public MemoryAllocatorWrapper {
|
|
public:
|
|
CountedMemoryAllocator()
|
|
: MemoryAllocatorWrapper(std::make_shared<DefaultMemoryAllocator>()),
|
|
allocations_(0),
|
|
deallocations_(0) {}
|
|
|
|
explicit CountedMemoryAllocator(const std::shared_ptr<MemoryAllocator>& t)
|
|
: MemoryAllocatorWrapper(t), allocations_(0), deallocations_(0) {}
|
|
static const char* kClassName() { return "CountedMemoryAllocator"; }
|
|
const char* Name() const override { return kClassName(); }
|
|
std::string GetId() const override { return std::string(Name()); }
|
|
void* Allocate(size_t size) override {
|
|
allocations_++;
|
|
return MemoryAllocatorWrapper::Allocate(size);
|
|
}
|
|
|
|
void Deallocate(void* p) override {
|
|
deallocations_++;
|
|
MemoryAllocatorWrapper::Deallocate(p);
|
|
}
|
|
uint64_t GetNumAllocations() const { return allocations_; }
|
|
uint64_t GetNumDeallocations() const { return deallocations_; }
|
|
|
|
private:
|
|
std::atomic<uint64_t> allocations_;
|
|
std::atomic<uint64_t> deallocations_;
|
|
};
|
|
} // namespace ROCKSDB_NAMESPACE
|