mirror of
https://github.com/facebook/rocksdb.git
synced 2026-10-23 08:09:02 +03:00
Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/15387 ## Summary RocksDB's `.clang-tidy` enables `cppcoreguidelines-special-member-functions`, `cppcoreguidelines-virtual-class-destructor` and the noexcept-move checks, and clang warns `-Wdeprecated-copy-with-user-provided-dtor`. A full scan reports 476 findings. In most of them, a class declares a destructor (or copy operations) but leaves the rest of copy/move implicit. That has two costs. Readers can't tell whether a class may be copied or moved. And resource-owning classes keep an implicit copy that would double-free if anyone ever used it. This diff resolves 453 of the 476. Approach, picked per class from least to most invasive: 1. An empty user-provided destructor becomes `= default`. This covers most interface classes, such as `virtual ~X() {}` -> `= default`. If the class is still copied, that would only rename the deprecated-copy warning, so the destructor is removed instead when nothing needs it (`Customizable`, `TableFactory` and `InternalKeyComparator` inherit a virtual one; `IteratorWrapperBase` isn't polymorphic), and `MemTableRep::KeyComparator` gets defaulted copy and move. 2. Classes whose copy is already deleted get explicitly deleted move operations too. Move was already unavailable, so this only documents it. 3. Resource-owning classes that are never copied get deleted copy and move operations. Examples: the C API wrapper structs, which run a `destructor_` callback (edited in `tools/c_api_gen/c_base.cc` and regenerated into `db/c.cc`); `ShardedCache`, which frees its shards; iterator wrappers; and RAII handles. 4. Value types that are copied or moved get the missing operations as `= default`, which keeps their current behavior. 5. Exception specifications of existing functions are unchanged, except for `WriteBatch`'s move assignment (below): no other `noexcept` is added or removed. Only the move operations this diff newly declares (`Comparator`, `FileSampledStats` and the thread-local `Entry`) are `noexcept`; they copy only scalars or atomics. `WriteBatch`'s copy and move assignment destroyed `*this` and placement-new'ed a new `WriteBatch` over it. That is undefined behavior when `*this` is a subclass, and if the copy constructor threw, `*this` was left destroyed and was later destroyed again. Move assignment now assigns member-wise and ends in the same state as the move constructor, which leaves `has_key_with_ts_`, the timestamp-size tracking and the other fields it doesn't copy at their defaults. `rep_` is swapped through a temporary, because a plain string move-assignment can keep the old buffer (e.g. a large batch reset with `batch = WriteBatch()` would keep its memory). Nothing in it can throw, so it is now `noexcept`. Copy assignment copies into a temporary and moves it in, so a throwing copy leaves `*this` unchanged. Bugs this exposed and fixed: - `RestoreAfterCopyOrCreateWorkItem` (backup engine): the hand-written move constructor and assignment moved only some fields, so `from_file` and `to_file` were empty after `push_back(std::move(...))`. A restore that hit a checksum mismatch then reported "While restoring -> : ..." without file names. It now uses the compiler-generated moves, which are still `noexcept`. - `ExternalSstFileIngestionJob` lived in a `std::vector`, and its destructor frees raw-owned pointers, so the implicit copy used on vector reallocation would double-free. Its file batches also point into its own inline file storage, so neither a copy nor a move is safe after `Prepare()`. Copy and move are now deleted, and `DBImpl` holds jobs through `std::unique_ptr`. Compatibility: no public class loses an operation users can call. Public interfaces mostly only get `virtual ~X() = default;`. `WriteBatch`'s move assignment becomes `noexcept`, which is not part of the mangled name, so the ABI doesn't change. `SubcompactionJobInfo` and `CompactionJobInfo` intentionally stay C++20 aggregates, so users' aggregate and designated initializers keep compiling. `Configurable`, `CompareInterface`, `WriteBatchBase`, `ObjectLibrary::Entry` and `MemTableRep::KeyComparator` declare defaulted copy and move, and `Customizable` no longer declares a destructor. As a result, `Configurable` and `Customizable` subclasses that declare no destructor or copy operations of their own now move their registered-options list instead of copying it. In-tree, these are the mutable-options adapters, the table factories, the memory allocators and test classes; all are held through smart pointers or used in place, and `Clone()` copies, so none is moved by value. Not changed (23): `IODebugContext` (custom deep copy plus a `std::shared_mutex`), `DBWithColumnFamilies` in db_bench (stored in a `std::vector` with non-movable members), `Snapshot`'s protected virtual destructor (intended), `ManagedSnapshot`, the `SubcompactionJobInfo` and `CompactionJobInfo` aggregates, and the 16 noexcept-move-constructor and noexcept-swap findings on existing functions, including `autovector`'s move assignment (adding `noexcept` would change their exception specifications). Copying `ManagedSnapshot` already double-releases the snapshot. Fixing that needs a real move implementation and is a behavior change, so it is left for a separate diff. Reviewed By: rban1 Differential Revision: D123186309 fbshipit-source-id: 6f8e57e233e12199a007407130bb9a1f6d52e8d1
155 lines
5.0 KiB
C++
155 lines
5.0 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
#pragma once
|
|
#include "monitoring/statistics_impl.h"
|
|
#include "rocksdb/system_clock.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
// Auto-scoped.
|
|
// When statistics is not nullptr, records the measured time into any enabled
|
|
// histograms supplied to the constructor. A histogram argument may be omitted
|
|
// by setting it to Histograms::HISTOGRAM_ENUM_MAX. It is also saved into
|
|
// *elapsed if the pointer is not nullptr and overwrite is true, it will be
|
|
// added to *elapsed if overwrite is false.
|
|
class StopWatch {
|
|
public:
|
|
StopWatch(SystemClock* clock, Statistics* statistics,
|
|
const uint32_t hist_type_1,
|
|
const uint32_t hist_type_2 = Histograms::HISTOGRAM_ENUM_MAX,
|
|
uint64_t* elapsed = nullptr, bool overwrite = true,
|
|
bool delay_enabled = false)
|
|
: clock_(clock),
|
|
statistics_(statistics),
|
|
hist_type_1_(statistics && statistics->HistEnabledForType(hist_type_1)
|
|
? hist_type_1
|
|
: Histograms::HISTOGRAM_ENUM_MAX),
|
|
hist_type_2_(statistics && statistics->HistEnabledForType(hist_type_2)
|
|
? hist_type_2
|
|
: Histograms::HISTOGRAM_ENUM_MAX),
|
|
elapsed_(elapsed),
|
|
overwrite_(overwrite),
|
|
stats_enabled_(statistics &&
|
|
statistics->get_stats_level() >
|
|
StatsLevel::kExceptTimers &&
|
|
(hist_type_1_ != Histograms::HISTOGRAM_ENUM_MAX ||
|
|
hist_type_2_ != Histograms::HISTOGRAM_ENUM_MAX)),
|
|
delay_enabled_(delay_enabled),
|
|
total_delay_(0),
|
|
delay_start_time_(0),
|
|
start_time_((stats_enabled_ || elapsed != nullptr) ? clock->NowMicros()
|
|
: 0) {}
|
|
|
|
// No copying allowed
|
|
StopWatch(const StopWatch&) = delete;
|
|
StopWatch& operator=(const StopWatch&) = delete;
|
|
StopWatch(StopWatch&&) = delete;
|
|
StopWatch& operator=(StopWatch&&) = delete;
|
|
|
|
~StopWatch() {
|
|
if (elapsed_) {
|
|
if (overwrite_) {
|
|
*elapsed_ = clock_->NowMicros() - start_time_;
|
|
} else {
|
|
*elapsed_ += clock_->NowMicros() - start_time_;
|
|
}
|
|
}
|
|
if (elapsed_ && delay_enabled_) {
|
|
*elapsed_ -= total_delay_;
|
|
}
|
|
if (stats_enabled_) {
|
|
const auto time = (elapsed_ != nullptr)
|
|
? *elapsed_
|
|
: (clock_->NowMicros() - start_time_);
|
|
if (hist_type_1_ != Histograms::HISTOGRAM_ENUM_MAX) {
|
|
statistics_->reportTimeToHistogram(hist_type_1_, time);
|
|
}
|
|
if (hist_type_2_ != Histograms::HISTOGRAM_ENUM_MAX) {
|
|
statistics_->reportTimeToHistogram(hist_type_2_, time);
|
|
}
|
|
}
|
|
}
|
|
|
|
void DelayStart() {
|
|
// if delay_start_time_ is not 0, it means we are already tracking delay,
|
|
// so delay_start_time_ should not be overwritten
|
|
if (elapsed_ && delay_enabled_ && delay_start_time_ == 0) {
|
|
delay_start_time_ = clock_->NowMicros();
|
|
}
|
|
}
|
|
|
|
void DelayStop() {
|
|
if (elapsed_ && delay_enabled_ && delay_start_time_ != 0) {
|
|
total_delay_ += clock_->NowMicros() - delay_start_time_;
|
|
}
|
|
// reset to 0 means currently no delay is being tracked, so two consecutive
|
|
// calls to DelayStop will not increase total_delay_
|
|
delay_start_time_ = 0;
|
|
}
|
|
|
|
uint64_t GetDelay() const { return delay_enabled_ ? total_delay_ : 0; }
|
|
|
|
uint64_t start_time() const { return start_time_; }
|
|
|
|
private:
|
|
SystemClock* clock_;
|
|
Statistics* statistics_;
|
|
const uint32_t hist_type_1_;
|
|
const uint32_t hist_type_2_;
|
|
uint64_t* elapsed_;
|
|
bool overwrite_;
|
|
bool stats_enabled_;
|
|
bool delay_enabled_;
|
|
uint64_t total_delay_;
|
|
uint64_t delay_start_time_;
|
|
const uint64_t start_time_;
|
|
};
|
|
|
|
// a nano second precision stopwatch
|
|
template <bool use_cpu_time = false>
|
|
class StopWatchNano {
|
|
public:
|
|
explicit StopWatchNano(SystemClock* clock, bool auto_start = false)
|
|
: clock_(clock), start_(0) {
|
|
if (auto_start) {
|
|
Start();
|
|
}
|
|
}
|
|
void Start() {
|
|
assert(clock_);
|
|
if constexpr (use_cpu_time) {
|
|
start_ = clock_->CPUNanos();
|
|
} else {
|
|
start_ = clock_->NowNanos();
|
|
}
|
|
}
|
|
uint64_t ElapsedNanos(bool reset = false) {
|
|
assert(clock_);
|
|
uint64_t now = 0;
|
|
if constexpr (use_cpu_time) {
|
|
now = clock_->CPUNanos();
|
|
} else {
|
|
now = clock_->NowNanos();
|
|
}
|
|
auto elapsed = now - start_;
|
|
if (reset) {
|
|
start_ = now;
|
|
}
|
|
return elapsed;
|
|
}
|
|
uint64_t ElapsedNanosSafe(bool reset = false) {
|
|
return (clock_ != nullptr) ? ElapsedNanos(reset) : 0U;
|
|
}
|
|
bool IsStarted() { return start_ != 0; }
|
|
uint64_t ElapsedMicros(bool reset = false) {
|
|
return ElapsedNanos(reset) / 1000;
|
|
}
|
|
|
|
private:
|
|
SystemClock* clock_;
|
|
uint64_t start_;
|
|
};
|
|
} // namespace ROCKSDB_NAMESPACE
|