1
0
mirror of https://github.com/facebook/rocksdb.git synced 2026-10-23 08:09:02 +03:00
Files
rocksdb/util/slice_test.cc
Josh Kang 014e1c43c1 Apply readability fixes (isolate decls, braces) (#15394)
Summary:
Pull Request resolved: https://github.com/facebook/rocksdb/pull/15394

## Summary

RocksDB's `.clang-tidy` enables several readability checks that existing
code still violates: `readability-isolate-declaration` (476 findings),
`readability-braces-around-statements` (49),
`readability-redundant-string-init` (25), `modernize-use-using` (10),
`misc-definitions-in-headers` (3) and `readability-duplicate-include`
(1). They keep getting flagged whenever nearby lines change. This diff
fixes 553 of the 564; upstream has since fixed the other 11.

What changed:
- Multi-variable declarations such as `std::string a, b;` are split into
  one declaration per variable. Pointer and reference declarators are kept
  per variable.
- Braces are added around single-statement `if`/`else`/`for`/`while`
  bodies, and empty spin loops get an empty `{}` body.
- `std::string s = ""` / `member("")` initializers are removed.
- Remaining `typedef`s in the touched C++ files become `using`. C headers
  and `extern "C"` code are untouched.
- `inline` is added to non-template function definitions in test headers.
- A duplicate `#include "util/udt_util.h"` in `db_impl.cc` is removed.

These are clang-tidy's own fix-its, applied mechanically and then
clang-formatted on the changed lines. Three kinds of broken fix-it output
were repaired by hand. Removing a `member("")` initializer left a dangling
comma in constructor initializer lists (`ExternalSstFileInfo`,
`ColumnFamilyMetaData` and others). The function-type typedefs in
`block_test.cc` came out malformed. Empty `while (cond);` spin loops got a
`{;` body. Splitting declarations also exposed two vectors in
`db_etc2_test.cc` to `performance-inefficient-vector-operation`, so a
`reserve()` was added for each.

The lint bot reports every finding in a file a diff touches. This diff
splits declarations in `options/configurable_test.cc`, so it also fixes
that file's 14 older `cert-err58-cpp` and
`cppcoreguidelines-avoid-non-const-global-variables` findings, which come
from seven mutable file-level maps. Six are now `const` and built where
they are used (function-local statics, or locals in their only user).
The unused `imm_struct_option_info` is deleted.

Compatibility: no behavior change. In public headers, the only edits are
removed redundant `""` initializers, split declarations and added braces.

Reviewed By: rban1

Differential Revision: D123186310

fbshipit-source-id: f9c8e88b00e997db0196f8725c7c8d880cf798da
2026-10-13 14:06:55 -07:00

905 lines
29 KiB
C++

// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
// This source code is licensed under both the GPLv2 (found in the
// COPYING file in the root directory) and Apache 2.0 License
// (found in the LICENSE.Apache file in the root directory).
// Because there are a small set of tests for Slice and there's a cost in having
// extra test binaries for each component, this test file has evolved into a
// "grab bag" of small tests for various reusable components, mostly in util/.
#include "rocksdb/slice.h"
#include <gtest/gtest.h>
#include <cstdint>
#include <cstring>
#include <new>
#include <semaphore>
#include "port/port.h"
#include "port/stack_trace.h"
#include "rocksdb/data_structure.h"
#include "rocksdb/sst_partitioner.h"
#include "rocksdb/types.h"
#include "test_util/testharness.h"
#include "test_util/testutil.h"
#include "util/bit_fields.h"
#include "util/cast_util.h"
#include "util/semaphore.h"
#include "util/string_util.h"
namespace ROCKSDB_NAMESPACE {
TEST(SliceTest, StringView) {
std::string s = "foo";
std::string_view sv = s;
ASSERT_EQ(Slice(s), Slice(sv));
ASSERT_EQ(Slice(s), Slice(std::move(sv)));
}
// Use this to keep track of the cleanups that were actually performed
void Multiplier(void* arg1, void* arg2) {
int* res = static_cast<int*>(arg1);
int* num = static_cast<int*>(arg2);
*res *= *num;
}
class PinnableSliceTest : public testing::Test {
public:
void AssertSameData(const std::string& expected, const PinnableSlice& slice) {
std::string got;
got.assign(slice.data(), slice.size());
ASSERT_EQ(expected, got);
}
};
// Test that the external buffer is moved instead of being copied.
TEST_F(PinnableSliceTest, MoveExternalBuffer) {
Slice s("123");
std::string buf;
PinnableSlice v1(&buf);
v1.PinSelf(s);
PinnableSlice v2(std::move(v1));
ASSERT_EQ(buf.data(), v2.data());
ASSERT_EQ(&buf, v2.GetSelf());
PinnableSlice v3;
v3 = std::move(v2);
ASSERT_EQ(buf.data(), v3.data());
ASSERT_EQ(&buf, v3.GetSelf());
}
TEST_F(PinnableSliceTest, MoveConstructPinnedThenReuse) {
int n2 = 2;
int res = 1;
Slice s("123");
PinnableSlice v1;
v1.PinSlice(s, Multiplier, &res, &n2);
alignas(PinnableSlice) unsigned char storage[sizeof(PinnableSlice)];
std::memset(storage, 0xab, sizeof(storage));
PinnableSlice* v2 = new (storage) PinnableSlice(std::move(v1));
ASSERT_TRUE(v2->IsPinned());
AssertSameData("123", *v2);
v2->Reset();
ASSERT_EQ(2, res);
v2->PinSelf(Slice("456"));
AssertSameData("456", *v2);
v2->~PinnableSlice();
}
TEST_F(PinnableSliceTest, Move) {
int n2 = 2;
int res = 1;
const std::string const_str1 = "123";
const std::string const_str2 = "ABC";
Slice slice1(const_str1);
Slice slice2(const_str2);
{
// Test move constructor on a pinned slice.
res = 1;
PinnableSlice v1;
v1.PinSlice(slice1, Multiplier, &res, &n2);
PinnableSlice v2(std::move(v1));
// Since v1's Cleanable has been moved to v2,
// no cleanup should happen in Reset.
v1.Reset(); // NOLINT(bugprone-use-after-move)
ASSERT_EQ(1, res);
AssertSameData(const_str1, v2);
}
// v2 is cleaned up.
ASSERT_EQ(2, res);
{
// Test move constructor on an unpinned slice.
PinnableSlice v1;
v1.PinSelf(slice1);
PinnableSlice v2(std::move(v1));
AssertSameData(const_str1, v2);
}
{
// Test move assignment from a pinned slice to
// another pinned slice.
res = 1;
PinnableSlice v1;
v1.PinSlice(slice1, Multiplier, &res, &n2);
PinnableSlice v2;
v2.PinSlice(slice2, Multiplier, &res, &n2);
v2 = std::move(v1);
// v2's Cleanable will be Reset before moving
// anything from v1.
ASSERT_EQ(2, res);
// Since v1's Cleanable has been moved to v2,
// no cleanup should happen in Reset.
v1.Reset(); // NOLINT(bugprone-use-after-move)
ASSERT_EQ(2, res);
AssertSameData(const_str1, v2);
}
// The Cleanable moved from v1 to v2 will be Reset.
ASSERT_EQ(4, res);
{
// Test move assignment from a pinned slice to
// an unpinned slice.
res = 1;
PinnableSlice v1;
v1.PinSlice(slice1, Multiplier, &res, &n2);
PinnableSlice v2;
v2.PinSelf(slice2);
v2 = std::move(v1);
// Since v1's Cleanable has been moved to v2,
// no cleanup should happen in Reset.
v1.Reset(); // NOLINT(bugprone-use-after-move)
ASSERT_EQ(1, res);
AssertSameData(const_str1, v2);
}
// The Cleanable moved from v1 to v2 will be Reset.
ASSERT_EQ(2, res);
{
// Test move assignment from an upinned slice to
// another unpinned slice.
PinnableSlice v1;
v1.PinSelf(slice1);
PinnableSlice v2;
v2.PinSelf(slice2);
v2 = std::move(v1);
AssertSameData(const_str1, v2);
}
{
// Test move assignment from an upinned slice to
// a pinned slice.
res = 1;
PinnableSlice v1;
v1.PinSelf(slice1);
PinnableSlice v2;
v2.PinSlice(slice2, Multiplier, &res, &n2);
v2 = std::move(v1);
// v2's Cleanable will be Reset before moving
// anything from v1.
ASSERT_EQ(2, res);
AssertSameData(const_str1, v2);
}
// No Cleanable is moved from v1 to v2, so no more cleanup.
ASSERT_EQ(2, res);
}
// ***************************************************************** //
// Unit test for SmallEnumSet
class SmallEnumSetTest : public testing::Test {
public:
SmallEnumSetTest() = default;
~SmallEnumSetTest() override = default;
};
TEST_F(SmallEnumSetTest, SmallEnumSetTest1) {
FileTypeSet fs; // based on a legacy enum type
ASSERT_TRUE(fs.empty());
ASSERT_EQ(fs.count(), 0U);
ASSERT_TRUE(fs.Add(FileType::kIdentityFile));
ASSERT_FALSE(fs.empty());
ASSERT_EQ(fs.count(), 1U);
ASSERT_FALSE(fs.Add(FileType::kIdentityFile));
ASSERT_TRUE(fs.Add(FileType::kInfoLogFile));
ASSERT_TRUE(fs.Contains(FileType::kIdentityFile));
ASSERT_FALSE(fs.Contains(FileType::kDBLockFile));
ASSERT_FALSE(fs.empty());
ASSERT_EQ(fs.count(), 2U);
ASSERT_FALSE(fs.Remove(FileType::kDBLockFile));
ASSERT_TRUE(fs.Remove(FileType::kIdentityFile));
ASSERT_FALSE(fs.empty());
ASSERT_EQ(fs.count(), 1U);
ASSERT_TRUE(fs.Remove(FileType::kInfoLogFile));
ASSERT_TRUE(fs.empty());
ASSERT_EQ(fs.count(), 0U);
}
namespace {
enum class MyEnumClass { A, B, C };
} // namespace
using MyEnumClassSet = SmallEnumSet<MyEnumClass, MyEnumClass::C>;
TEST_F(SmallEnumSetTest, SmallEnumSetTest2) {
MyEnumClassSet s; // based on an enum class type
ASSERT_TRUE(s.Add(MyEnumClass::A));
ASSERT_TRUE(s.Contains(MyEnumClass::A));
ASSERT_FALSE(s.Contains(MyEnumClass::B));
ASSERT_TRUE(s.With(MyEnumClass::B).Contains(MyEnumClass::B));
ASSERT_TRUE(s.With(MyEnumClass::A).Contains(MyEnumClass::A));
ASSERT_FALSE(s.Contains(MyEnumClass::B));
ASSERT_FALSE(s.Without(MyEnumClass::A).Contains(MyEnumClass::A));
ASSERT_FALSE(
s.With(MyEnumClass::B).Without(MyEnumClass::B).Contains(MyEnumClass::B));
ASSERT_TRUE(
s.Without(MyEnumClass::B).With(MyEnumClass::B).Contains(MyEnumClass::B));
ASSERT_TRUE(s.Contains(MyEnumClass::A));
const MyEnumClassSet cs = s;
ASSERT_TRUE(cs.Contains(MyEnumClass::A));
ASSERT_EQ(cs, MyEnumClassSet{MyEnumClass::A});
ASSERT_EQ(cs.Without(MyEnumClass::A), MyEnumClassSet{});
ASSERT_EQ(cs, MyEnumClassSet::All().Without(MyEnumClass::B, MyEnumClass::C));
ASSERT_EQ(cs.With(MyEnumClass::B, MyEnumClass::C), MyEnumClassSet::All());
ASSERT_EQ(
MyEnumClassSet::All(),
MyEnumClassSet{}.With(MyEnumClass::A, MyEnumClass::B, MyEnumClass::C));
ASSERT_NE(cs, MyEnumClassSet{MyEnumClass::B});
ASSERT_NE(cs, MyEnumClassSet::All());
ASSERT_EQ(MyEnumClassSet{}.count(), 0U);
ASSERT_EQ(MyEnumClassSet::All().count(), 3U);
int count = 0;
for (MyEnumClass e : cs) {
ASSERT_EQ(e, MyEnumClass::A);
++count;
}
ASSERT_EQ(count, 1);
ASSERT_EQ(cs.count(), 1U);
count = 0;
for (MyEnumClass e : MyEnumClassSet::All().Without(MyEnumClass::B)) {
ASSERT_NE(e, MyEnumClass::B);
++count;
}
ASSERT_EQ(count, 2);
for (MyEnumClass e : MyEnumClassSet{}) {
(void)e;
assert(false);
}
}
template <typename ENUM_TYPE, ENUM_TYPE MAX_ENUMERATOR>
void TestBiggerEnumSet() {
using MySet = SmallEnumSet<ENUM_TYPE, MAX_ENUMERATOR>;
constexpr int kMaxValue = static_cast<int>(MAX_ENUMERATOR);
SCOPED_TRACE("kMaxValue = " + std::to_string(kMaxValue));
ASSERT_EQ(sizeof(MySet), (kMaxValue + 1 + 63) / 64 * 8);
MySet s;
ASSERT_TRUE(s.empty());
ASSERT_EQ(s.count(), 0U);
ASSERT_TRUE(s.Add(ENUM_TYPE(0)));
ASSERT_FALSE(s.empty());
ASSERT_EQ(s.count(), 1U);
ASSERT_TRUE(s.Add(ENUM_TYPE(kMaxValue - 1)));
ASSERT_FALSE(s.empty());
ASSERT_EQ(s.count(), 2U);
ASSERT_TRUE(s.Add(ENUM_TYPE(kMaxValue)));
ASSERT_FALSE(s.empty());
ASSERT_EQ(s.count(), 3U);
int count = 0;
for (ENUM_TYPE e : s) {
ASSERT_TRUE(e == ENUM_TYPE(0) || e == ENUM_TYPE(kMaxValue - 1) ||
e == ENUM_TYPE(kMaxValue));
++count;
}
ASSERT_EQ(count, 3);
ASSERT_TRUE(s.Remove(ENUM_TYPE(0)));
ASSERT_TRUE(s.Remove(ENUM_TYPE(kMaxValue)));
ASSERT_FALSE(s.empty());
ASSERT_EQ(s.count(), 1U);
count = 0;
for (ENUM_TYPE e : s) {
ASSERT_EQ(e, ENUM_TYPE(kMaxValue - 1));
++count;
}
ASSERT_EQ(count, 1);
}
TEST_F(SmallEnumSetTest, BiggerEnumClasses) {
enum class BiggerEnumClass63 { A, B, C = 63 };
enum class BiggerEnumClass64 { A, B, C = 64 };
enum class BiggerEnumClass65 { A, B, C = 65 };
enum class BiggerEnumClass127 { A, B, C = 127 };
enum class BiggerEnumClass128 { A, B, C = 128 };
enum class BiggerEnumClass129 { A, B, C = 129 };
enum class BiggerEnumClass150 { A, B, C = 150 };
enum class BiggerEnumClass255 { A, B, C = 255 };
TestBiggerEnumSet<BiggerEnumClass63, BiggerEnumClass63::C>();
TestBiggerEnumSet<BiggerEnumClass64, BiggerEnumClass64::C>();
TestBiggerEnumSet<BiggerEnumClass65, BiggerEnumClass65::C>();
TestBiggerEnumSet<BiggerEnumClass127, BiggerEnumClass127::C>();
TestBiggerEnumSet<BiggerEnumClass128, BiggerEnumClass128::C>();
TestBiggerEnumSet<BiggerEnumClass129, BiggerEnumClass129::C>();
TestBiggerEnumSet<BiggerEnumClass150, BiggerEnumClass150::C>();
TestBiggerEnumSet<BiggerEnumClass255, BiggerEnumClass255::C>();
}
// ***************************************************************** //
// Unit test for Status
TEST(StatusTest, Update) {
const Status ok = Status::OK();
const Status inc = Status::Incomplete("blah");
const Status notf = Status::NotFound("meow");
Status s = ok;
ASSERT_TRUE(s.UpdateIfOk(Status::Corruption("bad")).IsCorruption());
ASSERT_TRUE(s.IsCorruption());
s = ok;
ASSERT_TRUE(s.UpdateIfOk(Status::OK()).ok());
ASSERT_TRUE(s.UpdateIfOk(ok).ok());
ASSERT_TRUE(s.ok());
ASSERT_TRUE(s.UpdateIfOk(inc).IsIncomplete());
ASSERT_TRUE(s.IsIncomplete());
ASSERT_TRUE(s.UpdateIfOk(notf).IsIncomplete());
ASSERT_TRUE(s.UpdateIfOk(ok).IsIncomplete());
ASSERT_TRUE(s.IsIncomplete());
// Keeps left-most non-OK status
s = ok;
ASSERT_TRUE(
s.UpdateIfOk(Status()).UpdateIfOk(notf).UpdateIfOk(inc).IsNotFound());
ASSERT_TRUE(s.IsNotFound());
}
// ***************************************************************** //
// Unit test for lossless_cast
namespace {
enum class TestEnum8 : uint8_t { kZero = 0, kMax = 255 };
enum TestEnumUnscoped : int { kNegative = -1, kPositive = 1 };
} // namespace
TEST(LosslessCastTest, Values) {
// Signed <-> unsigned of the same size
ASSERT_EQ(lossless_cast<uint8_t>(int8_t{-1}), uint8_t{255});
ASSERT_EQ(lossless_cast<int8_t>(uint8_t{255}), int8_t{-1});
// Widening
ASSERT_EQ(lossless_cast<int64_t>(int16_t{-42}), int64_t{-42});
ASSERT_EQ(lossless_cast<uint64_t>(uint16_t{42}), uint64_t{42});
// Enum <-> underlying type
ASSERT_EQ(lossless_cast<uint8_t>(TestEnum8::kMax), uint8_t{255});
ASSERT_EQ(lossless_cast<TestEnum8>(uint8_t{0}), TestEnum8::kZero);
ASSERT_EQ(lossless_cast<int>(kNegative), -1);
ASSERT_EQ(lossless_cast<TestEnumUnscoped>(1), kPositive);
}
TEST(LosslessCastTest, Pointers) {
// Signed <-> unsigned of the same size
int32_t i = -1;
uint32_t* up = lossless_cast<uint32_t*>(&i);
ASSERT_EQ(*up, uint32_t{0xffffffff});
ASSERT_EQ(lossless_cast<int32_t*>(up), &i);
// Enum type -> underlying type
TestEnum8 e = TestEnum8::kMax;
uint8_t* bp = lossless_cast<uint8_t*>(&e);
ASSERT_EQ(*bp, uint8_t{255});
// Underlying type -> enum type
uint8_t b = 0;
TestEnum8* ep = lossless_cast<TestEnum8*>(&b);
ASSERT_EQ(*ep, TestEnum8::kZero);
// Enum type -> enum type of the same size
ASSERT_EQ(lossless_cast<TestEnum8*>(&e), &e);
// These must not compile:
/*
// Not lossless
lossless_cast<uint64_t*>(&i);
// Not a pointer destination
lossless_cast<uint32_t>(&i);
// Not an integral or enum type
struct Foo {
uint32_t x;
} foo;
lossless_cast<Foo*>(&i);
lossless_cast<uint32_t*>(&foo);
*/
// END must not compile
}
// ***************************************************************** //
// Unit test for UnownedPtr
TEST(UnownedPtrTest, Tests) {
{
int x = 0;
UnownedPtr<int> p(&x);
ASSERT_EQ(p.get(), &x);
ASSERT_EQ(*p, 0);
x = 1;
ASSERT_EQ(*p, 1);
ASSERT_EQ(p.get(), &x);
ASSERT_EQ(*p, 1);
*p = 2;
ASSERT_EQ(x, 2);
ASSERT_EQ(*p, 2);
ASSERT_EQ(p.get(), &x);
ASSERT_EQ(*p, 2);
}
{
std::unique_ptr<std::pair<int, int>> u =
std::make_unique<std::pair<int, int>>();
*u = {1, 2};
UnownedPtr<std::pair<int, int>> p;
ASSERT_FALSE(p);
p = u.get();
ASSERT_TRUE(p);
ASSERT_EQ(p->first, 1);
// These must not compile:
/*
u = p;
u = std::move(p);
std::unique_ptr<std::pair<int, int>> v{p};
std::unique_ptr<std::pair<int, int>> v{std::move(p)};
*/
// END must not compile
UnownedPtr<std::pair<int, int>> q;
q = std::move(p);
ASSERT_EQ(q->first, 1);
// Not committing to any moved-from semantics (on p here)
}
{
std::shared_ptr<std::pair<int, int>> s =
std::make_shared<std::pair<int, int>>();
*s = {1, 2};
UnownedPtr<std::pair<int, int>> p;
ASSERT_FALSE(p);
p = s.get();
ASSERT_TRUE(p);
ASSERT_EQ(p->first, 1);
// These must not compile:
/*
s = p;
s = std::move(p);
std::unique_ptr<std::pair<int, int>> t{p};
std::unique_ptr<std::pair<int, int>> t{std::move(p)};
*/
// END must not compile
UnownedPtr<std::pair<int, int>> q;
q = std::move(p);
ASSERT_EQ(q->first, 1);
// Not committing to any moved-from semantics (on p here)
}
}
TEST(ToBaseCharsStringTest, Tests) {
using ROCKSDB_NAMESPACE::ToBaseCharsString;
// Base 16
ASSERT_EQ(ToBaseCharsString<16>(5, 0, true), "00000");
ASSERT_EQ(ToBaseCharsString<16>(5, 42, true), "0002A");
ASSERT_EQ(ToBaseCharsString<16>(5, 42, false), "0002a");
ASSERT_EQ(ToBaseCharsString<16>(2, 255, false), "ff");
// Base 32
ASSERT_EQ(ToBaseCharsString<32>(2, 255, false), "7v");
}
TEST(SemaphoreTest, CountingSemaphore) {
CountingSemaphore sem{0};
int kCount = 5;
std::vector<std::thread> threads;
for (int i = 0; i < kCount; ++i) {
threads.emplace_back([&sem] { sem.Release(); });
}
for (int i = 0; i < kCount; ++i) {
threads.emplace_back([&sem] { sem.Acquire(); });
}
for (auto& t : threads) {
t.join();
}
// Nothing left on the semaphore
ASSERT_FALSE(sem.TryAcquire());
// Keep testing
sem.Release(2);
ASSERT_TRUE(sem.TryAcquire());
sem.Acquire();
ASSERT_FALSE(sem.TryAcquire());
}
TEST(SemaphoreTest, BinarySemaphore) {
BinarySemaphore sem{0};
int kCount = 5;
std::vector<std::thread> threads;
for (int i = 0; i < kCount; ++i) {
threads.emplace_back([&sem] {
sem.Acquire();
sem.Release();
});
}
threads.emplace_back([&sem] { sem.Release(); });
for (auto& t : threads) {
t.join();
}
// Only able to acquire one excess release
ASSERT_TRUE(sem.TryAcquire());
ASSERT_FALSE(sem.TryAcquire());
}
TEST(BitFieldsTest, BitFields) {
// Start by verifying example from BitFields comment
struct MyState : public BitFields<uint32_t, MyState> {
// Extra helper declarations and/or field type declarations
};
using Field1 = UnsignedBitField<MyState, 16, NoPrevBitField>;
using Field2 = BoolBitField<MyState, Field1>;
using Field3 = BoolBitField<MyState, Field2>;
using Field4 = UnsignedBitField<MyState, 5, Field3>;
// MyState{} is zero-initialized
auto state = MyState{}.With<Field1>(42U).With<Field2>(true);
state.Set<Field4>(3U);
state.Ref<Field1>() += state.Get<Field4>();
ASSERT_EQ(state.Get<Field1>(), 45U);
ASSERT_EQ(state.Get<Field2>(), true);
ASSERT_EQ(state.Get<Field3>(), false);
ASSERT_EQ(state.Get<Field4>(), 3U);
// Misc operators
auto ref = state.Ref<Field3>();
auto ref2 = std::move(ref);
ref2 = true;
ASSERT_EQ(state.Get<Field3>(), true);
MyState state2;
// Basic non-concurrent tests for atomic wrappers
{
RelaxedBitFieldsAtomic<MyState> relaxed{state};
ASSERT_EQ(state, relaxed.LoadRelaxed());
relaxed.StoreRelaxed(state2);
ASSERT_EQ(state2, relaxed.LoadRelaxed());
MyState state3 = relaxed.ExchangeRelaxed(state);
ASSERT_EQ(state2, state3);
ASSERT_TRUE(relaxed.CasStrongRelaxed(state, state2));
while (!relaxed.CasWeakRelaxed(state2, state)) {
}
ASSERT_EQ(state2, state3);
ASSERT_EQ(state, relaxed.LoadRelaxed());
auto transform1 = Field2::ClearTransform() + Field3::ClearTransform();
MyState before;
MyState after;
relaxed.ApplyRelaxed(transform1, &before, &after);
ASSERT_EQ(before, state);
ASSERT_NE(after, state);
ASSERT_EQ(after.Get<Field2>(), false);
ASSERT_EQ(after.Get<Field3>(), false);
auto transform2 = Field2::SetTransform() + Field3::SetTransform();
relaxed.ApplyRelaxed(transform2, &before, &after);
ASSERT_NE(before, state);
ASSERT_EQ(before.Get<Field2>(), false);
ASSERT_EQ(before.Get<Field3>(), false);
ASSERT_EQ(after, state);
ASSERT_EQ(state.Get<Field1>(), 45U);
ASSERT_EQ(after.Get<Field2>(), true);
ASSERT_EQ(after.Get<Field3>(), true);
ASSERT_EQ(state.Get<Field4>(), 3U);
auto transform3 = Field1::PlusTransformPromiseNoOverflow(10000U) +
Field4::MinusTransformPromiseNoUnderflow(3U);
relaxed.ApplyRelaxed(transform3, &before, &after);
ASSERT_EQ(before, state);
ASSERT_NE(after, state);
ASSERT_EQ(after.Get<Field1>(), 10045U);
ASSERT_EQ(after.Get<Field4>(), 0U);
auto transform4 = Field1::MinusTransformPromiseNoUnderflow(999U) +
Field4::PlusTransformPromiseNoOverflow(31U);
relaxed.ApplyRelaxed(transform4, &before, &after);
ASSERT_EQ(after.Get<Field1>(), 9046U);
ASSERT_EQ(after.Get<Field4>(), 31U);
// Unmodified
ASSERT_EQ(after.Get<Field2>(), true);
ASSERT_EQ(after.Get<Field3>(), true);
// Test overflow/underflow detection
relaxed.StoreRelaxed(MyState{}.With<Field1>(65535U)); // Field1 max value
ASSERT_TESTABLE_FAILURE(
relaxed.ApplyRelaxed(Field1::PlusTransformPromiseNoOverflow(1U)));
relaxed.StoreRelaxed(MyState{}.With<Field4>(31U)); // Field4 max value
ASSERT_TESTABLE_FAILURE(
relaxed.ApplyRelaxed(Field4::PlusTransformPromiseNoOverflow(1U)));
relaxed.StoreRelaxed(MyState{}.With<Field1>(0U));
ASSERT_TESTABLE_FAILURE(
relaxed.ApplyRelaxed(Field1::MinusTransformPromiseNoUnderflow(1U)));
relaxed.StoreRelaxed(MyState{}.With<Field4>(0U));
ASSERT_TESTABLE_FAILURE(
relaxed.ApplyRelaxed(Field4::MinusTransformPromiseNoUnderflow(1U)));
ASSERT_TESTABLE_FAILURE(relaxed.ApplyRelaxed(
Field4::MinusTransformPromiseNoUnderflow(64U))); // Too big
ASSERT_TESTABLE_FAILURE(relaxed.ApplyRelaxed(
Field4::PlusTransformPromiseNoOverflow(64U))); // Too big
// Including combinations
relaxed.StoreRelaxed(MyState{}.With<Field4>(31U)); // Field4 max value
relaxed.StoreRelaxed(MyState{}.With<Field1>(0U));
ASSERT_TESTABLE_FAILURE(
relaxed.ApplyRelaxed(Field4::PlusTransformPromiseNoOverflow(1U) +
Field1::MinusTransformPromiseNoUnderflow(1U)));
// But a field at the limit of upper bits is allowed to over/underflow
using Field5 = UnsignedBitField<MyState, 9, Field4>;
relaxed.StoreRelaxed(MyState{}.With<Field5>(0)); // Field5 max value
relaxed.ApplyRelaxed(Field5::MinusTransformIgnoreUnderflow(1U), &before,
&after); // "Safe" underflow
ASSERT_EQ(after.Get<Field5>(), 511U);
relaxed.ApplyRelaxed(Field5::PlusTransformIgnoreOverflow(1U), &before,
&after); // "Safe" overflow
ASSERT_EQ(after.Get<Field5>(), 0U);
relaxed.ApplyRelaxed(Field5::PlusTransformIgnoreOverflow(2048U), &before,
&after); // "Safe" overflow
ASSERT_EQ(after.Get<Field5>(), 0U);
}
{
BitFieldsAtomic<MyState> acqrel{state};
ASSERT_EQ(state, acqrel.Load());
acqrel.Store(state2);
ASSERT_EQ(state2, acqrel.Load());
MyState state3 = acqrel.Exchange(state);
ASSERT_EQ(state2, state3);
ASSERT_TRUE(acqrel.CasStrong(state, state2));
while (!acqrel.CasWeak(state2, state)) {
}
ASSERT_EQ(state2, state3);
ASSERT_EQ(state, acqrel.Load());
auto transform1 = Field2::ClearTransform() + Field3::ClearTransform();
MyState before;
MyState after;
acqrel.Apply(transform1, &before, &after);
ASSERT_EQ(before, state);
ASSERT_NE(after, state);
ASSERT_EQ(after.Get<Field2>(), false);
ASSERT_EQ(after.Get<Field3>(), false);
auto transform2 = Field2::SetTransform() + Field3::SetTransform();
acqrel.Apply(transform2, &before, &after);
ASSERT_NE(before, state);
ASSERT_EQ(before.Get<Field2>(), false);
ASSERT_EQ(before.Get<Field3>(), false);
ASSERT_EQ(after, state);
ASSERT_EQ(state.Get<Field1>(), 45U);
ASSERT_EQ(after.Get<Field2>(), true);
ASSERT_EQ(after.Get<Field3>(), true);
ASSERT_EQ(state.Get<Field4>(), 3U);
auto transform2a = Field2::And(true) + Field3::And(false);
acqrel.Apply(transform2a, &before, &after);
ASSERT_EQ(after.Get<Field2>(), true);
ASSERT_EQ(after.Get<Field3>(), false);
auto transform2b = Field2::And(false) + Field3::And(true);
acqrel.Apply(transform2b, &before, &after);
ASSERT_EQ(after.Get<Field2>(), false);
ASSERT_EQ(after.Get<Field3>(), false);
auto transform2c = Field2::Or(true) + Field3::Or(false);
acqrel.Apply(transform2c, &before, &after);
ASSERT_EQ(after.Get<Field2>(), true);
ASSERT_EQ(after.Get<Field3>(), false);
auto transform2d = Field2::Or(false) + Field3::Or(true);
acqrel.Apply(transform2d, &before, &after);
ASSERT_EQ(after.Get<Field2>(), true);
ASSERT_EQ(after.Get<Field3>(), true);
ASSERT_EQ(state.Get<Field1>(), 45U);
ASSERT_EQ(state.Get<Field4>(), 3U);
auto transform3 = Field1::PlusTransformPromiseNoOverflow(10000U) +
Field4::MinusTransformPromiseNoUnderflow(3U);
acqrel.Apply(transform3, &before, &after);
ASSERT_EQ(before, state);
ASSERT_NE(after, state);
ASSERT_EQ(after.Get<Field1>(), 10045U);
ASSERT_EQ(after.Get<Field4>(), 0U);
auto transform4 = Field1::MinusTransformPromiseNoUnderflow(999U) +
Field4::PlusTransformPromiseNoOverflow(31U);
acqrel.Apply(transform4, &before, &after);
ASSERT_EQ(after.Get<Field1>(), 9046U);
ASSERT_EQ(after.Get<Field4>(), 31U);
auto transform4a =
Field1::AndTransform(8192U + 4096U) + Field4::AndTransform(15U);
acqrel.Apply(transform4a, &before, &after);
ASSERT_EQ(after.Get<Field1>(), 8192U);
ASSERT_EQ(after.Get<Field4>(), 15U);
auto transform4b = Field1::OrTransform(127U) + Field4::OrTransform(16U);
acqrel.Apply(transform4b, &before, &after);
ASSERT_EQ(after.Get<Field1>(), 8192U + 127U);
ASSERT_EQ(after.Get<Field4>(), 31U);
// Unmodified
ASSERT_EQ(after.Get<Field2>(), true);
ASSERT_EQ(after.Get<Field3>(), true);
// Test overflow/underflow detection
acqrel.Store(MyState{}.With<Field1>(65535U));
ASSERT_TESTABLE_FAILURE(
acqrel.Apply(Field1::PlusTransformPromiseNoOverflow(1U)));
acqrel.Store(MyState{}.With<Field4>(0U));
ASSERT_TESTABLE_FAILURE(
acqrel.Apply(Field4::MinusTransformPromiseNoUnderflow(1U)));
}
}
namespace {
// Whether the fixed-prefix partitioner cuts a new file between `prev` and
// `cur`.
bool FixedPrefixShouldPartition(SstPartitionerFixedPrefix& partitioner,
const Slice& prev, const Slice& cur) {
return partitioner.ShouldPartition(PartitionerRequest(
prev, cur, /*current_output_file_size=*/0)) == kRequired;
}
// Given the prefix returned by ShouldPartitionByPrefix for some start key,
// decide whether the transition to `next` requests a partition, per the
// documented prefix contract (only meaningful when the prefix has a value).
bool PrefixImpliesPartition(const Slice& prefix, const Slice& next) {
if (next.size() < prefix.size()) {
return true;
}
return Slice(next.data(), prefix.size()).compare(prefix) != 0;
}
} // namespace
TEST(SstPartitionerFixedPrefixTest, ShouldPartition) {
struct Case {
size_t len;
std::string prev;
std::string cur;
bool partition;
};
const Case kCases[] = {
// len 0 never partitions
{0, "", "", false},
{0, "abc", "xyz", false},
// equal prefixes -> no partition (differences beyond the prefix ignored)
{4, "abcd", "abcd", false},
{4, "abcd1", "abcd2", false},
{3, "abcX", "abcY", false},
// differences within the prefix -> partition
{4, "abcd", "abce", true},
{4, "abc1zzz", "abc2zzz", true},
// short keys (shorter than len are used as-is)
{4, "ab", "ab", false}, // identical short keys
{4, "ab", "abc", true}, // short vs longer sharing leading bytes
{4, "abc", "ab", true}, // longer vs short
{4, "ab", "ac", true}, // short, differing
{4, "", "a", true}, // empty vs non-empty
{4, "", "", false}, // empty vs empty
};
for (const auto& c : kCases) {
SCOPED_TRACE("len=" + std::to_string(c.len) + " prev=" + c.prev +
" cur=" + c.cur);
SstPartitionerFixedPrefix partitioner(c.len);
EXPECT_EQ(FixedPrefixShouldPartition(partitioner, c.prev, c.cur),
c.partition);
// The decision is symmetric in prev/cur for this partitioner.
EXPECT_EQ(FixedPrefixShouldPartition(partitioner, c.cur, c.prev),
c.partition);
}
}
TEST(SstPartitionerFixedPrefixTest, ShouldPartitionByPrefix) {
// len 0: present but empty prefix, meaning "no further partitions".
{
SstPartitionerFixedPrefix partitioner(0);
std::string key = "anything";
OptSlice r = partitioner.ShouldPartitionByPrefix(key);
ASSERT_TRUE(r.has_value());
EXPECT_EQ(r->size(), 0u);
}
// key longer than len: the len-byte prefix, as a view into the key.
{
SstPartitionerFixedPrefix partitioner(3);
std::string key = "abcdef";
OptSlice r = partitioner.ShouldPartitionByPrefix(key);
ASSERT_TRUE(r.has_value());
EXPECT_EQ(*r, Slice("abc"));
EXPECT_EQ(r->data(), key.data()); // does not copy
}
// key exactly len: the whole key.
{
SstPartitionerFixedPrefix partitioner(3);
std::string key = "abc";
OptSlice r = partitioner.ShouldPartitionByPrefix(key);
ASSERT_TRUE(r.has_value());
EXPECT_EQ(*r, Slice("abc"));
}
// key shorter than len: no value (cannot be represented as a prefix).
{
SstPartitionerFixedPrefix partitioner(4);
EXPECT_FALSE(partitioner.ShouldPartitionByPrefix("ab").has_value());
EXPECT_FALSE(partitioner.ShouldPartitionByPrefix("").has_value());
}
}
// Whenever ShouldPartitionByPrefix returns a prefix, using that prefix to
// decide partitioning must match calling ShouldPartition on every transition.
TEST(SstPartitionerFixedPrefixTest, PrefixConsistentWithShouldPartition) {
const std::string kKeys[] = {"", "a", "ab", "abc", "abcd", "abce",
"abcz", "abcdef", "abd", "b", "xyz", "abcde"};
for (size_t len : {size_t{0}, size_t{1}, size_t{3}, size_t{4}, size_t{8}}) {
SstPartitionerFixedPrefix partitioner(len);
for (const std::string& start : kKeys) {
OptSlice prefix = partitioner.ShouldPartitionByPrefix(start);
if (!prefix.has_value()) {
// Contract allows deferring to ShouldPartition; nothing to cross-check.
continue;
}
for (const std::string& next : kKeys) {
SCOPED_TRACE("len=" + std::to_string(len) + " start=" + start +
" next=" + next);
EXPECT_EQ(PrefixImpliesPartition(*prefix, next),
FixedPrefixShouldPartition(partitioner, start, next));
}
}
}
}
TEST(SstPartitionerFixedPrefixTest, CanDoTrivialMove) {
{
SstPartitionerFixedPrefix partitioner(3);
EXPECT_TRUE(partitioner.CanDoTrivialMove("abc1", "abc2")); // same prefix
EXPECT_FALSE(partitioner.CanDoTrivialMove("abc", "abd")); // differ
}
{
SstPartitionerFixedPrefix partitioner(0);
EXPECT_TRUE(partitioner.CanDoTrivialMove("abc", "xyz")); // len 0
}
}
} // namespace ROCKSDB_NAMESPACE
int main(int argc, char** argv) {
ROCKSDB_NAMESPACE::port::InstallStackTraceHandler();
::testing::InitGoogleTest(&argc, argv);
return RUN_ALL_TESTS();
}