mirror of
https://github.com/facebook/rocksdb.git
synced 2026-10-27 20:33:15 +03:00
Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/15387 ## Summary RocksDB's `.clang-tidy` enables `cppcoreguidelines-special-member-functions`, `cppcoreguidelines-virtual-class-destructor` and the noexcept-move checks, and clang warns `-Wdeprecated-copy-with-user-provided-dtor`. A full scan reports 476 findings. In most of them, a class declares a destructor (or copy operations) but leaves the rest of copy/move implicit. That has two costs. Readers can't tell whether a class may be copied or moved. And resource-owning classes keep an implicit copy that would double-free if anyone ever used it. This diff resolves 453 of the 476. Approach, picked per class from least to most invasive: 1. An empty user-provided destructor becomes `= default`. This covers most interface classes, such as `virtual ~X() {}` -> `= default`. If the class is still copied, that would only rename the deprecated-copy warning, so the destructor is removed instead when nothing needs it (`Customizable`, `TableFactory` and `InternalKeyComparator` inherit a virtual one; `IteratorWrapperBase` isn't polymorphic), and `MemTableRep::KeyComparator` gets defaulted copy and move. 2. Classes whose copy is already deleted get explicitly deleted move operations too. Move was already unavailable, so this only documents it. 3. Resource-owning classes that are never copied get deleted copy and move operations. Examples: the C API wrapper structs, which run a `destructor_` callback (edited in `tools/c_api_gen/c_base.cc` and regenerated into `db/c.cc`); `ShardedCache`, which frees its shards; iterator wrappers; and RAII handles. 4. Value types that are copied or moved get the missing operations as `= default`, which keeps their current behavior. 5. Exception specifications of existing functions are unchanged, except for `WriteBatch`'s move assignment (below): no other `noexcept` is added or removed. Only the move operations this diff newly declares (`Comparator`, `FileSampledStats` and the thread-local `Entry`) are `noexcept`; they copy only scalars or atomics. `WriteBatch`'s copy and move assignment destroyed `*this` and placement-new'ed a new `WriteBatch` over it. That is undefined behavior when `*this` is a subclass, and if the copy constructor threw, `*this` was left destroyed and was later destroyed again. Move assignment now assigns member-wise and ends in the same state as the move constructor, which leaves `has_key_with_ts_`, the timestamp-size tracking and the other fields it doesn't copy at their defaults. `rep_` is swapped through a temporary, because a plain string move-assignment can keep the old buffer (e.g. a large batch reset with `batch = WriteBatch()` would keep its memory). Nothing in it can throw, so it is now `noexcept`. Copy assignment copies into a temporary and moves it in, so a throwing copy leaves `*this` unchanged. Bugs this exposed and fixed: - `RestoreAfterCopyOrCreateWorkItem` (backup engine): the hand-written move constructor and assignment moved only some fields, so `from_file` and `to_file` were empty after `push_back(std::move(...))`. A restore that hit a checksum mismatch then reported "While restoring -> : ..." without file names. It now uses the compiler-generated moves, which are still `noexcept`. - `ExternalSstFileIngestionJob` lived in a `std::vector`, and its destructor frees raw-owned pointers, so the implicit copy used on vector reallocation would double-free. Its file batches also point into its own inline file storage, so neither a copy nor a move is safe after `Prepare()`. Copy and move are now deleted, and `DBImpl` holds jobs through `std::unique_ptr`. Compatibility: no public class loses an operation users can call. Public interfaces mostly only get `virtual ~X() = default;`. `WriteBatch`'s move assignment becomes `noexcept`, which is not part of the mangled name, so the ABI doesn't change. `SubcompactionJobInfo` and `CompactionJobInfo` intentionally stay C++20 aggregates, so users' aggregate and designated initializers keep compiling. `Configurable`, `CompareInterface`, `WriteBatchBase`, `ObjectLibrary::Entry` and `MemTableRep::KeyComparator` declare defaulted copy and move, and `Customizable` no longer declares a destructor. As a result, `Configurable` and `Customizable` subclasses that declare no destructor or copy operations of their own now move their registered-options list instead of copying it. In-tree, these are the mutable-options adapters, the table factories, the memory allocators and test classes; all are held through smart pointers or used in place, and `Clone()` copies, so none is moved by value. Not changed (23): `IODebugContext` (custom deep copy plus a `std::shared_mutex`), `DBWithColumnFamilies` in db_bench (stored in a `std::vector` with non-movable members), `Snapshot`'s protected virtual destructor (intended), `ManagedSnapshot`, the `SubcompactionJobInfo` and `CompactionJobInfo` aggregates, and the 16 noexcept-move-constructor and noexcept-swap findings on existing functions, including `autovector`'s move assignment (adding `noexcept` would change their exception specifications). Copying `ManagedSnapshot` already double-releases the snapshot. Fixing that needs a real move implementation and is a behavior change, so it is left for a separate diff. Reviewed By: rban1 Differential Revision: D123186309 fbshipit-source-id: 6f8e57e233e12199a007407130bb9a1f6d52e8d1
253 lines
7.0 KiB
C++
253 lines
7.0 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#pragma once
|
|
#include <assert.h>
|
|
|
|
#include <atomic>
|
|
#include <functional>
|
|
#include <memory>
|
|
#include <mutex>
|
|
#include <thread>
|
|
|
|
#include "port/port.h"
|
|
#include "util/fastrange.h"
|
|
#include "util/hash.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// Helper class that locks a mutex on construction and unlocks the mutex when
|
|
// the destructor of the MutexLock object is invoked.
|
|
//
|
|
// Typical usage:
|
|
//
|
|
// void MyClass::MyMethod() {
|
|
// MutexLock l(&mu_); // mu_ is an instance variable
|
|
// ... some complex code, possibly with multiple return paths ...
|
|
// }
|
|
|
|
class MutexLock {
|
|
public:
|
|
explicit MutexLock(port::Mutex* mu) : mu_(mu) { this->mu_->Lock(); }
|
|
// No copying allowed
|
|
MutexLock(const MutexLock&) = delete;
|
|
void operator=(const MutexLock&) = delete;
|
|
MutexLock(MutexLock&&) = delete;
|
|
void operator=(MutexLock&&) = delete;
|
|
|
|
~MutexLock() { this->mu_->Unlock(); }
|
|
|
|
private:
|
|
port::Mutex* const mu_;
|
|
};
|
|
|
|
//
|
|
// Acquire a ReadLock on the specified RWMutex.
|
|
// The Lock will be automatically released when the
|
|
// object goes out of scope.
|
|
//
|
|
class ReadLock {
|
|
public:
|
|
explicit ReadLock(port::RWMutex* mu) : mu_(mu) { this->mu_->ReadLock(); }
|
|
// No copying allowed
|
|
ReadLock(const ReadLock&) = delete;
|
|
void operator=(const ReadLock&) = delete;
|
|
ReadLock(ReadLock&&) = delete;
|
|
void operator=(ReadLock&&) = delete;
|
|
|
|
~ReadLock() { this->mu_->ReadUnlock(); }
|
|
|
|
private:
|
|
port::RWMutex* const mu_;
|
|
};
|
|
|
|
//
|
|
// Try to acquire a ReadLock on the specified RWMutex without blocking.
|
|
//
|
|
class TryReadLock {
|
|
public:
|
|
explicit TryReadLock(port::RWMutex* mu)
|
|
: mu_(mu), owns_(mu_->TryReadLock()) {}
|
|
// No copying allowed
|
|
TryReadLock(const TryReadLock&) = delete;
|
|
void operator=(const TryReadLock&) = delete;
|
|
TryReadLock(TryReadLock&&) = delete;
|
|
void operator=(TryReadLock&&) = delete;
|
|
|
|
~TryReadLock() {
|
|
if (owns_) {
|
|
mu_->ReadUnlock();
|
|
}
|
|
}
|
|
|
|
bool OwnsLock() const { return owns_; }
|
|
|
|
private:
|
|
port::RWMutex* const mu_;
|
|
const bool owns_;
|
|
};
|
|
|
|
//
|
|
// Automatically unlock a locked mutex when the object is destroyed
|
|
//
|
|
class ReadUnlock {
|
|
public:
|
|
explicit ReadUnlock(port::RWMutex* mu) : mu_(mu) { mu->AssertHeld(); }
|
|
// No copying allowed
|
|
ReadUnlock(const ReadUnlock&) = delete;
|
|
ReadUnlock& operator=(const ReadUnlock&) = delete;
|
|
ReadUnlock(ReadUnlock&&) = delete;
|
|
ReadUnlock& operator=(ReadUnlock&&) = delete;
|
|
|
|
~ReadUnlock() { mu_->ReadUnlock(); }
|
|
|
|
private:
|
|
port::RWMutex* const mu_;
|
|
};
|
|
|
|
//
|
|
// Acquire a WriteLock on the specified RWMutex.
|
|
// The Lock will be automatically released then the
|
|
// object goes out of scope.
|
|
//
|
|
class WriteLock {
|
|
public:
|
|
explicit WriteLock(port::RWMutex* mu) : mu_(mu) { this->mu_->WriteLock(); }
|
|
// No copying allowed
|
|
WriteLock(const WriteLock&) = delete;
|
|
void operator=(const WriteLock&) = delete;
|
|
WriteLock(WriteLock&&) = delete;
|
|
void operator=(WriteLock&&) = delete;
|
|
|
|
~WriteLock() { this->mu_->WriteUnlock(); }
|
|
|
|
private:
|
|
port::RWMutex* const mu_;
|
|
};
|
|
|
|
//
|
|
// Try to acquire a WriteLock on the specified RWMutex without blocking.
|
|
// If acquired, the lock is released when the object goes out of scope.
|
|
// If not acquired, the destructor is a no-op. Use OwnsLock() to check
|
|
// whether the lock was acquired.
|
|
//
|
|
class TryWriteLock {
|
|
public:
|
|
explicit TryWriteLock(port::RWMutex* mu)
|
|
: mu_(mu), owns_(mu_->TryWriteLock()) {}
|
|
// No copying allowed
|
|
TryWriteLock(const TryWriteLock&) = delete;
|
|
void operator=(const TryWriteLock&) = delete;
|
|
TryWriteLock(TryWriteLock&&) = delete;
|
|
void operator=(TryWriteLock&&) = delete;
|
|
|
|
~TryWriteLock() {
|
|
if (owns_) {
|
|
mu_->WriteUnlock();
|
|
}
|
|
}
|
|
|
|
bool OwnsLock() const { return owns_; }
|
|
|
|
private:
|
|
port::RWMutex* const mu_;
|
|
const bool owns_;
|
|
};
|
|
|
|
//
|
|
// SpinMutex has very low overhead for low-contention cases. Method names
|
|
// are chosen so you can use std::unique_lock or std::lock_guard with it.
|
|
//
|
|
class SpinMutex {
|
|
public:
|
|
SpinMutex() : locked_(false) {}
|
|
|
|
bool try_lock() {
|
|
auto currently_locked = locked_.load(std::memory_order_relaxed);
|
|
return !currently_locked &&
|
|
locked_.compare_exchange_weak(currently_locked, true,
|
|
std::memory_order_acquire,
|
|
std::memory_order_relaxed);
|
|
}
|
|
|
|
void lock() {
|
|
for (size_t tries = 0;; ++tries) {
|
|
if (try_lock()) {
|
|
// success
|
|
break;
|
|
}
|
|
port::AsmVolatilePause();
|
|
if (tries > 100) {
|
|
std::this_thread::yield();
|
|
}
|
|
}
|
|
}
|
|
|
|
void unlock() { locked_.store(false, std::memory_order_release); }
|
|
|
|
private:
|
|
std::atomic<bool> locked_;
|
|
};
|
|
|
|
// For preventing false sharing, especially for mutexes.
|
|
// NOTE: if a mutex is less than half the size of a cache line, it would
|
|
// make more sense for Striped structure below to pack more than one mutex
|
|
// into each cache line, as this would only reduce contention for the same
|
|
// amount of space and cache sharing. However, a mutex is often 40 bytes out
|
|
// of a 64 byte cache line.
|
|
template <class T>
|
|
struct ALIGN_AS(CACHE_LINE_SIZE) CacheAlignedWrapper {
|
|
T obj_;
|
|
};
|
|
template <class T>
|
|
struct Unwrap {
|
|
using type = T;
|
|
static type& Go(T& t) { return t; }
|
|
};
|
|
template <class T>
|
|
struct Unwrap<CacheAlignedWrapper<T>> {
|
|
using type = T;
|
|
static type& Go(CacheAlignedWrapper<T>& t) { return t.obj_; }
|
|
};
|
|
|
|
//
|
|
// Inspired by Guava: https://github.com/google/guava/wiki/StripedExplained
|
|
// A striped Lock. This offers the underlying lock striping similar
|
|
// to that of ConcurrentHashMap in a reusable form, and extends it for
|
|
// semaphores and read-write locks. Conceptually, lock striping is the technique
|
|
// of dividing a lock into many <i>stripes</i>, increasing the granularity of a
|
|
// single lock and allowing independent operations to lock different stripes and
|
|
// proceed concurrently, instead of creating contention for a single lock.
|
|
//
|
|
template <class T, class Key = Slice, class Hash = SliceNPHasher64>
|
|
class Striped {
|
|
public:
|
|
explicit Striped(size_t stripe_count)
|
|
: stripe_count_(stripe_count), data_(new T[stripe_count]) {}
|
|
|
|
using Unwrapped = typename Unwrap<T>::type;
|
|
Unwrapped& Get(const Key& key, uint64_t seed = 0) {
|
|
size_t index = FastRangeGeneric(hash_(key, seed), stripe_count_);
|
|
return Unwrap<T>::Go(data_[index]);
|
|
}
|
|
|
|
size_t ApproximateMemoryUsage() const {
|
|
// NOTE: could use malloc_usable_size() here, but that could count unmapped
|
|
// pages and could mess up unit test OccLockBucketsTest::CacheAligned
|
|
return sizeof(*this) + stripe_count_ * sizeof(T);
|
|
}
|
|
|
|
private:
|
|
size_t stripe_count_;
|
|
std::unique_ptr<T[]> data_;
|
|
Hash hash_;
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|