mirror of
https://github.com/facebook/rocksdb.git
synced 2026-10-23 08:09:02 +03:00
Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/15387 ## Summary RocksDB's `.clang-tidy` enables `cppcoreguidelines-special-member-functions`, `cppcoreguidelines-virtual-class-destructor` and the noexcept-move checks, and clang warns `-Wdeprecated-copy-with-user-provided-dtor`. A full scan reports 476 findings. In most of them, a class declares a destructor (or copy operations) but leaves the rest of copy/move implicit. That has two costs. Readers can't tell whether a class may be copied or moved. And resource-owning classes keep an implicit copy that would double-free if anyone ever used it. This diff resolves 453 of the 476. Approach, picked per class from least to most invasive: 1. An empty user-provided destructor becomes `= default`. This covers most interface classes, such as `virtual ~X() {}` -> `= default`. If the class is still copied, that would only rename the deprecated-copy warning, so the destructor is removed instead when nothing needs it (`Customizable`, `TableFactory` and `InternalKeyComparator` inherit a virtual one; `IteratorWrapperBase` isn't polymorphic), and `MemTableRep::KeyComparator` gets defaulted copy and move. 2. Classes whose copy is already deleted get explicitly deleted move operations too. Move was already unavailable, so this only documents it. 3. Resource-owning classes that are never copied get deleted copy and move operations. Examples: the C API wrapper structs, which run a `destructor_` callback (edited in `tools/c_api_gen/c_base.cc` and regenerated into `db/c.cc`); `ShardedCache`, which frees its shards; iterator wrappers; and RAII handles. 4. Value types that are copied or moved get the missing operations as `= default`, which keeps their current behavior. 5. Exception specifications of existing functions are unchanged, except for `WriteBatch`'s move assignment (below): no other `noexcept` is added or removed. Only the move operations this diff newly declares (`Comparator`, `FileSampledStats` and the thread-local `Entry`) are `noexcept`; they copy only scalars or atomics. `WriteBatch`'s copy and move assignment destroyed `*this` and placement-new'ed a new `WriteBatch` over it. That is undefined behavior when `*this` is a subclass, and if the copy constructor threw, `*this` was left destroyed and was later destroyed again. Move assignment now assigns member-wise and ends in the same state as the move constructor, which leaves `has_key_with_ts_`, the timestamp-size tracking and the other fields it doesn't copy at their defaults. `rep_` is swapped through a temporary, because a plain string move-assignment can keep the old buffer (e.g. a large batch reset with `batch = WriteBatch()` would keep its memory). Nothing in it can throw, so it is now `noexcept`. Copy assignment copies into a temporary and moves it in, so a throwing copy leaves `*this` unchanged. Bugs this exposed and fixed: - `RestoreAfterCopyOrCreateWorkItem` (backup engine): the hand-written move constructor and assignment moved only some fields, so `from_file` and `to_file` were empty after `push_back(std::move(...))`. A restore that hit a checksum mismatch then reported "While restoring -> : ..." without file names. It now uses the compiler-generated moves, which are still `noexcept`. - `ExternalSstFileIngestionJob` lived in a `std::vector`, and its destructor frees raw-owned pointers, so the implicit copy used on vector reallocation would double-free. Its file batches also point into its own inline file storage, so neither a copy nor a move is safe after `Prepare()`. Copy and move are now deleted, and `DBImpl` holds jobs through `std::unique_ptr`. Compatibility: no public class loses an operation users can call. Public interfaces mostly only get `virtual ~X() = default;`. `WriteBatch`'s move assignment becomes `noexcept`, which is not part of the mangled name, so the ABI doesn't change. `SubcompactionJobInfo` and `CompactionJobInfo` intentionally stay C++20 aggregates, so users' aggregate and designated initializers keep compiling. `Configurable`, `CompareInterface`, `WriteBatchBase`, `ObjectLibrary::Entry` and `MemTableRep::KeyComparator` declare defaulted copy and move, and `Customizable` no longer declares a destructor. As a result, `Configurable` and `Customizable` subclasses that declare no destructor or copy operations of their own now move their registered-options list instead of copying it. In-tree, these are the mutable-options adapters, the table factories, the memory allocators and test classes; all are held through smart pointers or used in place, and `Clone()` copies, so none is moved by value. Not changed (23): `IODebugContext` (custom deep copy plus a `std::shared_mutex`), `DBWithColumnFamilies` in db_bench (stored in a `std::vector` with non-movable members), `Snapshot`'s protected virtual destructor (intended), `ManagedSnapshot`, the `SubcompactionJobInfo` and `CompactionJobInfo` aggregates, and the 16 noexcept-move-constructor and noexcept-swap findings on existing functions, including `autovector`'s move assignment (adding `noexcept` would change their exception specifications). Copying `ManagedSnapshot` already double-releases the snapshot. Fixing that needs a real move implementation and is a behavior change, so it is left for a separate diff. Reviewed By: rban1 Differential Revision: D123186309 fbshipit-source-id: 6f8e57e233e12199a007407130bb9a1f6d52e8d1
159 lines
5.5 KiB
C++
159 lines
5.5 KiB
C++
// Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include "rocksdb/cache.h"
|
|
#include "rocksdb/secondary_cache.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// A SecondaryCache that implements stacking of a compressed secondary cache
|
|
// and a non-volatile (local flash) cache. It implements an admission
|
|
// policy of warming the bottommost tier (local flash) with compressed
|
|
// blocks from the SST on misses, and on hits in the bottommost tier,
|
|
// promoting to the compressed and/or primary block cache. The admission
|
|
// policies of the primary block cache and compressed secondary cache remain
|
|
// unchanged - promote on second access. There is no demotion ofablocks
|
|
// evicted from a tier. They are just discarded.
|
|
//
|
|
// In order to properly handle compressed blocks directly read from SSTs, and
|
|
// to allow writeback of blocks compressed by the compressed secondary
|
|
// cache in the future, we make use of the compression type and source
|
|
// cache tier arguments in InsertSaved.
|
|
class TieredSecondaryCache : public SecondaryCacheWrapper {
|
|
public:
|
|
TieredSecondaryCache(std::shared_ptr<SecondaryCache> comp_sec_cache,
|
|
std::shared_ptr<SecondaryCache> nvm_sec_cache,
|
|
TieredAdmissionPolicy adm_policy)
|
|
: SecondaryCacheWrapper(comp_sec_cache), nvm_sec_cache_(nvm_sec_cache) {
|
|
#ifndef NDEBUG
|
|
assert(adm_policy == TieredAdmissionPolicy::kAdmPolicyThreeQueue);
|
|
#else
|
|
(void)adm_policy;
|
|
#endif
|
|
}
|
|
|
|
~TieredSecondaryCache() override = default;
|
|
|
|
const char* Name() const override { return "TieredSecondaryCache"; }
|
|
|
|
// This is a no-op as we currently don't allow demotion (i.e
|
|
// insertion by the upper layer) of evicted blocks.
|
|
Status Insert(const Slice& /*key*/, Cache::ObjectPtr /*obj*/,
|
|
const Cache::CacheItemHelper* /*helper*/,
|
|
bool /*force_insert*/) override {
|
|
return Status::OK();
|
|
}
|
|
|
|
// Warm up the nvm tier directly
|
|
Status InsertSaved(const Slice& key, const Slice& saved,
|
|
CompressionType type = CompressionType::kNoCompression,
|
|
CacheTier source = CacheTier::kVolatileTier) override {
|
|
return nvm_sec_cache_->InsertSaved(key, saved, type, source);
|
|
}
|
|
|
|
std::unique_ptr<SecondaryCacheResultHandle> Lookup(
|
|
const Slice& key, const Cache::CacheItemHelper* helper,
|
|
Cache::CreateContext* create_context, bool wait, bool advise_erase,
|
|
Statistics* stats, bool& kept_in_sec_cache) override;
|
|
|
|
void WaitAll(std::vector<SecondaryCacheResultHandle*> handles) override;
|
|
|
|
private:
|
|
struct CreateContext : public Cache::CreateContext {
|
|
const Slice* key;
|
|
bool advise_erase;
|
|
const Cache::CacheItemHelper* helper;
|
|
Cache::CreateContext* inner_ctx;
|
|
std::shared_ptr<SecondaryCacheResultHandle> inner_handle;
|
|
SecondaryCache* comp_sec_cache;
|
|
Statistics* stats;
|
|
};
|
|
|
|
class ResultHandle : public SecondaryCacheResultHandle {
|
|
public:
|
|
~ResultHandle() override = default;
|
|
|
|
bool IsReady() override {
|
|
if (inner_handle_ && inner_handle_->IsReady()) {
|
|
Complete();
|
|
}
|
|
return ready_;
|
|
}
|
|
|
|
void Wait() override {
|
|
inner_handle_->Wait();
|
|
Complete();
|
|
}
|
|
|
|
size_t Size() override { return size_; }
|
|
|
|
Cache::ObjectPtr Value() override { return value_; }
|
|
|
|
void Complete() {
|
|
size_ = inner_handle_->Size();
|
|
value_ = inner_handle_->Value();
|
|
inner_handle_.reset();
|
|
ready_ = true;
|
|
}
|
|
|
|
void SetInnerHandle(std::unique_ptr<SecondaryCacheResultHandle>&& handle) {
|
|
inner_handle_ = std::move(handle);
|
|
}
|
|
|
|
void SetSize(size_t size) { size_ = size; }
|
|
|
|
void SetValue(Cache::ObjectPtr val) { value_ = val; }
|
|
|
|
CreateContext* ctx() { return &ctx_; }
|
|
|
|
SecondaryCacheResultHandle* inner_handle() { return inner_handle_.get(); }
|
|
|
|
private:
|
|
std::unique_ptr<SecondaryCacheResultHandle> inner_handle_;
|
|
CreateContext ctx_;
|
|
size_t size_;
|
|
Cache::ObjectPtr value_;
|
|
bool ready_ = false;
|
|
};
|
|
|
|
static void NoopDelete(Cache::ObjectPtr /*obj*/,
|
|
MemoryAllocator* /*allocator*/) {
|
|
assert(false);
|
|
}
|
|
static size_t ZeroSize(Cache::ObjectPtr /*obj*/) {
|
|
assert(false);
|
|
return 0;
|
|
}
|
|
static Status NoopSaveTo(Cache::ObjectPtr /*from_obj*/,
|
|
size_t /*from_offset*/, size_t /*length*/,
|
|
char* /*out_buf*/) {
|
|
assert(false);
|
|
return Status::OK();
|
|
}
|
|
static Status MaybeInsertAndCreate(const Slice& data, CompressionType type,
|
|
CacheTier source,
|
|
Cache::CreateContext* ctx,
|
|
MemoryAllocator* allocator,
|
|
Cache::ObjectPtr* out_obj,
|
|
size_t* out_charge);
|
|
|
|
static const Cache::CacheItemHelper* GetHelper() {
|
|
const static Cache::CacheItemHelper basic_helper(CacheEntryRole::kMisc,
|
|
&NoopDelete);
|
|
const static Cache::CacheItemHelper maybe_insert_and_create_helper{
|
|
CacheEntryRole::kMisc, &NoopDelete, &ZeroSize,
|
|
&NoopSaveTo, &MaybeInsertAndCreate, &basic_helper,
|
|
};
|
|
return &maybe_insert_and_create_helper;
|
|
}
|
|
|
|
std::shared_ptr<SecondaryCache> comp_sec_cache_;
|
|
std::shared_ptr<SecondaryCache> nvm_sec_cache_;
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|