From 2cd4346df6703b190d1497719bb1e3fa4336cd42 Mon Sep 17 00:00:00 2001 From: Jaepil Jeong Date: Thu, 2 May 2024 16:54:21 -0700 Subject: [PATCH] Fix compile error in Clang (#12588) Summary: This PR fixes the following compile errors with Clang: ``` .../rocksdb/env/fs_on_demand.cc:184:5: error: no member named 'for_each' in namespace 'std'; did you mean 'std::ranges::for_each'? 184 | std::for_each(rchildren.begin(), rchildren.end(), [&](std::string& name) { | ^~~~~~~~~~~~~ | std::ranges::for_each /opt/homebrew/opt/llvm@17/bin/../include/c++/v1/__algorithm/ranges_for_each.h:68:23: note: 'std::ranges::for_each' declared here 68 | inline constexpr auto for_each = __for_each::__fn{}; | ^ .../rocksdb/env/fs_on_demand.cc:188:10: error: no member named 'sort' in namespace 'std' 188 | std::sort(result->begin(), result->end()); | ~~~~~^ .../rocksdb/env/fs_on_demand.cc:189:10: error: no member named 'sort' in namespace 'std' 189 | std::sort(rchildren.begin(), rchildren.end()); | ~~~~~^ .../rocksdb/env/fs_on_demand.cc:193:10: error: no member named 'set_union' in namespace 'std' 193 | std::set_union(result->begin(), result->end(), rchildren.begin(), | ~~~~~^ .../rocksdb/env/fs_on_demand.cc:221:5: error: no member named 'for_each' in namespace 'std'; did you mean 'std::ranges::for_each'? 221 | std::for_each( | ^~~~~~~~~~~~~ | std::ranges::for_each /opt/homebrew/opt/llvm@17/bin/../include/c++/v1/__algorithm/ranges_for_each.h:68:23: note: 'std::ranges::for_each' declared here 68 | inline constexpr auto for_each = __for_each::__fn{}; | ^ .../rocksdb/env/fs_on_demand.cc:226:10: error: no member named 'sort' in namespace 'std' 226 | std::sort(result->begin(), result->end(), file_attr_sorter); | ~~~~~^ .../rocksdb/env/fs_on_demand.cc:227:10: error: no member named 'sort' in namespace 'std' 227 | std::sort(rchildren.begin(), rchildren.end(), file_attr_sorter); | ~~~~~^ .../rocksdb/env/fs_on_demand.cc:231:10: error: no member named 'set_union' in namespace 'std' 231 | std::set_union(rchildren.begin(), rchildren.end(), result->begin(), | ~~~~~^ 8 errors generated. ``` Pull Request resolved: https://github.com/facebook/rocksdb/pull/12588 Reviewed By: jaykorean Differential Revision: D56656222 Pulled By: ajkr fbshipit-source-id: 7e94b6250fc9edfe597a61b7622f09d6b6cd9cbd --- env/fs_on_demand.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/env/fs_on_demand.cc b/env/fs_on_demand.cc index bac424264a..a2f23f5c41 100644 --- a/env/fs_on_demand.cc +++ b/env/fs_on_demand.cc @@ -5,6 +5,7 @@ #include "env/fs_on_demand.h" +#include #include #include "file/filename.h"