mirror of
https://github.com/postgres/postgres.git
synced 2025-12-21 05:21:08 +03:00
c7b8998ebb
Change pg_bsd_indent to follow upstream rules for placement of comments
to the right of code, and remove pgindent hack that caused comments
following #endif to not obey the general rule.
Commit e3860ffa4d wasn't actually using
the published version of pg_bsd_indent, but a hacked-up version that
tried to minimize the amount of movement of comments to the right of
code. The situation of interest is where such a comment has to be
moved to the right of its default placement at column 33 because there's
code there. BSD indent has always moved right in units of tab stops
in such cases --- but in the previous incarnation, indent was working
in 8-space tab stops, while now it knows we use 4-space tabs. So the
net result is that in about half the cases, such comments are placed
one tab stop left of before. This is better all around: it leaves
more room on the line for comment text, and it means that in such
cases the comment uniformly starts at the next 4-space tab stop after
the code, rather than sometimes one and sometimes two tabs after.
Also, ensure that comments following #endif are indented the same
as comments following other preprocessor commands such as #else.
That inconsistency turns out to have been self-inflicted damage
from a poorly-thought-through post-indent "fixup" in pgindent.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
73 lines
2.7 KiB
C
73 lines
2.7 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* tlist.h
|
|
* prototypes for tlist.c.
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/optimizer/tlist.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef TLIST_H
|
|
#define TLIST_H
|
|
|
|
#include "nodes/relation.h"
|
|
|
|
|
|
extern TargetEntry *tlist_member(Expr *node, List *targetlist);
|
|
extern TargetEntry *tlist_member_ignore_relabel(Expr *node, List *targetlist);
|
|
|
|
extern List *add_to_flat_tlist(List *tlist, List *exprs);
|
|
|
|
extern List *get_tlist_exprs(List *tlist, bool includeJunk);
|
|
|
|
extern int count_nonjunk_tlist_entries(List *tlist);
|
|
|
|
extern bool tlist_same_exprs(List *tlist1, List *tlist2);
|
|
|
|
extern bool tlist_same_datatypes(List *tlist, List *colTypes, bool junkOK);
|
|
extern bool tlist_same_collations(List *tlist, List *colCollations, bool junkOK);
|
|
|
|
extern void apply_tlist_labeling(List *dest_tlist, List *src_tlist);
|
|
|
|
extern TargetEntry *get_sortgroupref_tle(Index sortref,
|
|
List *targetList);
|
|
extern TargetEntry *get_sortgroupclause_tle(SortGroupClause *sgClause,
|
|
List *targetList);
|
|
extern Node *get_sortgroupclause_expr(SortGroupClause *sgClause,
|
|
List *targetList);
|
|
extern List *get_sortgrouplist_exprs(List *sgClauses,
|
|
List *targetList);
|
|
|
|
extern SortGroupClause *get_sortgroupref_clause(Index sortref,
|
|
List *clauses);
|
|
extern SortGroupClause *get_sortgroupref_clause_noerr(Index sortref,
|
|
List *clauses);
|
|
|
|
extern Oid *extract_grouping_ops(List *groupClause);
|
|
extern AttrNumber *extract_grouping_cols(List *groupClause, List *tlist);
|
|
extern bool grouping_is_sortable(List *groupClause);
|
|
extern bool grouping_is_hashable(List *groupClause);
|
|
|
|
extern PathTarget *make_pathtarget_from_tlist(List *tlist);
|
|
extern List *make_tlist_from_pathtarget(PathTarget *target);
|
|
extern PathTarget *copy_pathtarget(PathTarget *src);
|
|
extern PathTarget *create_empty_pathtarget(void);
|
|
extern void add_column_to_pathtarget(PathTarget *target,
|
|
Expr *expr, Index sortgroupref);
|
|
extern void add_new_column_to_pathtarget(PathTarget *target, Expr *expr);
|
|
extern void add_new_columns_to_pathtarget(PathTarget *target, List *exprs);
|
|
extern void apply_pathtarget_labeling_to_tlist(List *tlist, PathTarget *target);
|
|
extern void split_pathtarget_at_srfs(PlannerInfo *root,
|
|
PathTarget *target, PathTarget *input_target,
|
|
List **targets, List **targets_contain_srfs);
|
|
|
|
/* Convenience macro to get a PathTarget with valid cost/width fields */
|
|
#define create_pathtarget(root, tlist) \
|
|
set_pathtarget_cost_width(root, make_pathtarget_from_tlist(tlist))
|
|
|
|
#endif /* TLIST_H */
|