mirror of
https://github.com/postgres/postgres.git
synced 2026-10-23 13:29:09 +03:00
c68cba09dd
The tests added by this commit cover a large ground in terms of the introduction of oid8 in TOAST tables, with the following areas covered, with all the gaps found during the development of the feature: - Tables with oid8 TOAST tables in general, under strings.sql. - ALTER TABLE with attribute manipulations in transactions and different toast_table_value settings. - Relation rewrites, not affecting the TOAST relation after initial creation with VACUUM FULL, CLUSTER, REPACK. - pg_column_compression(). - test_decoding, for external and extended TOAST data. - amcheck, external and extended storage with heap checked. - UPDATE with out-of-line datums that belongs to another TOAST table. This offers coverage for toast_tuple_init(), where external vartags could be mixed once multiple on-disk external TOAST pointers can co-exist. This pattern can be triggered with asan/ubsan, with an out-of-bound memcpy when unpatched. These tests are added before the new vartag_external, mostly as a matter of avoiding dead code in the tree. Author: Michael Paquier <michael@paquier.xyz> Reviewed-by: Greg Burd <greg@burd.me> Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> Reviewed-by: Yugo Nagata <nagata@sraoss.co.jp> Discussion: https://postgr.es/m/af19kUjwjhaoUTLn@paquier.xy