mirror of
https://github.com/postgres/postgres.git
synced 2025-08-17 01:02:17 +03:00
07172b20f1
Before initializing iteration over a subtransaction's changes, the last few changes were not spilled to disk. That's correct if the transaction didn't spill to disk, but otherwise... This bug can lead to missed or misorderd subtransaction contents when they were spilled to disk. Move spilling of the remaining in-memory changes to ReorderBufferIterTXNInit(), where it can easily be applied to the top transaction and, if present, subtransactions. Since this code had too many bugs already, noticeably increase test coverage. Fixes: #14319 Reported-By: Huan Ruan Discussion: <20160909012610.20024.58169@wrigleys.postgresql.org> Backport: 9,4-, where logical decoding was added
75 lines
2.4 KiB
Makefile
75 lines
2.4 KiB
Makefile
# contrib/test_decoding/Makefile
|
|
|
|
MODULES = test_decoding
|
|
OBJS = test_decoding.o
|
|
|
|
# Note: because we don't tell the Makefile there are any regression tests,
|
|
# we have to clean those result files explicitly
|
|
EXTRA_CLEAN = $(pg_regress_clean_files) ./regression_output ./isolation_output
|
|
|
|
ifdef USE_PGXS
|
|
PG_CONFIG = pg_config
|
|
PGXS := $(shell $(PG_CONFIG) --pgxs)
|
|
include $(PGXS)
|
|
else
|
|
subdir = contrib/test_decoding
|
|
top_builddir = ../..
|
|
include $(top_builddir)/src/Makefile.global
|
|
include $(top_srcdir)/contrib/contrib-global.mk
|
|
endif
|
|
|
|
# Disabled because these tests require "wal_level=logical", which
|
|
# typical installcheck users do not have (e.g. buildfarm clients).
|
|
installcheck:;
|
|
|
|
# But it can nonetheless be very helpful to run tests on preexisting
|
|
# installation, allow to do so, but only if requested explicitly.
|
|
installcheck-force: regresscheck-install-force isolationcheck-install-force
|
|
|
|
check: regresscheck isolationcheck
|
|
|
|
submake-regress:
|
|
$(MAKE) -C $(top_builddir)/src/test/regress all
|
|
|
|
submake-isolation:
|
|
$(MAKE) -C $(top_builddir)/src/test/isolation all
|
|
|
|
submake-test_decoding:
|
|
$(MAKE) -C $(top_builddir)/contrib/test_decoding
|
|
|
|
REGRESSCHECKS=ddl xact rewrite toast permissions decoding_in_xact \
|
|
decoding_into_rel binary prepared spill
|
|
|
|
regresscheck: all | submake-regress submake-test_decoding
|
|
$(MKDIR_P) regression_output
|
|
$(pg_regress_check) \
|
|
--temp-config $(top_srcdir)/contrib/test_decoding/logical.conf \
|
|
--temp-install=./tmp_check \
|
|
--extra-install=contrib/test_decoding \
|
|
--outputdir=./regression_output \
|
|
$(REGRESSCHECKS)
|
|
|
|
regresscheck-install-force: | submake-regress submake-test_decoding
|
|
$(pg_regress_installcheck) \
|
|
--extra-install=contrib/test_decoding \
|
|
$(REGRESSCHECKS)
|
|
|
|
ISOLATIONCHECKS=mxact delayed_startup ondisk_startup concurrent_ddl_dml
|
|
|
|
isolationcheck: all | submake-isolation submake-test_decoding
|
|
$(MKDIR_P) isolation_output
|
|
$(pg_isolation_regress_check) \
|
|
--temp-config $(top_srcdir)/contrib/test_decoding/logical.conf \
|
|
--extra-install=contrib/test_decoding \
|
|
--outputdir=./isolation_output \
|
|
$(ISOLATIONCHECKS)
|
|
|
|
isolationcheck-install-force: all | submake-isolation submake-test_decoding
|
|
$(pg_isolation_regress_installcheck) \
|
|
--extra-install=contrib/test_decoding \
|
|
$(ISOLATIONCHECKS)
|
|
|
|
.PHONY: submake-test_decoding submake-regress check \
|
|
regresscheck regresscheck-install-force \
|
|
isolationcheck isolationcheck-install-force
|