mirror of
https://github.com/postgres/postgres.git
synced 2025-07-02 09:02:37 +03:00
e8f4922c86
Due to simplistic quoting and confusion of database names with conninfo strings, roles with the CREATEDB or CREATEROLE option could escalate to superuser privileges when a superuser next ran certain maintenance commands. The new coding rule for PQconnectdbParams() calls, documented at conninfo_array_parse(), is to pass expand_dbname=true and wrap literal database names in a trivial connection string. Escape zero-length values in appendConnStrVal(). Back-patch to 9.1 (all supported versions). Nathan Bossart, Michael Paquier, and Noah Misch. Reviewed by Peter Eisentraut. Reported by Nathan Bossart. Security: CVE-2016-5424
358 lines
9.9 KiB
C
358 lines
9.9 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* reindexdb
|
|
*
|
|
* Portions Copyright (c) 1996-2012, PostgreSQL Global Development Group
|
|
*
|
|
* src/bin/scripts/reindexdb.c
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
|
|
#include "postgres_fe.h"
|
|
#include "common.h"
|
|
#include "dumputils.h"
|
|
|
|
|
|
static void reindex_one_database(const char *name, const char *dbname,
|
|
const char *type, const char *host,
|
|
const char *port, const char *username,
|
|
enum trivalue prompt_password, const char *progname,
|
|
bool echo);
|
|
static void reindex_all_databases(const char *maintenance_db,
|
|
const char *host, const char *port,
|
|
const char *username, enum trivalue prompt_password,
|
|
const char *progname, bool echo,
|
|
bool quiet);
|
|
static void reindex_system_catalogs(const char *dbname,
|
|
const char *host, const char *port,
|
|
const char *username, enum trivalue prompt_password,
|
|
const char *progname, bool echo);
|
|
static void help(const char *progname);
|
|
|
|
int
|
|
main(int argc, char *argv[])
|
|
{
|
|
static struct option long_options[] = {
|
|
{"host", required_argument, NULL, 'h'},
|
|
{"port", required_argument, NULL, 'p'},
|
|
{"username", required_argument, NULL, 'U'},
|
|
{"no-password", no_argument, NULL, 'w'},
|
|
{"password", no_argument, NULL, 'W'},
|
|
{"echo", no_argument, NULL, 'e'},
|
|
{"quiet", no_argument, NULL, 'q'},
|
|
{"dbname", required_argument, NULL, 'd'},
|
|
{"all", no_argument, NULL, 'a'},
|
|
{"system", no_argument, NULL, 's'},
|
|
{"table", required_argument, NULL, 't'},
|
|
{"index", required_argument, NULL, 'i'},
|
|
{"maintenance-db", required_argument, NULL, 2},
|
|
{NULL, 0, NULL, 0}
|
|
};
|
|
|
|
const char *progname;
|
|
int optindex;
|
|
int c;
|
|
|
|
const char *dbname = NULL;
|
|
const char *maintenance_db = NULL;
|
|
const char *host = NULL;
|
|
const char *port = NULL;
|
|
const char *username = NULL;
|
|
enum trivalue prompt_password = TRI_DEFAULT;
|
|
bool syscatalog = false;
|
|
bool alldb = false;
|
|
bool echo = false;
|
|
bool quiet = false;
|
|
const char *table = NULL;
|
|
const char *index = NULL;
|
|
|
|
progname = get_progname(argv[0]);
|
|
set_pglocale_pgservice(argv[0], PG_TEXTDOMAIN("pgscripts"));
|
|
|
|
handle_help_version_opts(argc, argv, "reindexdb", help);
|
|
|
|
/* process command-line options */
|
|
while ((c = getopt_long(argc, argv, "h:p:U:wWeqd:ast:i:", long_options, &optindex)) != -1)
|
|
{
|
|
switch (c)
|
|
{
|
|
case 'h':
|
|
host = optarg;
|
|
break;
|
|
case 'p':
|
|
port = optarg;
|
|
break;
|
|
case 'U':
|
|
username = optarg;
|
|
break;
|
|
case 'w':
|
|
prompt_password = TRI_NO;
|
|
break;
|
|
case 'W':
|
|
prompt_password = TRI_YES;
|
|
break;
|
|
case 'e':
|
|
echo = true;
|
|
break;
|
|
case 'q':
|
|
quiet = true;
|
|
break;
|
|
case 'd':
|
|
dbname = optarg;
|
|
break;
|
|
case 'a':
|
|
alldb = true;
|
|
break;
|
|
case 's':
|
|
syscatalog = true;
|
|
break;
|
|
case 't':
|
|
table = optarg;
|
|
break;
|
|
case 'i':
|
|
index = optarg;
|
|
break;
|
|
case 2:
|
|
maintenance_db = optarg;
|
|
break;
|
|
default:
|
|
fprintf(stderr, _("Try \"%s --help\" for more information.\n"), progname);
|
|
exit(1);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Non-option argument specifies database name as long as it wasn't
|
|
* already specified with -d / --dbname
|
|
*/
|
|
if (optind < argc && dbname == NULL)
|
|
{
|
|
dbname = argv[optind];
|
|
optind++;
|
|
}
|
|
|
|
if (optind < argc)
|
|
{
|
|
fprintf(stderr, _("%s: too many command-line arguments (first is \"%s\")\n"),
|
|
progname, argv[optind]);
|
|
fprintf(stderr, _("Try \"%s --help\" for more information.\n"), progname);
|
|
exit(1);
|
|
}
|
|
|
|
setup_cancel_handler();
|
|
|
|
if (alldb)
|
|
{
|
|
if (dbname)
|
|
{
|
|
fprintf(stderr, _("%s: cannot reindex all databases and a specific one at the same time\n"), progname);
|
|
exit(1);
|
|
}
|
|
if (syscatalog)
|
|
{
|
|
fprintf(stderr, _("%s: cannot reindex all databases and system catalogs at the same time\n"), progname);
|
|
exit(1);
|
|
}
|
|
if (table)
|
|
{
|
|
fprintf(stderr, _("%s: cannot reindex a specific table in all databases\n"), progname);
|
|
exit(1);
|
|
}
|
|
if (index)
|
|
{
|
|
fprintf(stderr, _("%s: cannot reindex a specific index in all databases\n"), progname);
|
|
exit(1);
|
|
}
|
|
|
|
reindex_all_databases(maintenance_db, host, port, username,
|
|
prompt_password, progname, echo, quiet);
|
|
}
|
|
else if (syscatalog)
|
|
{
|
|
if (table)
|
|
{
|
|
fprintf(stderr, _("%s: cannot reindex a specific table and system catalogs at the same time\n"), progname);
|
|
exit(1);
|
|
}
|
|
if (index)
|
|
{
|
|
fprintf(stderr, _("%s: cannot reindex a specific index and system catalogs at the same time\n"), progname);
|
|
exit(1);
|
|
}
|
|
|
|
if (dbname == NULL)
|
|
{
|
|
if (getenv("PGDATABASE"))
|
|
dbname = getenv("PGDATABASE");
|
|
else if (getenv("PGUSER"))
|
|
dbname = getenv("PGUSER");
|
|
else
|
|
dbname = get_user_name(progname);
|
|
}
|
|
|
|
reindex_system_catalogs(dbname, host, port, username, prompt_password,
|
|
progname, echo);
|
|
}
|
|
else
|
|
{
|
|
if (dbname == NULL)
|
|
{
|
|
if (getenv("PGDATABASE"))
|
|
dbname = getenv("PGDATABASE");
|
|
else if (getenv("PGUSER"))
|
|
dbname = getenv("PGUSER");
|
|
else
|
|
dbname = get_user_name(progname);
|
|
}
|
|
|
|
if (index)
|
|
reindex_one_database(index, dbname, "INDEX", host, port,
|
|
username, prompt_password, progname, echo);
|
|
if (table)
|
|
reindex_one_database(table, dbname, "TABLE", host, port,
|
|
username, prompt_password, progname, echo);
|
|
/* reindex database only if index or table is not specified */
|
|
if (index == NULL && table == NULL)
|
|
reindex_one_database(NULL, dbname, "DATABASE", host, port,
|
|
username, prompt_password, progname, echo);
|
|
}
|
|
|
|
exit(0);
|
|
}
|
|
|
|
static void
|
|
reindex_one_database(const char *name, const char *dbname, const char *type,
|
|
const char *host, const char *port, const char *username,
|
|
enum trivalue prompt_password, const char *progname, bool echo)
|
|
{
|
|
PQExpBufferData sql;
|
|
|
|
PGconn *conn;
|
|
|
|
conn = connectDatabase(dbname, host, port, username, prompt_password,
|
|
progname, false);
|
|
|
|
initPQExpBuffer(&sql);
|
|
|
|
appendPQExpBuffer(&sql, "REINDEX");
|
|
if (strcmp(type, "TABLE") == 0)
|
|
appendPQExpBuffer(&sql, " TABLE %s", name);
|
|
else if (strcmp(type, "INDEX") == 0)
|
|
appendPQExpBuffer(&sql, " INDEX %s", name);
|
|
else if (strcmp(type, "DATABASE") == 0)
|
|
appendPQExpBuffer(&sql, " DATABASE %s", fmtId(PQdb(conn)));
|
|
appendPQExpBuffer(&sql, ";\n");
|
|
|
|
if (!executeMaintenanceCommand(conn, sql.data, echo))
|
|
{
|
|
if (strcmp(type, "TABLE") == 0)
|
|
fprintf(stderr, _("%s: reindexing of table \"%s\" in database \"%s\" failed: %s"),
|
|
progname, name, PQdb(conn), PQerrorMessage(conn));
|
|
if (strcmp(type, "INDEX") == 0)
|
|
fprintf(stderr, _("%s: reindexing of index \"%s\" in database \"%s\" failed: %s"),
|
|
progname, name, PQdb(conn), PQerrorMessage(conn));
|
|
else
|
|
fprintf(stderr, _("%s: reindexing of database \"%s\" failed: %s"),
|
|
progname, PQdb(conn), PQerrorMessage(conn));
|
|
PQfinish(conn);
|
|
exit(1);
|
|
}
|
|
|
|
PQfinish(conn);
|
|
termPQExpBuffer(&sql);
|
|
}
|
|
|
|
static void
|
|
reindex_all_databases(const char *maintenance_db,
|
|
const char *host, const char *port,
|
|
const char *username, enum trivalue prompt_password,
|
|
const char *progname, bool echo, bool quiet)
|
|
{
|
|
PGconn *conn;
|
|
PGresult *result;
|
|
PQExpBufferData connstr;
|
|
int i;
|
|
|
|
conn = connectMaintenanceDatabase(maintenance_db, host, port, username,
|
|
prompt_password, progname);
|
|
result = executeQuery(conn, "SELECT datname FROM pg_database WHERE datallowconn ORDER BY 1;", progname, echo);
|
|
PQfinish(conn);
|
|
|
|
initPQExpBuffer(&connstr);
|
|
for (i = 0; i < PQntuples(result); i++)
|
|
{
|
|
char *dbname = PQgetvalue(result, i, 0);
|
|
|
|
if (!quiet)
|
|
{
|
|
printf(_("%s: reindexing database \"%s\"\n"), progname, dbname);
|
|
fflush(stdout);
|
|
}
|
|
|
|
resetPQExpBuffer(&connstr);
|
|
appendPQExpBuffer(&connstr, "dbname=");
|
|
appendConnStrVal(&connstr, dbname);
|
|
|
|
reindex_one_database(NULL, connstr.data, "DATABASE", host,
|
|
port, username, prompt_password,
|
|
progname, echo);
|
|
}
|
|
termPQExpBuffer(&connstr);
|
|
|
|
PQclear(result);
|
|
}
|
|
|
|
static void
|
|
reindex_system_catalogs(const char *dbname, const char *host, const char *port,
|
|
const char *username, enum trivalue prompt_password,
|
|
const char *progname, bool echo)
|
|
{
|
|
PGconn *conn;
|
|
PQExpBufferData sql;
|
|
|
|
conn = connectDatabase(dbname, host, port, username, prompt_password,
|
|
progname, false);
|
|
|
|
initPQExpBuffer(&sql);
|
|
|
|
appendPQExpBuffer(&sql, "REINDEX SYSTEM %s;\n", fmtId(PQdb(conn)));
|
|
|
|
if (!executeMaintenanceCommand(conn, sql.data, echo))
|
|
{
|
|
fprintf(stderr, _("%s: reindexing of system catalogs failed: %s"),
|
|
progname, PQerrorMessage(conn));
|
|
PQfinish(conn);
|
|
exit(1);
|
|
}
|
|
PQfinish(conn);
|
|
termPQExpBuffer(&sql);
|
|
}
|
|
|
|
static void
|
|
help(const char *progname)
|
|
{
|
|
printf(_("%s reindexes a PostgreSQL database.\n\n"), progname);
|
|
printf(_("Usage:\n"));
|
|
printf(_(" %s [OPTION]... [DBNAME]\n"), progname);
|
|
printf(_("\nOptions:\n"));
|
|
printf(_(" -a, --all reindex all databases\n"));
|
|
printf(_(" -d, --dbname=DBNAME database to reindex\n"));
|
|
printf(_(" -e, --echo show the commands being sent to the server\n"));
|
|
printf(_(" -i, --index=INDEX recreate specific index only\n"));
|
|
printf(_(" -q, --quiet don't write any messages\n"));
|
|
printf(_(" -s, --system reindex system catalogs\n"));
|
|
printf(_(" -t, --table=TABLE reindex specific table only\n"));
|
|
printf(_(" -V, --version output version information, then exit\n"));
|
|
printf(_(" -?, --help show this help, then exit\n"));
|
|
printf(_("\nConnection options:\n"));
|
|
printf(_(" -h, --host=HOSTNAME database server host or socket directory\n"));
|
|
printf(_(" -p, --port=PORT database server port\n"));
|
|
printf(_(" -U, --username=USERNAME user name to connect as\n"));
|
|
printf(_(" -w, --no-password never prompt for password\n"));
|
|
printf(_(" -W, --password force password prompt\n"));
|
|
printf(_(" --maintenance-db=DBNAME alternate maintenance database\n"));
|
|
printf(_("\nRead the description of the SQL command REINDEX for details.\n"));
|
|
printf(_("\nReport bugs to <pgsql-bugs@postgresql.org>.\n"));
|
|
}
|